Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Jun 14 2019

markblundeberg added a task to D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag: T653: Clean up past upgrades.
Jun 14 2019, 04:23
teamcity added a comment to D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 04:22
markblundeberg planned changes to D3264: sigencoding_tests: improve test coverage.
Jun 14 2019, 04:18
teamcity added a comment to D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 04:14
markblundeberg created D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.
Jun 14 2019, 04:13
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 03:23
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 03:14
markblundeberg updated the summary of D3253: Remove Schnorr activation.

rework into first of multiple parts

Jun 14 2019, 03:14
teamcity added a comment to D3329: [txindex] transaction Hash -> TxId.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 02:03
teamcity added a comment to D3329: [txindex] transaction Hash -> TxId.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 01:57
markblundeberg added a comment to D3329: [txindex] transaction Hash -> TxId.

missed a few spots!

Jun 14 2019, 01:57
teamcity added a comment to D3292: Explicitly call out updating makeseeds.py after major releases.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 01:06
jasonbcox retitled D3292: Explicitly call out updating makeseeds.py after major releases from Explicitly call out updating makeseeds.py for major releases to Explicitly call out updating makeseeds.py after major releases.
Jun 14 2019, 01:00
teamcity added a comment to D3292: Explicitly call out updating makeseeds.py after major releases.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 01:00
jasonbcox added a comment to D3292: Explicitly call out updating makeseeds.py after major releases.

Should come after a major release, not during

Jun 14 2019, 01:00
D3316: Update mempool eviction benchmark is now accepted and ready to land.
Jun 14 2019, 00:54
jasonbcox updated the summary of D3316: Update mempool eviction benchmark.
Jun 14 2019, 00:52
D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags is now accepted and ready to land.
Jun 14 2019, 00:51
jasonbcox retitled D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags from Take a CTransactiona s argument for ValidateCheckInputsForAllFlags to Take a CTransaction as argument for ValidateCheckInputsForAllFlags.
Jun 14 2019, 00:50
D3327: Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp is now accepted and ready to land.
Jun 14 2019, 00:49
D3326: Relayout comments in validation.cpp is now accepted and ready to land.
Jun 14 2019, 00:45
D3317: Use MakeTransactionRef in serialize_tests.cpp is now accepted and ready to land.
Jun 14 2019, 00:45
D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…) is now accepted and ready to land.
Jun 14 2019, 00:43
D3313: Make float <-> int casts explicit outside of test, qt, CFeeRate is now accepted and ready to land.
Jun 14 2019, 00:34
D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp is now accepted and ready to land.
Jun 14 2019, 00:31
D3329: [txindex] transaction Hash -> TxId now requires changes to proceed.
Jun 14 2019, 00:24
D3315: Make m_coinbase_txns a vector of CTransactionRef is now accepted and ready to land.
Jun 14 2019, 00:19
D3314: coinbaseTxns => m_coinbase_txns is now accepted and ready to land.

For posterity: D3315 explains why the name change is not applied by simply backporting this PR: https://github.com/bitcoin/bitcoin/pull/12949/files

Jun 14 2019, 00:14
teamcity added a comment to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 00:08
jasonbcox committed rABCd44c820bd23a: Bump version to 0.19.9 (authored by jasonbcox).
Bump version to 0.19.9
Jun 14 2019, 00:04
jasonbcox closed D3325: Bump version to 0.19.9.
Jun 14 2019, 00:04
jasonbcox updated the test plan for D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.
Jun 14 2019, 00:03
teamcity added a comment to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 00:02
jasonbcox added a comment to D3193: Added update-chainparams.py to fetch and replace assume valid block values from a node using HTTP RPC.
  • Added unit tests
  • Improved test coverage
  • Added new unit tests as a new cmake target check-devtools
  • Fixed some bugs in the original script as a result of the new tests
Jun 14 2019, 00:01

Jun 13 2019

teamcity added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 23:47
teamcity added a comment to D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 23:41
teamcity added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 23:41
markblundeberg added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

use GetId

Jun 13 2019, 23:40
teamcity added a comment to D3329: [txindex] transaction Hash -> TxId.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 23:40
markblundeberg added inline comments to D3310: Merge #14085: index: Fix for indexers skipping genesis block..
Jun 13 2019, 23:40
teamcity added a comment to D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 23:35
deadalnix created D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.
Jun 13 2019, 23:35
teamcity added a comment to D3329: [txindex] transaction Hash -> TxId.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 23:34
markblundeberg created D3329: [txindex] transaction Hash -> TxId.
Jun 13 2019, 23:34
teamcity added a comment to D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 22:59
teamcity added a comment to D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 22:55
teamcity added a comment to D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 22:52
deadalnix added a comment to D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags.

Remove unecessary copy

Jun 13 2019, 22:51
teamcity added a comment to D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 22:49
deadalnix created D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags.
Jun 13 2019, 22:49
teamcity added a comment to D3327: Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 22:45
teamcity added a comment to D3327: Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 22:38
deadalnix created D3327: Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp.
Jun 13 2019, 22:38
teamcity added a comment to D3326: Relayout comments in validation.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 22:36
markblundeberg planned changes to D3269: move CheckMinimalPush to script.h.
Jun 13 2019, 22:31
markblundeberg planned changes to D3270: add CScript::IsMinimalPushOnly.
Jun 13 2019, 22:31
markblundeberg planned changes to D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Jun 13 2019, 22:31
teamcity added a comment to D3326: Relayout comments in validation.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 22:30
deadalnix created D3326: Relayout comments in validation.cpp.
Jun 13 2019, 22:30
deadalnix added a comment to D3318: [LINTER] Prevent including a source file.

Has this error actually happened in the wild ? Also, do we need a new linter for each thing that can go wrong with includes ? It seems like one should be enough.

Jun 13 2019, 22:26
D3318: [LINTER] Prevent including a source file now requires changes to proceed.

This should also detect the inclusion of a .c .

Jun 13 2019, 22:24
nakihito added a comment to D3283: Merge #10408, #13291, and partial #13163.
In D3283#78033, @deadalnix wrote:

Why are all of these together ?

Jun 13 2019, 22:24
D3310: Merge #14085: index: Fix for indexers skipping genesis block. now requires changes to proceed.
Jun 13 2019, 22:23
D3319: [LINTER] Enforce using angle brackets in #include directives is now accepted and ready to land.
Jun 13 2019, 22:20
markblundeberg added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

What I recall is that the new label commands that get added are sorted in correctly, and it's the existing label entries that are wrong. So we do want this Diff, and indeed some old code isn't cleaned up right.

Jun 13 2019, 22:04
D3325: Bump version to 0.19.9 is now accepted and ready to land.

Looks good

Jun 13 2019, 21:16
teamcity added a comment to D3325: Bump version to 0.19.9.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 20:39
jasonbcox retitled D3325: Bump version to 0.19.9 from Bump version to 0.19.8 to Bump version to 0.19.9.
Jun 13 2019, 20:31
teamcity added a comment to D3325: Bump version to 0.19.9.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 20:31
jasonbcox created D3325: Bump version to 0.19.9.
Jun 13 2019, 20:31
Nico Guiton <nico@bitframe.org> committed rABC4a3656974de3: Merge #9949: [bench] Avoid function call arguments which are pointers to… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #9949: [bench] Avoid function call arguments which are pointers to…
Jun 13 2019, 20:28
Nico Guiton <nico@bitframe.org> closed D3324: Merge #9949: [bench] Avoid function call arguments which are pointers to uninitialized values.
Jun 13 2019, 20:28
jasonbcox added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

Investigate the duplicate RPCs in the help message. It sounds to me like some of the accounts code as either not deprecated correctly or needs to be cleaned up before this is backported.

Jun 13 2019, 20:24
markblundeberg added inline comments to D3323: Add missing release notes for 0.19.8 release.
Jun 13 2019, 20:16
teamcity added a comment to D3324: Merge #9949: [bench] Avoid function call arguments which are pointers to uninitialized values.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 20:05
nakihito updated the test plan for D3324: Merge #9949: [bench] Avoid function call arguments which are pointers to uninitialized values.
Jun 13 2019, 20:02
D3324: Merge #9949: [bench] Avoid function call arguments which are pointers to uninitialized values is now accepted and ready to land.
Jun 13 2019, 20:01
jasonbcox closed D3323: Add missing release notes for 0.19.8 release.
Jun 13 2019, 19:59
jasonbcox committed rABC2f7b26a00036: Add missing release notes for 0.19.8 release (authored by jasonbcox).
Add missing release notes for 0.19.8 release
Jun 13 2019, 19:59
teamcity added a comment to D3324: Merge #9949: [bench] Avoid function call arguments which are pointers to uninitialized values.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 19:59
nakihito created D3324: Merge #9949: [bench] Avoid function call arguments which are pointers to uninitialized values.
Jun 13 2019, 19:58
D3323: Add missing release notes for 0.19.8 release is now accepted and ready to land.
Jun 13 2019, 18:50
jasonbcox committed rABC60dea04ed605: Update manpages for 0.19.8 release (authored by jasonbcox).
Update manpages for 0.19.8 release
Jun 13 2019, 17:55
jasonbcox closed D3322: Update manpages for 0.19.8 release.
Jun 13 2019, 17:55
jasonbcox committed rABC64576902969d: Update seeds for 0.19.8 release (authored by jasonbcox).
Update seeds for 0.19.8 release
Jun 13 2019, 17:54
jasonbcox closed D3320: Update seeds for 0.19.8 release.
Jun 13 2019, 17:54
jasonbcox committed rABCc106fcb25e17: Updated chainparams for 0.19.8 release (authored by jasonbcox).
Updated chainparams for 0.19.8 release
Jun 13 2019, 17:54
jasonbcox closed D3321: Updated chainparams for 0.19.8 release.
Jun 13 2019, 17:54
teamcity added a comment to D3323: Add missing release notes for 0.19.8 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 17:52
teamcity added a comment to D3323: Add missing release notes for 0.19.8 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 17:46
jasonbcox created D3323: Add missing release notes for 0.19.8 release.
Jun 13 2019, 17:46
markblundeberg accepted D3321: Updated chainparams for 0.19.8 release.
Jun 13 2019, 17:45
markblundeberg added a comment to D3321: Updated chainparams for 0.19.8 release.

Confirm (note: at this time the mainnet block is 9 confs old).

Jun 13 2019, 17:45
teamcity added a comment to D3322: Update manpages for 0.19.8 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 17:38
D3322: Update manpages for 0.19.8 release is now accepted and ready to land.
Jun 13 2019, 17:37
D3321: Updated chainparams for 0.19.8 release is now accepted and ready to land.
Jun 13 2019, 17:35
teamcity added a comment to D3321: Updated chainparams for 0.19.8 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 17:32
D3320: Update seeds for 0.19.8 release is now accepted and ready to land.
Jun 13 2019, 17:31
teamcity added a comment to D3322: Update manpages for 0.19.8 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 17:31
jasonbcox created D3322: Update manpages for 0.19.8 release.
Jun 13 2019, 17:31
First
Prev
Next