Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Jun 14 2019

teamcity added a comment to D3341: Add benchmark for AES.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 20:03

Fabien created D3341: Add benchmark for AES.

Jun 14 2019, 20:03

teamcity added a comment to D3340: Cleanup ibd.sh.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 18:52

teamcity added a comment to D3340: Cleanup ibd.sh.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 18:46

jasonbcox planned changes to D3340: Cleanup ibd.sh.

Jun 14 2019, 18:46

jasonbcox created D3340: Cleanup ibd.sh.

Jun 14 2019, 18:45

teamcity added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 18:34

teamcity added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 18:28

markblundeberg added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

rebase for good measure

Jun 14 2019, 18:28

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCb343df905518: [txindex] transaction Hash -> TxId (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).

[txindex] transaction Hash -> TxId

Jun 14 2019, 18:21

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3329: [txindex] transaction Hash -> TxId.

Jun 14 2019, 18:21

jasonbcox committed rABC164b37e003d6: Explicitly call out updating makeseeds.py after major releases (authored by jasonbcox).

Explicitly call out updating makeseeds.py after major releases

Jun 14 2019, 18:16

jasonbcox closed D3292: Explicitly call out updating makeseeds.py after major releases.

Jun 14 2019, 18:16

teamcity added a comment to D3329: [txindex] transaction Hash -> TxId.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 17:48

teamcity added a comment to D3329: [txindex] transaction Hash -> TxId.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 17:41

markblundeberg added a comment to D3329: [txindex] transaction Hash -> TxId.

rebase for conflict (txindex_tests' GetHash -> GetId changes were done in D3315 too)

Jun 14 2019, 17:41

teamcity added a comment to D3339: Make CMutableTransaction constructor explicit.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 17:27

teamcity added a comment to D3339: Make CMutableTransaction constructor explicit.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 17:17

deadalnix created D3339: Make CMutableTransaction constructor explicit.

Jun 14 2019, 17:17

teamcity added a comment to D3338: bitcoin-tx: Remove unused for loop.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 17:08

teamcity added a comment to D3337: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 17:06

teamcity added a comment to D3338: bitcoin-tx: Remove unused for loop.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 16:58

deadalnix created D3338: bitcoin-tx: Remove unused for loop.

Jun 14 2019, 16:58

teamcity added a comment to D3337: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 16:55

deadalnix created D3337: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&).

Jun 14 2019, 16:55

teamcity added a comment to D3336: tests: Avoid copies of CTransaction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 16:37

markblundeberg updated the task description for T653: Clean up past upgrades.

Jun 14 2019, 16:33

markblundeberg updated the test plan for D3253: Remove Schnorr activation.

Jun 14 2019, 16:30

teamcity added a comment to D3336: tests: Avoid copies of CTransaction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 16:28

deadalnix created D3336: tests: Avoid copies of CTransaction.

Jun 14 2019, 16:28

D3329: [txindex] transaction Hash -> TxId is now accepted and ready to land.

Jun 14 2019, 16:18

deadalnix committed rABCdf7e2bdc4ea5: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp (authored by deadalnix).

Directly use CMutableTransaction more often in txvaidationcache_tests.cpp

Jun 14 2019, 15:54

deadalnix closed D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.

Jun 14 2019, 15:53

deadalnix committed rABCaf600301e61b: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool… (authored by practicalswift <practicalswift@users.noreply.github.com>).

mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool…

Jun 14 2019, 15:53

deadalnix closed D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).

Jun 14 2019, 15:53

teamcity added a comment to D3335: [LINTER] Make the check-doc linter run only once.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 15:22

teamcity added a comment to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 15:18

teamcity added a comment to D3335: [LINTER] Make the check-doc linter run only once.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 15:16

Fabien created D3335: [LINTER] Make the check-doc linter run only once.

Jun 14 2019, 15:16

teamcity added a comment to D3334: [LINTER] Set the rules for the phpdoc comments.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 15:14

teamcity added a comment to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 15:07

deadalnix added a comment to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).

rebase

Jun 14 2019, 15:07

teamcity added a comment to D3334: [LINTER] Set the rules for the phpdoc comments.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 15:05

Fabien created D3334: [LINTER] Set the rules for the phpdoc comments.

Jun 14 2019, 15:05

teamcity added a comment to D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 13:49

teamcity added a comment to D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 13:40

deadalnix added a comment to D3330: Directly use CMutableTransaction more often in txvaidationcache_tests.cpp.

Rebase

Jun 14 2019, 13:39

deadalnix committed rABCbd6817fcbf75: Take a CTransaction as argument for ValidateCheckInputsForAllFlags (authored by deadalnix).

Take a CTransaction as argument for ValidateCheckInputsForAllFlags

Jun 14 2019, 13:25

deadalnix closed D3328: Take a CTransaction as argument for ValidateCheckInputsForAllFlags.

Jun 14 2019, 13:25

deadalnix committed rABC8ccdaf871c43: Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp (authored by deadalnix).

Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp

Jun 14 2019, 13:23

deadalnix closed D3327: Avoid creating transaction copies in script_tests.cpp and multisig_tests.cpp.

Jun 14 2019, 13:23

deadalnix committed rABC137afdf1c0f2: Use MakeTransactionRef in serialize_tests.cpp (authored by deadalnix).

Use MakeTransactionRef in serialize_tests.cpp

Jun 14 2019, 13:20

deadalnix closed D3317: Use MakeTransactionRef in serialize_tests.cpp.

Jun 14 2019, 13:20

deadalnix added inline comments to D3318: [LINTER] Prevent including a source file.

Jun 14 2019, 13:18

deadalnix committed rABC2109be3bca2a: Update mempool eviction benchmark (authored by deadalnix).

Update mempool eviction benchmark

Jun 14 2019, 13:18

deadalnix closed D3316: Update mempool eviction benchmark.

Jun 14 2019, 13:18

D3292: Explicitly call out updating makeseeds.py after major releases is now accepted and ready to land.

Jun 14 2019, 13:17

D3333: Avoid including a C file in crypto/aes.cpp now requires changes to proceed.

I suspect this might be pretty bad for performance. I also suspect you don't intend to become maintainer of ctaes.

Jun 14 2019, 13:16

deadalnix committed rABC175362193461: Make m_coinbase_txns a vector of CTransactionRef (authored by deadalnix).

Make m_coinbase_txns a vector of CTransactionRef

Jun 14 2019, 13:16

deadalnix closed D3315: Make m_coinbase_txns a vector of CTransactionRef.

Jun 14 2019, 13:16

deadalnix accepted D3329: [txindex] transaction Hash -> TxId.

Jun 14 2019, 13:15

deadalnix committed rABCe4c7e9c8b157: coinbaseTxns => m_coinbase_txns (authored by deadalnix).

coinbaseTxns => m_coinbase_txns

Jun 14 2019, 13:07

deadalnix closed D3314: coinbaseTxns => m_coinbase_txns.

Jun 14 2019, 13:07

deadalnix committed rABC861e1e268cd6: Relayout comments in validation.cpp (authored by Andrew Chow <achow101-github@achow101.com>).

Relayout comments in validation.cpp

Jun 14 2019, 12:56

deadalnix closed D3326: Relayout comments in validation.cpp.

Jun 14 2019, 12:56

teamcity added a comment to D3319: [LINTER] Enforce using angle brackets in #include directives.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 12:22

teamcity added a comment to D3318: [LINTER] Prevent including a source file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 12:15

teamcity added a comment to D3319: [LINTER] Enforce using angle brackets in #include directives.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 12:15

Fabien added a comment to D3319: [LINTER] Enforce using angle brackets in #include directives.

Remove useless parent method overriding.

Jun 14 2019, 12:15

Fabien updated the summary of D3318: [LINTER] Prevent including a source file.

Jun 14 2019, 12:10

teamcity added a comment to D3318: [LINTER] Prevent including a source file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 12:09

Fabien added a comment to D3318: [LINTER] Prevent including a source file.

Check for *.c inclusion.
Fix indent.

Jun 14 2019, 12:09

teamcity added a comment to D3333: Avoid including a C file in crypto/aes.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 12:09

teamcity added a comment to D3333: Avoid including a C file in crypto/aes.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 12:00

Fabien created D3333: Avoid including a C file in crypto/aes.cpp.

Jun 14 2019, 12:00

Fabien added a comment to D3318: [LINTER] Prevent including a source file.

@deadalnix Yes this error did appear:
https://reviews.bitcoinabc.org/D3283?id=9308#inline-20242

Jun 14 2019, 07:43

Fabien committed rABC022cd307933d: Make float <-> int casts explicit outside of test, qt, CFeeRate (authored by Matt Corallo <git@bluematt.me>).

Make float <-> int casts explicit outside of test, qt, CFeeRate

Jun 14 2019, 07:28

Fabien closed D3313: Make float <-> int casts explicit outside of test, qt, CFeeRate.

Jun 14 2019, 07:28

D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific is now accepted and ready to land.

Jun 14 2019, 06:37

Fabien accepted D3310: Merge #14085: index: Fix for indexers skipping genesis block..

Jun 14 2019, 06:31

Fabien accepted D3329: [txindex] transaction Hash -> TxId.

Jun 14 2019, 06:22

teamcity added a comment to D3255: Remove unused great wall activation code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 04:59

teamcity added a comment to D3254: Revert "add flags to VerifySignature and sigcache".

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 04:55

markblundeberg added a comment to D3253: Remove Schnorr activation.

(Note that the functional test is identical to the prior version of this diff. This diff changes all externally-observable behaviour, and the follow ups just perform internal cleanup.)

Jun 14 2019, 04:53

markblundeberg retitled D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests from remove Schnorr flag and clean up tests to remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.

Jun 14 2019, 04:51

markblundeberg updated the summary of D3265: add new encoding checker for Schnorr sigs.

Jun 14 2019, 04:51

teamcity added a comment to D3255: Remove unused great wall activation code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 04:50

markblundeberg added a comment to D3255: Remove unused great wall activation code.

rebase onto split parent

Jun 14 2019, 04:49

teamcity added a comment to D3254: Revert "add flags to VerifySignature and sigcache".

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 04:48

markblundeberg updated the summary of D3254: Revert "add flags to VerifySignature and sigcache".

rebased onto split parent

Jun 14 2019, 04:47

teamcity added a comment to D3264: sigencoding_tests: improve test coverage.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 04:42

teamcity added a comment to D3264: sigencoding_tests: improve test coverage.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 04:35

markblundeberg updated the summary of D3264: sigencoding_tests: improve test coverage.

rebased onto split-up schnorr removal diffs

Jun 14 2019, 04:35

teamcity added a comment to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 14 2019, 04:34

markblundeberg added a comment to D3253: Remove Schnorr activation.

Now split out into three parts: D3253 (this) and D3331 and then D3332. The final result after D3332 is identical to unsplit version.

Jun 14 2019, 04:26

markblundeberg added a revision to T653: Clean up past upgrades: D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.

Jun 14 2019, 04:26

markblundeberg added a task to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests: T653: Clean up past upgrades.

Jun 14 2019, 04:26

teamcity added a comment to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 14 2019, 04:26

markblundeberg created D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.

Jun 14 2019, 04:25

markblundeberg added a revision to T653: Clean up past upgrades: D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.

Jun 14 2019, 04:23