Page MenuHomePhabricator
Feed Advanced Search

Oct 1 2019

fpelliccioni created D4189: Remove redundant assignments (dead stores).
Oct 1 2019, 15:41
fpelliccioni created D4186: refactor: Avoid locking tx pool cs thrice.
Oct 1 2019, 13:32

Sep 30 2019

fpelliccioni created D4179: Return void instead of bool for functions that cannot fail.
Sep 30 2019, 15:08
fpelliccioni committed rABC44a1e1cd6c81: doxygen: Fix member comments (authored by MarcoFalke <falke.marco@gmail.com>).
doxygen: Fix member comments
Sep 30 2019, 13:20
fpelliccioni closed D4173: doxygen: Fix member comments.
Sep 30 2019, 13:20
fpelliccioni created D4178: validation: Pass tx pool reference into CheckSequenceLocks.
Sep 30 2019, 13:18

Sep 27 2019

fpelliccioni committed rSTAGINGed346d416fd1: Avoid locking mutexes that are already held by the same thread (authored by practicalswift <practicalswift@users.noreply.github.com>).
Avoid locking mutexes that are already held by the same thread
Sep 27 2019, 22:49
fpelliccioni committed rSTAGINGb77978dd2b65: Move cs_main locking annotations from .cpp to .h (authored by practicalswift <practicalswift@users.noreply.github.com>).
Move cs_main locking annotations from .cpp to .h
Sep 27 2019, 22:49
fpelliccioni committed rSTAGING46b2cbc8507b: Remove redundant variables, statements and forward declarations (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant variables, statements and forward declarations
Sep 27 2019, 22:48
fpelliccioni committed rSTAGINGb5e2c50e1509: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 (authored by practicalswift <practicalswift@users.noreply.github.com>).
Fix compiler warnings emitted when compiling under stock OpenBSD 6.3
Sep 27 2019, 22:48
fpelliccioni committed rSTAGINGea8cef58c8dc: debug log number of unknown wallet records on load (authored by fpelliccioni).
debug log number of unknown wallet records on load
Sep 27 2019, 22:46
fpelliccioni committed rSTAGING9f466fe7a8ec: Add compile time verification of assumptions we're currently making… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Add compile time verification of assumptions we're currently making…
Sep 27 2019, 22:46
fpelliccioni committed rSTAGINGcf2b6f7276f0: bench: Use non-throwing ParseDouble(...) instead of throwing boost… (authored by fpelliccioni).
bench: Use non-throwing ParseDouble(...) instead of throwing boost…
Sep 27 2019, 22:46
fpelliccioni committed rSTAGING2ec61ddea958: [qt] send: Clear All also resets coin control options (authored by fpelliccioni).
[qt] send: Clear All also resets coin control options
Sep 27 2019, 22:46
fpelliccioni committed rSTAGING2d6763dd0b83: [qt] Replaces numbered place marker %2 with %1. (authored by fpelliccioni).
[qt] Replaces numbered place marker %2 with %1.
Sep 27 2019, 22:45
fpelliccioni updated the test plan for D4173: doxygen: Fix member comments.
Sep 27 2019, 17:59
fpelliccioni created D4173: doxygen: Fix member comments.
Sep 27 2019, 17:58
fpelliccioni committed rABCed346d416fd1: Avoid locking mutexes that are already held by the same thread (authored by practicalswift <practicalswift@users.noreply.github.com>).
Avoid locking mutexes that are already held by the same thread
Sep 27 2019, 14:24
fpelliccioni closed D4145: Avoid locking mutexes that are already held by the same thread.
Sep 27 2019, 14:24
fpelliccioni updated the diff for D4145: Avoid locking mutexes that are already held by the same thread.

Rebase from master branch.

Sep 27 2019, 13:46

Sep 25 2019

fpelliccioni committed rABCb77978dd2b65: Move cs_main locking annotations from .cpp to .h (authored by practicalswift <practicalswift@users.noreply.github.com>).
Move cs_main locking annotations from .cpp to .h
Sep 25 2019, 12:41
fpelliccioni closed D4149: Move cs_main locking annotations from .cpp to .h.
Sep 25 2019, 12:41

Sep 24 2019

fpelliccioni updated the test plan for D4149: Move cs_main locking annotations from .cpp to .h.
Sep 24 2019, 19:54
fpelliccioni created D4149: Move cs_main locking annotations from .cpp to .h.
Sep 24 2019, 19:52
fpelliccioni committed rABC46b2cbc8507b: Remove redundant variables, statements and forward declarations (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant variables, statements and forward declarations
Sep 24 2019, 18:12
fpelliccioni closed D4142: Remove redundant variables, statements and forward declarations.
Sep 24 2019, 18:11
fpelliccioni updated the diff for D4145: Avoid locking mutexes that are already held by the same thread.

Test Plan fixed.

Sep 24 2019, 15:16
fpelliccioni updated the test plan for D4145: Avoid locking mutexes that are already held by the same thread.
Sep 24 2019, 15:15
fpelliccioni updated the test plan for D4145: Avoid locking mutexes that are already held by the same thread.
Sep 24 2019, 15:06
fpelliccioni updated the test plan for D4145: Avoid locking mutexes that are already held by the same thread.
Sep 24 2019, 15:06
fpelliccioni committed rABCb5e2c50e1509: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 (authored by practicalswift <practicalswift@users.noreply.github.com>).
Fix compiler warnings emitted when compiling under stock OpenBSD 6.3
Sep 24 2019, 12:56
fpelliccioni closed D4141: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3.
Sep 24 2019, 12:56
fpelliccioni added a comment to D4142: Remove redundant variables, statements and forward declarations.

Can you clarify if the other instances are missing or all of them are already applied to the codebase?

Sep 24 2019, 12:47
fpelliccioni created D4145: Avoid locking mutexes that are already held by the same thread.
Sep 24 2019, 12:35

Sep 23 2019

fpelliccioni created D4142: Remove redundant variables, statements and forward declarations.
Sep 23 2019, 21:47
fpelliccioni updated the test plan for D4141: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3.
Sep 23 2019, 21:18
fpelliccioni created D4141: Fix compiler warnings emitted when compiling under stock OpenBSD 6.3.
Sep 23 2019, 21:14

Sep 20 2019

fpelliccioni committed rABCea8cef58c8dc: debug log number of unknown wallet records on load (authored by fpelliccioni).
debug log number of unknown wallet records on load
Sep 20 2019, 18:21
fpelliccioni closed D4079: debug log number of unknown wallet records on load.
Sep 20 2019, 18:21
fpelliccioni committed rABC9f466fe7a8ec: Add compile time verification of assumptions we're currently making… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Add compile time verification of assumptions we're currently making…
Sep 20 2019, 18:18
fpelliccioni closed D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.
Sep 20 2019, 18:17
fpelliccioni updated the diff for D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.

Removes obvious type checks.

Sep 20 2019, 13:16
fpelliccioni updated the diff for D4079: debug log number of unknown wallet records on load.

Test plan fixed.

Sep 20 2019, 13:03
fpelliccioni updated the test plan for D4079: debug log number of unknown wallet records on load.
Sep 20 2019, 13:01
fpelliccioni committed rABCcf2b6f7276f0: bench: Use non-throwing ParseDouble(...) instead of throwing boost… (authored by fpelliccioni).
bench: Use non-throwing ParseDouble(...) instead of throwing boost…
Sep 20 2019, 12:38
fpelliccioni closed D4080: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...).
Sep 20 2019, 12:38
fpelliccioni committed rABC2ec61ddea958: [qt] send: Clear All also resets coin control options (authored by fpelliccioni).
[qt] send: Clear All also resets coin control options
Sep 20 2019, 12:38
fpelliccioni closed D4078: [qt] send: Clear All also resets coin control options.
Sep 20 2019, 12:37
fpelliccioni committed rABC2d6763dd0b83: [qt] Replaces numbered place marker %2 with %1. (authored by fpelliccioni).
[qt] Replaces numbered place marker %2 with %1.
Sep 20 2019, 12:36
fpelliccioni closed D4077: [qt] Replaces numbered place marker %2 with %1..
Sep 20 2019, 12:36

Sep 19 2019

fpelliccioni committed rSTAGINGd6572b18700b: [trivial,doc] Fix memory consistency model in comment (authored by Jesse Cohen <jc@jc.lol>).
[trivial,doc] Fix memory consistency model in comment
Sep 19 2019, 02:20
fpelliccioni committed rSTAGINGa3cc9379de00: [qt] coincontrol: Remove unused qt4 workaround (authored by MarcoFalke <falke.marco@gmail.com>).
[qt] coincontrol: Remove unused qt4 workaround
Sep 19 2019, 02:19
fpelliccioni committed rSTAGINGb3925b2d6bb9: [build] .gitignore: add QT Creator artifacts (authored by Sjors Provoost <sjors@sprovoost.nl>).
[build] .gitignore: add QT Creator artifacts
Sep 19 2019, 02:19
fpelliccioni committed rSTAGING74a94f46047a: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json (authored by Chris Stewart <stewart.chris1234@gmail.com>).
Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json
Sep 19 2019, 02:19
fpelliccioni committed rSTAGINGc635eefa921b: Fixes compilation of leveldb tests broken in D4004 (authored by fpelliccioni).
Fixes compilation of leveldb tests broken in D4004
Sep 19 2019, 02:17
fpelliccioni committed rSTAGING39e41a449cfb: Do not construct out-of-bound pointers in SHA2 code (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Do not construct out-of-bound pointers in SHA2 code
Sep 19 2019, 02:16
fpelliccioni committed rSTAGING4210ed4fcc0e: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid…
Sep 19 2019, 02:16
fpelliccioni committed rSTAGING29fec420b3e2: Pull leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Pull leveldb subtree
Sep 19 2019, 02:16
fpelliccioni committed rSTAGING4ab217db8523: [rebase] threads: fix unitialized members in sched_param (authored by Cory Fields <cory-nospam-@coryfields.com>).
[rebase] threads: fix unitialized members in sched_param
Sep 19 2019, 02:10
fpelliccioni committed rSTAGING55441ec79bdb: Update univalue subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Update univalue subtree
Sep 19 2019, 02:10
fpelliccioni committed rSTAGING85bc68c4608a: Merge leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Merge leveldb subtree
Sep 19 2019, 02:10
fpelliccioni committed rSTAGING707568ec5670: Bump leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Bump leveldb subtree
Sep 19 2019, 02:10
fpelliccioni committed rSTAGING5c1f643c9f97: wallet: Catch filesystem_error and raise InitError (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Catch filesystem_error and raise InitError
Sep 19 2019, 02:08
fpelliccioni committed rSTAGING966fa58918e3: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon… (authored by Luke Dashjr <luke-jr+git@utopios.org>).
During IBD, when doing pruning, prune 10% extra to avoid pruning again soon…
Sep 19 2019, 02:08
fpelliccioni committed rSTAGING1bf9852e2c50: Default to defining endian-conversion DECLs in compat w/o config (authored by Matt Corallo <git@bluematt.me>).
Default to defining endian-conversion DECLs in compat w/o config
Sep 19 2019, 02:06
fpelliccioni committed rSTAGING51fbdf464a64: Consistently log CValidationState on failure (authored by Ben Woosley <ben.woosley@gmail.com>).
Consistently log CValidationState on failure
Sep 19 2019, 02:06
fpelliccioni committed rSTAGING8b217943d251: Add DynamicMemoryUsage() to LevelDB (authored by Evan Klitzke <evan@eklitzke.org>).
Add DynamicMemoryUsage() to LevelDB
Sep 19 2019, 02:01
fpelliccioni committed rSTAGING7b0d5028a6b5: use base58 map instead of strchr() (authored by Kevin Pan <bit.kevin@gmail.com>).
use base58 map instead of strchr()
Sep 19 2019, 02:01
fpelliccioni committed rSTAGING613c7d202468: trivial: Improve include comment in src/interfaces/wallet.h (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
trivial: Improve include comment in src/interfaces/wallet.h
Sep 19 2019, 01:58

Sep 18 2019

fpelliccioni updated the diff for D4005: cli: Ignore libevent warnings.

Code style: comment moved.

Sep 18 2019, 18:13
fpelliccioni added inline comments to D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.
Sep 18 2019, 18:08
fpelliccioni added inline comments to D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.
Sep 18 2019, 18:05
fpelliccioni updated the diff for D4078: [qt] send: Clear All also resets coin control options.

Test plan updated.

Sep 18 2019, 17:53
fpelliccioni updated the test plan for D4078: [qt] send: Clear All also resets coin control options.
Sep 18 2019, 17:52

Sep 17 2019

fpelliccioni abandoned D4066: [build] Tune wildcards for LIBSECP256K1 target.

As I told Fabien a few hours ago, I will avoid (for the moment) doing backports related to the build system.

Sep 17 2019, 19:55
fpelliccioni updated the diff for D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.

Fixed following Fabien suggestions.

Sep 17 2019, 19:41
fpelliccioni planned changes to D4009: zmq: log outbound message high water mark when reusing socket.

It depends on other backports not done yet.

Sep 17 2019, 19:20
fpelliccioni updated the diff for D4005: cli: Ignore libevent warnings.

updated test plan.

Sep 17 2019, 18:56
fpelliccioni updated the test plan for D4005: cli: Ignore libevent warnings.
Sep 17 2019, 18:55
fpelliccioni updated the test plan for D4005: cli: Ignore libevent warnings.
Sep 17 2019, 18:53
fpelliccioni planned changes to D4075: Integration of property based testing into Bitcoin Core.

Needs documentation.
Needs to port to CMake.
Needs some testing.

Sep 17 2019, 17:09
fpelliccioni updated the test plan for D4075: Integration of property based testing into Bitcoin Core.
Sep 17 2019, 17:08
fpelliccioni updated the diff for D4077: [qt] Replaces numbered place marker %2 with %1..

test plan updated.

Sep 17 2019, 16:14
fpelliccioni updated the test plan for D4077: [qt] Replaces numbered place marker %2 with %1..
Sep 17 2019, 16:11

Sep 13 2019

fpelliccioni created D4080: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...).
Sep 13 2019, 22:29
fpelliccioni created D4079: debug log number of unknown wallet records on load.
Sep 13 2019, 22:29
fpelliccioni created D4078: [qt] send: Clear All also resets coin control options.
Sep 13 2019, 22:28
fpelliccioni created D4077: [qt] Replaces numbered place marker %2 with %1..
Sep 13 2019, 22:28
fpelliccioni created D4075: Integration of property based testing into Bitcoin Core.
Sep 13 2019, 20:23
fpelliccioni committed rABCd6572b18700b: [trivial,doc] Fix memory consistency model in comment (authored by Jesse Cohen <jc@jc.lol>).
[trivial,doc] Fix memory consistency model in comment
Sep 13 2019, 17:41
fpelliccioni closed D4068: [trivial,doc] Fix memory consistency model in comment.
Sep 13 2019, 17:41
fpelliccioni committed rABCa3cc9379de00: [qt] coincontrol: Remove unused qt4 workaround (authored by MarcoFalke <falke.marco@gmail.com>).
[qt] coincontrol: Remove unused qt4 workaround
Sep 13 2019, 17:41
fpelliccioni closed D4065: [qt] coincontrol: Remove unused qt4 workaround.
Sep 13 2019, 17:40
fpelliccioni committed rABCb3925b2d6bb9: [build] .gitignore: add QT Creator artifacts (authored by Sjors Provoost <sjors@sprovoost.nl>).
[build] .gitignore: add QT Creator artifacts
Sep 13 2019, 17:38
fpelliccioni closed D4063: [build] .gitignore: add QT Creator artifacts.
Sep 13 2019, 17:38
fpelliccioni committed rABC74a94f46047a: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json (authored by Chris Stewart <stewart.chris1234@gmail.com>).
Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json
Sep 13 2019, 17:36
fpelliccioni closed D4062: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json.
Sep 13 2019, 17:36
fpelliccioni added a comment to D4062: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json.

check-all is unnecessary in that case. If you use cmake, I strongly advise you use ninja instead of make and it is way faster.

Sep 13 2019, 17:19
fpelliccioni abandoned D4064: [depends] Allow depends system to support armv7l.

Talked with Fabien, it is not worth backporting it.

Sep 13 2019, 17:15

Sep 12 2019

fpelliccioni abandoned D4067: bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err.

segwit related, I have to re-check it.

Sep 12 2019, 21:09