Page MenuHomePhabricator
Feed All Stories

Jan 17 2020

Fabien added a comment to D5006: [CMAKE] Fix daemon() detection on OSX.

I tested the binary from the Gitian build and it doesn't have the issue.

Jan 17 2020, 20:45
teamcity added a comment to D5005: Merge #13862: utils: drop boost::interprocess::file_lock.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 20:42
teamcity added a comment to D5006: [CMAKE] Fix daemon() detection on OSX.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Jan 17 2020, 20:42
teamcity added a comment to D5006: [CMAKE] Fix daemon() detection on OSX.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

Jan 17 2020, 20:38
teamcity added a comment to D5006: [CMAKE] Fix daemon() detection on OSX.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 20:34
Fabien created D5006: [CMAKE] Fix daemon() detection on OSX.
Jan 17 2020, 20:34
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 20:31
nakihito updated the diff for D4418: Add simple unit tests for parse_name().

assert() -> BOOST_CHECK_EQUAL(). More clarification to comments. Added testing for a maximum sized label.

Jan 17 2020, 20:31
nakihito added inline comments to D4418: Add simple unit tests for parse_name().
Jan 17 2020, 20:31
teamcity added a comment to D5005: Merge #13862: utils: drop boost::interprocess::file_lock.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 20:25
Harbormaster failed remote builds in B9031: Diff 15620 for D5005: Merge #13862: utils: drop boost::interprocess::file_lock!
Jan 17 2020, 20:06
teamcity added a comment to D5005: Merge #13862: utils: drop boost::interprocess::file_lock.
Jan 17 2020, 20:06
teamcity added a comment to D5005: Merge #13862: utils: drop boost::interprocess::file_lock.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 19:55
jasonbcox created D5005: Merge #13862: utils: drop boost::interprocess::file_lock.
Jan 17 2020, 19:54
nakihito committed rABC901fe9802776: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans) (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans)
Jan 17 2020, 19:38
nakihito closed D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).
Jan 17 2020, 19:38
jasonbcox committed rABCe65bde748260: Temporary fix for recent build flakiness (authored by jasonbcox).
Temporary fix for recent build flakiness
Jan 17 2020, 19:24
jasonbcox closed D5003: Temporary fix for recent build flakiness.
Jan 17 2020, 19:24
nakihito committed rABCfd82b9f9f31c: Merge #13126: util: Add Clang thread safety annotations for variables guarded… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13126: util: Add Clang thread safety annotations for variables guarded…
Jan 17 2020, 19:22
nakihito closed D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args.
Jan 17 2020, 19:22
Fabien accepted D5003: Temporary fix for recent build flakiness.
Jan 17 2020, 19:18
teamcity added a comment to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 19:07
teamcity added a comment to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 19:02
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 19:00
teamcity added a comment to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 18:54
teamcity added a comment to D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 18:52
jasonbcox created D5004: Merge #14146: wallet: Remove trailing separators from -walletdir arg.
Jan 17 2020, 18:44
jasonbcox accepted D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).

For posterity: the failed run was on the wrong build agent and should be ignored. The resource intensive build passed as expected.

Jan 17 2020, 18:38
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 18:26
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 18:22
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 18:17
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 18:12
nakihito requested review of D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).
Jan 17 2020, 18:11
jasonbcox committed rABCf1b94edf4392: Update manpages for 0.20.11 release (authored by jasonbcox).
Update manpages for 0.20.11 release
Jan 17 2020, 18:07
jasonbcox closed D4969: Update manpages for 0.20.11 release.
Jan 17 2020, 18:07
jasonbcox committed rABC5b51ba74e77a: Merge #12804: [tests] Fix intermittent rpc_net.py failure. (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12804: [tests] Fix intermittent rpc_net.py failure.
Jan 17 2020, 18:07
jasonbcox closed D4966: Merge #12804: [tests] Fix intermittent rpc_net.py failure..
Jan 17 2020, 18:07
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 18:06
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 18:06
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 18:06
jasonbcox committed rABC91dde1e3db09: Update seeds (authored by jasonbcox).
Update seeds
Jan 17 2020, 18:06
jasonbcox closed D4970: Update seeds.
Jan 17 2020, 18:06
jasonbcox committed rABCff116589e783: Update chainparams (authored by jasonbcox).
Update chainparams
Jan 17 2020, 18:05
jasonbcox closed D4968: Update chainparams.
Jan 17 2020, 18:05
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 18:02
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 18:02
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 18:02
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 18:02
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 18:02
teamcity added a comment to D5003: Temporary fix for recent build flakiness.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 18:02
jasonbcox created D5003: Temporary fix for recent build flakiness.
Jan 17 2020, 18:01
deadalnix committed rABC634c2286f402: [cmake] Always run native build standalone (authored by deadalnix).
[cmake] Always run native build standalone
Jan 17 2020, 17:41
deadalnix closed D5001: [cmake] Always run native build standalone.
Jan 17 2020, 17:41
deadalnix accepted D4968: Update chainparams.
Jan 17 2020, 17:38
teamcity added a comment to D4968: Update chainparams.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 17:33
teamcity added a comment to D5001: [cmake] Always run native build standalone.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 17:32
teamcity added a comment to D4968: Update chainparams.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 17:29
teamcity added a comment to D5001: [cmake] Always run native build standalone.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 17:17
deadalnix accepted D5002: [CMAKE] Get rid of `add_compiler_flags_to_var`.
Jan 17 2020, 16:44
teamcity added a comment to D5002: [CMAKE] Get rid of `add_compiler_flags_to_var`.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 16:40
teamcity added a comment to D4961: [CMAKE] Add a check_linker_flag function.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 16:36
Fabien requested review of D5002: [CMAKE] Get rid of `add_compiler_flags_to_var`.
Jan 17 2020, 16:27
teamcity added a comment to D5002: [CMAKE] Get rid of `add_compiler_flags_to_var`.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 16:25
teamcity added a comment to D4961: [CMAKE] Add a check_linker_flag function.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 16:25
deadalnix updated the diff for D5001: [cmake] Always run native build standalone.

Rerun build

Jan 17 2020, 16:22
deadalnix committed rABC9d9fd76f3b0f: Note intention of timing sidechannel freeness. (authored by Gregory Maxwell <greg@xiph.org>).
Note intention of timing sidechannel freeness.
Jan 17 2020, 16:18
deadalnix closed D5000: Note intention of timing sidechannel freeness..
Jan 17 2020, 16:18
deadalnix committed rABC308c4b941203: configure: Use CFLAGS_FOR_BUILD when checking native compiler (authored by Tim Ruffing <crypto@timruffing.de>).
configure: Use CFLAGS_FOR_BUILD when checking native compiler
Jan 17 2020, 16:16
deadalnix closed D4997: configure: Use CFLAGS_FOR_BUILD when checking native compiler.
Jan 17 2020, 16:16
deadalnix committed rABCbea9546d907e: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config (authored by DesWurstes <DesWurstes@users.noreply.github.com>).
Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config
Jan 17 2020, 16:14
deadalnix closed D4996: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config.
Jan 17 2020, 16:14
deadalnix requested changes to D5002: [CMAKE] Get rid of `add_compiler_flags_to_var`.
Jan 17 2020, 16:12
deadalnix committed rABCed9587d98918: Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...)
Jan 17 2020, 16:12
deadalnix closed D4995: Make sure we're not using an uninitialized variable in secp256k1_wnaf_const(...).
Jan 17 2020, 16:12
deadalnix committed rABC242e9d4bc7b5: Pass scalar by reference in secp256k1_wnaf_const() (authored by Tim Ruffing <crypto@timruffing.de>).
Pass scalar by reference in secp256k1_wnaf_const()
Jan 17 2020, 16:10
deadalnix closed D4994: Pass scalar by reference in secp256k1_wnaf_const().
Jan 17 2020, 16:09
deadalnix closed D4998: Avoid implementation-defined and undefined behavior when dealing with sizes.
Jan 17 2020, 16:08
deadalnix committed rABC56260aeec5fc: Avoid implementation-defined and undefined behavior when dealing with sizes (authored by Tim Ruffing <crypto@timruffing.de>).
Avoid implementation-defined and undefined behavior when dealing with sizes
Jan 17 2020, 16:08
Harbormaster failed remote builds in B9024: Diff 15597 for D5001: [cmake] Always run native build standalone!
Jan 17 2020, 16:07
teamcity added a comment to D5001: [cmake] Always run native build standalone.
Jan 17 2020, 16:07
Harbormaster failed remote builds in B9025: Diff 15598 for D5001: [cmake] Always run native build standalone!
Jan 17 2020, 16:04
teamcity added a comment to D5001: [cmake] Always run native build standalone.
Jan 17 2020, 16:04
Fabien created D5002: [CMAKE] Get rid of `add_compiler_flags_to_var`.
Jan 17 2020, 16:02
teamcity added a comment to D4999: Guard memcmp in tests against mixed size inputs..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 15:59
Fabien updated the diff for D4961: [CMAKE] Add a check_linker_flag function.

Rebase.

Jan 17 2020, 15:59
teamcity added a comment to D5001: [cmake] Always run native build standalone.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 15:59
teamcity added a comment to D4998: Avoid implementation-defined and undefined behavior when dealing with sizes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 15:58
teamcity added a comment to D5001: [cmake] Always run native build standalone.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 15:56
Fabien accepted D5001: [cmake] Always run native build standalone.
Jan 17 2020, 15:54
teamcity added a comment to D5000: Note intention of timing sidechannel freeness..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 15:49
deadalnix committed rABCfd526a1dc259: Guard memcmp in tests against mixed size inputs. (authored by Gregory Maxwell <greg@xiph.org>).
Guard memcmp in tests against mixed size inputs.
Jan 17 2020, 15:48
deadalnix closed D4999: Guard memcmp in tests against mixed size inputs..
Jan 17 2020, 15:48
teamcity added a comment to D5000: Note intention of timing sidechannel freeness..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 15:45
deadalnix committed rABCa071308f1954: Use __GNUC_PREREQ for detecting __builtin_expect (authored by Tim Ruffing <crypto@timruffing.de>).
Use __GNUC_PREREQ for detecting __builtin_expect
Jan 17 2020, 15:45
teamcity added a comment to D4999: Guard memcmp in tests against mixed size inputs..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 15:45
deadalnix closed D4973: Use __GNUC_PREREQ for detecting __builtin_expect.
Jan 17 2020, 15:45
teamcity added a comment to D4998: Avoid implementation-defined and undefined behavior when dealing with sizes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 15:44
deadalnix updated the diff for D5001: [cmake] Always run native build standalone.

Tweaks

Jan 17 2020, 15:42
Fabien accepted D4973: Use __GNUC_PREREQ for detecting __builtin_expect.

Looking into it a bit more, a lot of features are already made GCC only with this macro, so let this move forward for the sake of keeping in sync.

Jan 17 2020, 15:40
deadalnix created D5001: [cmake] Always run native build standalone.
Jan 17 2020, 15:39