update comment, second argument to execlp needs to be nonnull
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 10 2020
Feb 10 2020
markblundeberg added inline comments to D5232: util_tests.test_LockDirectory: avoid exit in forked process.
markblundeberg updated the diff for D5232: util_tests.test_LockDirectory: avoid exit in forked process.
Feb 9 2020
Feb 9 2020
markblundeberg updated the summary of D5232: util_tests.test_LockDirectory: avoid exit in forked process.
markblundeberg updated the summary of D5232: util_tests.test_LockDirectory: avoid exit in forked process.
markblundeberg updated the diff for D5232: util_tests.test_LockDirectory: avoid exit in forked process.
update comment
markblundeberg updated the summary of D5232: util_tests.test_LockDirectory: avoid exit in forked process.
markblundeberg retitled D5232: util_tests.test_LockDirectory: avoid exit in forked process from util_tests: avoid exit in forked process to util_tests.test_LockDirectory: avoid exit in forked process.
core dumping is working, so remove the manual trigger
also add -debug
markblundeberg added inline comments to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
try again
make core dump deliberately
reduce test overall time (don't need func tests)
In D5223#126124, @deadalnix wrote:I get what you want to do with this whole stack, and this is not a bad idea per, but you need to rework the approach so that flagset getting out of sync is less of a problem.
markblundeberg added a comment to D5122: [Review ONLY] Migrate bitcoinabc.org codebase into the ABC repo.
Hmm when you guys described moving the website into the repo I thought it was crazy as I was imagining something much bigger... this seems not so bad!
markblundeberg added inline comments to D5222: remove MANDATORY_SCRIPT_VERIFY_FLAGS in favour of explicit forgiveness flags.
Feb 8 2020
Feb 8 2020
In D5029#126007, @teamcity wrote:
markblundeberg added a revision to T704: sigChecks implementation: D5220: Make standard flags based off consensus flags.
markblundeberg updated the summary of D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
markblundeberg added inline comments to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
markblundeberg updated the diff for D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
address comments; simplify using D5220
markblundeberg added inline comments to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
markblundeberg added a revision to T653: Clean up past upgrades: D5223: clean up STANDARD_NOT_MANDATORY_VERIFY_FLAGS.
Please rebase on master and run arc lint again, it may pick some things up in the functional test (more aggressive rules in place now).
rebase with test lint changes
(note that this also enabled W503, W504 which are disabled by default)
markblundeberg updated the test plan for D5217: [python linting] apply aggressive mode in autopep8 (line wrapping).
markblundeberg updated the summary of D5217: [python linting] apply aggressive mode in autopep8 (line wrapping).
markblundeberg updated the summary of D5217: [python linting] apply aggressive mode in autopep8 (line wrapping).
Feb 7 2020
Feb 7 2020
(rebase)
markblundeberg added inline comments to D5208: [python linting] enforce E722: do not use bare except.
markblundeberg added inline comments to D5208: [python linting] enforce E722: do not use bare except.
(nb there have been a variety of intervening backports so it's not quite reading identically afterwards)
Hmm I guess one thing that could happen is if someone lands and the linting rules have since been restricted, then the rebase commit might have errors.
markblundeberg added inline comments to D5204: [python linting] enforce E731: Do not assign a lambda expression, use a def.
In D5196#125526, @Fabien wrote:This is strictly equivalent to running arc lint then arc land.
It applies to the current comment before the rebase. If there is no rebase conflict the risk that a new linter issue appear is very low.
markblundeberg added a comment to D5203: [LINTER] Prevent using inline doxygen comments on their own line.
Oh yeah good catch on those **< !
(from D4826)
I'm curious, supposing I'm on an old commit and the landing process needs to rebase me onto master, which state does it run lint on: the preland commit or the rebased commit?
markblundeberg updated the summary of D5198: [python linting] enforce all flake8 E & W codes besides some exceptions.
markblundeberg retitled D5197: [lint] trailing whitespaces in python tests from [lint] trailing whitespaces in tests to [lint] trailing whitespaces in python tests.
markblundeberg retitled D5197: [lint] trailing whitespaces in python tests from [nit] trailing whitespaces in tests to [lint] trailing whitespaces in tests.
markblundeberg added a comment to D4826: Add a facility to extract libsecp256k1 from the repository.
This produces some lint advice (the only output right now if you run arc lint --everything)
@tobias_ruck please make sure to run arc lint before landing if you get a rebase conflict. Actually, preferably do arc diff on the conflict-resolved version just to make sure everything is happy.
In D5042#122099, @Fabien wrote:Increase log level from warning to message.
Make a test to fail intentionally to see how the CI reacts.
In D5180#125121, @Fabien wrote:That could be a linter
Feb 6 2020
Feb 6 2020
markblundeberg added a comment to D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.
TODO: make a test that probes virtualsize priorities using sigchecks