Page MenuHomePhabricator
Feed Advanced Search

Apr 21 2020

jasonbcox closed D5793: Fix @generated marking in Phab for generate-seeds.py.
Apr 21 2020, 16:28
jasonbcox added a comment to D5790: core -> ABC in extract_strings_qt.py.

Both are still tagged as generated. As it turns out generate-seeds is too, so this is worth fixing: https://reviews.bitcoinabc.org/D3772#change-QXy06wMdqeAy

Apr 21 2020, 01:34
jasonbcox added inline comments to D5793: Fix @generated marking in Phab for generate-seeds.py.
Apr 21 2020, 01:33
jasonbcox created D5793: Fix @generated marking in Phab for generate-seeds.py.
Apr 21 2020, 01:33
jasonbcox updated the diff for D5790: core -> ABC in extract_strings_qt.py.

Actually mark the file as non-generated....

Apr 21 2020, 01:30
jasonbcox updated the diff for D5790: core -> ABC in extract_strings_qt.py.

Fix up @generated string

Apr 21 2020, 01:06
jasonbcox abandoned D5792: Mark translation files as @generated and update them.

Merged these changes into D5790

Apr 21 2020, 00:44
jasonbcox updated the diff for D5790: core -> ABC in extract_strings_qt.py.

Merged in changes from D5792

Apr 21 2020, 00:44
jasonbcox committed rABCa39dd3235283: Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate` (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate`
Apr 21 2020, 00:42
jasonbcox closed D5791: Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate`.
Apr 21 2020, 00:42
jasonbcox updated the summary of D5792: Mark translation files as @generated and update them.
Apr 21 2020, 00:36
jasonbcox created D5792: Mark translation files as @generated and update them.
Apr 21 2020, 00:36
jasonbcox updated the summary of D5791: Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate`.
Apr 21 2020, 00:14
jasonbcox created D5791: Merge #17068: qt: Always generate `bitcoinstrings.cpp` on `make translate`.
Apr 21 2020, 00:13
jasonbcox created D5790: core -> ABC in extract_strings_qt.py.
Apr 21 2020, 00:04

Apr 20 2020

jasonbcox planned changes to D5784: [build-configurations] Add build-without-cli.
Apr 20 2020, 23:33
jasonbcox updated the diff for D5784: [build-configurations] Add build-without-cli.

Rebase on D5789

Apr 20 2020, 23:32
jasonbcox updated the summary of D5784: [build-configurations] Add build-without-cli.
Apr 20 2020, 23:31
jasonbcox created D5789: Merge #17497: test: skip tests when utils haven't been compiled.
Apr 20 2020, 23:31
jasonbcox committed rABC1ea3681f8ceb: Fix a bug where running test_runner.py --usecli would fail when built without… (authored by jasonbcox).
Fix a bug where running test_runner.py --usecli would fail when built without…
Apr 20 2020, 23:24
jasonbcox closed D5788: Fix a bug where running test_runner.py --usecli would fail when built without bitcoin-cli.
Apr 20 2020, 23:24
jasonbcox committed rABCbc728213d1bb: Merge #14381: test: Add missing call to skip_if_no_cli() (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14381: test: Add missing call to skip_if_no_cli()
Apr 20 2020, 23:24
jasonbcox closed D5781: Merge #14381: test: Add missing call to skip_if_no_cli().
Apr 20 2020, 23:24
jasonbcox planned changes to D5784: [build-configurations] Add build-without-cli.
Apr 20 2020, 22:59
jasonbcox updated the summary of D5784: [build-configurations] Add build-without-cli.
Apr 20 2020, 22:57
jasonbcox updated the diff for D5784: [build-configurations] Add build-without-cli.

Rebase on top of D5788

Apr 20 2020, 22:57
jasonbcox created D5788: Fix a bug where running test_runner.py --usecli would fail when built without bitcoin-cli.
Apr 20 2020, 22:56
jasonbcox created D5786: [autopatch] Do not create a new git branch when fetching upstream.
Apr 20 2020, 22:09
jasonbcox added a comment to D5781: Merge #14381: test: Add missing call to skip_if_no_cli().

Sounds like something that CI should check.

Apr 20 2020, 18:44
jasonbcox planned changes to D5784: [build-configurations] Add build-without-cli.
Apr 20 2020, 18:42
jasonbcox created D5784: [build-configurations] Add build-without-cli.
Apr 20 2020, 18:42
jasonbcox created D5783: Merge #14298: [REST] improve performance for JSON calls.
Apr 20 2020, 18:27
jasonbcox created D5781: Merge #14381: test: Add missing call to skip_if_no_cli().
Apr 20 2020, 17:22
jasonbcox created D5780: Merge #14097: validation: Log FormatStateMessage on ConnectBlock error in ConnectTip.
Apr 20 2020, 17:09
jasonbcox committed rABC6434a8f4417a: Merge #13105: [qa] Add --failfast option to functional test runner (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13105: [qa] Add --failfast option to functional test runner
Apr 20 2020, 16:08
jasonbcox closed D5742: Merge #13105: [qa] Add --failfast option to functional test runner.
Apr 20 2020, 16:08
jasonbcox accepted D5779: Refactor: Replace fprintf with tfm::format.
Apr 20 2020, 15:55

Apr 17 2020

jasonbcox requested changes to D5766: Increase seeder timeout for non-Tor connections.

To make the test plan a little more compelling, is it easy to reproduce the problematic scenario that is fixed by this patch such that you can share logs to show the difference?

Apr 17 2020, 22:48
jasonbcox updated the diff for D5742: Merge #13105: [qa] Add --failfast option to functional test runner.

Improve the division of responsibilities by having test workers skip themselves if failfast is triggered

Apr 17 2020, 18:29

Apr 15 2020

jasonbcox updated the diff for D5742: Merge #13105: [qa] Add --failfast option to functional test runner.

Fix formatting weirdness not caught by linter

Apr 15 2020, 21:53
jasonbcox updated the diff for D5742: Merge #13105: [qa] Add --failfast option to functional test runner.

Remove unnecessary newline

Apr 15 2020, 21:39
jasonbcox created D5742: Merge #13105: [qa] Add --failfast option to functional test runner.
Apr 15 2020, 21:38
jasonbcox accepted D5701: [avalanche] Process AvalancheResponse.
Apr 15 2020, 00:56
jasonbcox committed rABC501a8f0d1edd: Merge #17121: test: speedup wallet_backup by whitelisting peers (immediate tx… (authored by fanquake <fanquake@gmail.com>).
Merge #17121: test: speedup wallet_backup by whitelisting peers (immediate tx…
Apr 15 2020, 00:53
jasonbcox closed D5731: Merge #17121: test: speedup wallet_backup by whitelisting peers (immediate tx relay).
Apr 15 2020, 00:53
jasonbcox committed rABC333d09ffaffd: [release-process] Update Ubuntu PPA instruction (authored by jasonbcox).
[release-process] Update Ubuntu PPA instruction
Apr 15 2020, 00:52
jasonbcox closed D5730: [release-process] Update Ubuntu PPA instruction.
Apr 15 2020, 00:52

Apr 14 2020

jasonbcox updated the summary of D5731: Merge #17121: test: speedup wallet_backup by whitelisting peers (immediate tx relay).
Apr 14 2020, 22:03
jasonbcox created D5731: Merge #17121: test: speedup wallet_backup by whitelisting peers (immediate tx relay).
Apr 14 2020, 22:02
jasonbcox created D5730: [release-process] Update Ubuntu PPA instruction.
Apr 14 2020, 21:52
jasonbcox added inline comments to D5723: Extract smoke tests from automated commits.
Apr 14 2020, 17:01
jasonbcox accepted D5728: Extract the event loop management from the avalanche code so it can be reused..

Would be nice to have some basic tests for EventLoop on its own, but these can come later.

Apr 14 2020, 16:55
jasonbcox committed rABCb9e3d1272c02: Extract smoke tests from automated commits (authored by jasonbcox).
Extract smoke tests from automated commits
Apr 14 2020, 16:35
jasonbcox closed D5723: Extract smoke tests from automated commits.
Apr 14 2020, 16:34
jasonbcox committed rABCcd6a6524c348: Merge #13891: [RPC] Remove getinfo deprecation warning (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13891: [RPC] Remove getinfo deprecation warning
Apr 14 2020, 16:14
jasonbcox closed D5727: Merge #13891: [RPC] Remove getinfo deprecation warning.
Apr 14 2020, 16:13
jasonbcox committed rABCb33ec898c04a: Add upgraded nodes as seeds (authored by jasonbcox).
Add upgraded nodes as seeds
Apr 14 2020, 16:13
jasonbcox closed D5724: Add upgraded nodes as seeds.
Apr 14 2020, 16:13
jasonbcox accepted D5682: Make use of ADDR_SOFT_CAP outside just the seeder test suite.
Apr 14 2020, 01:04
jasonbcox created D5727: Merge #13891: [RPC] Remove getinfo deprecation warning.
Apr 14 2020, 01:03
jasonbcox accepted D5713: Pass rpc/misc RPC argument descriptions to RPCHelpMan.
Apr 14 2020, 00:55
jasonbcox accepted D5710: Pass rpc/server RPC argument descriptions to RPCHelpMan.
Apr 14 2020, 00:34

Apr 13 2020

jasonbcox created D5724: Add upgraded nodes as seeds.
Apr 13 2020, 23:32
jasonbcox created D5723: Extract smoke tests from automated commits.
Apr 13 2020, 23:18
jasonbcox accepted D5719: [avalanche] Modernize the code via using instead of typedef.

Cool. TIL

Apr 13 2020, 22:57
jasonbcox committed rABCbaf31e908e8d: Remove win32 from Github release (authored by jasonbcox).
Remove win32 from Github release
Apr 13 2020, 22:49
jasonbcox closed D5721: Remove win32 from Github release.
Apr 13 2020, 22:49
jasonbcox created D5721: Remove win32 from Github release.
Apr 13 2020, 21:42
jasonbcox accepted D5708: [avalanche] Buffer avapoll and avaresponse.
Apr 13 2020, 17:52
jasonbcox added inline comments to D5701: [avalanche] Process AvalancheResponse.
Apr 13 2020, 17:48

Apr 11 2020

jasonbcox requested changes to D5380: [seeder] Require good seeds to have latest checkpoint.

This is getting there. Keep applying what you learned in the previous pass iteratively until the design is solid.

Apr 11 2020, 00:59
jasonbcox requested changes to D5686: Implement banning logic for Seeder for nodes on the wrong chain.
Apr 11 2020, 00:50
jasonbcox requested changes to D5682: Make use of ADDR_SOFT_CAP outside just the seeder test suite.
Apr 11 2020, 00:08
jasonbcox requested changes to D5701: [avalanche] Process AvalancheResponse.
Apr 11 2020, 00:04

Apr 10 2020

jasonbcox committed rABCb0e479a00ca6: Bump copyright year to 2020 (authored by jasonbcox).
Bump copyright year to 2020
Apr 10 2020, 23:31
jasonbcox closed D5698: Bump copyright year to 2020.
Apr 10 2020, 23:31
jasonbcox committed rABC6f51aca02e24: Bump version to 0.21.5 (authored by jasonbcox).
Bump version to 0.21.5
Apr 10 2020, 23:31
jasonbcox closed D5697: Bump version to 0.21.5.
Apr 10 2020, 23:31
jasonbcox added a comment to D5698: Bump copyright year to 2020.

It would be nice to also run the script to update the copyright in the source files at some point.

Apr 10 2020, 23:29
jasonbcox accepted D5695: Allow to extend and override the sanitizers options.
Apr 10 2020, 17:16
jasonbcox added inline comments to D5695: Allow to extend and override the sanitizers options.
Apr 10 2020, 17:07
jasonbcox created D5698: Bump copyright year to 2020.
Apr 10 2020, 16:51
jasonbcox updated the test plan for D5697: Bump version to 0.21.5.
Apr 10 2020, 16:51
jasonbcox created D5697: Bump version to 0.21.5.
Apr 10 2020, 16:46
jasonbcox abandoned D5692: Fix lock order in Avalanche event loop.
Apr 10 2020, 16:35
jasonbcox committed rABC150e11f7cea7: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded…
Apr 10 2020, 16:35
jasonbcox closed D5690: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes..
Apr 10 2020, 16:35
jasonbcox updated the diff for D5690: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes..

Rebase

Apr 10 2020, 15:53

Apr 9 2020

jasonbcox created D5693: [Avalanche] Gather INVs before entering critical section for cs_vNodes.
Apr 9 2020, 23:03
jasonbcox created D5692: Fix lock order in Avalanche event loop.
Apr 9 2020, 21:33
jasonbcox committed rABC22a803180de2: Use a different address in Avalanche test to prevent duplicate blocks (authored by jasonbcox).
Use a different address in Avalanche test to prevent duplicate blocks
Apr 9 2020, 21:15
jasonbcox closed D5691: Use a different address in Avalanche test to prevent duplicate blocks.
Apr 9 2020, 21:15
jasonbcox requested review of D5690: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes..

I often forget that... Fixed.

Apr 9 2020, 19:04
jasonbcox updated the test plan for D5690: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes..
Apr 9 2020, 18:59
jasonbcox updated the diff for D5691: Use a different address in Avalanche test to prevent duplicate blocks.

Fixed overwriting the address variable. These are expected to be re-used in the future, so I
will not remove those variables outright.

Apr 9 2020, 18:34
jasonbcox updated the diff for D5691: Use a different address in Avalanche test to prevent duplicate blocks.

Use get_deterministic_priv_key instead, as fork_node's deterministic key won't collide with node's

Apr 9 2020, 18:05
jasonbcox updated the test plan for D5691: Use a different address in Avalanche test to prevent duplicate blocks.
Apr 9 2020, 17:38
jasonbcox created D5691: Use a different address in Avalanche test to prevent duplicate blocks.
Apr 9 2020, 17:37
jasonbcox updated the summary of D5690: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes..
Apr 9 2020, 17:24
jasonbcox created D5690: Merge #15201: net: Add missing locking annotation for vNodes. vNodes is guarded by cs_vNodes..
Apr 9 2020, 17:24