Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jul 2 2020

jasonbcox abandoned D6692: [land-bot] Preserve committer name and email.

Abandoned in favor of D6799

Jul 2 2020, 22:40
jasonbcox accepted D6809: [avalanche] Implement compaction for the PeerManager.
Jul 2 2020, 22:39
jasonbcox closed D6805: Cleanup leftover phononactivationtime option.
Jul 2 2020, 15:43
jasonbcox committed rABCc931b3d676ed: Cleanup leftover phononactivationtime option (authored by jasonbcox).
Cleanup leftover phononactivationtime option
Jul 2 2020, 15:43

Jul 1 2020

jasonbcox requested review of D6805: Cleanup leftover phononactivationtime option.
Jul 1 2020, 23:34
jasonbcox abandoned D6783: Fix out-of-bounds index in Avalanche PeerManager.
Jul 1 2020, 21:21
jasonbcox requested review of D6799: [land-bot] Pass committer name/email to land bot endpoint.
Jul 1 2020, 18:10
jasonbcox committed rABCae150fdf9d0b: Cleanup unused --with-phononactivation from test_framework (authored by jasonbcox).
Cleanup unused --with-phononactivation from test_framework
Jul 1 2020, 18:09
jasonbcox closed D6797: Cleanup unused --with-phononactivation from test_framework.
Jul 1 2020, 18:09
jasonbcox committed rABC9bbe4cd78d8c: Cleanup phonon activation in functional tests (authored by jasonbcox).
Cleanup phonon activation in functional tests
Jul 1 2020, 17:36
jasonbcox closed D6796: Cleanup phonon activation in functional tests.
Jul 1 2020, 17:36
jasonbcox accepted D6716: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations.
Jul 1 2020, 01:36
jasonbcox accepted D6787: [avalanche] Manipulate peers via PeerId.
Jul 1 2020, 01:32
jasonbcox accepted D6793: [avalanche] Make peer score an uint32_t instead of an uint64_t.
Jul 1 2020, 01:31
jasonbcox requested review of D6797: Cleanup unused --with-phononactivation from test_framework.
Jul 1 2020, 01:10
jasonbcox requested review of D6796: Cleanup phonon activation in functional tests.
Jul 1 2020, 01:08

Jun 30 2020

jasonbcox accepted D6789: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus.
Jun 30 2020, 22:26
jasonbcox requested changes to D6787: [avalanche] Manipulate peers via PeerId.

The nits aren't a big deal, but the comment in selectPeerImpl() needs to be addressed in some way.

Jun 30 2020, 22:23
jasonbcox requested review of D6783: Fix out-of-bounds index in Avalanche PeerManager.
Jun 30 2020, 03:35
jasonbcox committed rABCa654cf361a4d: Enable Axion upgrades in functional tests (authored by jasonbcox).
Enable Axion upgrades in functional tests
Jun 30 2020, 03:31
jasonbcox closed D6782: Enable Axion upgrades in functional tests.
Jun 30 2020, 03:31
jasonbcox added a comment to D6782: Enable Axion upgrades in functional tests.
In D6782#164841, @deadalnix wrote:

Think about cleaning up the old activation.

Jun 30 2020, 03:31
jasonbcox committed rABC83d56eb029e2: Enable Axion upgrades in unit tests (authored by jasonbcox).
Enable Axion upgrades in unit tests
Jun 30 2020, 03:30
jasonbcox closed D6781: Enable Axion upgrades in unit tests.
Jun 30 2020, 03:30
jasonbcox added inline comments to D6780: Add facility and test for checking if Axion upgrade is enabled.
Jun 30 2020, 03:29
jasonbcox committed rABC0a5d600206c0: Add facility and test for checking if Axion upgrade is enabled (authored by jasonbcox).
Add facility and test for checking if Axion upgrade is enabled
Jun 30 2020, 03:28
jasonbcox closed D6780: Add facility and test for checking if Axion upgrade is enabled.
Jun 30 2020, 03:28
jasonbcox updated the summary of D6781: Enable Axion upgrades in unit tests.
Jun 30 2020, 01:03
jasonbcox requested review of D6782: Enable Axion upgrades in functional tests.
Jun 30 2020, 01:03
jasonbcox accepted D6773: [avalanche] Add the ability to remove and rescore peers.

Ok. Seems I was on the right track.

Jun 30 2020, 01:02
jasonbcox requested review of D6781: Enable Axion upgrades in unit tests.
Jun 30 2020, 00:56
jasonbcox updated the diff for D6780: Add facility and test for checking if Axion upgrade is enabled.

Add missing comment

Jun 30 2020, 00:52
jasonbcox requested review of D6780: Add facility and test for checking if Axion upgrade is enabled.
Jun 30 2020, 00:50

Jun 29 2020

jasonbcox accepted D6772: [avalanche] Introduce a datastructure to keep track of peers.

This change seems fine, but there isn't enough info in the summary to get a good picture for why this particular implementation was selected over other possible implementations. Regardless, it appears to do some job and is tested.

Jun 29 2020, 21:51
jasonbcox requested changes to D6773: [avalanche] Add the ability to remove and rescore peers.

What does this fragmentation score give you in the future? It's not clear what this is building towards and the rest of the stack does not clarify in regards to the fragmentation. Since the fragmentation is essentially a loosely-tracked sum of gaps between entries, is it intended as a cleanup trigger once the sum exceeds some threshold? If not, then how will it be used?

Jun 29 2020, 21:48
jasonbcox accepted D6776: [avalanche] Use utility method to find slots.
Jun 29 2020, 21:43
jasonbcox committed rABCeb48537aa444: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase
Jun 29 2020, 21:42
jasonbcox closed D6774: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase.
Jun 29 2020, 21:42
jasonbcox requested review of D6774: Merge #14543: [QA] minor p2p_sendheaders fix of height in coinbase.
Jun 29 2020, 20:44
jasonbcox accepted D6767: [CI] Log sanitizers output to stdout instead of log files.
Jun 29 2020, 15:59
jasonbcox accepted D6766: Move NodeContext from TestingSetup to BasicTestingSetup.
Jun 29 2020, 15:37

Jun 27 2020

jasonbcox committed rABC768822a9ef8b: Bump version to 0.21.11 (authored by jasonbcox).
Bump version to 0.21.11
Jun 27 2020, 15:19
jasonbcox closed D6752: Bump version to 0.21.11.
Jun 27 2020, 15:19
jasonbcox committed rABCc87b967f347e: [CI] Increase stream buffer limit for build subprocess (authored by jasonbcox).
[CI] Increase stream buffer limit for build subprocess
Jun 27 2020, 15:19
jasonbcox closed D6753: [CI] Increase stream buffer limit for build subprocess.
Jun 27 2020, 15:18
jasonbcox requested review of D6753: [CI] Increase stream buffer limit for build subprocess.
Jun 27 2020, 00:09
jasonbcox updated the test plan for D6753: [CI] Increase stream buffer limit for build subprocess.
Jun 27 2020, 00:09

Jun 26 2020

jasonbcox planned changes to D6753: [CI] Increase stream buffer limit for build subprocess.
Jun 26 2020, 23:55
jasonbcox requested review of D6753: [CI] Increase stream buffer limit for build subprocess.
Jun 26 2020, 23:55
jasonbcox requested review of D6752: Bump version to 0.21.11.
Jun 26 2020, 23:51
jasonbcox accepted D6735: [CI] Manage the build artifacts from the configuration.
Jun 26 2020, 15:40
jasonbcox committed rABCf42e227d0e70: [CI] Ensure llvm-symbolizer is available in PATH (authored by jasonbcox).
[CI] Ensure llvm-symbolizer is available in PATH
Jun 26 2020, 15:37
jasonbcox closed D6746: [CI] Ensure llvm-symbolizer is available in PATH.
Jun 26 2020, 15:37

Jun 25 2020

jasonbcox added a comment to D6746: [CI] Ensure llvm-symbolizer is available in PATH.

@bot build-asan build-ubsan build-tsan

Jun 25 2020, 23:34
jasonbcox requested review of D6746: [CI] Ensure llvm-symbolizer is available in PATH.
Jun 25 2020, 23:34
jasonbcox requested changes to D6735: [CI] Manage the build artifacts from the configuration.

The rest of this patch looks good, just needs some polish.

Jun 25 2020, 20:56
jasonbcox accepted D6733: [CI] Add a templating system to the configuration.
Jun 25 2020, 17:30
jasonbcox accepted D6732: [CI] Include the teamcity-messages library and display the build name.
Jun 25 2020, 17:29
jasonbcox accepted D6738: [refactor] Update some comments in validation.cpp as we arent doing DoS there.
Jun 25 2020, 17:24
jasonbcox accepted D6737: [refactor] Drop unused state.DoS(), state.GetDoS(), state.CorruptionPossible().
Jun 25 2020, 17:23
jasonbcox accepted D6734: CorruptionPossible -> TX_WITNESS_MUTATED.
Jun 25 2020, 17:12
jasonbcox committed rABCdef81dda8f71: Fix build path in build-make-generator (authored by jasonbcox).
Fix build path in build-make-generator
Jun 25 2020, 16:53
jasonbcox closed D6739: Fix build path in build-make-generator.
Jun 25 2020, 16:53
jasonbcox added a comment to D6739: Fix build path in build-make-generator.

@bot build-make-generator

Jun 25 2020, 16:39
jasonbcox requested review of D6739: Fix build path in build-make-generator.
Jun 25 2020, 16:37
jasonbcox accepted D6736: Use reason for checking for sigcheck in txvalidationcache.
Jun 25 2020, 16:14
jasonbcox committed rABC3142f48fcaf1: [CI] Cleanup unused build-configurations wrapper (authored by jasonbcox).
[CI] Cleanup unused build-configurations wrapper
Jun 25 2020, 16:09
jasonbcox closed D6726: [CI] Cleanup unused build-configurations wrapper.
Jun 25 2020, 16:09
jasonbcox committed rABC9063946fe040: [CI] Make sure every build directory is under a common 'build' directory (authored by jasonbcox).
[CI] Make sure every build directory is under a common 'build' directory
Jun 25 2020, 16:08
jasonbcox closed D6719: [CI] Make sure every build directory is under a common 'build' directory.
Jun 25 2020, 16:08
jasonbcox accepted D6728: Allow use of state.Invalid() for all reasons.
Jun 25 2020, 00:02

Jun 24 2020

jasonbcox accepted D6727: Fix handling of invalid headers.
Jun 24 2020, 23:59
jasonbcox requested review of D6726: [CI] Cleanup unused build-configurations wrapper.
Jun 24 2020, 22:56
jasonbcox accepted D6725: Use BlockHash in net_processing.cpp.
Jun 24 2020, 22:35
jasonbcox requested changes to D6716: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations.
Jun 24 2020, 22:27
jasonbcox updated the diff for D6719: [CI] Make sure every build directory is under a common 'build' directory.

build -> abc-ci-builds and added it to .gitignore

Jun 24 2020, 22:07
jasonbcox added inline comments to D6719: [CI] Make sure every build directory is under a common 'build' directory.
Jun 24 2020, 22:01
jasonbcox accepted D6722: [CI] Allow for setting environment variables from the configuration file.
Jun 24 2020, 21:16
jasonbcox committed rABC4b0c6d74041a: Merge #14051: [Tests] Make combine_logs.py handle multi-line logs (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14051: [Tests] Make combine_logs.py handle multi-line logs
Jun 24 2020, 20:43
jasonbcox closed D6669: Merge #14051: [Tests] Make combine_logs.py handle multi-line logs.
Jun 24 2020, 20:43
jasonbcox accepted D6715: [CI] Set build timeout in the configuration file.
Jun 24 2020, 20:39
jasonbcox updated the diff for D6719: [CI] Make sure every build directory is under a common 'build' directory.

Fix to make sure the entire build path is created

Jun 24 2020, 20:32
jasonbcox added inline comments to D6719: [CI] Make sure every build directory is under a common 'build' directory.
Jun 24 2020, 20:31
jasonbcox committed rABCd6121c79b0a8: Merge #14816: Add CScriptNum decode python implementation in functional suite (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14816: Add CScriptNum decode python implementation in functional suite
Jun 24 2020, 20:23
jasonbcox closed D6713: Merge #14816: Add CScriptNum decode python implementation in functional suite.
Jun 24 2020, 20:23
jasonbcox committed rABC7cb92239e4ad: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14658: qa: Add test to ensure node can generate all rpc help texts at…
Jun 24 2020, 20:21
jasonbcox closed D6709: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime.
Jun 24 2020, 20:21
jasonbcox committed rABC3ebf7e4b66d6: [CI] Fix a bug where CI scripts are not able to build in directories that are… (authored by jasonbcox).
[CI] Fix a bug where CI scripts are not able to build in directories that are…
Jun 24 2020, 20:20
jasonbcox closed D6718: [CI] Fix a bug where CI scripts are not able to build in directories that are not one level below the project root.
Jun 24 2020, 20:20
jasonbcox requested changes to D6715: [CI] Set build timeout in the configuration file.
Jun 24 2020, 20:19
jasonbcox accepted D6720: [LINTER] Enforce shellcheck >= 0.7.0.
Jun 24 2020, 20:16
jasonbcox accepted D6711: [CI] Convert the build-configurations.sh script to python, read config.
Jun 24 2020, 20:11
jasonbcox requested review of D6719: [CI] Make sure every build directory is under a common 'build' directory.
Jun 24 2020, 20:10
jasonbcox requested review of D6718: [CI] Fix a bug where CI scripts are not able to build in directories that are not one level below the project root.
Jun 24 2020, 19:58
jasonbcox requested review of D6713: Merge #14816: Add CScriptNum decode python implementation in functional suite.
Jun 24 2020, 19:03
jasonbcox requested changes to D6711: [CI] Convert the build-configurations.sh script to python, read config.
Jun 24 2020, 18:52
jasonbcox requested review of D6709: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime.
Jun 24 2020, 18:27
jasonbcox updated the test plan for D6709: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime.
Jun 24 2020, 18:06
jasonbcox updated the summary of D6709: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime.
Jun 24 2020, 18:05
jasonbcox planned changes to D6709: Merge #14658: qa: Add test to ensure node can generate all rpc help texts at runtime.
Jun 24 2020, 18:05
First
Prev
Next