Page MenuHomePhabricator
Feed All Stories

Jul 27 2022

sdulfari accepted D11802: [avalanche] Return all the status in getrawavalancheproof RPC.
Jul 27 2022, 17:51
sdulfari accepted D11808: [avalanche] Fix flakiness in the stale vote functional test.
Jul 27 2022, 17:47
sdulfari closed D11800: [avalanche] Verify that polling has started on an item before verifying that it has stopped.
Jul 27 2022, 17:45
sdulfari committed rABCc3de9a21195e: [avalanche] Verify that polling has started on an item before verifying that it… (authored by sdulfari).
[avalanche] Verify that polling has started on an item before verifying that it…
Jul 27 2022, 17:45
Fabien requested changes to D11807: [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp.
Jul 27 2022, 16:58
Fabien accepted D11806: [Chronik] Add `ENABLE_CHRONIK` #define macro.
Jul 27 2022, 16:36
kieran709 closed D11602: [Cashtab] Hide QR popup setting.
Jul 27 2022, 16:08
kieran709 committed rABC29f46e8cd7cf: [Cashtab] Hide QR popup setting (authored by kieran709).
[Cashtab] Hide QR popup setting
Jul 27 2022, 16:08
tobias_ruck updated the summary of D11807: [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp.
Jul 27 2022, 15:51
tobias_ruck retitled D11807: [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp from [Chronik] Add minimal `StartChronik` and `StopChronik` to init.cpp to [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp.
Jul 27 2022, 15:50
kieran709 requested review of D11810: [Cashtab] Change toSmallestDenomination and fromSmallestDenomination function names.
Jul 27 2022, 15:46
tobias_ruck updated the diff for D11807: [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp.

Build node with Chronik in CI, fix bad StopChronik

Jul 27 2022, 14:45
tobias_ruck updated the test plan for D11806: [Chronik] Add `ENABLE_CHRONIK` #define macro.
Jul 27 2022, 14:39
tobias_ruck updated the diff for D11806: [Chronik] Add `ENABLE_CHRONIK` #define macro.

Fix: Use #cmakedefine01 to define the macro. This is the expected behavior (define ENABLE_CHRONIK as either 1 or 0) and
meshes better with #if.

Jul 27 2022, 14:37
tobias_ruck updated the diff for D11807: [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp.

apply Fabien's C++ wisdom (:

Jul 27 2022, 14:15
tobias_ruck updated the diff for D11806: [Chronik] Add `ENABLE_CHRONIK` #define macro.

Move ENABLE_CHRONIK to its own block

Jul 27 2022, 13:52
tobias_ruck closed D11805: [Chronik] Set Chronik C++ standard to C++17.
Jul 27 2022, 13:47
tobias_ruck committed rABC7122a475a89b: [Chronik] Set Chronik C++ standard to C++17 (authored by tobias_ruck).
[Chronik] Set Chronik C++ standard to C++17
Jul 27 2022, 13:47
Fabien abandoned D11698: [avalanche] Don't clean up the proof radix tree when it's already null.
Jul 27 2022, 12:00
Fabien abandoned D11700: [avalanche] Send a sendava message to notify we support avalanche.
Jul 27 2022, 12:00
Fabien abandoned D11699: [avalanche] Send an empty compact proofs request if there is no shortid.
Jul 27 2022, 12:00
Fabien updated the diff for D11770: [avalanche] Request more peers for their avalanche nodes.

Update comments

Jul 27 2022, 11:58
Fabien requested changes to D11807: [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp.
Jul 27 2022, 10:50
Fabien added a comment to D11806: [Chronik] Add `ENABLE_CHRONIK` #define macro.

NVM about the option, it's already there

Jul 27 2022, 10:28
Fabien requested changes to D11806: [Chronik] Add `ENABLE_CHRONIK` #define macro.

You are missing the option(BUILD_BITCOIN_CHRONIK) statement.
Also please expand on the test plan to check the option creates the expected defines when set.

Jul 27 2022, 10:21
Fabien accepted D11805: [Chronik] Set Chronik C++ standard to C++17.
Jul 27 2022, 10:13
Fabien requested changes to D11796: test: test availability of ports before assigning them.
Jul 27 2022, 10:11
Fabien requested review of D11809: [avalanche] Simplify the wait_for_proof test facility.
Jul 27 2022, 09:44
Fabien updated the test plan for D11802: [avalanche] Return all the status in getrawavalancheproof RPC.
Jul 27 2022, 08:50
Fabien updated the summary of D11802: [avalanche] Return all the status in getrawavalancheproof RPC.
Jul 27 2022, 08:50
Fabien updated the diff for D11802: [avalanche] Return all the status in getrawavalancheproof RPC.

Rebase on top of D11808, split out the wait_for_proof refactor

Jul 27 2022, 08:49
emack added a comment to D11762: [Cashtab] [Chronik] [Tx Gen] SendXec() refactor.

yup I agree, rebasing this on top of a chronikfied utxo handling logic is the better approach as it's easier to debug the tx generation logic when combined.

Jul 27 2022, 08:07
Fabien requested review of D11808: [avalanche] Fix flakiness in the stale vote functional test.
Jul 27 2022, 08:05
Fabien accepted D11800: [avalanche] Verify that polling has started on an item before verifying that it has stopped.
Jul 27 2022, 07:47
PiRK added a comment to D11796: test: test availability of ports before assigning them.

What's the impact on performance ?

Jul 27 2022, 07:33

Jul 26 2022

bytesofman requested changes to D11627: [Cashtab] Hide msgs from unknown senders option.

Rebase after landing D11602

Jul 26 2022, 21:33
bytesofman accepted D11602: [Cashtab] Hide QR popup setting.
Jul 26 2022, 21:33
bytesofman requested changes to D11762: [Cashtab] [Chronik] [Tx Gen] SendXec() refactor.
Jul 26 2022, 21:17
tobias_ruck requested review of D11807: [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp.
Jul 26 2022, 19:41
tobias_ruck requested review of D11806: [Chronik] Add `ENABLE_CHRONIK` #define macro.
Jul 26 2022, 19:19
sdulfari updated the diff for D11800: [avalanche] Verify that polling has started on an item before verifying that it has stopped.

Reuse code per feedback

Jul 26 2022, 19:14
tobias_ruck requested review of D11805: [Chronik] Set Chronik C++ standard to C++17.
Jul 26 2022, 19:11
sdulfari abandoned D11801: [avalanche] Fix multiple flakiness issues in abc_p2p_avalanche_proof_voting.

You are right. This is the better solution: D11802

Jul 26 2022, 19:08
sdulfari requested changes to D11802: [avalanche] Return all the status in getrawavalancheproof RPC.
Jul 26 2022, 19:08
kieran709 closed D11804: [Cashtab] Hide spinner in Send.js Amount input on Firefox.
Jul 26 2022, 17:52
kieran709 committed rABCa33f0cff67bd: [Cashtab] Hide spinner in Send.js Amount input on Firefox (authored by kieran709).
[Cashtab] Hide spinner in Send.js Amount input on Firefox
Jul 26 2022, 17:52
bytesofman accepted D11804: [Cashtab] Hide spinner in Send.js Amount input on Firefox.
Jul 26 2022, 16:50
kieran709 updated the diff for D11627: [Cashtab] Hide msgs from unknown senders option.

Rebased to master, updated validation test for parseInvalidSettingsForMigration function to include new default setting and added logic to hide the 'Hide' button on outgoing messages.

Jul 26 2022, 16:31
Fabien closed D11803: [avalanche] Account for the avalanche outbound when checking for outbound eviction.
Jul 26 2022, 16:01
Fabien committed rABC09a92690b6b7: [avalanche] Account for the avalanche outbound when checking for outbound… (authored by Fabien).
[avalanche] Account for the avalanche outbound when checking for outbound…
Jul 26 2022, 16:01
Fabien added inline comments to D11803: [avalanche] Account for the avalanche outbound when checking for outbound eviction.
Jul 26 2022, 16:01
kieran709 updated the test plan for D11804: [Cashtab] Hide spinner in Send.js Amount input on Firefox.
Jul 26 2022, 15:50
kieran709 requested review of D11804: [Cashtab] Hide spinner in Send.js Amount input on Firefox.
Jul 26 2022, 15:49
sdulfari accepted D11803: [avalanche] Account for the avalanche outbound when checking for outbound eviction.
Jul 26 2022, 15:42
Fabien requested review of D11803: [avalanche] Account for the avalanche outbound when checking for outbound eviction.
Jul 26 2022, 15:33
Fabien requested changes to D11800: [avalanche] Verify that polling has started on an item before verifying that it has stopped.
Jul 26 2022, 14:56
sdulfari requested review of D11800: [avalanche] Verify that polling has started on an item before verifying that it has stopped.
Jul 26 2022, 14:41
kieran709 updated the diff for D11602: [Cashtab] Hide QR popup setting.

Rebased and updated validation tests to include new defaultSetting.

Jul 26 2022, 14:33
Fabien requested review of D11802: [avalanche] Return all the status in getrawavalancheproof RPC.
Jul 26 2022, 12:31
Fabien requested changes to D11801: [avalanche] Fix multiple flakiness issues in abc_p2p_avalanche_proof_voting.
Jul 26 2022, 09:31
Fabien requested changes to D11800: [avalanche] Verify that polling has started on an item before verifying that it has stopped.
Jul 26 2022, 09:24
emack updated the diff for D11762: [Cashtab] [Chronik] [Tx Gen] SendXec() refactor.

Following on from previous comment, post-rebase change calculation bug and subsequent new jest errors now resolved.

Jul 26 2022, 04:45
emack added a comment to D11762: [Cashtab] [Chronik] [Tx Gen] SendXec() refactor.

Rebasing to D11777 fixed the previous error relating to the buried async API call.

Jul 26 2022, 02:35

Jul 25 2022

sdulfari requested review of D11801: [avalanche] Fix multiple flakiness issues in abc_p2p_avalanche_proof_voting.
Jul 25 2022, 23:59
sdulfari requested review of D11800: [avalanche] Verify that polling has started on an item before verifying that it has stopped.
Jul 25 2022, 23:54
sdulfari closed D11761: [avalanche] Add a way to pass avalanche config values around.
Jul 25 2022, 21:38
sdulfari committed rABC72c060adeae9: [avalanche] Add a way to pass avalanche config values around (authored by sdulfari).
[avalanche] Add a way to pass avalanche config values around
Jul 25 2022, 21:38
bytesofman added a comment to D11762: [Cashtab] [Chronik] [Tx Gen] SendXec() refactor.

Please rebase and uncomment unit tests to see if issue has been corrected by D11777

Jul 25 2022, 15:45
teamcity closed T2582: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Resolved.
Jul 25 2022, 10:15
Fabien closed D11792: [avalanche] Request more node addresses upon receipt of a dangling proof.
Jul 25 2022, 09:46
Fabien committed rABCa5511ecff41e: [avalanche] Request more node addresses upon receipt of a dangling proof (authored by Fabien).
[avalanche] Request more node addresses upon receipt of a dangling proof
Jul 25 2022, 09:46
Fabien closed D11766: [avalanche] Don't consider our quorum valid if we don't have enough nodes connected.
Jul 25 2022, 09:44
Fabien committed rABCb86f8a391c2c: [avalanche] Don't consider our quorum valid if we don't have enough nodes… (authored by Fabien).
[avalanche] Don't consider our quorum valid if we don't have enough nodes…
Jul 25 2022, 09:44
Fabien added a comment to D11796: test: test availability of ports before assigning them.

What's the impact on performance ?

Jul 25 2022, 09:39
teamcity triaged T2582: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Unbreak Now! priority.
Jul 25 2022, 09:37
Fabien accepted D11761: [avalanche] Add a way to pass avalanche config values around.
Jul 25 2022, 09:20
tobias_ruck closed D11799: [Chronik] Add `BlockReader` to read blocks from `Db`.
Jul 25 2022, 09:16
tobias_ruck committed rABC971c6cc7d5ff: [Chronik] Add `BlockReader` to read blocks from `Db` (authored by tobias_ruck).
[Chronik] Add `BlockReader` to read blocks from `Db`
Jul 25 2022, 09:16
tobias_ruck closed D11798: [Chronik] Refactor serialization, add `db_serialize` and `db_deserialize`..
Jul 25 2022, 09:15
tobias_ruck committed rABC02a5714575bd: [Chronik] Refactor serialization, add `db_serialize` and `db_deserialize`. (authored by tobias_ruck).
[Chronik] Refactor serialization, add `db_serialize` and `db_deserialize`.
Jul 25 2022, 09:15
Fabien accepted D11798: [Chronik] Refactor serialization, add `db_serialize` and `db_deserialize`..
Jul 25 2022, 09:12
tobias_ruck updated the diff for D11799: [Chronik] Add `BlockReader` to read blocks from `Db`.

Rebase + revert comment change

Jul 25 2022, 09:10
tobias_ruck updated the diff for D11798: [Chronik] Refactor serialization, add `db_serialize` and `db_deserialize`..

Fix bad module comment.

Jul 25 2022, 09:07
Fabien accepted D11799: [Chronik] Add `BlockReader` to read blocks from `Db`.
Jul 25 2022, 09:06
tobias_ruck updated the diff for D11798: [Chronik] Refactor serialization, add `db_serialize` and `db_deserialize`..

Add tests for db_serialize/db_deserialize happy/unhappy paths

Jul 25 2022, 09:04
Fabien requested changes to D11798: [Chronik] Refactor serialization, add `db_serialize` and `db_deserialize`..
Jul 25 2022, 08:14

Jul 24 2022

tobias_ruck requested review of D11799: [Chronik] Add `BlockReader` to read blocks from `Db`.
Jul 24 2022, 18:33
tobias_ruck requested review of D11798: [Chronik] Refactor serialization, add `db_serialize` and `db_deserialize`..
Jul 24 2022, 18:28

Jul 23 2022

PiRK closed D11794: doc/style followups in MempoolAcceptResult.
Jul 23 2022, 18:32
PiRK committed rABC85d22539836d: doc/style followups in MempoolAcceptResult (authored by glozow <gzhao408@berkeley.edu>).
doc/style followups in MempoolAcceptResult
Jul 23 2022, 18:32
teamcity added a comment to D11796: test: test availability of ports before assigning them.
Jul 23 2022, 13:37
PiRK updated the diff for D11796: test: test availability of ports before assigning them.

functools.cache is not available prior to python version 3.9. Use functools.lru_cache(max_size=None) instead.

Jul 23 2022, 13:25
PiRK updated the summary of D11796: test: test availability of ports before assigning them.
Jul 23 2022, 13:19
teamcity added a comment to D11796: test: test availability of ports before assigning them.
Jul 23 2022, 13:19
PiRK published D11796: test: test availability of ports before assigning them for review.
Jul 23 2022, 13:19
sdulfari requested changes to D11770: [avalanche] Request more peers for their avalanche nodes.
Jul 23 2022, 06:01
sdulfari updated the diff for D11761: [avalanche] Add a way to pass avalanche config values around.

I'm not entirely convinced renaming AvalancheConfig -> Config is the best path because of the way
Config and ::Config both appear in avalanche code. But it's not all bad since it is nearly
impossible to pick the wrong one and get past compilation. I'm still posting this change here
so it will get reviewed.

Jul 23 2022, 05:56
sdulfari accepted D11766: [avalanche] Don't consider our quorum valid if we don't have enough nodes connected.
Jul 23 2022, 05:24
sdulfari accepted D11792: [avalanche] Request more node addresses upon receipt of a dangling proof.
Jul 23 2022, 05:21

Jul 22 2022

tobias_ruck closed D11797: [Chronik] Use lint! macro in chronik-db.
Jul 22 2022, 18:12