- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jul 27 2022
Build node with Chronik in CI, fix bad StopChronik
Fix: Use #cmakedefine01 to define the macro. This is the expected behavior (define ENABLE_CHRONIK as either 1 or 0) and
meshes better with #if.
apply Fabien's C++ wisdom (:
Move ENABLE_CHRONIK to its own block
Update comments
NVM about the option, it's already there
You are missing the option(BUILD_BITCOIN_CHRONIK) statement.
Also please expand on the test plan to check the option creates the expected defines when set.
Rebase on top of D11808, split out the wait_for_proof refactor
yup I agree, rebasing this on top of a chronikfied utxo handling logic is the better approach as it's easier to debug the tx generation logic when combined.
In D11796#264462, @Fabien wrote:What's the impact on performance ?
Jul 26 2022
Rebase after landing D11602
Reuse code per feedback
You are right. This is the better solution: D11802
Rebased to master, updated validation test for parseInvalidSettingsForMigration function to include new default setting and added logic to hide the 'Hide' button on outgoing messages.
Rebased and updated validation tests to include new defaultSetting.
Following on from previous comment, post-rebase change calculation bug and subsequent new jest errors now resolved.
Rebasing to D11777 fixed the previous error relating to the buried async API call.
Jul 25 2022
Please rebase and uncomment unit tests to see if issue has been corrected by D11777
What's the impact on performance ?
Rebase + revert comment change
Fix bad module comment.
Add tests for db_serialize/db_deserialize happy/unhappy paths
Jul 24 2022
Jul 23 2022
functools.cache is not available prior to python version 3.9. Use functools.lru_cache(max_size=None) instead.
I'm not entirely convinced renaming AvalancheConfig -> Config is the best path because of the way
Config and ::Config both appear in avalanche code. But it's not all bad since it is nearly
impossible to pick the wrong one and get past compilation. I'm still posting this change here
so it will get reviewed.