Page MenuHomePhabricator
Feed Advanced Search

Mar 20 2019

jasonbcox accepted D2702: qa: Improve getchaintxstats functional test.
Mar 20 2019, 17:00
jasonbcox added inline comments to D2711: Document method for reviewers to verify chainTxData.
Mar 20 2019, 16:57
jasonbcox closed T564: Backport Core PR 11027, a subtask of T562: Backport Core PR 10275, as Resolved.
Mar 20 2019, 16:29 · Backport
jasonbcox closed T564: Backport Core PR 11027 as Resolved.
Mar 20 2019, 16:29 · Backport
jasonbcox committed rABCe3b6fe0ed1ba: Merge #11027: [RPC] Only return hex field once in getrawtransaction (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11027: [RPC] Only return hex field once in getrawtransaction
Mar 20 2019, 16:29
jasonbcox closed D2709: Merge #11027: [RPC] Only return hex field once in getrawtransaction.
Mar 20 2019, 16:29
jasonbcox closed T563: Backport Core PR 11565 as Resolved.
Mar 20 2019, 16:24 · Backport
jasonbcox closed T563: Backport Core PR 11565, a subtask of T560: Backport Core PR 11041, as Resolved.
Mar 20 2019, 16:24 · Backport
jasonbcox committed rABC1d6970e88741: Merge #11565: Make listsinceblock refuse unknown block hash (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11565: Make listsinceblock refuse unknown block hash
Mar 20 2019, 16:23
jasonbcox closed D2703: Merge #11565: Make listsinceblock refuse unknown block hash.
Mar 20 2019, 16:23
jasonbcox requested changes to D1936: Move handling for `-maxtxfee` to the config object.
Mar 20 2019, 01:43
jasonbcox requested changes to D2133: Move shared qt/bitcoind initialization steps to shared functions..

This directly conflicts with T417. I don't think this change is worth it.

Mar 20 2019, 01:33

Mar 19 2019

Herald added a reviewer for D2709: Merge #11027: [RPC] Only return hex field once in getrawtransaction: Restricted Project.
Mar 19 2019, 17:09
jasonbcox accepted D2698: [LINTER] build: Add linter for checking accidental locale dependence.
Mar 19 2019, 16:45
jasonbcox accepted D2706: refactor: remove usage of locale dependent std::isspace.
Mar 19 2019, 16:21
jasonbcox accepted D2707: Fix braces in utilstrencodings.
Mar 19 2019, 16:10
jasonbcox accepted D2708: Fix braces in netbase.cpp.
Mar 19 2019, 16:05
jasonbcox triaged T565: Backport Core PR 11529 as High priority.
Mar 19 2019, 01:08 · Backport
jasonbcox triaged T564: Backport Core PR 11027 as Normal priority.
Mar 19 2019, 01:06 · Backport
jasonbcox added inline comments to D2702: qa: Improve getchaintxstats functional test.
Mar 19 2019, 00:43
jasonbcox requested changes to D2702: qa: Improve getchaintxstats functional test.
Mar 19 2019, 00:29
Herald added a reviewer for D2703: Merge #11565: Make listsinceblock refuse unknown block hash: Restricted Project.
Mar 19 2019, 00:24
jasonbcox requested changes to D2702: qa: Improve getchaintxstats functional test.

Missing the refactor in rpc/blockchain.cpp

Mar 19 2019, 00:02

Mar 18 2019

jasonbcox triaged T563: Backport Core PR 11565 as High priority.
Mar 18 2019, 23:53 · Backport
jasonbcox triaged T562: Backport Core PR 10275 as High priority.
Mar 18 2019, 23:48 · Backport
jasonbcox reassigned T561: Backport Core PR 12083 from jasonbcox to nakihito.
Mar 18 2019, 23:41 · Backport
jasonbcox triaged T561: Backport Core PR 12083 as High priority.
Mar 18 2019, 23:39 · Backport
jasonbcox triaged T560: Backport Core PR 11041 as Unbreak Now! priority.
Mar 18 2019, 22:40 · Backport
jasonbcox accepted D2701: Pass SendCoinsRecipient (208 bytes) by const reference.
Mar 18 2019, 22:16
jasonbcox triaged T559: Backport Core PR 10964 as Normal priority.
Mar 18 2019, 21:40 · Bootcamp, Backport
jasonbcox accepted D2695: [LINTER] Fix check doc incompatibility with BSD grep.
Mar 18 2019, 21:34
jasonbcox accepted D2700: Remove redundant locks.
Mar 18 2019, 20:36
jasonbcox accepted D2694: [LINTER] Improve check-doc regex.
Mar 18 2019, 19:58
jasonbcox added a subtask for T558: Backport Core PR 12830: T417: Backport PR10244 from core.
Mar 18 2019, 19:06 · Bootcamp, Restricted Project
jasonbcox added a parent task for T417: Backport PR10244 from core: T558: Backport Core PR 12830.
Mar 18 2019, 19:06 · Backport
jasonbcox triaged T558: Backport Core PR 12830 as Normal priority.
Mar 18 2019, 19:05 · Bootcamp, Restricted Project
jasonbcox reassigned T557: Backport Core PR 11733 from jasonbcox to nakihito.
Mar 18 2019, 18:56 · Backport
jasonbcox triaged T557: Backport Core PR 11733 as High priority.
Mar 18 2019, 18:56 · Backport
Herald added a reviewer for D2699: Merge #10742: scripted-diff: Use scoped enumerations (C++11, "enum class"): Restricted Project.
Mar 18 2019, 18:08
jasonbcox accepted D2697: test: Replace remaining sprintf with snprintf.
Mar 18 2019, 16:52

Mar 16 2019

jasonbcox committed rABC6a8115b98cca: Merge #12327: [gui] Defer coin control instancing (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #12327: [gui] Defer coin control instancing
Mar 16 2019, 15:48
jasonbcox closed T556: Backport Core PR 12327 as Resolved.
Mar 16 2019, 15:48 · Backport
jasonbcox closed T556: Backport Core PR 12327, a subtask of T417: Backport PR10244 from core, as Resolved.
Mar 16 2019, 15:48 · Backport
jasonbcox closed D2693: Merge #12327: [gui] Defer coin control instancing.
Mar 16 2019, 15:48
jasonbcox closed T550: Backport Core PR 11039 as Resolved.
Mar 16 2019, 15:47 · Backport
jasonbcox closed T550: Backport Core PR 11039, a subtask of T417: Backport PR10244 from core, as Resolved.
Mar 16 2019, 15:47 · Backport
jasonbcox committed rABC812ae90b6cee: Merge #11039: Avoid second mapWallet lookup (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11039: Avoid second mapWallet lookup
Mar 16 2019, 15:47
jasonbcox closed D2690: Merge #11039: Avoid second mapWallet lookup.
Mar 16 2019, 15:46
jasonbcox closed T551: Backport Core PR 9622 as Resolved.
Mar 16 2019, 15:32 · Backport
jasonbcox closed T551: Backport Core PR 9622, a subtask of T550: Backport Core PR 11039, as Resolved.
Mar 16 2019, 15:32 · Backport
jasonbcox committed rABCd1c1b1620a48: Merge #9622: [rpc] listsinceblock should include lost transactions when… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #9622: [rpc] listsinceblock should include lost transactions when…
Mar 16 2019, 15:32
jasonbcox closed D2689: Merge #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block.
Mar 16 2019, 15:31
Herald added a reviewer for D2696: Added better error reporting for running individual functional tests: Restricted Project.
Mar 16 2019, 15:29

Mar 15 2019

Herald added a reviewer for D2693: Merge #12327: [gui] Defer coin control instancing: Restricted Project.
Mar 15 2019, 23:28
jasonbcox triaged T556: Backport Core PR 12327 as High priority.
Mar 15 2019, 23:04 · Backport
jasonbcox triaged T555: Backport Core PR 10498 as Normal priority.
Mar 15 2019, 21:48 · Bootcamp, Restricted Project
jasonbcox triaged T554: Backport Core PR 11499 as Normal priority.
Mar 15 2019, 17:07 · Backport, Bootcamp, Restricted Project
jasonbcox accepted D2656: [CMAKE] Add DEBUG and DEBUG_LOCKORDER definitions to the Debug config.
Mar 15 2019, 16:51
jasonbcox updated the diff for D2689: Merge #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block.

linting, BTC -> BCH, and release notes

Mar 15 2019, 16:30
jasonbcox added inline comments to D2690: Merge #11039: Avoid second mapWallet lookup.
Mar 15 2019, 16:24
jasonbcox committed rABC68777835645a: Merge #10775: nCheckDepth chain height fix (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10775: nCheckDepth chain height fix
Mar 15 2019, 16:17
jasonbcox closed D2691: Merge #10775: nCheckDepth chain height fix.
Mar 15 2019, 16:17
jasonbcox committed rABC97a60cd531da: Bump version to 0.19.2 (authored by jasonbcox).
Bump version to 0.19.2
Mar 15 2019, 16:16
jasonbcox closed D2692: Bump version to 0.19.2.
Mar 15 2019, 16:16

Mar 14 2019

jasonbcox updated the diff for D2692: Bump version to 0.19.2.

Forgot to git add the release notes

Mar 14 2019, 22:29
Herald added a reviewer for D2692: Bump version to 0.19.2: Restricted Project.
Mar 14 2019, 22:27
Herald added a reviewer for D2691: Merge #10775: nCheckDepth chain height fix: Restricted Project.
Mar 14 2019, 18:51
jasonbcox added inline comments to D2689: Merge #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block.
Mar 14 2019, 18:42
jasonbcox updated the summary of D2690: Merge #11039: Avoid second mapWallet lookup.
Mar 14 2019, 18:39
jasonbcox added inline comments to D2690: Merge #11039: Avoid second mapWallet lookup.
Mar 14 2019, 18:39
Herald added a reviewer for D2690: Merge #11039: Avoid second mapWallet lookup: Restricted Project.
Mar 14 2019, 18:37
Herald added a reviewer for D2689: Merge #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block: Restricted Project.
Mar 14 2019, 18:14
jasonbcox closed T552: Backport Core PR 10783 as Resolved.
Mar 14 2019, 17:59 · Backport
jasonbcox closed T552: Backport Core PR 10783, a subtask of T551: Backport Core PR 9622, as Resolved.
Mar 14 2019, 17:59 · Backport
jasonbcox committed rABC33097f296256: Merge #10783: [RPC] Various rpc argument fixes (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10783: [RPC] Various rpc argument fixes
Mar 14 2019, 17:59
jasonbcox closed D2688: Merge #10783: [RPC] Various rpc argument fixes.
Mar 14 2019, 17:59
jasonbcox committed rABC168844a9c880: Merge #11618: rpc: Lock cs_main in blockToJSON/blockheaderToJSON (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11618: rpc: Lock cs_main in blockToJSON/blockheaderToJSON
Mar 14 2019, 17:55
jasonbcox closed D2684: Merge #11618: rpc: Lock cs_main in blockToJSON/blockheaderToJSON.
Mar 14 2019, 17:55
jasonbcox added inline comments to D2686: Added build-secp256k1.sh for running secp tests in TeamCity.
Mar 14 2019, 17:53
jasonbcox planned changes to D2686: Added build-secp256k1.sh for running secp tests in TeamCity.
Mar 14 2019, 17:52

Mar 13 2019

Herald added a reviewer for D2688: Merge #10783: [RPC] Various rpc argument fixes: Restricted Project.
Mar 13 2019, 21:26
jasonbcox triaged T552: Backport Core PR 10783 as High priority.
Mar 13 2019, 20:39 · Backport
jasonbcox triaged T551: Backport Core PR 9622 as Normal priority.
Mar 13 2019, 20:35 · Backport
jasonbcox triaged T550: Backport Core PR 11039 as High priority.
Mar 13 2019, 18:55 · Backport

Mar 12 2019

Herald added a reviewer for D2686: Added build-secp256k1.sh for running secp tests in TeamCity: deadalnix.
Mar 12 2019, 23:59
Herald added a reviewer for D2684: Merge #11618: rpc: Lock cs_main in blockToJSON/blockheaderToJSON: Restricted Project.
Mar 12 2019, 22:50
jasonbcox lowered the priority of T549: Backport Core PR 10742 from Low to Wishlist.
Mar 12 2019, 20:36 · Backport
jasonbcox lowered the priority of T549: Backport Core PR 10742 from Normal to Low.
Mar 12 2019, 20:36 · Backport
jasonbcox triaged T549: Backport Core PR 10742 as Normal priority.
Mar 12 2019, 19:39 · Backport
jasonbcox committed rABC3236d1a66a98: Fix feerate coin control (authored by jasonbcox).
Fix feerate coin control
Mar 12 2019, 19:28
jasonbcox closed D2683: Fix feerate coin control.
Mar 12 2019, 19:28
jasonbcox updated the diff for D2683: Fix feerate coin control.

Defensive check on m_feerate

Mar 12 2019, 18:50
Herald added a reviewer for D2683: Fix feerate coin control: Restricted Project.
Mar 12 2019, 17:40
jasonbcox committed rABC6224111e2005: Cleanup unused RPCServer references in qt/bitcoin.cpp (authored by jasonbcox).
Cleanup unused RPCServer references in qt/bitcoin.cpp
Mar 12 2019, 16:36
jasonbcox closed D2679: Cleanup unused RPCServer references in qt/bitcoin.cpp.
Mar 12 2019, 16:36
jasonbcox closed T548: Backport Core PR 11809 as Resolved.
Mar 12 2019, 16:35 · Backport
jasonbcox closed T548: Backport Core PR 11809, a subtask of T417: Backport PR10244 from core, as Resolved.
Mar 12 2019, 16:35 · Backport
jasonbcox committed rABC16fbb449f47c: Merge #11809: gui: Fix proxy setting options dialog crash (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11809: gui: Fix proxy setting options dialog crash
Mar 12 2019, 16:35
jasonbcox closed D2680: Merge #11809: gui: Fix proxy setting options dialog crash.
Mar 12 2019, 16:35
jasonbcox accepted D2682: [CMAKE] Avoid displaying the console when launching bitcoin-qt.exe.
Mar 12 2019, 15:25