Rebased from master
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Aug 15 2022
Aug 15 2022
Aug 13 2022
Aug 13 2022
tobias_ruck updated the diff for D11807: [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp.
tobias_ruck updated the diff for D11807: [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp.
Fix a handful of style stuff
Added whitespace check
Aug 12 2022
Aug 12 2022
Added new validation test per review feedback.
Responding to review feedback
Fabien committed rABCcc47d240176a: [avalanche] Don't poll blocks who are ancestors of a vote finalized block (authored by Fabien).
[avalanche] Don't poll blocks who are ancestors of a vote finalized block
sdulfari committed rABCa74757f1b30d: [avalanche] Fix comment related to proof requests (authored by sdulfari).
[avalanche] Fix comment related to proof requests
Fabien updated the diff for D11849: [avalanche] Don't poll blocks who are ancestors of a vote finalized block.
Feedback
Fabien added inline comments to D11849: [avalanche] Don't poll blocks who are ancestors of a vote finalized block.
sdulfari requested changes to D11849: [avalanche] Don't poll blocks who are ancestors of a vote finalized block.
bytesofman committed rABCf7934a691428: [Cashtab] [p6 and final of normalizeBalance improvements] Remove double… (authored by bytesofman).
[Cashtab] [p6 and final of normalizeBalance improvements] Remove double…
bytesofman committed rABC6ba5e0d6f442: [Cashtab] [p5 normalizeBalance fix] Improve name of normalizeBalance function (authored by bytesofman).
[Cashtab] [p5 normalizeBalance fix] Improve name of normalizeBalance function
bytesofman committed rABC0e4ad827a420: [Cashtab] [p4 normalizeBalance fix] Change function input to nonSlpUtxos (authored by bytesofman).
[Cashtab] [p4 normalizeBalance fix] Change function input to nonSlpUtxos
bytesofman committed rABC3dc92c1711e5: [Cashtab] [p3 normalizeBalance fix] Add unit tests (authored by bytesofman).
[Cashtab] [p3 normalizeBalance fix] Add unit tests
bytesofman committed rABCef429b86f59f: [Cashtab] [p2 normalizeBalance fix] Remove unused import from cashMethods.test. (authored by bytesofman).
[Cashtab] [p2 normalizeBalance fix] Remove unused import from cashMethods.test.
bytesofman committed rABC290b7a35106e: [Cashtab] [p1 normalizeBalance fix] Remove extra spaces from cashMethods.test.js (authored by bytesofman).
[Cashtab] [p1 normalizeBalance fix] Remove extra spaces from cashMethods.test.js
Fabien committed rABC621d6b79ad74: [avalanche] Bump the peer replacement cooldown (authored by Fabien).
[avalanche] Bump the peer replacement cooldown
Problem is that the arg manager doesn't work with std::chrono, so even if it is chrono internally the default value needs to be integer compatible
Fabien requested review of D11849: [avalanche] Don't poll blocks who are ancestors of a vote finalized block.
emack accepted D11848: [Cashtab] [p6 and final of normalizeBalance improvements] Remove double definition of this function in useWallet.
pre and post patch balances match all ok
bytesofman updated the diff for D11848: [Cashtab] [p6 and final of normalizeBalance improvements] Remove double definition of this function in useWallet.
Remove now-unused import function from cashMethods
teamcity added a comment to D11848: [Cashtab] [p6 and final of normalizeBalance improvements] Remove double definition of this function in useWallet.
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Aug 11 2022
Aug 11 2022
bytesofman updated the summary of D11846: [Cashtab] [p4 normalizeBalance fix] Change function input to nonSlpUtxos.
Looks like prettier also hadn't run...which bumps up lots of incidental changes in this diff not related to the first task. Will abandon and rework as a stacked diff.
bytesofman requested review of D11842: [Cashtab] Clean up, rename, unit tests for normalizeBalance function.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
removed test comment
Rebased + added test comment
Responding to review feedback
This should be a std::chrono::duration
Fabien committed rABCe758dde8096e: [avalanche] Hide the master and session keys in the debug log and console (authored by Fabien).
[avalanche] Hide the master and session keys in the debug log and console
[Automated] Update timing.json
[Automated] Update chainparams
Aug 10 2022
Aug 10 2022
Fabien requested review of D11839: [avalanche] Hide the master and session keys in the debug log and console.
bytesofman added a comment to D11741: [Cashtab] currency.prefixes & currency.tokenPrefixes converted to strings.
In D11741#265200, @kieran709 wrote:I noticed that in ScanQrCode there is a reference on line 72 to currency.tokenPrefix, which does not exist in the currency object, so it will not be a problem to remove them altogether, but we may need another task / diff to fix what is happening in ScanQrCode.
Fabien committed rABCc3895d0e0f91: Revert "[avalanche] Ban peers that send conflicting proofs repeatidly" (authored by Fabien).
Revert "[avalanche] Ban peers that send conflicting proofs repeatidly"
Fabien requested review of D11838: Revert "[avalanche] Ban peers that send conflicting proofs repeatidly".
kieran709 committed rABC0f0562e10f14: [Cashtab] Remove color change of address on hover in contact list (authored by kieran709).
[Cashtab] Remove color change of address on hover in contact list
teamcity triaged T2596: Build Bitcoin-ABC / Nightly Builds / Gitian Builds / Gitian - OSX is broken. as Unbreak Now! priority.
Aug 9 2022
Aug 9 2022
bytesofman planned changes to D11832: [Cashtab] [utxo handling p2] Sort etoken and non-etoken utxos.
In implementing a unit test for the token method, discovered that earlier mock of chronik.script('p2pkh', hash160).utxos(); was not actually mocking anything. Updated mocked chronik client URL to be fake as a way to catch future failed mocks.
bytesofman updated the diff for D11832: [Cashtab] [utxo handling p2] Sort etoken and non-etoken utxos.
Adding functionality, unit test
[avalanche] Fix getavaaddr on OSX
Aug 8 2022
Aug 8 2022
Use the dust threshold directly where it is needed, not involving the config.
The patch is now simpler and accomplishes a more focused set of changes.