Is it OK to store timing.json in git (test/function/timing.json)?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 24 2018
Feb 23 2018
Feb 21 2018
Feb 18 2018
Hmm, PushSig already has default SigHashType parameter (introduced in D932):
Feb 16 2018
Feb 15 2018
Feb 13 2018
@jasonbcox, should I also try to remove the following functions from DstEncode.h:
Feb 11 2018
Feb 10 2018
Feb 9 2018
Feb 8 2018
Feb 4 2018
Jan 30 2018
Jan 25 2018
Jan 24 2018
At D1028
Jan 23 2018
ok, on it.
Fixed the task title and descrition. It wasn't CChainParams directly, but rather a subcomponent of that, which is Consensus::Params. Look at calls to ContextualCheckBlock and it will be clear that the "params" parameter is redundant. Thanks for taking a look at this. :)
Checking ContextualCheckBlock at https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/src/validation.cpp;2c81a03ad212b73ca7002ef9f9f891a025c1f6bd$3523
Jan 22 2018
This flag should be added as part of the build as it is not a default on all the plateforms.
Right now, a lot of developers understand how to use Github. For a variety of reasons, we have chosen to use Phabricator, and will remain on Phabricator for the time being.
Jan 20 2018
Jan 19 2018
Jan 18 2018
Thinking that a bit more, I'm not sure sure we want to have different path. We can just have a cutoff that is time based, and if no time is provided, we run.
That sounds like a plan that could work.
ok, what about we have 3 paths:
We can have some file describing timing, but the absence of timing or listing shouldn't mean the test doesn't run.
Tests are ordered by the estimated runtime, to favor running tests in parallel (at BASE_SCRIPTS and EXTENDED_SCRIPTS arrays).