Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Jun 18 2020

Fabien updated the diff for D6635: [CI] Temporarly fix adoptopenjdk8 failure.

Add execution permission to the new script

Jun 18 2020, 08:44
Fabien requested review of D6635: [CI] Temporarly fix adoptopenjdk8 failure.
Jun 18 2020, 08:34
Fabien requested review of D6627: [CI] Add a build plan to run clang-tidy on the changed files.

The error is unrelated and caused by an infra failure.

Jun 18 2020, 07:00

Jun 17 2020

Fabien requested review of D6627: [CI] Add a build plan to run clang-tidy on the changed files.
Jun 17 2020, 19:10
Fabien requested review of D6621: tests: Make coins_tests/updatecoins_simulation_test deterministic.
Jun 17 2020, 14:40
Fabien requested review of D6620: tests: Make updatecoins_simulation_test deterministic.
Jun 17 2020, 14:36
Fabien accepted D6616: [backport#15427 1/3] Abstract out EvalDescriptorStringOrObject from scantxoutset.
Jun 17 2020, 09:37
Fabien accepted D6615: [backport#15744] refactor: Extract ParseDescriptorRange.
Jun 17 2020, 09:33
Fabien accepted D6614: [backport#15497] Make deriveaddresses use stop/[start,stop] notation for ranges.
Jun 17 2020, 09:29
Fabien accepted D6613: [backport#15497] Use stop/[start,stop] notation in importmulti desc range.

Out of scope for this diff, but please investigate why we don't have the # Test importing of a ranged descriptor without keys case like core

Jun 17 2020, 09:24
Fabien accepted D6612: [backport#15497] Add support for stop/[start,stop] ranges to scantxoutset.
Jun 17 2020, 09:15
Fabien accepted D6611: [backport#15497] Support ranges arguments in RPC help.
Jun 17 2020, 09:12
Fabien accepted D6610: [backport#15497] Add ParseRange function to parse args of the form int/[int,int].
Jun 17 2020, 09:07
Fabien accepted D6609: [backport#15368] Add checksums to descriptors.md.
Jun 17 2020, 09:06

Jun 16 2020

Fabien accepted D6602: [backport#15368] Make descriptor checksums mandatory in deriveaddresses and importmulti.
Jun 16 2020, 20:09
Fabien committed rABC19e3653189e6: [CI] Make the coverage report available to Teamcity (authored by Fabien).
[CI] Make the coverage report available to Teamcity
Jun 16 2020, 17:12
Fabien closed D6608: [CI] Make the coverage report available to Teamcity.
Jun 16 2020, 17:12
Fabien accepted D6600: [backport#15368] Descriptor checksum.
Jun 16 2020, 16:42
Fabien added inline comments to D6608: [CI] Make the coverage report available to Teamcity.
Jun 16 2020, 16:41
Fabien updated the diff for D6608: [CI] Make the coverage report available to Teamcity.

Use tar instead of zip

Jun 16 2020, 16:39
Fabien planned changes to D6608: [CI] Make the coverage report available to Teamcity.

Actually the ZIP is the default configuration, hence the doc, but this can be overridden. I'll update this diff.

Jun 16 2020, 16:22
Fabien added inline comments to D6608: [CI] Make the coverage report available to Teamcity.
Jun 16 2020, 16:06
Fabien committed rABC287efccb62cb: [CI] Add a build-coverage target (authored by Fabien).
[CI] Add a build-coverage target
Jun 16 2020, 16:00
Fabien closed D6607: [CI] Add a build-coverage target.
Jun 16 2020, 16:00
Fabien requested review of D6608: [CI] Make the coverage report available to Teamcity.
Jun 16 2020, 15:58
Fabien requested review of D6607: [CI] Add a build-coverage target.

See https://build.bitcoinabc.org/viewLog.html?tab=buildLog&buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=80478&guest=1

Jun 16 2020, 15:55
Fabien added a comment to D6607: [CI] Add a build-coverage target.

@bot build-coverage

Jun 16 2020, 14:58
Fabien planned changes to D6607: [CI] Add a build-coverage target.

Pending build success

Jun 16 2020, 14:58
Fabien requested review of D6607: [CI] Add a build-coverage target.
Jun 16 2020, 14:57
Fabien committed rABCebe9c33ab580: [Qt] Fix deprecated QButtonGroup::buttonClicked event (authored by Fabien).
[Qt] Fix deprecated QButtonGroup::buttonClicked event
Jun 16 2020, 13:12
Fabien closed D6606: [Qt] Fix deprecated QButtonGroup::buttonClicked event.
Jun 16 2020, 13:12
Fabien added inline comments to D6606: [Qt] Fix deprecated QButtonGroup::buttonClicked event.
Jun 16 2020, 13:11
Fabien committed rABC40aba5c53a0f: [Qt] Fix deprecated QString::SplitBehavior (now Qt::SplitBehavior) (authored by Fabien).
[Qt] Fix deprecated QString::SplitBehavior (now Qt::SplitBehavior)
Jun 16 2020, 13:08
Fabien closed D6605: [Qt] Fix deprecated QString::SplitBehavior (now Qt::SplitBehavior).
Jun 16 2020, 13:08
Fabien committed rABC2a52c6dfc888: [Qt] Fix deprecated QSignalMapper::mapped event (authored by Fabien).
[Qt] Fix deprecated QSignalMapper::mapped event
Jun 16 2020, 13:07
Fabien closed D6604: [Qt] Fix deprecated QSignalMapper::mapped event.
Jun 16 2020, 13:07
Fabien requested review of D6606: [Qt] Fix deprecated QButtonGroup::buttonClicked event.
Jun 16 2020, 10:25
Fabien requested review of D6605: [Qt] Fix deprecated QString::SplitBehavior (now Qt::SplitBehavior).
Jun 16 2020, 10:24
Fabien requested review of D6604: [Qt] Fix deprecated QSignalMapper::mapped event.
Jun 16 2020, 10:23
Fabien accepted D6599: Leftovers from PR14119.
Jun 16 2020, 08:16
Fabien requested changes to D6602: [backport#15368] Make descriptor checksums mandatory in deriveaddresses and importmulti.

Is it possible to adapt the test to cover the bad checksum case when importing using a descriptor ?

Jun 16 2020, 08:10
Fabien accepted D6601: [backport#15368] Add getdescriptorinfo to compute checksum.
Jun 16 2020, 08:01
Fabien requested changes to D6600: [backport#15368] Descriptor checksum.

Only comment nits, otherwise LGTM

Jun 16 2020, 07:57
Fabien accepted D6562: [avalanche] Poll all candidate tips.
Jun 16 2020, 05:58

Jun 15 2020

Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-should-fail

Jun 15 2020, 19:20
Fabien committed rABCff275be8629a: [Qt] Fix deprecated QDateTime(const QDate &) (authored by Fabien).
[Qt] Fix deprecated QDateTime(const QDate &)
Jun 15 2020, 19:13
Fabien closed D6575: [Qt] Fix deprecated QDateTime(const QDate &).
Jun 15 2020, 19:13
Fabien committed rABCa7a19984d08a: [Qt] Fix deprecated pixmap() return by pointer with Qt 5.15 (authored by Fabien).
[Qt] Fix deprecated pixmap() return by pointer with Qt 5.15
Jun 15 2020, 19:12
Fabien closed D6573: [Qt] Fix deprecated pixmap() return by pointer with Qt 5.15.
Jun 15 2020, 19:12
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-make-generator build-win64

Jun 15 2020, 19:09
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-autotools

Jun 15 2020, 19:06
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-clang-10

Jun 15 2020, 19:03
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-clang-10

Jun 15 2020, 16:17
Fabien accepted D6574: Update Bitcoin ABC RPC to use the Check facility.
Jun 15 2020, 15:06
Fabien updated the diff for D6573: [Qt] Fix deprecated pixmap() return by pointer with Qt 5.15.

Address feedback

Jun 15 2020, 14:55
Fabien requested review of D6575: [Qt] Fix deprecated QDateTime(const QDate &).
Jun 15 2020, 14:47
Fabien updated the diff for D6573: [Qt] Fix deprecated pixmap() return by pointer with Qt 5.15.

Add the missed one

Jun 15 2020, 13:45
Fabien planned changes to D6573: [Qt] Fix deprecated pixmap() return by pointer with Qt 5.15.

I missed one

Jun 15 2020, 13:42
Fabien committed rABC7e894b265dac: [Qt] Remove unused WindowFlags parameters (authored by Fabien).
[Qt] Remove unused WindowFlags parameters
Jun 15 2020, 13:32
Fabien closed D6572: [Qt] Remove unused WindowFlags parameters.
Jun 15 2020, 13:32
Fabien committed rABC1b58d6694721: Consistently use the QT_VERSION_CHECK macro (authored by Fabien).
Consistently use the QT_VERSION_CHECK macro
Jun 15 2020, 13:32
Fabien retitled D6572: [Qt] Remove unused WindowFlags parameters from [Qt] Remove unused WindowFlags paramters to [Qt] Remove unused WindowFlags parameters.
Jun 15 2020, 13:32
Fabien closed D6570: Consistently use the QT_VERSION_CHECK macro.
Jun 15 2020, 13:32
Fabien committed rABC5e39715d20bb: Cleanup Qt branches on old unsupported version (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
Cleanup Qt branches on old unsupported version
Jun 15 2020, 13:31
Fabien closed D6569: Cleanup Qt branches on old unsupported version.
Jun 15 2020, 13:30
Fabien committed rABCe1c4fc1249f5: [CI] Fix wrong path to bitcoind binary on build-ibd-* (authored by Fabien).
[CI] Fix wrong path to bitcoind binary on build-ibd-*
Jun 15 2020, 13:30
Fabien added a comment to D6568: [CI] Fix wrong path to bitcoind binary on build-ibd-*.

Good call

Jun 15 2020, 13:30
Fabien closed D6568: [CI] Fix wrong path to bitcoind binary on build-ibd-*.
Jun 15 2020, 13:30
Fabien requested review of D6573: [Qt] Fix deprecated pixmap() return by pointer with Qt 5.15.
Jun 15 2020, 13:29
Fabien requested review of D6572: [Qt] Remove unused WindowFlags parameters.
Jun 15 2020, 12:20
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-clang-10

Jun 15 2020, 11:54
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Jun 15 2020, 11:33
Fabien requested review of D6571: [WIP] Test commit, don't review.
Jun 15 2020, 11:33
Fabien requested review of D6570: Consistently use the QT_VERSION_CHECK macro.
Jun 15 2020, 10:32
Fabien requested review of D6569: Cleanup Qt branches on old unsupported version.
Jun 15 2020, 10:21
Fabien requested review of D6568: [CI] Fix wrong path to bitcoind binary on build-ibd-*.
Jun 15 2020, 09:22
Fabien accepted D6526: Merge #14719: qa: Check specific reject reasons in feature_block.
Jun 15 2020, 09:09
Fabien requested changes to D6283: [seeder] Request headers from new connections.

Clearing my queue for now, this is subject to changes depending on D6357

Jun 15 2020, 08:50
Fabien accepted D6567: Always repport proper sigcheck count.
Jun 15 2020, 08:45
Fabien accepted D6566: Remove activation logic for chained transaction limit.
Jun 15 2020, 08:33
Fabien accepted D6565: Make CLIENT_VERSION constexpr.
Jun 15 2020, 08:31
Fabien accepted D6564: CBlockTreeDB::ReadReindexing => CBlockTreeDB::IsReindexing.
Jun 15 2020, 08:30
Fabien accepted D6563: Continue relaying transactions after they expire from mapRelay.
Jun 15 2020, 08:24
Fabien added a comment to D6562: [avalanche] Poll all candidate tips.

This needs rebase to avoid conflict with D6559

Jun 15 2020, 08:17
Fabien accepted D6559: [avalanche] Process AvalancheResponse and act based on the result..
Jun 15 2020, 08:16
Fabien accepted D6548: Update avalanche integration test to use a quorum.
Jun 15 2020, 07:54

Jun 13 2020

Fabien committed rABC853bb5f94ea6: [CI] Prevent ccache crosstalk by building in separate directories (authored by Fabien).
[CI] Prevent ccache crosstalk by building in separate directories
Jun 13 2020, 08:53
Fabien closed D6551: [CI] Prevent ccache crosstalk by building in separate directories.
Jun 13 2020, 08:53
Fabien updated the diff for D6551: [CI] Prevent ccache crosstalk by building in separate directories.

Comment

Jun 13 2020, 08:52

Jun 12 2020

Fabien committed rABC0edc1fe896af: [LINTER] Check for missing explicit (authored by Fabien).
[LINTER] Check for missing explicit
Jun 12 2020, 18:45
Fabien closed D6549: [LINTER] Check for missing explicit.
Jun 12 2020, 18:45
Fabien updated the diff for D6549: [LINTER] Check for missing explicit.

Fix anti-pattern

Jun 12 2020, 18:31
Fabien added a comment to D6549: [LINTER] Check for missing explicit.

TBH I didn't expect so much changes when I started !

Jun 12 2020, 18:29
Fabien requested review of D6551: [CI] Prevent ccache crosstalk by building in separate directories.
Jun 12 2020, 16:11
Fabien requested review of D6549: [LINTER] Check for missing explicit.
Jun 12 2020, 16:02
Fabien committed rABC05720a8d6d46: [CMAKE] Fail early if a lib header is missing, remove garbage in version (authored by Fabien).
[CMAKE] Fail early if a lib header is missing, remove garbage in version
Jun 12 2020, 16:01
Fabien closed D6545: [CMAKE] Fail early if a lib header is missing, remove garbage in version.
Jun 12 2020, 16:01
Fabien committed rABCae5e07f4111a: [CMAKE] Don't require jemalloc for systems where it's the default (authored by Fabien).
[CMAKE] Don't require jemalloc for systems where it's the default
Jun 12 2020, 16:00
Fabien closed D6544: [CMAKE] Don't require jemalloc for systems where it's the default.
Jun 12 2020, 16:00
Fabien committed rABC09768becd9a8: Fix single parameter constructors not marked "explicit" (authored by practicalswift <practicalswift@users.noreply.github.com>).
Fix single parameter constructors not marked "explicit"
Jun 12 2020, 15:58
First
Prev
Next