Page MenuHomePhabricator
Feed Advanced Search

May 7 2019

jasonbcox triaged T641: Backport Core PR 11281 as High priority.
May 7 2019, 20:02
Herald added a reviewer for D2972: Merge #11744: net: Add missing locks in net.{cpp,h}: Restricted Project.
May 7 2019, 19:43
Herald added a reviewer for D2971: Merge #9539: [net] Avoid initialization to a value that is never read: Restricted Project.
May 7 2019, 19:25
jasonbcox accepted D2929: Sanitize some wallet serialization.
May 7 2019, 16:15
jasonbcox accepted D2967: qt: refactor: Use absolute include paths in .ui files.
May 7 2019, 16:03
jasonbcox accepted D2968: qt: refactor: Changes to make include paths absolute.
May 7 2019, 16:02
jasonbcox accepted D2969: test: refactor: Use absolute include paths for test data files.
May 7 2019, 16:02
jasonbcox committed rABC52ac6f78e561: Merge #12326: net: initialize socket to avoid closing random fd's (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12326: net: initialize socket to avoid closing random fd's
May 7 2019, 16:00
jasonbcox closed D2959: Merge #12326: net: initialize socket to avoid closing random fd's.
May 7 2019, 16:00
jasonbcox committed rABC964c6f19d6e3: Merge #11252: [P2P] When clearing addrman clear mapInfo and mapAddr. (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #11252: [P2P] When clearing addrman clear mapInfo and mapAddr.
May 7 2019, 15:59
jasonbcox closed D2944: Merge #11252: [P2P] When clearing addrman clear mapInfo and mapAddr..
May 7 2019, 15:59
jasonbcox committed rABC67c8c68f91cc: Merge #12448: Interrupt block generation on shutdown request (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12448: Interrupt block generation on shutdown request
May 7 2019, 15:58
jasonbcox closed D2956: Merge #12448: Interrupt block generation on shutdown request.
May 7 2019, 15:58
jasonbcox committed rABC402885bcf980: Merge #11585: addrman: Add missing lock in Clear() (CAddrMan) (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11585: addrman: Add missing lock in Clear() (CAddrMan)
May 7 2019, 15:24
jasonbcox closed D2945: Merge #11585: addrman: Add missing lock in Clear() (CAddrMan).
May 7 2019, 15:24
jasonbcox committed rABC0c835225f245: Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue() (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue()
May 7 2019, 15:21
jasonbcox closed D2943: Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue().
May 7 2019, 15:21
jasonbcox committed rABC11beaacd1c4f: Merge #11831: Always return true if AppInitMain got to the end (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11831: Always return true if AppInitMain got to the end
May 7 2019, 15:20
jasonbcox closed D2962: Merge #11831: Always return true if AppInitMain got to the end.
May 7 2019, 15:20
jasonbcox committed rABC7735f949b68e: Merge #10057: [init] Deduplicated sigaction() boilerplate (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10057: [init] Deduplicated sigaction() boilerplate
May 7 2019, 15:18
jasonbcox closed D2961: Merge #10057: [init] Deduplicated sigaction() boilerplate.
May 7 2019, 15:18
Herald added a reviewer for D2962: Merge #11831: Always return true if AppInitMain got to the end: Restricted Project.
May 7 2019, 03:40
jasonbcox accepted D2947: [CMAKE] Determine the Qt library directory from a public variable.
May 7 2019, 03:39
jasonbcox accepted D2949: [CMAKE] Fix the prl conversion script linking against lib_NOTFOUND.
May 7 2019, 03:38
jasonbcox triaged T640: Backport Core PR 9856 as Normal priority.
May 7 2019, 03:28 · Bootcamp, Restricted Project
jasonbcox added inline comments to D2961: Merge #10057: [init] Deduplicated sigaction() boilerplate.
May 7 2019, 03:23
Herald added a reviewer for D2961: Merge #10057: [init] Deduplicated sigaction() boilerplate: Restricted Project.
May 7 2019, 03:22
Herald added a reviewer for D2960: Merge #10489: build: silence gcc7's implicit fallthrough warning: Restricted Project.
May 7 2019, 02:53
jasonbcox added a parent task for T638: Backport Core PR 11738 (fix hang in sendrawtransaction): T639: Backport Core PR 11877 (tests).
May 7 2019, 01:49
jasonbcox added a subtask for T639: Backport Core PR 11877 (tests): T638: Backport Core PR 11738 (fix hang in sendrawtransaction).
May 7 2019, 01:49
jasonbcox triaged T639: Backport Core PR 11877 (tests) as High priority.
May 7 2019, 01:49
jasonbcox added a parent task for T436: Backport core PR 10286: T638: Backport Core PR 11738 (fix hang in sendrawtransaction).
May 7 2019, 01:49 · Restricted Project
jasonbcox added a subtask for T638: Backport Core PR 11738 (fix hang in sendrawtransaction): T436: Backport core PR 10286.
May 7 2019, 01:49
jasonbcox triaged T638: Backport Core PR 11738 (fix hang in sendrawtransaction) as High priority.
May 7 2019, 01:48
Herald added a reviewer for D2959: Merge #12326: net: initialize socket to avoid closing random fd's: Restricted Project.
May 7 2019, 00:55
Herald added a reviewer for D2958: Merge #12415: Interrupt loading thread after shutdown request: Restricted Project.
May 7 2019, 00:43
jasonbcox accepted D2953: Init: Remove redundant exit(EXIT_FAILURE) instances and replace with return false.
May 7 2019, 00:40
jasonbcox accepted D2954: Ignore macOS daemon() depracation warning.
May 7 2019, 00:39
jasonbcox updated the summary of D2957: Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished.
May 7 2019, 00:37
Herald added a reviewer for D2957: Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished: Restricted Project.
May 7 2019, 00:37
jasonbcox accepted D2950: Merge #9693: Prevent integer overflow in ReadVarInt..
May 7 2019, 00:33
Herald added a reviewer for D2956: Merge #12448: Interrupt block generation on shutdown request: Restricted Project.
May 7 2019, 00:23
Herald added a reviewer for D2955: Merge #13080: mempool: Add compile time checking for ::mempool.cs runtime locking assertions: Restricted Project.
May 7 2019, 00:16
jasonbcox requested changes to D2950: Merge #9693: Prevent integer overflow in ReadVarInt..
May 7 2019, 00:13

May 6 2019

Herald added a reviewer for D2952: Make functions in rpc/blockchain.cpp static.: Restricted Project.
May 6 2019, 23:55
Herald added a reviewer for D2951: Merge #12206: qa: Sync with validationinterface queue in sync_mempools: Restricted Project.
May 6 2019, 23:49
Herald added a reviewer for D2946: Merge #11099: [RPC][mempool]: Add savemempool RPC: Restricted Project.
May 6 2019, 23:09
jasonbcox committed rABCf5919276fb6e: Merge #10027: Set to nullptr after delete (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10027: Set to nullptr after delete
May 6 2019, 21:30
jasonbcox closed D2942: Merge #10027: Set to nullptr after delete.
May 6 2019, 21:30
jasonbcox accepted D2941: Backport dev notes on RPC.
May 6 2019, 21:29
Herald added a reviewer for D2945: Merge #11585: addrman: Add missing lock in Clear() (CAddrMan): Restricted Project.
May 6 2019, 21:26
Herald added a reviewer for D2944: Merge #11252: [P2P] When clearing addrman clear mapInfo and mapAddr.: Restricted Project.
May 6 2019, 21:21
Herald added a reviewer for D2943: Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue(): Restricted Project.
May 6 2019, 21:16
Herald added a reviewer for D2942: Merge #10027: Set to nullptr after delete: Restricted Project.
May 6 2019, 21:10
jasonbcox committed rABCb3bfd0767d45: Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files
May 6 2019, 19:50
jasonbcox closed D2940: Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files.
May 6 2019, 19:49
jasonbcox removed a parent task for T436: Backport core PR 10286: T623: Backport Core PR 13023.
May 6 2019, 19:46 · Restricted Project
jasonbcox removed a subtask for T623: Backport Core PR 13023: T436: Backport core PR 10286.
May 6 2019, 19:46
jasonbcox added a parent task for T436: Backport core PR 10286: T626: Backport Core PR 12988.
May 6 2019, 19:46 · Restricted Project
jasonbcox added a subtask for T626: Backport Core PR 12988: T436: Backport core PR 10286.
May 6 2019, 19:46
jasonbcox added a comment to D2940: Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files.

Note for reviewers: txmempool.* changes are not necessary since we've already renamed them to more appropriate names.

May 6 2019, 19:44
Herald added a reviewer for D2940: Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files: Restricted Project.
May 6 2019, 19:32
jasonbcox updated the task description for T436: Backport core PR 10286.
May 6 2019, 18:54 · Restricted Project
jasonbcox committed rABCea00f38e32db: Merge #12349: shutdown: fix crash on shutdown with reindex-chainstate (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12349: shutdown: fix crash on shutdown with reindex-chainstate
May 6 2019, 16:15
jasonbcox closed D2907: Merge #12349: shutdown: fix crash on shutdown with reindex-chainstate.
May 6 2019, 16:15
jasonbcox closed T624: Backport Core PR 12367 as Resolved.
May 6 2019, 16:13
jasonbcox closed T624: Backport Core PR 12367, a subtask of T623: Backport Core PR 13023, as Resolved.
May 6 2019, 16:13
jasonbcox committed rABCbb92536992e0: Merge #12367: Fix two fast-shutdown bugs (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12367: Fix two fast-shutdown bugs
May 6 2019, 16:13
jasonbcox closed D2906: Merge #12367: Fix two fast-shutdown bugs.
May 6 2019, 16:13
jasonbcox closed T627: Backport Core PR 11238, a subtask of T626: Backport Core PR 12988, as Resolved.
May 6 2019, 16:12
jasonbcox closed T627: Backport Core PR 11238 as Resolved.
May 6 2019, 16:12
jasonbcox committed rABCe87cb7d7a375: Merge #11238: Add assertions before potential null deferences (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11238: Add assertions before potential null deferences
May 6 2019, 16:12
jasonbcox closed D2909: Merge #11238: Add assertions before potential null deferences.
May 6 2019, 16:12
jasonbcox closed T417: Backport PR10244 from core, a subtask of T416: October backport session, as Resolved.
May 6 2019, 15:45 · Backport
jasonbcox closed T417: Backport PR10244 from core, a subtask of T541: Backport Core PR10267 to support includeconf, as Resolved.
May 6 2019, 15:45 · Restricted Project
jasonbcox closed T417: Backport PR10244 from core, a subtask of T436: Backport core PR 10286, as Resolved.
May 6 2019, 15:45 · Restricted Project
jasonbcox closed T417: Backport PR10244 from core, a subtask of T558: Backport Core PR 12830, as Resolved.
May 6 2019, 15:45 · Bootcamp, Restricted Project
jasonbcox closed T417: Backport PR10244 from core, a subtask of T571: Backport Core PR 10973, as Resolved.
May 6 2019, 15:45 · Restricted Project
jasonbcox closed T417: Backport PR10244 from core, a subtask of T583: Backport Core PR 13190, as Resolved.
May 6 2019, 15:45 · Backport, Bootcamp, Restricted Project
jasonbcox closed T417: Backport PR10244 from core, a subtask of T590: Backport Core 14555: Move util files to new directory, as Resolved.
May 6 2019, 15:45 · Backport, Restricted Project
jasonbcox closed T417: Backport PR10244 from core, a subtask of T598: Backport Core PR 12909: wallet: Make fee settings to be non-static members, as Resolved.
May 6 2019, 15:45 · Restricted Project, Backport
jasonbcox closed T417: Backport PR10244 from core as Resolved.
May 6 2019, 15:45 · Backport
jasonbcox committed rABC9dfd6fbb3272: Add developer notes about blocking GUI code and src/interfaces/README.md (authored by Russell Yanofsky <russ@yanofsky.org>).
Add developer notes about blocking GUI code and src/interfaces/README.md
May 6 2019, 15:45
jasonbcox closed D2900: Add developer notes about blocking GUI code and src/interfaces/README.md.
May 6 2019, 15:45

May 5 2019

jasonbcox accepted D2918: test: Plug memory leaks and stack-use-after-scope.
May 5 2019, 18:01

May 3 2019

jasonbcox requested changes to D2918: test: Plug memory leaks and stack-use-after-scope.

Please still include the change in test_bitcoin.cpp. Although it appears useless, there's no telling if Core will write a new test in the future that depends on this, which we would then want to backport. Essentially, by leaving this change out, we are taking ownership of the code. Unless we also want to own net.h's definitions and switch vNodes to a vector of smart pointers, then I don't think this half-ownership is wise.

May 3 2019, 21:21
jasonbcox accepted D2919: Fix a memory leak in DoS_tests.
May 3 2019, 21:14
jasonbcox accepted D2917: Use angle bracket in include for qt tests.
May 3 2019, 21:13
jasonbcox accepted D2903: [db] Migration for txindex data to new, separate database..
May 3 2019, 17:21
jasonbcox accepted D2901: [db] Create separate database for txindex..
May 3 2019, 17:18
jasonbcox requested changes to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
May 3 2019, 17:09
jasonbcox requested changes to D2917: Use angle bracket in include for qt tests.
May 3 2019, 17:02
jasonbcox accepted D2916: Use angle bracket in include for remaining qt files.
May 3 2019, 16:59
jasonbcox accepted D2915: Use angle bracket in include for qt pages, widgets and views.
May 3 2019, 16:54
jasonbcox accepted D2914: Use angle bracket in include for qt model files.
May 3 2019, 16:52
jasonbcox accepted D2913: Use angle bracket in include for qt dialog files.
May 3 2019, 16:51
jasonbcox accepted D2912: Use angle bracket in include for qt/bitcoin* files.
May 3 2019, 16:50
jasonbcox committed rABCab16e612d2ac: Added some notes for the 0.19.5 release (authored by jasonbcox).
Added some notes for the 0.19.5 release
May 3 2019, 16:00
jasonbcox closed D2910: Added some notes for the 0.19.5 release.
May 3 2019, 16:00
jasonbcox committed rABCc4571f6c6fdb: Updated mainnet seeds for 0.19.5 release (authored by jasonbcox).
Updated mainnet seeds for 0.19.5 release
May 3 2019, 16:00