Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

	Include stories about projects I am a member of.

Jul 10 2019

markblundeberg added inline comments to D3625: [refactor multisig] make const values up front.

Jul 10 2019, 02:12

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCe1feff241410: [script_tests] add tests for pubkey encoding with strictenc + nullfail (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).

[script_tests] add tests for pubkey encoding with strictenc + nullfail

Jul 10 2019, 02:03

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3613: [script_tests] add tests for pubkey encoding with strictenc + nullfail.

Jul 10 2019, 02:03

deadalnix requested changes to D3625: [refactor multisig] make const values up front.

Jul 10 2019, 02:01

deadalnix accepted D3623: Merge #10728: fix typo in help text for removeprunedfunds.

Jul 10 2019, 01:54

teamcity added a comment to D3626: [refactor multisig] separate nullfail from stack cleanup.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 10 2019, 01:44

teamcity added a comment to D3626: [refactor multisig] separate nullfail from stack cleanup.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 10 2019, 01:38

markblundeberg created D3626: [refactor multisig] separate nullfail from stack cleanup.

Jul 10 2019, 01:38

teamcity added a comment to D3625: [refactor multisig] make const values up front.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 10 2019, 01:31

markblundeberg added a comment to D3625: [refactor multisig] make const values up front.

@deadalnix I know you want to switch it to size_t but I'd like to defer that until after this refactor... I'm not 100% comfortable with the C++ casting rules and I think it would make more sense as a consistent style change over the entire EvalScript function, not just one opcode.

Jul 10 2019, 01:25

teamcity added a comment to D3625: [refactor multisig] make const values up front.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 10 2019, 01:22

markblundeberg created D3625: [refactor multisig] make const values up front.

Jul 10 2019, 01:22

markblundeberg abandoned D3612: [script_tests] consolidate multisig order tests.

Jul 10 2019, 00:40

teamcity added a comment to D3623: Merge #10728: fix typo in help text for removeprunedfunds.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 10 2019, 00:39

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC826bd16fe02a: [schnorr functional test] improve tx handling (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).

[schnorr functional test] improve tx handling

Jul 10 2019, 00:39

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3617: [schnorr functional test] improve tx handling.

Jul 10 2019, 00:38

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC3f385a74e17b: [schnorr functional test] simplify funding logic (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).

[schnorr functional test] simplify funding logic

Jul 10 2019, 00:38

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3616: [schnorr functional test] simplify funding logic.

Jul 10 2019, 00:38

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCc8c8028beb14: [schnorr functional test] change block setup logic (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).

[schnorr functional test] change block setup logic

Jul 10 2019, 00:37

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3615: [schnorr functional test] change block setup logic.

Jul 10 2019, 00:37

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCc5c9afad5db9: [schnorr functional test] remove ComparisonTestFramework dependency (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).

[schnorr functional test] remove ComparisonTestFramework dependency

Jul 10 2019, 00:37

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3601: [schnorr functional test] remove ComparisonTestFramework dependency.

Jul 10 2019, 00:36

teamcity added a comment to D3624: Rename wallet_accounts.py test.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 10 2019, 00:28

teamcity added a comment to D3623: Merge #10728: fix typo in help text for removeprunedfunds.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 10 2019, 00:26

nakihito updated the diff for D3623: Merge #10728: fix typo in help text for removeprunedfunds.

Allowed linter to relayout help string.

Jul 10 2019, 00:26

teamcity added a comment to D3624: Rename wallet_accounts.py test.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 10 2019, 00:22

deadalnix created D3624: Rename wallet_accounts.py test.

Jul 10 2019, 00:21

Nico Guiton <nico@bitframe.org> committed rABC71ee453fecf0: Merge #10684: Remove no longer used mempool.exists(outpoint) (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #10684: Remove no longer used mempool.exists(outpoint)

Jul 10 2019, 00:12

Nico Guiton <nico@bitframe.org> closed D3621: Merge #10684: Remove no longer used mempool.exists(outpoint).

Jul 10 2019, 00:12

deadalnix requested changes to D3623: Merge #10728: fix typo in help text for removeprunedfunds.

Jul 10 2019, 00:11

teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Jul 10 2019, 00:06

teamcity added a comment to D3623: Merge #10728: fix typo in help text for removeprunedfunds.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 10 2019, 00:03

teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 10 2019, 00:01

Nico Guiton <nico@bitframe.org> committed rABCbd9e25638438: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache) (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache)

Jul 10 2019, 00:01

Nico Guiton <nico@bitframe.org> closed D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).

Jul 10 2019, 00:01

Jul 9 2019

teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Jul 9 2019, 23:54

teamcity added a comment to D3623: Merge #10728: fix typo in help text for removeprunedfunds.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 9 2019, 23:53

nakihito created D3623: Merge #10728: fix typo in help text for removeprunedfunds.

Jul 9 2019, 23:53

teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 9 2019, 23:52

Fabien updated the diff for D3197: Make Teamcity agent setup easier.

Update COMMIT setting

Jul 9 2019, 23:52

deadalnix accepted D3617: [schnorr functional test] improve tx handling.

Jul 9 2019, 23:48

deadalnix accepted D3616: [schnorr functional test] simplify funding logic.

Jul 9 2019, 23:46

teamcity added a comment to D3581: Merge #10657: Utils: Improvements to ECDSA key-handling code.

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) passed.

Jul 9 2019, 23:45

deadalnix accepted D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).

Jul 9 2019, 23:42

teamcity added a comment to D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 9 2019, 23:42

deadalnix accepted D3615: [schnorr functional test] change block setup logic.

Jul 9 2019, 23:40

Nico Guiton <nico@bitframe.org> committed rABC8cf3702cb6f0: Merge #10685: Clarify CCoinsViewMemPool documentation. (authored by Pieter Wuille <pieter.wuille@gmail.com>).

Merge #10685: Clarify CCoinsViewMemPool documentation.

Jul 9 2019, 23:37

Nico Guiton <nico@bitframe.org> closed D3622: Merge #10685: Clarify CCoinsViewMemPool documentation..

Jul 9 2019, 23:37

teamcity added a comment to D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 9 2019, 23:33

nakihito updated the diff for D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).

Fixed comment formatting.

Jul 9 2019, 23:32

teamcity added a comment to D3622: Merge #10685: Clarify CCoinsViewMemPool documentation..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 9 2019, 23:28

deadalnix requested changes to D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).

Jul 9 2019, 23:25

teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC Gitian Diff Testing failed.

Jul 9 2019, 23:24

teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Jul 9 2019, 23:24

deadalnix accepted D3621: Merge #10684: Remove no longer used mempool.exists(outpoint).

Jul 9 2019, 23:21

deadalnix accepted D3622: Merge #10685: Clarify CCoinsViewMemPool documentation..

Jul 9 2019, 23:20

teamcity added a comment to D3622: Merge #10685: Clarify CCoinsViewMemPool documentation..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 9 2019, 23:17

nakihito created D3622: Merge #10685: Clarify CCoinsViewMemPool documentation..

Jul 9 2019, 23:17

teamcity added a comment to D3568: Fix memory leak in work_comparator_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 9 2019, 23:13

teamcity added a comment to D3567: (not for review) a deliberately failing test.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Jul 9 2019, 23:07

teamcity added a comment to D3568: Fix memory leak in work_comparator_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 9 2019, 22:56

teamcity added a comment to D3567: (not for review) a deliberately failing test.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 9 2019, 22:55

teamcity added a comment to D3621: Merge #10684: Remove no longer used mempool.exists(outpoint).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 9 2019, 22:50

teamcity added a comment to D3621: Merge #10684: Remove no longer used mempool.exists(outpoint).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 9 2019, 22:40

nakihito created D3621: Merge #10684: Remove no longer used mempool.exists(outpoint).

Jul 9 2019, 22:40

teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC Gitian Diff Testing failed.

Jul 9 2019, 22:39

teamcity added a comment to D3197: Make Teamcity agent setup easier.

Build Bitcoin-ABC / Master / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Jul 9 2019, 22:39

markblundeberg updated the task description for T589: BIP157 & BIP158 backports.

Jul 9 2019, 22:19

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC6699751c2d32: Merge #14571: [tests] Test that nodes respond to getdata with notfound (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #14571: [tests] Test that nodes respond to getdata with notfound

Jul 9 2019, 22:04

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3614: Merge #14571: [tests] Test that nodes respond to getdata with notfound.

Jul 9 2019, 22:04

Fabien committed rABCc9b857a42499: Move CheckBlock() call to critical section (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).

Move CheckBlock() call to critical section

Jul 9 2019, 22:02

Fabien closed D3607: Move CheckBlock() call to critical section.

Jul 9 2019, 22:02

markblundeberg added a comment to T589: BIP157 & BIP158 backports.

Also need https://github.com/bitcoin/bitcoin/pull/15623/files

Jul 9 2019, 21:56

markblundeberg added inline comments to D3601: [schnorr functional test] remove ComparisonTestFramework dependency.

Jul 9 2019, 21:40

markblundeberg added a comment to D3613: [script_tests] add tests for pubkey encoding with strictenc + nullfail.

In D3613#85311, @deadalnix wrote:

Accepting, but this probably needs to be shuffled around based on change in the parent's diff.

Jul 9 2019, 21:34

teamcity added a comment to D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jul 9 2019, 21:16

nakihito added a comment to D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).

GetCoin() in txmempool.h was changed here: https://reviews.bitcoinabc.org/D763#change-X7xlaclCBwBo

Jul 9 2019, 21:09

teamcity added a comment to D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jul 9 2019, 21:07

nakihito created D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).

Jul 9 2019, 21:07

nakihito added a comment to D3587: [3 of 5] Move CDiskBlockPos from chain to flatfile..

In D3587#84811, @markblundeberg wrote:

Note: alternatively we could keep the split and rename diskblockpos.h to flatfilepos.h and put the ToString() implementation in a .cpp file also, or ...?

I'm not totally sure if it's worth splitting up the two, the main thing seems to have been getting it out of chain.h.

Jul 9 2019, 20:43

Nico Guiton <nico@bitframe.org> committed rABC411992b4182a: Merge #10191: [trivial] Rename unused RPC arguments 'dummy' (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #10191: [trivial] Rename unused RPC arguments 'dummy'

Jul 9 2019, 20:37

Nico Guiton <nico@bitframe.org> closed D3599: Merge #10191: [trivial] Rename unused RPC arguments 'dummy'.

Jul 9 2019, 20:37

deadalnix accepted D3613: [script_tests] add tests for pubkey encoding with strictenc + nullfail.

Accepting, but this probably needs to be shuffled around based on change in the parent's diff.

Jul 9 2019, 20:30

deadalnix accepted D3611: [qt] Add support to search the address book.

Jul 9 2019, 20:26

deadalnix accepted D3601: [schnorr functional test] remove ComparisonTestFramework dependency.