After some discussion with Fabien, we decided it wasn't urgent to get this change in without tests to accompany it (or at least be landed shortly after). https://github.com/bitcoin/bitcoin/pull/13983/ This PR and it's dependencies get us there, but will take some more time. Putting this diff on the back burner until then.

Sep 6 2019, 00:24

teamcity added a comment to D4013: Merge #13715: tests: fixes mininode's P2PConnection sending messages on closing transport.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 6 2019, 00:19

teamcity added a comment to D4012: Merge #13517: qa: Remove need to handle the network thread in tests.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Sep 6 2019, 00:19

teamcity added a comment to D4012: Merge #13517: qa: Remove need to handle the network thread in tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 00:13

teamcity added a comment to D4012: Merge #13517: qa: Remove need to handle the network thread in tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 00:12

teamcity added a comment to D4013: Merge #13715: tests: fixes mininode's P2PConnection sending messages on closing transport.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 6 2019, 00:12

jasonbcox created D4013: Merge #13715: tests: fixes mininode's P2PConnection sending messages on closing transport.

Sep 6 2019, 00:12

Harbormaster failed remote builds in B7338: Diff 11115 for D4012: Merge #13517: qa: Remove need to handle the network thread in tests!

Sep 6 2019, 00:02

Sep 5 2019

teamcity added a comment to D4012: Merge #13517: qa: Remove need to handle the network thread in tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 23:57

jasonbcox created D4012: Merge #13517: qa: Remove need to handle the network thread in tests.

Sep 5 2019, 23:57

nakihito updated the summary of D3950: Merge #12953: Deprecate accounts.

Sep 5 2019, 22:48

teamcity added a comment to D4011: Merge #13512: [qa] mininode: Expose connection state through is_connected.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 22:11

teamcity added a comment to D4011: Merge #13512: [qa] mininode: Expose connection state through is_connected.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 22:04

jasonbcox created D4011: Merge #13512: [qa] mininode: Expose connection state through is_connected.

Sep 5 2019, 22:03

teamcity added a comment to D4010: Fix incorrectly backported return statements in mininode.py.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 21:42

teamcity added a comment to D4010: Fix incorrectly backported return statements in mininode.py.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 21:35

jasonbcox created D4010: Fix incorrectly backported return statements in mininode.py.

Sep 5 2019, 21:34

teamcity added a comment to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 19:58

Fabien requested review of D4000: Increase LevelDB max_open_files unless on 32-bit Unix..

IBD was successful (w/o checkpoint). Duration was ~7h, against ~9h before the patch :)

Sep 5 2019, 19:55

teamcity added a comment to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:48

teamcity added a comment to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:47

Harbormaster failed remote builds in B7334: Diff 11108 for D4009: zmq: log outbound message high water mark when reusing socket!

Sep 5 2019, 19:44

teamcity added a comment to D4009: zmq: log outbound message high water mark when reusing socket.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Sep 5 2019, 19:44

teamcity added a comment to D4007: Update univalue subtree.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 19:29

Fabien accepted D3732: Added a script to generate chainparams intermediate files.

Sep 5 2019, 19:27

Harbormaster failed remote builds in B7335: Diff 11110 for D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments!

Sep 5 2019, 19:24

teamcity added a comment to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Sep 5 2019, 19:24

fpelliccioni committed rABC5c1f643c9f97: wallet: Catch filesystem_error and raise InitError (authored by MarcoFalke <falke.marco@gmail.com>).

wallet: Catch filesystem_error and raise InitError

Sep 5 2019, 19:20

fpelliccioni closed D3987: wallet: Catch filesystem_error and raise InitError.

Sep 5 2019, 19:20

teamcity added a comment to D4006: Merge leveldb subtree.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 19:20

nakihito added inline comments to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

Sep 5 2019, 19:20

fpelliccioni committed rABC966fa58918e3: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon… (authored by Luke Dashjr <luke-jr+git@utopios.org>).

During IBD, when doing pruning, prune 10% extra to avoid pruning again soon…

Sep 5 2019, 19:20

fpelliccioni closed D3986: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after.

Sep 5 2019, 19:20

teamcity added a comment to D4008: [rebase] threads: fix unitialized members in sched_param.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 19:19

teamcity added a comment to D4004: Bump leveldb subtree.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 19:19

nakihito updated the summary of D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

Sep 5 2019, 19:16

teamcity added a comment to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:16

teamcity added a comment to D4005: cli: Ignore libevent warnings.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 19:16

nakihito updated the diff for D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

Corrected nits, rebased off D3464, and added changes to logging().

Sep 5 2019, 19:15

teamcity added a comment to D4009: zmq: log outbound message high water mark when reusing socket.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:14

teamcity added a comment to D4009: zmq: log outbound message high water mark when reusing socket.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:12

fpelliccioni created D4009: zmq: log outbound message high water mark when reusing socket.

Sep 5 2019, 19:12

teamcity added a comment to D4007: Update univalue subtree.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:10

teamcity added a comment to D4006: Merge leveldb subtree.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:09

teamcity added a comment to D4008: [rebase] threads: fix unitialized members in sched_param.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:09

fpelliccioni created D4008: [rebase] threads: fix unitialized members in sched_param.

Sep 5 2019, 19:09

teamcity added a comment to D4007: Update univalue subtree.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:08

fpelliccioni created D4007: Update univalue subtree.

Sep 5 2019, 19:08

teamcity added a comment to D4006: Merge leveldb subtree.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:08

fpelliccioni created D4006: Merge leveldb subtree.

Sep 5 2019, 19:08

teamcity added a comment to D4005: cli: Ignore libevent warnings.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:07

fpelliccioni created D4005: cli: Ignore libevent warnings.

Sep 5 2019, 19:07

teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 19:05

teamcity added a comment to D4004: Bump leveldb subtree.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 19:05

fpelliccioni created D4004: Bump leveldb subtree.

Sep 5 2019, 19:05

teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) started.

Sep 5 2019, 19:00

teamcity added a comment to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 18:58

jasonbcox planned changes to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Sep 5 2019, 18:58

jasonbcox created D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.

Sep 5 2019, 18:58

Fabien requested changes to D4002: Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework].

Sep 5 2019, 18:10

Nico Guiton <nico@bitframe.org> committed rABCec813bc91426: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking… (authored by MarcoFalke <falke.marco@gmail.com>).

Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking…

Sep 5 2019, 18:03

Nico Guiton <nico@bitframe.org> closed D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Sep 5 2019, 18:03

Nico Guiton <nico@bitframe.org> committed rABC08e2c02735c6: Merge #11044: [wallet] Keypool topup cleanups (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #11044: [wallet] Keypool topup cleanups

Sep 5 2019, 17:41

Nico Guiton <nico@bitframe.org> closed D3998: Merge #11044: [wallet] Keypool topup cleanups.

Sep 5 2019, 17:40

teamcity added a comment to D4000: Increase LevelDB max_open_files unless on 32-bit Unix..

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) passed.

Sep 5 2019, 16:32

teamcity added a comment to D4002: Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework].

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 16:17

teamcity added a comment to D4002: Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework].

Build Bitcoin-ABC / Diffs / Diff Testing started.