Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Sep 5 2019

jasonbcox created D4002: Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework].
Sep 5 2019, 15:41
jasonbcox committed rABC23dd085f1312: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework (authored by jasonbcox).
Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework
Sep 5 2019, 15:25
jasonbcox closed D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.
Sep 5 2019, 15:24
jasonbcox committed rABC2557eb97aa72: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework (authored by jasonbcox).
Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework
Sep 5 2019, 15:24
jasonbcox closed D3995: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.
Sep 5 2019, 15:24
jasonbcox committed rABC30ad164a8285: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework (authored by jasonbcox).
Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework
Sep 5 2019, 15:23
jasonbcox closed D3991: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.
Sep 5 2019, 15:23
jasonbcox committed rABCa6e32827ea6a: Migrated abc-transaction-ordering.py off of ComparisonTestFramework (authored by jasonbcox).
Migrated abc-transaction-ordering.py off of ComparisonTestFramework
Sep 5 2019, 15:22
jasonbcox closed D3990: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.
Sep 5 2019, 15:22
teamcity added a comment to D4001: [Linter] Check the log prints are terminated with a newline.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 13:28
teamcity added a comment to D4001: [Linter] Check the log prints are terminated with a newline.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 13:21
Fabien created D4001: [Linter] Check the log prints are terminated with a newline.
Sep 5 2019, 13:21
fpelliccioni added a comment to D4000: Increase LevelDB max_open_files unless on 32-bit Unix..

Code seems good to me. Awaiting for the IBD result.

Sep 5 2019, 13:20
fpelliccioni accepted D4000: Increase LevelDB max_open_files unless on 32-bit Unix..
Sep 5 2019, 13:18
teamcity added a comment to D4000: Increase LevelDB max_open_files unless on 32-bit Unix..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 09:28
Fabien planned changes to D4000: Increase LevelDB max_open_files unless on 32-bit Unix..

Started IBD on this diff: https://build.bitcoinabc.org/viewLog.html?tab=buildLog&buildTypeId=BitcoinABC_ResourceIntensiveBuilds_BitcoinAbcIbdDiffTestingWOCheckpoints&buildId=18634
I will request for review when it ends successfully.

Sep 5 2019, 09:25
teamcity added a comment to D4000: Increase LevelDB max_open_files unless on 32-bit Unix..

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) started.

Sep 5 2019, 09:24
teamcity added a comment to D4000: Increase LevelDB max_open_files unless on 32-bit Unix..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 09:21
Fabien created D4000: Increase LevelDB max_open_files unless on 32-bit Unix..
Sep 5 2019, 09:21
teamcity added a comment to D3999: Remove extra newline that leads to linter warning.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 09:11
teamcity added a comment to D3999: Remove extra newline that leads to linter warning.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 09:03
Fabien created D3999: Remove extra newline that leads to linter warning.
Sep 5 2019, 09:03
Fabien accepted D3995: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.
Sep 5 2019, 08:57
Fabien accepted D3991: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.
Sep 5 2019, 08:55
Fabien accepted D3990: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.
Sep 5 2019, 08:52
Fabien accepted D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.
Sep 5 2019, 08:45
teamcity added a comment to D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 5 2019, 07:12
Fabien accepted D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.
Sep 5 2019, 07:01
teamcity added a comment to D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 5 2019, 06:57
Fabien requested changes to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

The changes to rpc/misc.cpp are missing.
It's not from an outdated code, but applies to the logging RPC backport that you did (stack starting from D3464). You need to rebase this diff on top of it.
The setaccount change is missing from rpcwallet.cpp (alias for setlabel).

Sep 5 2019, 06:54
Fabien accepted D3998: Merge #11044: [wallet] Keypool topup cleanups.
Sep 5 2019, 06:04

Sep 4 2019

teamcity added a comment to D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 22:16
nakihito updated the summary of D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.
Sep 4 2019, 22:09
teamcity added a comment to D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 22:08
nakihito updated the diff for D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Rebased off D3998.

Sep 4 2019, 22:08
teamcity added a comment to D3998: Merge #11044: [wallet] Keypool topup cleanups.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 22:01
teamcity added a comment to D3998: Merge #11044: [wallet] Keypool topup cleanups.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 21:54
Harbormaster failed remote builds in B7322: Diff 11090 for D3998: Merge #11044: [wallet] Keypool topup cleanups!
Sep 4 2019, 21:53
teamcity added a comment to D3998: Merge #11044: [wallet] Keypool topup cleanups.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Sep 4 2019, 21:52
teamcity added a comment to D3998: Merge #11044: [wallet] Keypool topup cleanups.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 21:50
nakihito created D3998: Merge #11044: [wallet] Keypool topup cleanups.
Sep 4 2019, 21:50
nakihito planned changes to D3950: Merge #12953: Deprecate accounts.

Nits fixed. Will rebase after D3997 is landed.

Sep 4 2019, 21:44
nakihito added a comment to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

rpc/blockchain.cpp changes were made here: D954
rpc/mining.cpp changes were excluded because we did not backport much of Core's fee code.
Changes to rpc/misc.cpp that were excluded were to outdated logging code.
signrawtransaction() was removed after being deprecated: D3978

Sep 4 2019, 21:36
teamcity added a comment to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 21:26
teamcity added a comment to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 21:17
nakihito created D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.
Sep 4 2019, 21:17
jasonbcox accepted D3986: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after.
Sep 4 2019, 20:24
jasonbcox requested changes to D3993: [CI] Refactor the build configuration by moving out tests from the build.
Sep 4 2019, 20:19
teamcity added a comment to D3993: [CI] Refactor the build configuration by moving out tests from the build.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 19:48
teamcity added a comment to D3993: [CI] Refactor the build configuration by moving out tests from the build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 19:41
Fabien updated the diff for D3993: [CI] Refactor the build configuration by moving out tests from the build.

Move to the build dir *AFTER* its creation...

Sep 4 2019, 19:40
teamcity added a comment to D3993: [CI] Refactor the build configuration by moving out tests from the build.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Sep 4 2019, 19:38
Harbormaster failed remote builds in B7319: Diff 11086 for D3993: [CI] Refactor the build configuration by moving out tests from the build!
Sep 4 2019, 19:38
teamcity added a comment to D3993: [CI] Refactor the build configuration by moving out tests from the build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 19:38
Fabien updated the diff for D3993: [CI] Refactor the build configuration by moving out tests from the build.

Remove setup.sh, now it is a function in build-configurations.sh.

Sep 4 2019, 19:38
teamcity added a comment to D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 18:35
jasonbcox requested changes to D3308: Merge #9894: remove 'label' filter for rpc command help.

I will green this once D3950 is getting close to completion. Right now, there are some missing backports so it's difficult to estimate a timeline.

Sep 4 2019, 18:31
jasonbcox requested changes to D3950: Merge #12953: Deprecate accounts.
Sep 4 2019, 18:29
teamcity added a comment to D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 18:21
jasonbcox added a revision to T669: Removing comparison test framework: D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.
Sep 4 2019, 18:21
jasonbcox created D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.
Sep 4 2019, 18:21
Nico Guiton <nico@bitframe.org> committed rABC69b14ee35aff: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13077: Add compile time checking for all cs_KeyStore runtime locking…
Sep 4 2019, 18:15
Nico Guiton <nico@bitframe.org> closed D3980: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions.
Sep 4 2019, 18:15
jasonbcox accepted D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.
Sep 4 2019, 18:10
Fabien requested review of D3992: [CI] Improve error catching and build log verbosity.

Gitian build added to the test plan and run successfully: https://build.bitcoinabc.org/viewLog.html?tab=buildLog&buildTypeId=BitcoinABC_ResourceIntensiveBuilds_NightlyBuilds_BitcoinAbcGitianDiffTesting&buildId=18612

Sep 4 2019, 16:18
teamcity added a comment to D3992: [CI] Improve error catching and build log verbosity.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Sep 4 2019, 16:17
Fabien updated the test plan for D3992: [CI] Improve error catching and build log verbosity.
Sep 4 2019, 16:13
teamcity added a comment to D3995: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 16:13
teamcity added a comment to D3992: [CI] Improve error catching and build log verbosity.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Sep 4 2019, 16:12
teamcity added a comment to D3995: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 16:06
jasonbcox added a revision to T669: Removing comparison test framework: D3995: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.
Sep 4 2019, 16:06
jasonbcox created D3995: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.
Sep 4 2019, 16:06
jasonbcox requested changes to D3992: [CI] Improve error catching and build log verbosity.

set -eux is a good idea. I'm not yet convinced on set -o pipefail, though I think it's probably best to have it on by default rather than not.

Sep 4 2019, 16:01
teamcity added a comment to D3994: [CI] Workaround ubsan failure in functional tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 15:59
teamcity added a comment to D3994: [CI] Workaround ubsan failure in functional tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 15:58
Fabien requested changes to D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Don't fix it if it ain't broken: https://github.com/bitcoin/bitcoin/pull/11044/files

Sep 4 2019, 15:55
Fabien accepted D3980: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions.
Sep 4 2019, 15:47
teamcity added a comment to D3994: [CI] Workaround ubsan failure in functional tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 15:45
teamcity added a comment to D3994: [CI] Workaround ubsan failure in functional tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 15:44
teamcity added a comment to D3994: [CI] Workaround ubsan failure in functional tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 15:42
Fabien created D3994: [CI] Workaround ubsan failure in functional tests.
Sep 4 2019, 15:41
teamcity added a comment to D3993: [CI] Refactor the build configuration by moving out tests from the build.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 15:40
Fabien committed rABC8f5f90aa1296: Add missing override keyword to DummySignatureCreator::CreateSig() (authored by Fabien).
Add missing override keyword to DummySignatureCreator::CreateSig()
Sep 4 2019, 15:36
Fabien closed D3985: Add missing override keyword to DummySignatureCreator::CreateSig().
Sep 4 2019, 15:36
teamcity added a comment to D3993: [CI] Refactor the build configuration by moving out tests from the build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 15:33
Fabien created D3993: [CI] Refactor the build configuration by moving out tests from the build.
Sep 4 2019, 15:33
teamcity added a comment to D3992: [CI] Improve error catching and build log verbosity.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 15:09
teamcity added a comment to D3992: [CI] Improve error catching and build log verbosity.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 15:02
Fabien created D3992: [CI] Improve error catching and build log verbosity.
Sep 4 2019, 15:02
teamcity added a comment to D3991: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 14:58
teamcity added a comment to D3991: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 14:51
jasonbcox added a revision to T669: Removing comparison test framework: D3991: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.
Sep 4 2019, 14:51
jasonbcox created D3991: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.
Sep 4 2019, 14:51
teamcity added a comment to D3990: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 4 2019, 14:50
teamcity added a comment to D3990: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Sep 4 2019, 14:39
jasonbcox added a revision to T669: Removing comparison test framework: D3990: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.
Sep 4 2019, 14:39
jasonbcox created D3990: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.
Sep 4 2019, 14:39
deadalnix accepted D3987: wallet: Catch filesystem_error and raise InitError.
Sep 4 2019, 14:11

Sep 3 2019

teamcity added a comment to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 3 2019, 20:02
teamcity added a comment to D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Sep 3 2019, 19:55
First
Prev
Next