Page MenuHomePhabricator
Feed All Stories

Nov 29 2019

deadalnix requested changes to D4584: [CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions.

Considering every single assignation is done to the parent_scope, you know this should have been a macro and not a function.

Nov 29 2019, 16:20
teamcity added a comment to D4583: Remove unnecessary const_cast.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 16:17
teamcity added a comment to D4584: [CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 16:15
Fabien created D4584: [CMAKE] Fix scope issue in the remove_<lang>_compiler_flags() functions.
Nov 29 2019, 16:15
teamcity added a comment to D4583: Remove unnecessary const_cast.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 16:07
deadalnix created D4583: Remove unnecessary const_cast.
Nov 29 2019, 16:07
markblundeberg updated the test plan for D4577: remove NULLDUMMY.
Nov 29 2019, 15:57
teamcity added a comment to D4582: Move pindexFinalized in CChainState.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 15:33
teamcity added a comment to D4581: Rationalize lock anotation in validation code.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 15:24
teamcity added a comment to D4582: Move pindexFinalized in CChainState.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 15:15
deadalnix created D4582: Move pindexFinalized in CChainState.
Nov 29 2019, 15:15
teamcity added a comment to D4581: Rationalize lock anotation in validation code.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 15:11
deadalnix created D4581: Rationalize lock anotation in validation code.
Nov 29 2019, 15:11
Harbormaster failed remote builds in B8332: Diff 14500 for D4580: Add fuzz testing for BlockTransactions and BlockTransactionsRequest!
Nov 29 2019, 14:21
teamcity added a comment to D4580: Add fuzz testing for BlockTransactions and BlockTransactionsRequest.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Nov 29 2019, 14:20
Fabien committed rABC34dff0361d75: Add fuzz testing for BlockTransactions and BlockTransactionsRequest (authored by practicalswift <practicalswift@users.noreply.github.com>).
Add fuzz testing for BlockTransactions and BlockTransactionsRequest
Nov 29 2019, 14:19
Fabien closed D4580: Add fuzz testing for BlockTransactions and BlockTransactionsRequest.
Nov 29 2019, 14:19
deadalnix accepted D4580: Add fuzz testing for BlockTransactions and BlockTransactionsRequest.
Nov 29 2019, 14:18
Fabien committed rABC6cec48af5cc3: [test] Speed up fuzzing by ~200x when using afl-fuzz (authored by practicalswift <practicalswift@users.noreply.github.com>).
[test] Speed up fuzzing by ~200x when using afl-fuzz
Nov 29 2019, 14:18
Fabien closed D4578: [test] Speed up fuzzing by ~200x when using afl-fuzz.
Nov 29 2019, 14:17
Fabien committed rABCbdfa82d939e6: [CMAKE] Build test_bitcoin_fuzzy (authored by Fabien).
[CMAKE] Build test_bitcoin_fuzzy
Nov 29 2019, 14:17
Fabien closed D4579: [CMAKE] Build test_bitcoin_fuzzy.
Nov 29 2019, 14:16
teamcity added a comment to D4580: Add fuzz testing for BlockTransactions and BlockTransactionsRequest.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 14:14
Fabien created D4580: Add fuzz testing for BlockTransactions and BlockTransactionsRequest.
Nov 29 2019, 14:14
deadalnix requested changes to D4577: remove NULLDUMMY.

Please Run IBD, otherwise, LGTM.

Nov 29 2019, 14:12
deadalnix updated the test plan for D4577: remove NULLDUMMY.
Nov 29 2019, 14:11
deadalnix accepted D4579: [CMAKE] Build test_bitcoin_fuzzy.
Nov 29 2019, 14:07
deadalnix accepted D4578: [test] Speed up fuzzing by ~200x when using afl-fuzz.
Nov 29 2019, 14:06
teamcity added a comment to D4579: [CMAKE] Build test_bitcoin_fuzzy.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 13:42
teamcity added a comment to D4579: [CMAKE] Build test_bitcoin_fuzzy.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 13:32
Fabien created D4579: [CMAKE] Build test_bitcoin_fuzzy.
Nov 29 2019, 13:32
teamcity added a comment to D4578: [test] Speed up fuzzing by ~200x when using afl-fuzz.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 13:31
teamcity added a comment to D4578: [test] Speed up fuzzing by ~200x when using afl-fuzz.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 13:21
Fabien created D4578: [test] Speed up fuzzing by ~200x when using afl-fuzz.
Nov 29 2019, 13:21
Mengerian added a comment to D4577: remove NULLDUMMY.

Great to see this!

Nov 29 2019, 05:25
teamcity added a comment to D4577: remove NULLDUMMY.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 29 2019, 04:57
teamcity added a comment to D4577: remove NULLDUMMY.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 04:46
markblundeberg updated the diff for D4577: remove NULLDUMMY.

remove spurious newline and request teamcity rerun

Nov 29 2019, 04:46
Harbormaster failed remote builds in B8328: Diff 14496 for D4577: remove NULLDUMMY!
Nov 29 2019, 04:23
teamcity added a comment to D4577: remove NULLDUMMY.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Nov 29 2019, 04:23
markblundeberg added inline comments to D4577: remove NULLDUMMY.
Nov 29 2019, 04:16
teamcity added a comment to D4577: remove NULLDUMMY.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 29 2019, 04:13
markblundeberg created D4577: remove NULLDUMMY.
Nov 29 2019, 04:13
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC7a0f207cdf2f: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
drop 'check3' upgrade-conditional-script-failure for Schnorr multisig
Nov 29 2019, 03:21
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D4576: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig.
Nov 29 2019, 03:21

Nov 28 2019

Mengerian added a subtask for T653: Clean up past upgrades: T703: clean up schnorr activations.
Nov 28 2019, 22:21
Mengerian added a parent task for T703: clean up schnorr activations: T653: Clean up past upgrades.
Nov 28 2019, 22:21
teamcity added a comment to D4576: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 28 2019, 22:00
deadalnix committed rABCf5ffef56ba54: Nit in net_processing.cpp (authored by deadalnix).
Nit in net_processing.cpp
Nov 28 2019, 21:54
deadalnix closed D4575: Nit in net_processing.cpp.
Nov 28 2019, 21:54
deadalnix accepted D4576: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig.
Nov 28 2019, 21:53
markblundeberg added a comment to T703: clean up schnorr activations.

TODO:

  • add SCHNORR_MULTISIG to mandatory flags
  • remove NULLDUMMY completely from codebase
Nov 28 2019, 21:52
markblundeberg added a revision to T703: clean up schnorr activations: D4576: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig.
Nov 28 2019, 21:51
markblundeberg added a task to D4576: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig: T703: clean up schnorr activations.
Nov 28 2019, 21:51
markblundeberg triaged T703: clean up schnorr activations as Normal priority.
Nov 28 2019, 21:51
markblundeberg closed T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics), a subtask of T526: Schnorr-ifying, as Resolved.
Nov 28 2019, 21:49
markblundeberg closed T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics) as Resolved.
Nov 28 2019, 21:49
teamcity added a comment to D4576: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 28 2019, 21:49
markblundeberg created D4576: drop 'check3' upgrade-conditional-script-failure for Schnorr multisig.
Nov 28 2019, 21:49
Fabien accepted D4575: Nit in net_processing.cpp.
Nov 28 2019, 20:13
deadalnix retitled D4575: Nit in net_processing.cpp from Nit in ne_processing.cpp to Nit in net_processing.cpp.
Nov 28 2019, 19:40
teamcity added a comment to D4575: Nit in net_processing.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 28 2019, 18:23
teamcity added a comment to D4575: Nit in net_processing.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 28 2019, 18:09
teamcity added a comment to D4575: Nit in net_processing.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 28 2019, 18:02
deadalnix updated the diff for D4575: Nit in net_processing.cpp.

rebase

Nov 28 2019, 17:56
teamcity added a comment to D4574: Backport PR14897, PR15834 and PR16196.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 28 2019, 17:55
deadalnix committed rABC8d1a1da709dc: Backport PR14897, PR15834 and PR16196 (authored by Gleb Naumenko <naumenko.gs@gmail.com>).
Backport PR14897, PR15834 and PR16196
Nov 28 2019, 17:53
deadalnix closed D4574: Backport PR14897, PR15834 and PR16196.
Nov 28 2019, 17:53
teamcity added a comment to D4575: Nit in net_processing.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 28 2019, 17:50
deadalnix created D4575: Nit in net_processing.cpp.
Nov 28 2019, 17:49
Fabien accepted D4574: Backport PR14897, PR15834 and PR16196.
Nov 28 2019, 17:41
teamcity added a comment to D4574: Backport PR14897, PR15834 and PR16196.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 28 2019, 17:40
deadalnix updated the diff for D4574: Backport PR14897, PR15834 and PR16196.

Address various comments

Nov 28 2019, 17:40
jasonbcox closed T699: Backport 15149, a subtask of T702: Backport 15210, as Resolved.
Nov 28 2019, 16:07
jasonbcox closed T699: Backport 15149, a subtask of T697: Backport 15101, as Resolved.
Nov 28 2019, 16:07
jasonbcox closed T699: Backport 15149 as Resolved.
Nov 28 2019, 16:07
jasonbcox committed rABC0e28ecba8ec1: Merge #15149: gui: Show current wallet name in window title (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #15149: gui: Show current wallet name in window title
Nov 28 2019, 16:07
jasonbcox closed D4568: Merge #15149: gui: Show current wallet name in window title.
Nov 28 2019, 16:07
Fabien requested changes to D4574: Backport PR14897, PR15834 and PR16196.
Nov 28 2019, 15:28
Fabien committed rABC24a8f30646e2: Update timings.json (authored by Fabien).
Update timings.json
Nov 28 2019, 14:24
Fabien closed D4573: Update timings.json.
Nov 28 2019, 14:24
teamcity added a comment to D4574: Backport PR14897, PR15834 and PR16196.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 28 2019, 14:23
deadalnix abandoned D4513: Change in transaction pull scheduling to prevent InvBlock-related attacks.

Superseeded by D4574

Nov 28 2019, 14:06
teamcity added a comment to D4574: Backport PR14897, PR15834 and PR16196.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 28 2019, 14:06
deadalnix created D4574: Backport PR14897, PR15834 and PR16196.
Nov 28 2019, 14:05
deadalnix requested changes to D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).

Back on the queue.

Nov 28 2019, 13:43
deadalnix accepted D4573: Update timings.json.
Nov 28 2019, 13:28
deadalnix committed rABC98fa98d6ad64: Various nits in net_processing.cpp (authored by deadalnix).
Various nits in net_processing.cpp
Nov 28 2019, 13:26
deadalnix closed D4572: Various nits in net_processing.cpp.
Nov 28 2019, 13:26
deadalnix committed rABC96a51590b6c6: p2p: Clarify control flow in ProcessMessage() (authored by MarcoFalke <falke.marco@gmail.com>).
p2p: Clarify control flow in ProcessMessage()
Nov 28 2019, 13:25
deadalnix closed D4571: p2p: Clarify control flow in ProcessMessage().
Nov 28 2019, 13:25
teamcity added a comment to D4573: Update timings.json.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 28 2019, 09:09
teamcity added a comment to D4573: Update timings.json.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 28 2019, 08:59
Fabien created D4573: Update timings.json.
Nov 28 2019, 08:59
Fabien accepted D4572: Various nits in net_processing.cpp.
Nov 28 2019, 07:16
Fabien accepted D4571: p2p: Clarify control flow in ProcessMessage().
Nov 28 2019, 07:15
Fabien updated the summary of D4571: p2p: Clarify control flow in ProcessMessage().
Nov 28 2019, 07:04
Fabien requested changes to D4550: crypto: Remove unused AES-128 code.

Clearing my queue

Nov 28 2019, 07:03
Fabien accepted D4568: Merge #15149: gui: Show current wallet name in window title.
Nov 28 2019, 06:34
teamcity added a comment to D4572: Various nits in net_processing.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 28 2019, 00:44