Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 22 2020
May 22 2020
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.
nakihito updated the diff for D6204: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}.
Fixed nits.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.
Fixed overwrite.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
deadalnix requested changes to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
deadalnix committed rABCa299d8aa29fe: rpc: Actually throw help when passed invalid number of params (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Actually throw help when passed invalid number of params
deadalnix committed rABC20bb047dd3a5: RPCHelpMan: Check default values are given at compile-time (authored by MarcoFalke <falke.marco@gmail.com>).
RPCHelpMan: Check default values are given at compile-time
Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.
majcosta added inline comments to D6220: rpc: Actually throw help when passed invalid number of params.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.
Fix OMITTED
deadalnix added inline comments to D6064: RPCHelpMan: Check default values are given at compile-time.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
teamcity updated the summary of D6220: rpc: Actually throw help when passed invalid number of params.
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.
majcosta updated the diff for D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
addressed comments, added more explicit names, replaced a constructor initialization with list initialization to guard against narrowind conversions, made a TxId function parameter const
Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.
deadalnix requested changes to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.
Rebase and various manual fixups
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.
teamcity added a comment to D6219: [refactor] change orphan txs std::map member to use TxId instead of uint256.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.
deadalnix committed rABC5a5256baa9ab: rpc: Document default values for optional arguments (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Document default values for optional arguments
Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.
Address comments
Fabien requested changes to D6204: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}.
Only nits
Fabien committed rABCfce972a3a0b9: random: mark RandAddPeriodic and SeedPeriodic as noexcept (authored by fanquake <fanquake@gmail.com>).
random: mark RandAddPeriodic and SeedPeriodic as noexcept
Fabien committed rABCfcd7977a3ece: Report amount of data gathered from environment (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Report amount of data gathered from environment
Fabien committed rABC5ff89a0754c2: Use thread-safe atomic in perfmon seeder (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Use thread-safe atomic in perfmon seeder
Fabien committed rABC88aae1e03756: Run background seeding periodically instead of unpredictably (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Run background seeding periodically instead of unpredictably
Fabien committed rABC05debbcdd0a2: Add information gathered through getauxval() (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Add information gathered through getauxval()
Fabien committed rABC192d4bb47c3f: Feed CPUID data into RNG (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Feed CPUID data into RNG
deadalnix committed rABCdfee6a88179c: [rpc] util: add deriveaddresses method (authored by Sjors Provoost <sjors@sprovoost.nl>).
[rpc] util: add deriveaddresses method
deadalnix requested changes to D6216: [backport#15644] Simplify orphan processing in preparation for interruptibility.
There is clearly some txid confusion that needs to be cleared before this can proceed.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.
teamcity added a comment to D6217: [backport#15644] [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.
Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.