Page MenuHomePhabricator
Feed All Stories

Oct 13 2020

teamcity updated the summary of D7912: Merge #16470: test: Fail early on disconnect in mininode.wait_for_*.
Oct 13 2020, 23:23
jasonbcox requested review of D7912: Merge #16470: test: Fail early on disconnect in mininode.wait_for_*.
Oct 13 2020, 23:22
jasonbcox updated the summary of D7468: [land-bot] Add a sanity rebase after running smoke tests.
Oct 13 2020, 22:20
jasonbcox updated the diff for D7468: [land-bot] Add a sanity rebase after running smoke tests.

Make it more robust and add tests (now depends on D7911)

Oct 13 2020, 22:19
jasonbcox requested review of D7911: [land-bot] Add basic test coverage.
Oct 13 2020, 22:07
deadalnix accepted D7907: Support serialization of std::vector<bool>.
Oct 13 2020, 21:45
jasonbcox closed D7908: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase.
Oct 13 2020, 21:26
jasonbcox committed rABC8c361009afdd: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase
Oct 13 2020, 21:26
Fabien closed D7905: [DOC] Update gitian instructions with the new OSX SDK version.
Oct 13 2020, 17:58
Fabien committed rABC6c6a2852b03b: [DOC] Update gitian instructions with the new OSX SDK version (authored by Fabien).
[DOC] Update gitian instructions with the new OSX SDK version
Oct 13 2020, 17:58
PiRK closed D7909: test: add executable flag for wallet_watchonly.py.
Oct 13 2020, 17:55
PiRK committed rABCb1e4ccabcb48: test: add executable flag for wallet_watchonly.py (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: add executable flag for wallet_watchonly.py
Oct 13 2020, 17:55
PiRK requested review of D7907: Support serialization of std::vector<bool>.

If there is a PR description, I assume there is a PR somewhere.

Oct 13 2020, 16:59
PiRK updated the summary of D7907: Support serialization of std::vector<bool>.
Oct 13 2020, 16:59
deadalnix requested changes to D7910: Avoid using mutable default parameter values.

When you add a linter, make sure it runs with arc lint. @Fabien can help you with this.

Oct 13 2020, 16:56
PiRK updated the diff for D7910: Avoid using mutable default parameter values.

remove mutable default parameter in abc-transaction-ordering.py

Oct 13 2020, 16:51
teamcity updated the summary of D7910: Avoid using mutable default parameter values.
Oct 13 2020, 16:50
PiRK requested review of D7910: Avoid using mutable default parameter values.
Oct 13 2020, 16:50
deadalnix accepted D7909: test: add executable flag for wallet_watchonly.py.
Oct 13 2020, 16:45
deadalnix requested changes to D7907: Support serialization of std::vector<bool>.

If there is a PR description, I assume there is a PR somewhere.

Oct 13 2020, 16:44
deadalnix accepted D7908: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase.
Oct 13 2020, 16:43
teamcity updated the summary of D7909: test: add executable flag for wallet_watchonly.py.
Oct 13 2020, 16:34
PiRK requested review of D7909: test: add executable flag for wallet_watchonly.py.
Oct 13 2020, 16:34
teamcity added a comment to D7908: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase.
Oct 13 2020, 16:30
teamcity updated the summary of D7908: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase.
Oct 13 2020, 16:27
jasonbcox requested review of D7908: Merge #18487: rpc: Fix rpcRunLater race in walletpassphrase.
Oct 13 2020, 16:26
teamcity updated the summary of D7907: Support serialization of std::vector<bool>.
Oct 13 2020, 16:14
PiRK requested review of D7907: Support serialization of std::vector<bool>.
Oct 13 2020, 16:14
deadalnix accepted D7904: gui: Ensure tx send error highlight is visible.
Oct 13 2020, 15:42
deadalnix accepted D7905: [DOC] Update gitian instructions with the new OSX SDK version.
Oct 13 2020, 15:41
Fabien requested review of D7905: [DOC] Update gitian instructions with the new OSX SDK version.
Oct 13 2020, 15:10
PiRK closed D7902: [backport#16363] test: Add test for BIP30 duplicate tx.
Oct 13 2020, 15:06
PiRK committed rABC2e27aa637254: [backport#16363] test: Add test for BIP30 duplicate tx (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16363] test: Add test for BIP30 duplicate tx
Oct 13 2020, 15:06
PiRK closed D7901: [backport#16363] test: Properly serialize BIP34 coinbase height.
Oct 13 2020, 14:58
PiRK committed rABC8a6204742c0c: [backport#16363] test: Properly serialize BIP34 coinbase height (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16363] test: Properly serialize BIP34 coinbase height
Oct 13 2020, 14:58
teamcity updated the summary of D7904: gui: Ensure tx send error highlight is visible.
Oct 13 2020, 14:57
PiRK requested review of D7904: gui: Ensure tx send error highlight is visible.
Oct 13 2020, 14:56
deadalnix accepted D7902: [backport#16363] test: Add test for BIP30 duplicate tx.
Oct 13 2020, 14:18
deadalnix accepted D7901: [backport#16363] test: Properly serialize BIP34 coinbase height.
Oct 13 2020, 14:14
PiRK closed D7900: [backport#15801] GUI: Set the range of pruning size before loading its value.
Oct 13 2020, 14:01
PiRK committed rABC654a805e961e: [backport#15801] GUI: Set the range of pruning size before loading its value (authored by Luke Dashjr <luke-jr+git@utopios.org>).
[backport#15801] GUI: Set the range of pruning size before loading its value
Oct 13 2020, 14:00
PiRK closed D7903: doc: Fix typos in COPYRIGHT.
Oct 13 2020, 13:53
PiRK committed rABCbc053489c59e: doc: Fix typos in COPYRIGHT (authored by Chuf <42591821+gapeman@users.noreply.github.com>).
doc: Fix typos in COPYRIGHT
Oct 13 2020, 13:53
PiRK requested review of D7902: [backport#16363] test: Add test for BIP30 duplicate tx.

Link to the commit added to revision.

Oct 13 2020, 13:51
PiRK requested review of D7901: [backport#16363] test: Properly serialize BIP34 coinbase height.

Link to the commit added to revision.

Oct 13 2020, 13:51
PiRK updated the summary of D7901: [backport#16363] test: Properly serialize BIP34 coinbase height.
Oct 13 2020, 13:49
PiRK updated the summary of D7902: [backport#16363] test: Add test for BIP30 duplicate tx.
Oct 13 2020, 13:49
deadalnix accepted D7900: [backport#15801] GUI: Set the range of pruning size before loading its value.
Oct 13 2020, 13:35
deadalnix requested changes to D7901: [backport#16363] test: Properly serialize BIP34 coinbase height.

Please link to the commit.

Oct 13 2020, 13:33
deadalnix requested changes to D7902: [backport#16363] test: Add test for BIP30 duplicate tx.

Provide a link to the commit.

Oct 13 2020, 13:32
deadalnix accepted D7903: doc: Fix typos in COPYRIGHT.
Oct 13 2020, 13:31
teamcity updated the summary of D7903: doc: Fix typos in COPYRIGHT.
Oct 13 2020, 13:10
PiRK requested review of D7903: doc: Fix typos in COPYRIGHT.
Oct 13 2020, 13:10
PiRK added inline comments to D7804: [backport#15024] Allow specific private keys to be derived from descriptor.
Oct 13 2020, 12:22
stephenjones created T1110: 123.hp.com/setup : HP Printer Setup | 123.hp.com.
Oct 13 2020, 11:15
stephenjones created T1109: aol mail, aol, aol news, aol mail login,.
Oct 13 2020, 11:14
stephenjones created T1108: Mcafee.com/Activate : Enter Product Key | McAfee Activate.
Oct 13 2020, 11:14
stephenjones triaged T1107: Rand Mcnally Dock Update, rand mcnally dock software update, rand mcnally tnd dock update, rand mcnally, rand mcnally dock as Normal priority.
Oct 13 2020, 11:13
stephenjones updated the task description for T1106: www. office.com/setup , Office.com/setup , office setup uk , Office Setup , office.com/setup login.
Oct 13 2020, 11:13
stephenjones triaged T1106: www. office.com/setup , Office.com/setup , office setup uk , Office Setup , office.com/setup login as Normal priority.
Oct 13 2020, 11:12
stephenjones triaged T1105: Garmin Express - Garmin Express Update | Garmin.com/express as Normal priority.
Oct 13 2020, 11:11
stephenjones triaged T1104: Magellan GPS Update – Magellan GPS Map Update | Magellan Update as Normal priority.
Oct 13 2020, 11:09
stephenjones triaged T1103: Mywifiext.net Login / setup | Mywifiext.local | Wifi Range Extender , Mywifiext.net Login Mywifiext.net, as High priority.
Oct 13 2020, 11:08
PiRK updated the summary of D7902: [backport#16363] test: Add test for BIP30 duplicate tx.
Oct 13 2020, 10:58
PiRK retitled D7902: [backport#16363] test: Add test for BIP30 duplicate tx from test: Add test for BIP30 duplicate tx to [backport#16363] test: Add test for BIP30 duplicate tx.
Oct 13 2020, 10:56
teamcity updated the summary of D7902: [backport#16363] test: Add test for BIP30 duplicate tx.
Oct 13 2020, 10:55
PiRK requested review of D7902: [backport#16363] test: Add test for BIP30 duplicate tx.
Oct 13 2020, 10:55
PiRK updated the summary of D7901: [backport#16363] test: Properly serialize BIP34 coinbase height.
Oct 13 2020, 09:48
teamcity updated the summary of D7901: [backport#16363] test: Properly serialize BIP34 coinbase height.
Oct 13 2020, 09:43
PiRK requested review of D7901: [backport#16363] test: Properly serialize BIP34 coinbase height.
Oct 13 2020, 09:43
teamcity updated the summary of D7900: [backport#15801] GUI: Set the range of pruning size before loading its value.
Oct 13 2020, 08:44
PiRK requested review of D7900: [backport#15801] GUI: Set the range of pruning size before loading its value.
Oct 13 2020, 08:44
PiRK closed D7895: qt: Fix Window -> Minimize menu item on linux.
Oct 13 2020, 08:26
PiRK committed rABC0e60c8d5b7c9: qt: Fix Window -> Minimize menu item on linux (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
qt: Fix Window -> Minimize menu item on linux
Oct 13 2020, 08:26
PiRK abandoned D7782: Correct units for "-dbcache" and "-prune" and upper prune limit.
Oct 13 2020, 08:25
PiRK added a comment to D7782: Correct units for "-dbcache" and "-prune" and upper prune limit.

PR15163 has been backported separately in D7896, so I will just do PR15801 on its own.

Oct 13 2020, 08:25
PiRK closed D7894: [Qt] Restore < Qt5.6 compatibility for addAction.
Oct 13 2020, 08:20
PiRK committed rABCb01ba2ed250c: [Qt] Restore < Qt5.6 compatibility for addAction (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[Qt] Restore < Qt5.6 compatibility for addAction
Oct 13 2020, 08:20
payday-loans created T1102: Payday Loans Nationwide USA.
Oct 13 2020, 08:20
payday-loans updated payday-loans.
Oct 13 2020, 08:16
Fabien accepted D7894: [Qt] Restore < Qt5.6 compatibility for addAction.

@jasonbcox It is not needed anymore but it doesn't hurt either, so better have less merge conflicts for future backports

Oct 13 2020, 06:10
jasonbcox planned changes to D7899: Test patch; please ignore.
Oct 13 2020, 00:04
jasonbcox requested review of D7899: Test patch; please ignore.
Oct 13 2020, 00:04

Oct 12 2020

majcosta abandoned D7897: [cleanup] Remove ranged for loops over OUTPUT_TYPES from PR17261.

alright

Oct 12 2020, 23:54
jasonbcox requested changes to D7897: [cleanup] Remove ranged for loops over OUTPUT_TYPES from PR17261.

While OUTPUT_TYPES is not itself useful, this patch is only going to induce merge conflicts. This trade-off does not seem worth it since it does not get rid of a substantial amount of code.

Oct 12 2020, 23:47
majcosta updated the diff for D7897: [cleanup] Remove ranged for loops over OUTPUT_TYPES from PR17261.

rebase

Oct 12 2020, 23:08
jasonbcox closed D7829: Bump version to 0.22.5.
Oct 12 2020, 23:00
jasonbcox committed rABC943fb252a21e: Bump version to 0.22.5 (authored by jasonbcox).
Bump version to 0.22.5
Oct 12 2020, 23:00
majcosta closed D7896: [backport#15163] Correct units for "-dbcache" and "-prune".
Oct 12 2020, 22:26
majcosta committed rABCb94d4864933e: [backport#15163] Correct units for "-dbcache" and "-prune" (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#15163] Correct units for "-dbcache" and "-prune"
Oct 12 2020, 22:26
jasonbcox accepted D7896: [backport#15163] Correct units for "-dbcache" and "-prune".
Oct 12 2020, 22:23
jasonbcox added a comment to D7894: [Qt] Restore < Qt5.6 compatibility for addAction.

Is this change necessary given D7893 ?

Oct 12 2020, 22:15
jasonbcox accepted D7895: qt: Fix Window -> Minimize menu item on linux.
Oct 12 2020, 22:15
majcosta updated the summary of D7897: [cleanup] Remove ranged for loops over OUTPUT_TYPES from PR17261.
Oct 12 2020, 21:16
teamcity added a comment to D7897: [cleanup] Remove ranged for loops over OUTPUT_TYPES from PR17261.
Oct 12 2020, 20:56
majcosta requested review of D7897: [cleanup] Remove ranged for loops over OUTPUT_TYPES from PR17261.
Oct 12 2020, 20:44
teamcity updated the summary of D7896: [backport#15163] Correct units for "-dbcache" and "-prune".
Oct 12 2020, 19:50
majcosta requested review of D7896: [backport#15163] Correct units for "-dbcache" and "-prune".
Oct 12 2020, 19:49
PiRK updated the summary of D7895: qt: Fix Window -> Minimize menu item on linux.
Oct 12 2020, 19:29
PiRK closed D7889: wallet: Recognize -disablewallet option early.
Oct 12 2020, 19:26