Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Oct 23 2019

deadalnix created D4288: Refactor transaction creation and transaction funding logic.
Oct 23 2019, 17:44
Nico Guiton <nico@bitframe.org> committed rABC606edea78645: Merge #13043: [qt] OptionsDialog: add prune setting (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13043: [qt] OptionsDialog: add prune setting
Oct 23 2019, 17:41
Nico Guiton <nico@bitframe.org> closed D4271: Merge #13043: [qt] OptionsDialog: add prune setting.
Oct 23 2019, 17:41
teamcity added a comment to D4287: Added build-werror config to error on build warnings.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 17:37
jasonbcox created D4287: Added build-werror config to error on build warnings.
Oct 23 2019, 17:37
jasonbcox accepted D4274: [CMAKE] Create a windows installer.

Tested the installer/uninstaller on a Win 10 (64bit) machine.

Oct 23 2019, 17:29
teamcity added a comment to D4286: Methods for interacting with PSBT structs.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 23 2019, 17:06
teamcity added a comment to D4285: Add pubkeys and whether input was witness to SignatureData.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 23 2019, 17:02
teamcity added a comment to D4286: Methods for interacting with PSBT structs.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 16:55
deadalnix created D4286: Methods for interacting with PSBT structs.
Oct 23 2019, 16:55
teamcity added a comment to D4258: Implement PSBT Structures and un/serialization methods per BIP 174.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 23 2019, 16:51
deadalnix updated the summary of D4285: Add pubkeys and whether input was witness to SignatureData.
Oct 23 2019, 16:48
teamcity added a comment to D4285: Add pubkeys and whether input was witness to SignatureData.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 16:46
deadalnix created D4285: Add pubkeys and whether input was witness to SignatureData.
Oct 23 2019, 16:46
teamcity added a comment to D4258: Implement PSBT Structures and un/serialization methods per BIP 174.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 16:36
deadalnix updated the diff for D4258: Implement PSBT Structures and un/serialization methods per BIP 174.

Rebase, ping?

Oct 23 2019, 16:36
teamcity added a comment to D4234: bench: Benchmark MempoolToJSON.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 23 2019, 16:32
teamcity added a comment to D4234: bench: Benchmark MempoolToJSON.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 16:19
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fixes wrong rebase

Oct 23 2019, 16:19
deadalnix accepted D4274: [CMAKE] Create a windows installer.

I trust this works, because I have no way èl check.

Oct 23 2019, 16:11
deadalnix accepted D4284: [CMAKE] Move package name and copyright to the top level.
Oct 23 2019, 16:10
teamcity added a comment to D4234: bench: Benchmark MempoolToJSON.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 23 2019, 16:10
teamcity added a comment to D4234: bench: Benchmark MempoolToJSON.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 15:56
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

rebased from master

Oct 23 2019, 15:56
Fabien committed rABC71c0a7d5285c: Fix -Wrange-loop-analysis warnings (authored by Fabien).
Fix -Wrange-loop-analysis warnings
Oct 23 2019, 15:18
Fabien closed D4283: Fix -Wrange-loop-analysis warnings.
Oct 23 2019, 15:18
Fabien committed rABCdf29943217b8: Fix -Wthread-safety-analysis warnings (authored by Fabien).
Fix -Wthread-safety-analysis warnings
Oct 23 2019, 15:17
Fabien closed D4282: Fix -Wthread-safety-analysis warnings.
Oct 23 2019, 15:17
deadalnix accepted D4283: Fix -Wrange-loop-analysis warnings.
Oct 23 2019, 15:15
deadalnix accepted D4282: Fix -Wthread-safety-analysis warnings.
Oct 23 2019, 15:15
fpelliccioni updated the test plan for D4186: refactor: Avoid locking tx pool cs thrice.
Oct 23 2019, 14:43
fpelliccioni updated the test plan for D4186: refactor: Avoid locking tx pool cs thrice.
Oct 23 2019, 14:43
fpelliccioni updated the test plan for D4186: refactor: Avoid locking tx pool cs thrice.
Oct 23 2019, 14:43
teamcity added a comment to D4274: [CMAKE] Create a windows installer.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 23 2019, 12:18
teamcity added a comment to D4284: [CMAKE] Move package name and copyright to the top level.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 23 2019, 12:11
teamcity added a comment to D4274: [CMAKE] Create a windows installer.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 12:09
Fabien updated the summary of D4274: [CMAKE] Create a windows installer.
Oct 23 2019, 12:09
Fabien updated the diff for D4274: [CMAKE] Create a windows installer.

Rebase on top of D4284.

Oct 23 2019, 12:09
teamcity added a comment to D4284: [CMAKE] Move package name and copyright to the top level.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 23 2019, 11:59
teamcity added a comment to D4284: [CMAKE] Move package name and copyright to the top level.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 11:56
Fabien updated the diff for D4284: [CMAKE] Move package name and copyright to the top level.

Update package vendor to match copyright holder.

Oct 23 2019, 11:56
teamcity added a comment to D4284: [CMAKE] Move package name and copyright to the top level.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 11:50
Fabien created D4284: [CMAKE] Move package name and copyright to the top level.
Oct 23 2019, 11:50
Fabien accepted D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.
Oct 23 2019, 10:49
teamcity added a comment to D4283: Fix -Wrange-loop-analysis warnings.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 23 2019, 10:17
teamcity added a comment to D4283: Fix -Wrange-loop-analysis warnings.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 10:08
teamcity added a comment to D4282: Fix -Wthread-safety-analysis warnings.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 23 2019, 10:08
Fabien created D4283: Fix -Wrange-loop-analysis warnings.
Oct 23 2019, 10:08
teamcity added a comment to D4282: Fix -Wthread-safety-analysis warnings.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 09:59
Fabien created D4282: Fix -Wthread-safety-analysis warnings.
Oct 23 2019, 09:59
Fabien committed rABCebf78761756f: [CMAKE] Use CPack to build source packages (authored by Fabien).
[CMAKE] Use CPack to build source packages
Oct 23 2019, 09:14
Fabien closed D4273: [CMAKE] Use CPack to build source packages.
Oct 23 2019, 09:14
Fabien committed rABC5928cdaa5b2c: [CMAKE] Use CPack to build packages (authored by Fabien).
[CMAKE] Use CPack to build packages
Oct 23 2019, 09:13
Fabien closed D4267: [CMAKE] Use CPack to build packages.
Oct 23 2019, 09:13
deadalnix added a comment to D4279: Added autopatch script for patching and rebasing phabricator diffs.

Is it a rebase script, or an arc patch script?

Oct 23 2019, 02:08
teamcity added a comment to D4281: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 23 2019, 01:50
nakihito updated the summary of D4281: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py.
Oct 23 2019, 01:48
deadalnix requested changes to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Please rebase, otherwise LGTM.

Oct 23 2019, 01:45
teamcity added a comment to D4281: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 01:41
deadalnix accepted D4234: bench: Benchmark MempoolToJSON.
Oct 23 2019, 01:41
nakihito planned changes to D4281: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py.
Oct 23 2019, 01:40
nakihito created D4281: Add test_runner flag to suppress ASAN errors from wallet_multiwallet.py.
Oct 23 2019, 01:40
Harbormaster failed remote builds in B7838: Diff 13649 for D4279: Added autopatch script for patching and rebasing phabricator diffs!
Oct 23 2019, 01:35
teamcity added a comment to D4279: Added autopatch script for patching and rebasing phabricator diffs.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Oct 23 2019, 01:35
deadalnix accepted D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.
Oct 23 2019, 01:29
teamcity added a comment to D4279: Added autopatch script for patching and rebasing phabricator diffs.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 23 2019, 01:28
jasonbcox updated the diff for D4279: Added autopatch script for patching and rebasing phabricator diffs.

Cleaned up tests and lint issues

Oct 23 2019, 01:28
deadalnix accepted D4273: [CMAKE] Use CPack to build source packages.
Oct 23 2019, 01:15
deadalnix requested changes to D4272: Merge #13114: wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore.

The test plan is inadequate. If you actually checked for thread safety annotation warning from the compiler, you'd know that there are some since Oct, 3rd (!)

Oct 23 2019, 01:13
jasonbcox added inline comments to D4276: Add unit tests for seeder's parse_name().
Oct 23 2019, 00:44

Oct 22 2019

fpelliccioni planned changes to D4280: Minor cleanups for AcceptToMemoryPool.

Have to check what happened with the tests.

Oct 22 2019, 20:03
jasonbcox accepted D4271: Merge #13043: [qt] OptionsDialog: add prune setting.
Oct 22 2019, 20:02
Harbormaster failed remote builds in B7837: Diff 13647 for D4280: Minor cleanups for AcceptToMemoryPool!
Oct 22 2019, 19:55
teamcity added a comment to D4280: Minor cleanups for AcceptToMemoryPool.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Oct 22 2019, 19:55
fpelliccioni updated the test plan for D4280: Minor cleanups for AcceptToMemoryPool.
Oct 22 2019, 19:47
teamcity added a comment to D4280: Minor cleanups for AcceptToMemoryPool.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Oct 22 2019, 19:46
Harbormaster failed remote builds in B7836: Diff 13646 for D4280: Minor cleanups for AcceptToMemoryPool!
Oct 22 2019, 19:46
fpelliccioni committed rABCa76b928ad0d6: mempool: remove unused magic number from consistency check (authored by Gregory Sanders <gsanders87@gmail.com>).
mempool: remove unused magic number from consistency check
Oct 22 2019, 19:43
fpelliccioni closed D4278: mempool: remove unused magic number from consistency check.
Oct 22 2019, 19:43
teamcity added a comment to D4280: Minor cleanups for AcceptToMemoryPool.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 22 2019, 19:42
fpelliccioni updated the diff for D4280: Minor cleanups for AcceptToMemoryPool.

removed comment

Oct 22 2019, 19:42
teamcity added a comment to D4280: Minor cleanups for AcceptToMemoryPool.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 22 2019, 19:35
fpelliccioni created D4280: Minor cleanups for AcceptToMemoryPool.
Oct 22 2019, 19:35
jasonbcox updated the summary of D4279: Added autopatch script for patching and rebasing phabricator diffs.
Oct 22 2019, 19:03
teamcity added a comment to D4279: Added autopatch script for patching and rebasing phabricator diffs.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 22 2019, 18:03
teamcity added a comment to D4279: Added autopatch script for patching and rebasing phabricator diffs.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 22 2019, 17:47
jasonbcox planned changes to D4279: Added autopatch script for patching and rebasing phabricator diffs.
Oct 22 2019, 17:46
jasonbcox created D4279: Added autopatch script for patching and rebasing phabricator diffs.
Oct 22 2019, 17:46
teamcity added a comment to D4258: Implement PSBT Structures and un/serialization methods per BIP 174.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 22 2019, 17:00
teamcity added a comment to D4258: Implement PSBT Structures and un/serialization methods per BIP 174.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 22 2019, 16:45
deadalnix updated the diff for D4258: Implement PSBT Structures and un/serialization methods per BIP 174.

Addres comments

Oct 22 2019, 16:45
Nico Guiton <nico@bitframe.org> committed rABC104e5e612728: Merge #13258: uint256: Remove unnecessary crypto/common.h dependency (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13258: uint256: Remove unnecessary crypto/common.h dependency
Oct 22 2019, 16:28
Nico Guiton <nico@bitframe.org> closed D4277: Merge #13258: uint256: Remove unnecessary crypto/common.h dependency.
Oct 22 2019, 16:28
deadalnix added inline comments to D4258: Implement PSBT Structures and un/serialization methods per BIP 174.
Oct 22 2019, 15:32
deadalnix accepted D4278: mempool: remove unused magic number from consistency check.
Oct 22 2019, 15:22
teamcity added a comment to D4278: mempool: remove unused magic number from consistency check.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 22 2019, 13:47
fpelliccioni updated the test plan for D4278: mempool: remove unused magic number from consistency check.
Oct 22 2019, 13:39
teamcity added a comment to D4278: mempool: remove unused magic number from consistency check.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 22 2019, 13:38
fpelliccioni created D4278: mempool: remove unused magic number from consistency check.
Oct 22 2019, 13:38
deadalnix requested changes to D4275: Move parse_name() to dns.h so it can be tested.
Oct 22 2019, 13:11
First
Prev
Next