Page MenuHomePhabricator
Feed All Stories

Oct 22 2019

deadalnix accepted D4277: Merge #13258: uint256: Remove unnecessary crypto/common.h dependency.
Oct 22 2019, 13:10
teamcity added a comment to D4273: [CMAKE] Use CPack to build source packages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 22 2019, 11:18
teamcity added a comment to D4273: [CMAKE] Use CPack to build source packages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 22 2019, 11:14
teamcity added a comment to D4273: [CMAKE] Use CPack to build source packages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 22 2019, 11:07
Fabien updated the diff for D4273: [CMAKE] Use CPack to build source packages.

Newline.

Oct 22 2019, 11:06
teamcity added a comment to D4273: [CMAKE] Use CPack to build source packages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 22 2019, 11:05
Fabien updated the diff for D4273: [CMAKE] Use CPack to build source packages.

Use git to get an list of files/directories to exclude.

Oct 22 2019, 11:05
Fabien planned changes to D4273: [CMAKE] Use CPack to build source packages.
Oct 22 2019, 06:04
nakihito requested review of D4275: Move parse_name() to dns.h so it can be tested.
Oct 22 2019, 00:45
teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 22 2019, 00:32
teamcity added a comment to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 22 2019, 00:29
nakihito added inline comments to D4275: Move parse_name() to dns.h so it can be tested.
Oct 22 2019, 00:20
nakihito requested review of D4277: Merge #13258: uint256: Remove unnecessary crypto/common.h dependency.
Oct 22 2019, 00:19
teamcity added a comment to D4190: Rename master key to seed.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 22 2019, 00:19
nakihito planned changes to D4190: Rename master key to seed.
Oct 22 2019, 00:18
nakihito updated the diff for D4190: Rename master key to seed.

Rebased.

Oct 22 2019, 00:18
teamcity added a comment to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 22 2019, 00:16
nakihito planned changes to D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.
Oct 22 2019, 00:16
nakihito updated the diff for D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Rebased and missed a hdmasterkey -> hdseedid.

Oct 22 2019, 00:16

Oct 21 2019

deadalnix added inline comments to D4273: [CMAKE] Use CPack to build source packages.
Oct 21 2019, 23:37
nakihito planned changes to D4276: Add unit tests for seeder's parse_name().
Oct 21 2019, 23:09
jasonbcox requested changes to D4276: Add unit tests for seeder's parse_name().
Oct 21 2019, 20:44
jasonbcox requested changes to D4275: Move parse_name() to dns.h so it can be tested.
Oct 21 2019, 20:38
teamcity added a comment to D4277: Merge #13258: uint256: Remove unnecessary crypto/common.h dependency.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 21 2019, 20:17
teamcity added a comment to D4277: Merge #13258: uint256: Remove unnecessary crypto/common.h dependency.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 21 2019, 20:01
nakihito planned changes to D4277: Merge #13258: uint256: Remove unnecessary crypto/common.h dependency.
Oct 21 2019, 20:01
nakihito created D4277: Merge #13258: uint256: Remove unnecessary crypto/common.h dependency.
Oct 21 2019, 20:01
teamcity added a comment to D4276: Add unit tests for seeder's parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 21 2019, 19:56
teamcity added a comment to D4275: Move parse_name() to dns.h so it can be tested.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 21 2019, 19:49
nakihito retitled D4276: Add unit tests for seeder's parse_name() from Add unit tests for parse_name() to Add unit tests for seeder's parse_name().
Oct 21 2019, 19:48
nakihito requested review of D4276: Add unit tests for seeder's parse_name().
Oct 21 2019, 19:45
nakihito updated the summary of D4276: Add unit tests for seeder's parse_name().
Oct 21 2019, 19:45
teamcity added a comment to D4276: Add unit tests for seeder's parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 21 2019, 19:45
nakihito planned changes to D4276: Add unit tests for seeder's parse_name().
Oct 21 2019, 19:45
nakihito created D4276: Add unit tests for seeder's parse_name().
Oct 21 2019, 19:45
nakihito requested review of D4275: Move parse_name() to dns.h so it can be tested.
Oct 21 2019, 19:41
teamcity added a comment to D4275: Move parse_name() to dns.h so it can be tested.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 21 2019, 19:40
nakihito planned changes to D4275: Move parse_name() to dns.h so it can be tested.
Oct 21 2019, 19:40
nakihito updated the diff for D4275: Move parse_name() to dns.h so it can be tested.

Added formatting changes to this patch.

Oct 21 2019, 19:39
Harbormaster failed remote builds in B7824: Diff 13629 for D4275: Move parse_name() to dns.h so it can be tested!
Oct 21 2019, 19:36
teamcity added a comment to D4275: Move parse_name() to dns.h so it can be tested.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Oct 21 2019, 19:36
teamcity added a comment to D4275: Move parse_name() to dns.h so it can be tested.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 21 2019, 19:34
nakihito planned changes to D4275: Move parse_name() to dns.h so it can be tested.
Oct 21 2019, 19:34
nakihito created D4275: Move parse_name() to dns.h so it can be tested.
Oct 21 2019, 19:34
teamcity added a comment to D4271: Merge #13043: [qt] OptionsDialog: add prune setting.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 21 2019, 17:55
teamcity added a comment to D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 21 2019, 17:46
teamcity added a comment to D4271: Merge #13043: [qt] OptionsDialog: add prune setting.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 21 2019, 17:45
nakihito updated the diff for D4271: Merge #13043: [qt] OptionsDialog: add prune setting.

Added braces.

Oct 21 2019, 17:42
nakihito requested review of D4272: Merge #13114: wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore.
Oct 21 2019, 17:37
teamcity added a comment to D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 21 2019, 17:37
nakihito updated the diff for D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.

Added braces.

Oct 21 2019, 17:36
Nico Guiton <nico@bitframe.org> committed rABCbc8ad5ec1d81: Merge #11491: [gui] Add proxy icon in statusbar (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #11491: [gui] Add proxy icon in statusbar
Oct 21 2019, 17:31
Nico Guiton <nico@bitframe.org> closed D4269: Merge #11491: [gui] Add proxy icon in statusbar.
Oct 21 2019, 17:31
jasonbcox added inline comments to D4195: Added a land bot script.
Oct 21 2019, 17:31
jasonbcox added inline comments to D4195: Added a land bot script.
Oct 21 2019, 16:28
jasonbcox accepted D3308: Merge #9894: remove 'label' filter for rpc command help.

Looks like the stack is clearing up. Please don't land this until D3950 is green.

Oct 21 2019, 16:10
jasonbcox accepted D3950: Merge #12953: Deprecate accounts.
Oct 21 2019, 16:09
teamcity added a comment to D4274: [CMAKE] Create a windows installer.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 21 2019, 10:15
teamcity added a comment to D4274: [CMAKE] Create a windows installer.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 21 2019, 10:07
Fabien created D4274: [CMAKE] Create a windows installer.
Oct 21 2019, 10:06
teamcity added a comment to D4273: [CMAKE] Use CPack to build source packages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 21 2019, 08:51
teamcity added a comment to D4273: [CMAKE] Use CPack to build source packages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 21 2019, 08:41
Fabien created D4273: [CMAKE] Use CPack to build source packages.
Oct 21 2019, 08:41
Fabien requested changes to D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.
Oct 21 2019, 06:32
deadalnix accepted D4269: Merge #11491: [gui] Add proxy icon in statusbar.
Oct 21 2019, 00:39

Oct 20 2019

teamcity added a comment to D4272: Merge #13114: wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 20 2019, 22:43
teamcity added a comment to D4272: Merge #13114: wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 20 2019, 22:32
nakihito planned changes to D4272: Merge #13114: wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore.
Oct 20 2019, 22:32
nakihito created D4272: Merge #13114: wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore.
Oct 20 2019, 22:32
teamcity added a comment to D4271: Merge #13043: [qt] OptionsDialog: add prune setting.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 20 2019, 22:08
nakihito updated the test plan for D4271: Merge #13043: [qt] OptionsDialog: add prune setting.
Oct 20 2019, 22:02
teamcity added a comment to D4271: Merge #13043: [qt] OptionsDialog: add prune setting.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 20 2019, 21:59
nakihito planned changes to D4271: Merge #13043: [qt] OptionsDialog: add prune setting.
Oct 20 2019, 21:58
nakihito created D4271: Merge #13043: [qt] OptionsDialog: add prune setting.
Oct 20 2019, 21:58

Oct 19 2019

teamcity added a comment to D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 19 2019, 04:57
nakihito requested review of D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.
Oct 19 2019, 04:48
teamcity added a comment to D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 19 2019, 04:47
nakihito planned changes to D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.
Oct 19 2019, 04:47
nakihito created D4270: Merge #13248: [gui] Make proxy icon from statusbar clickable.
Oct 19 2019, 04:47
teamcity added a comment to D4269: Merge #11491: [gui] Add proxy icon in statusbar.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 19 2019, 04:40
nakihito requested review of D4269: Merge #11491: [gui] Add proxy icon in statusbar.
Oct 19 2019, 04:34
nakihito updated the test plan for D4269: Merge #11491: [gui] Add proxy icon in statusbar.
Oct 19 2019, 04:33
teamcity added a comment to D4269: Merge #11491: [gui] Add proxy icon in statusbar.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 19 2019, 04:29
nakihito planned changes to D4269: Merge #11491: [gui] Add proxy icon in statusbar.
Oct 19 2019, 04:29
nakihito created D4269: Merge #11491: [gui] Add proxy icon in statusbar.
Oct 19 2019, 04:29
teamcity added a comment to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 19 2019, 03:11
teamcity added a comment to D3950: Merge #12953: Deprecate accounts.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 19 2019, 03:11
teamcity added a comment to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 19 2019, 03:00
nakihito updated the diff for D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Rebased.

Oct 19 2019, 03:00
teamcity added a comment to D3950: Merge #12953: Deprecate accounts.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 19 2019, 02:59
nakihito updated the diff for D3950: Merge #12953: Deprecate accounts.

Rebase and fixed nits.

Oct 19 2019, 02:59
Nico Guiton <nico@bitframe.org> committed rABC40d9c234aa53: bugfix: Remove dangling wallet env instance and Delete walletView in… (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
bugfix: Remove dangling wallet env instance and Delete walletView in…
Oct 19 2019, 02:36
Nico Guiton <nico@bitframe.org> closed D4255: bugfix: Remove dangling wallet env instance and Delete walletView in WalletFrame::removeWallet.
Oct 19 2019, 02:36
Nico Guiton <nico@bitframe.org> committed rABCcde4830c698e: ui: Support wallets unloaded dynamically (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
ui: Support wallets unloaded dynamically
Oct 19 2019, 02:31
Nico Guiton <nico@bitframe.org> closed D4254: ui: Support wallets unloaded dynamically.
Oct 19 2019, 02:31
Nico Guiton <nico@bitframe.org> committed rABC05f446d4fa29: rpc: Add unloadwallet RPC, release notes, and tests (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
rpc: Add unloadwallet RPC, release notes, and tests
Oct 19 2019, 02:20
Nico Guiton <nico@bitframe.org> closed D4253: rpc: Add unloadwallet RPC, release notes, and tests.
Oct 19 2019, 02:20
Nico Guiton <nico@bitframe.org> committed rABC7e34a0fa1bdf: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest
Oct 19 2019, 02:14
Nico Guiton <nico@bitframe.org> closed D4252: rpc: Extract GetWalletNameFromJSONRPCRequest from GetWalletForJSONRPCRequest.
Oct 19 2019, 02:14

Oct 18 2019

jasonbcox accepted D4267: [CMAKE] Use CPack to build packages.

Thanks for explaining. I think there's some minor improvements we can make later, but they don't need to block this diff specifically.

Oct 18 2019, 21:51