Build Bitcoin-ABC / Diffs / Diff Testing passed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Oct 18 2019
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Remove useless EXCLUDE_FROM_ALL.
Remove some boilerplates:
- Let the function define a couple variables so the target names are directly testable and accessible
- Move the versioning and output naming back into the function as they are not library specific.
Oct 17 2019
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Rebased.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Rebased.
Rebased.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Reverted constructor change for BitcoinGUI.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
In D4234#102664, @deadalnix wrote:It's not clear you go the dependency in the right order.in any case, it seems that you have https://github.com/bitcoin/bitcoin/pull/11062 to go through first.
In D4243#102663, @deadalnix wrote:I think you got the dependency reversed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
The changes made in D3371 do not affect the constructor, so the rationale for not backporting makes no sense whatsoever.
Where are the other rename done, then ? I don't see a patch in the stack doing that. I don't understand why the double write doesn't come first, then the scripted diff? The way this is done is exceedingly difficult to review.
Actually run your test plan.
It's not clear you go the dependency in the right order.in any case, it seems that you have https://github.com/bitcoin/bitcoin/pull/11062 to go through first.
I think you got the dependency reversed.
Oct 16 2019
In D4240#102152, @deadalnix wrote:Why increased automation would make this parameter obsolete? Why remove it before such automation exists and the parameter actually is obsolete?
In D4241#102149, @deadalnix wrote:First, I'm not convinced this is ambiguous. What would you sign in there that makes any sense? Is that worth breaking things? Second, the test plan doesn't cover the feature whatsoever.
I don't see a good reason to block this based on the discussion in PR14941. That change is an improvement, but we'll need to backport up to it to get it.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Rebased.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Revert dependency, now depends on D4257.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Revert diff dependency.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
In D4190#102420, @deadalnix wrote:The diff doesn't match the description anymore. It's also unclear to me why the double outputs wasn't stacked first.
Build Bitcoin-ABC / Diffs / Diff Testing passed.