Page MenuHomePhabricator
Feed All Stories

Nov 20 2019

Fabien closed D4471: test: Add tests for RPC help.
Nov 20 2019, 08:45
Fabien committed rABCa0a2b7ce7a5c: Remove obj_c for macOS Dock icon setting (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
Remove obj_c for macOS Dock icon setting
Nov 20 2019, 08:44
Fabien closed D4472: Remove obj_c for macOS Dock icon setting.
Nov 20 2019, 08:44
Fabien committed rABC082ffb71c5ce: gui: Favor macOS show / hide action in dock menu (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
gui: Favor macOS show / hide action in dock menu
Nov 20 2019, 08:40
Fabien closed D4473: gui: Favor macOS show / hide action in dock menu.
Nov 20 2019, 08:40
teamcity added a comment to D4480: Use Qt signal for macOS Dock icon click event.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 20 2019, 08:39
Fabien created D4480: Use Qt signal for macOS Dock icon click event.
Nov 20 2019, 08:38
Fabien accepted D4475: Test that a non-witness script as witness utxo is not signed.
Nov 20 2019, 08:10
Fabien accepted D4470: Use 72 byte dummy signatures when watching only inputs may be used.
Nov 20 2019, 08:08
Fabien accepted D4462: Use local instance of ArgsManager in getarg_tests.
Nov 20 2019, 07:54
Fabien requested changes to D4417: Add a separate executable for seeder tests.
Nov 20 2019, 07:50
Fabien requested changes to D4279: Added autopatch script for patching and rebasing phabricator diffs.
Nov 20 2019, 07:33
Fabien accepted D4459: Additional sanity checks in SignPSBTInput.
Nov 20 2019, 06:53
jasonbcox accepted D4468: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR.
Nov 20 2019, 01:05
jasonbcox accepted D4467: Always create 70 byte signatures with low R values.
Nov 20 2019, 01:03
nakihito updated the summary of D4300: Integrate gArgs and chainparams into the Seeder.
Nov 20 2019, 00:01
nakihito updated the summary of D4300: Integrate gArgs and chainparams into the Seeder.
Nov 20 2019, 00:00

Nov 19 2019

nakihito updated the summary of D4476: Move primitives/transaction.cpp to common for CMake.
Nov 19 2019, 23:50
deadalnix accepted D4407: [GITIAN] Migrate OSX Gitian builds to CMake and Ninja.
Nov 19 2019, 23:39
deadalnix accepted D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.
Nov 19 2019, 23:37
deadalnix accepted D4472: Remove obj_c for macOS Dock icon setting.
Nov 19 2019, 23:34
Fabien accepted D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.
Nov 19 2019, 20:19
jasonbcox accepted D4473: gui: Favor macOS show / hide action in dock menu.
Nov 19 2019, 20:06
teamcity added a comment to D4476: Move primitives/transaction.cpp to common for CMake.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 20:01
teamcity added a comment to D4476: Move primitives/transaction.cpp to common for CMake.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 19:52
nakihito planned changes to D4476: Move primitives/transaction.cpp to common for CMake.
Nov 19 2019, 19:52
nakihito created D4476: Move primitives/transaction.cpp to common for CMake.
Nov 19 2019, 19:52
teamcity added a comment to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 19:38
nakihito added inline comments to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.
Nov 19 2019, 19:28
teamcity added a comment to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 19:27
nakihito updated the diff for D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.

Fixed comment formatting.

Nov 19 2019, 19:26
teamcity added a comment to D4475: Test that a non-witness script as witness utxo is not signed.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 18:24
teamcity added a comment to D4474: Added support for -gravitonactivationtime to unit tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 18:17
jasonbcox updated the test plan for D4474: Added support for -gravitonactivationtime to unit tests.
Nov 19 2019, 18:09
teamcity added a comment to D4475: Test that a non-witness script as witness utxo is not signed.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 18:08
deadalnix created D4475: Test that a non-witness script as witness utxo is not signed.
Nov 19 2019, 18:07
jasonbcox updated the test plan for D4474: Added support for -gravitonactivationtime to unit tests.
Nov 19 2019, 18:07
teamcity added a comment to D4474: Added support for -gravitonactivationtime to unit tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 18:07
jasonbcox created D4474: Added support for -gravitonactivationtime to unit tests.
Nov 19 2019, 18:07
jasonbcox accepted D4469: Introduce a maximum size for locators..
Nov 19 2019, 17:54
jasonbcox planned changes to D4195: Added a land bot script.
Nov 19 2019, 17:48
jasonbcox accepted D4471: test: Add tests for RPC help.
Nov 19 2019, 17:47
teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing passed.

Nov 19 2019, 17:11
deadalnix committed rABC449bfe2bb4b2: Add missing braces on key.cpp (authored by deadalnix).
Add missing braces on key.cpp
Nov 19 2019, 17:09
deadalnix closed D4466: Add missing braces on key.cpp.
Nov 19 2019, 17:09
fpelliccioni abandoned D4280: Minor cleanups for AcceptToMemoryPool.
Nov 19 2019, 17:06
fpelliccioni abandoned D4075: Integration of property based testing into Bitcoin Core.
Nov 19 2019, 17:05
fpelliccioni abandoned D4009: zmq: log outbound message high water mark when reusing socket.
Nov 19 2019, 17:05
teamcity added a comment to D4473: gui: Favor macOS show / hide action in dock menu.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 16:46
teamcity added a comment to D4473: gui: Favor macOS show / hide action in dock menu.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 16:37
Fabien created D4473: gui: Favor macOS show / hide action in dock menu.
Nov 19 2019, 16:37
teamcity added a comment to D4472: Remove obj_c for macOS Dock icon setting.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 16:34
teamcity added a comment to D4472: Remove obj_c for macOS Dock icon setting.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 16:24
Fabien created D4472: Remove obj_c for macOS Dock icon setting.
Nov 19 2019, 16:24
teamcity added a comment to D4471: test: Add tests for RPC help.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 16:12
teamcity added a comment to D4470: Use 72 byte dummy signatures when watching only inputs may be used.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 16:05
teamcity added a comment to D4471: test: Add tests for RPC help.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 16:02
Fabien created D4471: test: Add tests for RPC help.
Nov 19 2019, 16:02
teamcity added a comment to D4469: Introduce a maximum size for locators..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 16:00
teamcity added a comment to D4470: Use 72 byte dummy signatures when watching only inputs may be used.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 15:53
deadalnix created D4470: Use 72 byte dummy signatures when watching only inputs may be used.
Nov 19 2019, 15:53
teamcity added a comment to D4469: Introduce a maximum size for locators..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 15:49
Fabien created D4469: Introduce a maximum size for locators..
Nov 19 2019, 15:48
Fabien accepted D4466: Add missing braces on key.cpp.
Nov 19 2019, 15:40
teamcity added a comment to D4468: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 15:32
teamcity added a comment to D4467: Always create 70 byte signatures with low R values.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 15:18
teamcity added a comment to D4468: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 15:15
deadalnix created D4468: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR.
Nov 19 2019, 15:15
Fabien requested changes to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.
Nov 19 2019, 15:04
teamcity added a comment to D4467: Always create 70 byte signatures with low R values.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 15:03
deadalnix created D4467: Always create 70 byte signatures with low R values.
Nov 19 2019, 14:48
Fabien committed rABCbd48f686c71a: qa: Premine to deterministic address with -disablewallet (authored by MarcoFalke <falke.marco@gmail.com>).
qa: Premine to deterministic address with -disablewallet
Nov 19 2019, 14:23
Fabien closed D4450: qa: Premine to deterministic address with -disablewallet.
Nov 19 2019, 14:23
Fabien committed rABC5df3c1d33e94: RPC: Add new getzmqnotifications method. (authored by Daniel Kraft <d@domob.eu>).
RPC: Add new getzmqnotifications method.
Nov 19 2019, 14:20
Fabien closed D4447: RPC: Add new getzmqnotifications method..
Nov 19 2019, 14:20
Fabien committed rABC25f5e271799d: Break circular dependency: init -> * -> init by extracting shutdown.h (authored by Ben Woosley <ben.woosley@gmail.com>).
Break circular dependency: init -> * -> init by extracting shutdown.h
Nov 19 2019, 14:15
Fabien closed D4465: Break circular dependency: init -> * -> init by extracting shutdown.h.
Nov 19 2019, 14:15
Fabien added a comment to D4465: Break circular dependency: init -> * -> init by extracting shutdown.h.

After breaking your depends (D4461) :)

Nov 19 2019, 14:14
Fabien committed rABC8130cbde42fb: Drop unused init.h includes (authored by Ben Woosley <ben.woosley@gmail.com>).
Drop unused init.h includes
Nov 19 2019, 14:14
Fabien closed D4464: Drop unused init.h includes.
Nov 19 2019, 14:13
teamcity added a comment to D4466: Add missing braces on key.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 14:06
teamcity added a comment to D4466: Add missing braces on key.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 13:57
deadalnix created D4466: Add missing braces on key.cpp.
Nov 19 2019, 13:57
deadalnix accepted D4465: Break circular dependency: init -> * -> init by extracting shutdown.h.

Go on, trash my ccache :)

Nov 19 2019, 13:39
teamcity added a comment to D4459: Additional sanity checks in SignPSBTInput.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 13:34
deadalnix accepted D4464: Drop unused init.h includes.
Nov 19 2019, 13:33
teamcity added a comment to D4459: Additional sanity checks in SignPSBTInput.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 13:25
deadalnix updated the diff for D4459: Additional sanity checks in SignPSBTInput.

Remove 'both'

Nov 19 2019, 13:25
teamcity added a comment to D4465: Break circular dependency: init -> * -> init by extracting shutdown.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 11:37
teamcity added a comment to D4464: Drop unused init.h includes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 19 2019, 11:33
teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing started.

Nov 19 2019, 11:28
teamcity added a comment to D4465: Break circular dependency: init -> * -> init by extracting shutdown.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 11:26
Fabien created D4465: Break circular dependency: init -> * -> init by extracting shutdown.h.
Nov 19 2019, 11:26
teamcity added a comment to D4464: Drop unused init.h includes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 19 2019, 11:24
Fabien created D4464: Drop unused init.h includes.
Nov 19 2019, 11:23
Fabien committed rABC36179f426c82: Add Windows shutdown handler (authored by Chun Kuan Lee <ken2812221@gmail.com>).
Add Windows shutdown handler
Nov 19 2019, 09:40
Fabien closed D4460: Add Windows shutdown handler.
Nov 19 2019, 09:40
Fabien requested changes to D4459: Additional sanity checks in SignPSBTInput.
Nov 19 2019, 09:19
Fabien added a comment to D4459: Additional sanity checks in SignPSBTInput.

This is a very weird review, as there is almost nothing from the original PR !

Nov 19 2019, 09:18
teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing passed.

Nov 19 2019, 02:30