Yes this works because the mempool is being reprocessed now due to another upgrade, as the reversebytes thing D5130 (==D5283) is landed already. 👍
(that's not bad btw, I rely on the same in my now-landed D5224 tests)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 14 2020
Feb 14 2020
@dagurval this is the only way I know how to do these kinds of tests. We have never written tests that depend explicitly on --with-phononactivation and we avoid writing tests that directly invoke time(), so that would be pretty weird if you did that. In other words we write tests that are either testing activation-independent behaviour, or if they are sensitive then they must handle their own activation parameters and override any effect that --with-phononactivation might have, like you've done here.
teamcity added a comment to D5288: Merge #14679: importmulti: Don't add internal addresses to address book.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
I won't block this as I'm not confident to effectively review its substance, but good to see the build failures are showing up now.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D5288: Merge #14679: importmulti: Don't add internal addresses to address book.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity updated the summary of D5288: Merge #14679: importmulti: Don't add internal addresses to address book.
teamcity added a comment to D5288: Merge #14679: importmulti: Don't add internal addresses to address book.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
[Automated] Update chainparams
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fix exit behavior in test-seeds
Build Bitcoin-ABC / Diffs / Diff Testing started.
jasonbcox updated the diff for D5269: Add --commit to automated-commits to make local testing easier.
Fixed confusing double-negative
Feb 13 2020
Feb 13 2020
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Changed BOOST_AUTO_TEST_SUITE to BOOST_FIXTURE_TEST_SUITE and BOOST_AUTO_TEST_CASE to BOOST_FIXTURE_TEST_CASE. Added SeederTestingSetup struct for the fixture test suite. Changed user_agent type to std::string.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
jasonbcox added inline comments to D5269: Add --commit to automated-commits to make local testing easier.
Build Bitcoin-ABC / Diffs / Diff Testing started.
jasonbcox updated the test plan for D5269: Add --commit to automated-commits to make local testing easier.
Build Bitcoin-ABC / Diffs / Diff Testing started.
jasonbcox updated the diff for D5269: Add --commit to automated-commits to make local testing easier.
- Fixes according to feedback
- Small refactor so error messages will appear early
- Rename --commit to --parent since this is more self explanatory. Associated variable names changed as well.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Removed type casts.
jasonbcox added inline comments to D5270: Make all automated commits run smoke tests prior to pushing.
nakihito committed rABC054899250f31: Merge #14720: rpc: Correctly name arguments (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14720: rpc: Correctly name arguments
teamcity added a comment to D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
[CMAKE] Use the new FindPython module
teamcity added a comment to D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien updated the diff for D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
Use Unix EOL.
nakihito committed rABC30527d21d9fe: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Added CFeeRate changes.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
In D5282#127515, @markblundeberg wrote:Teamcity is not able to post build failures here unless it's given permission (it's not part of Bitcoin ABC group) -- if you want that you have to add it to policy as a second entry.
Build Bitcoin-ABC / Diffs / Diff Testing started.
jasonbcox closed T672: Build Bitcoin-ABC / Master / Gitian Builds / Nightly - OSX is broken. as Resolved.
jasonbcox closed T741: Build Bitcoin-ABC / Master / Bitcoin-ABC Master UBSAN is broken. as Resolved.
jasonbcox committed rABC7f63be6a4ba6: Fix a race condition with rpc ports in check-seeds (authored by jasonbcox).
Fix a race condition with rpc ports in check-seeds
deadalnix requested changes to D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
In D5282#127660, @deadalnix wrote:The builds are clean.
The builds are clean.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
dagurval retitled D5245: [qa] Test that mempool reverts to pre-phonon policies from Remove longer ancestor/descendants chain in case of reorg to [qa] Test that mempool reverts to pre-phonon policies.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Remove redundant changes in validation.cpp
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Thanks! I'm going to give this a whirl... (I was the one having pyenv issues 😊 )
Build Bitcoin-ABC / Diffs / Diff Testing started.
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC65e1afb8a6c2: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
[standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade
teamcity added a comment to D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien updated the diff for D5240: [LINTER] Fix the doxygen linter when inline comments are multilined.
Use the Filesystem facility and explode the string.
You should probably forbid to push (no dry run) if commit is not origin/master.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Part of the PR is missing (new cases for the CFeeRate constructor).
Build Bitcoin-ABC / Diffs / Diff Testing started.
Rebase to fix merge conflict with release notes.
There is already a facility to run test pre and post upgrade. Please use this unless you are specifically testing for the activation.