Page MenuHomePhabricator
Feed All Stories

May 29 2020

teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 21:35
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 21:35
jasonbcox requested changes to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.
May 29 2020, 21:33
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 21:32
deadalnix requested changes to D6295: [backport#15139] util: Make ToLower and ToUpper take a char.
May 29 2020, 21:32
deadalnix updated the diff for D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Update release notes

May 29 2020, 21:31
deadalnix added inline comments to D6290: Remove CBlockIndex::SetNull.
May 29 2020, 21:28
deadalnix requested changes to D6291: [SECP256K1] Fix -Wmaybe-uninitialized in tests.

I would rather avoid taking ownership of this. The part of libsecp256k1 we have ownership over are very well delimited and separated from the rest of the codebase. IMO this is a feature.

May 29 2020, 21:25
deadalnix committed rABCe19a6b1c5386: Pass Consensus::Params to load block index family of functions (authored by deadalnix).
Pass Consensus::Params to load block index family of functions
May 29 2020, 21:23
deadalnix closed D6293: Pass Consensus::Params to load block index family of functions.
May 29 2020, 21:23
deadalnix requested changes to D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.
May 29 2020, 21:17
deadalnix requested changes to D6294: [backport#14599] Use functions guaranteed to be locale independent.
May 29 2020, 21:16
jasonbcox added a comment to D6265: Add land bot dependencies to base image setup script.

Why would we want the land bot to use different dependencies that CI builds?

May 29 2020, 20:58
Fabien requested changes to D6264: Add arcanist land bot workflow.
May 29 2020, 20:50
nakihito committed rABC5cf3c08e993d: Fix WSL file locking by using flock instead of fcntl (authored by Samuel Dobson <dobsonsa68@gmail.com>).
Fix WSL file locking by using flock instead of fcntl
May 29 2020, 20:39
nakihito closed D6299: Fix WSL file locking by using flock instead of fcntl.
May 29 2020, 20:39
jasonbcox requested changes to D6294: [backport#14599] Use functions guaranteed to be locale independent.

Are the missed changes in LocaleDependenceLinter due to missing backports? If so, why not do those first?

May 29 2020, 20:26
jasonbcox committed rABCd5188dc324c4: Bump version to 0.21.9 (authored by jasonbcox).
Bump version to 0.21.9
May 29 2020, 20:21
jasonbcox closed D6298: Bump version to 0.21.9.
May 29 2020, 20:20
jasonbcox added a comment to D6298: Bump version to 0.21.9.

Should probably start including checking the seeder version?

May 29 2020, 20:19
jasonbcox accepted D6299: Fix WSL file locking by using flock instead of fcntl.
May 29 2020, 20:19
majcosta updated the test plan for D6297: [backport#15932] rpc: Serialize in getblock without cs_main.
May 29 2020, 20:14
majcosta requested review of D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.

expanded test plan

May 29 2020, 20:13
majcosta updated the test plan for D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.
May 29 2020, 20:13
teamcity added a comment to D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 20:07
nakihito requested changes to D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.

Test plan is insufficient.

May 29 2020, 20:04
nakihito requested changes to D6297: [backport#15932] rpc: Serialize in getblock without cs_main.

Test plan doesn't test lock changes.

May 29 2020, 20:04
teamcity added a comment to D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 20:01
nakihito accepted D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.
May 29 2020, 20:01
nakihito accepted D6297: [backport#15932] rpc: Serialize in getblock without cs_main.
May 29 2020, 19:59
teamcity added a comment to D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 19:59
teamcity added a comment to D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 19:58
teamcity added a comment to D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 19:58
teamcity added a comment to D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 29 2020, 19:58
teamcity added a comment to D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 29 2020, 19:58
teamcity updated the summary of D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.
May 29 2020, 19:58
majcosta requested review of D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.
May 29 2020, 19:58
nakihito accepted D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.
May 29 2020, 19:57
nakihito accepted D6298: Bump version to 0.21.9.

Should probably start including checking the seeder version?

May 29 2020, 19:49
teamcity added a comment to D6299: Fix WSL file locking by using flock instead of fcntl.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 19:46
nakihito updated the test plan for D6299: Fix WSL file locking by using flock instead of fcntl.
May 29 2020, 19:41
teamcity added a comment to D6299: Fix WSL file locking by using flock instead of fcntl.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 19:40
teamcity added a comment to D6299: Fix WSL file locking by using flock instead of fcntl.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 19:37
teamcity added a comment to D6299: Fix WSL file locking by using flock instead of fcntl.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 19:36
teamcity added a comment to D6299: Fix WSL file locking by using flock instead of fcntl.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 19:36
teamcity added a comment to D6299: Fix WSL file locking by using flock instead of fcntl.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 29 2020, 19:36
teamcity added a comment to D6299: Fix WSL file locking by using flock instead of fcntl.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 29 2020, 19:36
teamcity updated the summary of D6299: Fix WSL file locking by using flock instead of fcntl.
May 29 2020, 19:36
nakihito requested review of D6299: Fix WSL file locking by using flock instead of fcntl.
May 29 2020, 19:36
teamcity added a comment to D6298: Bump version to 0.21.9.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 19:31
teamcity added a comment to D6298: Bump version to 0.21.9.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 19:24
teamcity added a comment to D6298: Bump version to 0.21.9.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 19:22
teamcity added a comment to D6298: Bump version to 0.21.9.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 19:20
teamcity added a comment to D6298: Bump version to 0.21.9.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 19:20
teamcity added a comment to D6298: Bump version to 0.21.9.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 29 2020, 19:20
jasonbcox requested review of D6298: Bump version to 0.21.9.
May 29 2020, 19:20
teamcity added a comment to D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 19:06
teamcity added a comment to D6297: [backport#15932] rpc: Serialize in getblock without cs_main.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 18:58
teamcity added a comment to D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 18:57
teamcity added a comment to D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 18:54
teamcity added a comment to D6297: [backport#15932] rpc: Serialize in getblock without cs_main.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 18:54
teamcity added a comment to D6297: [backport#15932] rpc: Serialize in getblock without cs_main.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 18:50
teamcity added a comment to D6297: [backport#15932] rpc: Serialize in getblock without cs_main.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 29 2020, 18:50
teamcity added a comment to D6297: [backport#15932] rpc: Serialize in getblock without cs_main.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 18:49
teamcity added a comment to D6297: [backport#15932] rpc: Serialize in getblock without cs_main.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 18:49
teamcity added a comment to D6297: [backport#15932] rpc: Serialize in getblock without cs_main.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 29 2020, 18:49
teamcity updated the summary of D6297: [backport#15932] rpc: Serialize in getblock without cs_main.
May 29 2020, 18:49
majcosta requested review of D6297: [backport#15932] rpc: Serialize in getblock without cs_main.
May 29 2020, 18:49
teamcity added a comment to D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Build Bitcoin ABC Diffs / Diff Testing (build-ibd-no-assumevalid-checkpoint) started.

May 29 2020, 18:47
teamcity added a comment to D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 29 2020, 18:46
teamcity added a comment to D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 18:46
teamcity added a comment to D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 18:46
jasonbcox updated the diff for D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Fixed output ordering issue + tests

May 29 2020, 18:46
teamcity added a comment to D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 18:44
teamcity added a comment to D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 18:38
teamcity added a comment to D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 18:36
majcosta accepted D6293: Pass Consensus::Params to load block index family of functions.
May 29 2020, 18:36
teamcity added a comment to D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 29 2020, 18:35
teamcity added a comment to D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 18:35
teamcity added a comment to D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 18:35
teamcity added a comment to D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 29 2020, 18:34
teamcity updated the summary of D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.
May 29 2020, 18:34
majcosta requested review of D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.
May 29 2020, 18:34
teamcity added a comment to D6295: [backport#15139] util: Make ToLower and ToUpper take a char.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 18:18
teamcity added a comment to D6294: [backport#14599] Use functions guaranteed to be locale independent.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 18:13
teamcity added a comment to D6295: [backport#15139] util: Make ToLower and ToUpper take a char.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 18:11
teamcity added a comment to D6294: [backport#14599] Use functions guaranteed to be locale independent.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 18:07
teamcity added a comment to D6295: [backport#15139] util: Make ToLower and ToUpper take a char.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 18:07
teamcity added a comment to D6294: [backport#14599] Use functions guaranteed to be locale independent.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 18:07
teamcity added a comment to D6295: [backport#15139] util: Make ToLower and ToUpper take a char.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 29 2020, 18:05
teamcity added a comment to D6295: [backport#15139] util: Make ToLower and ToUpper take a char.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 18:05
teamcity added a comment to D6295: [backport#15139] util: Make ToLower and ToUpper take a char.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 18:05
teamcity added a comment to D6295: [backport#15139] util: Make ToLower and ToUpper take a char.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 29 2020, 18:05
teamcity updated the summary of D6295: [backport#15139] util: Make ToLower and ToUpper take a char.
May 29 2020, 18:05
majcosta requested review of D6295: [backport#15139] util: Make ToLower and ToUpper take a char.
May 29 2020, 18:05
teamcity added a comment to D6294: [backport#14599] Use functions guaranteed to be locale independent.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 18:04
teamcity added a comment to D6294: [backport#14599] Use functions guaranteed to be locale independent.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 29 2020, 18:04
teamcity added a comment to D6294: [backport#14599] Use functions guaranteed to be locale independent.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 18:04
majcosta updated the diff for D6294: [backport#14599] Use functions guaranteed to be locale independent.

reverted some core changes to locale-dependence linter that were wrong

May 29 2020, 18:03
majcosta planned changes to D6294: [backport#14599] Use functions guaranteed to be locale independent.
May 29 2020, 17:49