Page MenuHomePhabricator
Feed All Stories

Jun 9 2020

nakihito closed D6470: Implement poll() on systems which support it properly..
Jun 9 2020, 23:42
nakihito committed rABC96827c217616: Move SocketEvents logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Move SocketEvents logic to private method.
Jun 9 2020, 23:32
nakihito closed D6461: Move SocketEvents logic to private method..
Jun 9 2020, 23:32
nakihito committed rABC716ac6e899ad: Move GenerateSelectSet logic to private method. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Move GenerateSelectSet logic to private method.
Jun 9 2020, 23:21
nakihito closed D6460: Move GenerateSelectSet logic to private method..
Jun 9 2020, 23:21
nakihito committed rABC7ef2a7b7612c: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS. (authored by Patrick Strateman <patrick.strateman@gmail.com>).
Introduce and use constant SELECT_TIMEOUT_MILLISECONDS.
Jun 9 2020, 23:13
nakihito closed D6459: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS..
Jun 9 2020, 23:13
majcosta accepted D6471: Increase maxconnections limit when using poll..
Jun 9 2020, 23:07
nakihito committed rABCa242a8ddcadd: Merge #15597: net: Generate log entry when blocks messages are received… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15597: net: Generate log entry when blocks messages are received…
Jun 9 2020, 23:06
nakihito closed D6491: Merge #15597: net: Generate log entry when blocks messages are received unexpectedly.
Jun 9 2020, 23:06
jasonbcox accepted D6461: Move SocketEvents logic to private method..
Jun 9 2020, 23:05
jasonbcox accepted D6460: Move GenerateSelectSet logic to private method..
Jun 9 2020, 23:02
nakihito committed rABC9dca86e63a4a: Merge #15718: docs: Improve netaddress comments (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15718: docs: Improve netaddress comments
Jun 9 2020, 22:57
nakihito closed D6494: Merge #15718: docs: Improve netaddress comments.
Jun 9 2020, 22:57
jasonbcox accepted D6459: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS..
Jun 9 2020, 22:57
jasonbcox accepted D6491: Merge #15597: net: Generate log entry when blocks messages are received unexpectedly.
Jun 9 2020, 22:54
jasonbcox accepted D6494: Merge #15718: docs: Improve netaddress comments.
Jun 9 2020, 22:45
majcosta committed rABCc7721f4a83cd: [backport#16898] test: Remove unused connect_nodes_bi (authored by majcosta).
[backport#16898] test: Remove unused connect_nodes_bi
Jun 9 2020, 22:44
majcosta closed D6493: [backport#16898] test: Remove unused connect_nodes_bi.
Jun 9 2020, 22:44
majcosta committed rABC68a74407607c: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with… (authored by majcosta).
[backport#16898] scripted-diff: test: Replace connect_nodes_bi with…
Jun 9 2020, 22:43
majcosta closed D6492: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes.
Jun 9 2020, 22:43
jasonbcox accepted D6493: [backport#16898] test: Remove unused connect_nodes_bi.
Jun 9 2020, 22:41
jasonbcox accepted D6492: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes.

As is, the change looks good. But please look into out-of-order backports in these files that will likely be a headache for others:

  • rpc_psbt.py
  • wallet_avoidreuse.py
  • wallet_keypool_topup.py
Jun 9 2020, 22:39
majcosta committed rABC2804ca503a84: [backport#16898] test: Use connect_nodes when connecting nodes in the… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16898] test: Use connect_nodes when connecting nodes in the…
Jun 9 2020, 21:31
majcosta closed D6490: [backport#16898] test: Use connect_nodes when connecting nodes in the test_framework.
Jun 9 2020, 21:31
majcosta updated the summary of D6492: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes.
Jun 9 2020, 21:29
teamcity added a comment to D6494: Merge #15718: docs: Improve netaddress comments.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 21:26
teamcity updated the summary of D6494: Merge #15718: docs: Improve netaddress comments.
Jun 9 2020, 21:26
nakihito requested review of D6494: Merge #15718: docs: Improve netaddress comments.
Jun 9 2020, 21:26
majcosta updated the diff for D6492: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes.

rebase

Jun 9 2020, 21:20
jasonbcox accepted D6490: [backport#16898] test: Use connect_nodes when connecting nodes in the test_framework.

Looks like other parts of the stack take care of it.

Jun 9 2020, 21:11
jasonbcox requested changes to D6490: [backport#16898] test: Use connect_nodes when connecting nodes in the test_framework.
Jun 9 2020, 20:55
teamcity added a comment to D6493: [backport#16898] test: Remove unused connect_nodes_bi.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 20:51
teamcity updated the summary of D6493: [backport#16898] test: Remove unused connect_nodes_bi.
Jun 9 2020, 20:51
majcosta requested review of D6493: [backport#16898] test: Remove unused connect_nodes_bi.
Jun 9 2020, 20:51
majcosta updated the summary of D6492: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes.
Jun 9 2020, 20:37
teamcity added a comment to D6492: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 20:36
teamcity updated the summary of D6492: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes.
Jun 9 2020, 20:36
majcosta requested review of D6492: [backport#16898] scripted-diff: test: Replace connect_nodes_bi with connect_nodes.
Jun 9 2020, 20:36
nakihito updated the diff for D6471: Increase maxconnections limit when using poll..

Rebased.

Jun 9 2020, 20:23
nakihito updated the diff for D6459: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS..

Rebased.

Jun 9 2020, 20:20
nakihito committed rABCee323c8b68d7: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...)… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...)…
Jun 9 2020, 20:17
nakihito closed D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 20:17
Fabien accepted D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 20:15
nakihito requested review of D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 20:09
nakihito updated the test plan for D6481: Merge #13503: Document FreeBSD quirk. Fix FreeBSD build: Use std::min<int>(...) to allow for compilation under certain FreeBSD versions..
Jun 9 2020, 20:09
nakihito updated the diff for D6489: Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups.

Fixed comment.

Jun 9 2020, 20:06
teamcity added a comment to D6491: Merge #15597: net: Generate log entry when blocks messages are received unexpectedly.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 20:04
teamcity updated the summary of D6491: Merge #15597: net: Generate log entry when blocks messages are received unexpectedly.
Jun 9 2020, 20:03
nakihito requested review of D6491: Merge #15597: net: Generate log entry when blocks messages are received unexpectedly.
Jun 9 2020, 20:03
teamcity added a comment to D6490: [backport#16898] test: Use connect_nodes when connecting nodes in the test_framework.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 19:38
teamcity updated the summary of D6490: [backport#16898] test: Use connect_nodes when connecting nodes in the test_framework.
Jun 9 2020, 19:38
majcosta requested review of D6490: [backport#16898] test: Use connect_nodes when connecting nodes in the test_framework.
Jun 9 2020, 19:38
jasonbcox requested changes to D6489: Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups.
Jun 9 2020, 19:38
jasonbcox committed rABC910e12658934: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill
Jun 9 2020, 19:36
jasonbcox closed D6485: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill.
Jun 9 2020, 19:36
teamcity updated the summary of D6489: Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups.
Jun 9 2020, 19:21
teamcity added a comment to D6489: Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 19:21
nakihito requested review of D6489: Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups.
Jun 9 2020, 19:21
teamcity closed T924: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Jun 9 2020, 19:14
jasonbcox accepted D6487: [backport#16239] docs: release note wording.
Jun 9 2020, 19:07
Mengerian committed rABCWEB41f5dcd2f520: Remove upgrade notice (authored by Mengerian).
Remove upgrade notice
Jun 9 2020, 19:04
Mengerian closed D6484: Remove upgrade notice.
Jun 9 2020, 19:04
majcosta updated the diff for D6487: [backport#16239] docs: release note wording.

fix

Jun 9 2020, 19:00
majcosta accepted D6485: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill.
Jun 9 2020, 19:00
nakihito updated the summary of D6283: [seeder] Request headers from new connections.
Jun 9 2020, 18:58
jasonbcox requested changes to D6487: [backport#16239] docs: release note wording.
Jun 9 2020, 18:53
jasonbcox accepted D6484: Remove upgrade notice.

In the future, we need to make this notice deactivate on its own once the date has past. That will decouple the code cleanup from requiring a new deployment to remove the notice.

Jun 9 2020, 18:48
teamcity assigned T924: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. to nakihito.
Jun 9 2020, 18:39
teamcity triaged T924: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
Jun 9 2020, 18:39
teamcity added a comment to D6488: Merge #14626: Select orphan transaction uniformly for eviction.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 18:35
teamcity updated the summary of D6488: Merge #14626: Select orphan transaction uniformly for eviction.
Jun 9 2020, 18:35
nakihito requested review of D6488: Merge #14626: Select orphan transaction uniformly for eviction.
Jun 9 2020, 18:35
nakihito committed rABCc1e1a85bd303: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive
Jun 9 2020, 18:31
nakihito closed D6476: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive.
Jun 9 2020, 18:31
nakihito committed rABC89c98c77854c: Merge #15254: Trivial: fixup a few doxygen comments (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15254: Trivial: fixup a few doxygen comments
Jun 9 2020, 18:28
nakihito closed D6475: Merge #15254: Trivial: fixup a few doxygen comments.
Jun 9 2020, 18:28
teamcity added a comment to D6487: [backport#16239] docs: release note wording.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 18:27
teamcity updated the summary of D6487: [backport#16239] docs: release note wording.
Jun 9 2020, 18:27
majcosta requested review of D6487: [backport#16239] docs: release note wording.
Jun 9 2020, 18:27
teamcity added a comment to D6486: [backport#16239] wallet/rpc: use static help text.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 18:25
teamcity updated the summary of D6486: [backport#16239] wallet/rpc: use static help text.
Jun 9 2020, 18:25
majcosta requested review of D6486: [backport#16239] wallet/rpc: use static help text.
Jun 9 2020, 18:24
nakihito committed rABC47f476c061cf: Merge #15194: Add comment describing fDisconnect behavior (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15194: Add comment describing fDisconnect behavior
Jun 9 2020, 18:24
nakihito closed D6474: Merge #15194: Add comment describing fDisconnect behavior.
Jun 9 2020, 18:24
teamcity added a comment to D6485: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 18:23
teamcity updated the summary of D6485: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill.
Jun 9 2020, 18:23
jasonbcox requested review of D6485: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill.
Jun 9 2020, 18:23
nakihito committed rABC03892e93a414: Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg
Jun 9 2020, 18:21
nakihito closed D6472: Merge #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg.
Jun 9 2020, 18:20
Mengerian requested review of D6484: Remove upgrade notice.
Jun 9 2020, 18:15
jasonbcox committed rABCWEB8862868761ff: Add .arcconfig (authored by jasonbcox).
Add .arcconfig
Jun 9 2020, 18:12
jasonbcox closed D6483: Add .arcconfig.
Jun 9 2020, 18:12
nakihito closed D6457: Merge #14436: doc: add comment explaining recentRejects-DoS behavior.
Jun 9 2020, 18:12
nakihito committed rABC063c90dc91a7: Merge #14436: doc: add comment explaining recentRejects-DoS behavior (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14436: doc: add comment explaining recentRejects-DoS behavior
Jun 9 2020, 18:12
Fabien accepted D6483: Add .arcconfig.
Jun 9 2020, 18:11
jasonbcox requested review of D6483: Add .arcconfig.
Jun 9 2020, 18:08
teamcity added a comment to D6482: [backport#16239] wallet/rpc/getbalances: add entry for 'mine.used' balance in results.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 9 2020, 18:08
teamcity updated the summary of D6482: [backport#16239] wallet/rpc/getbalances: add entry for 'mine.used' balance in results.
Jun 9 2020, 18:08
majcosta requested review of D6482: [backport#16239] wallet/rpc/getbalances: add entry for 'mine.used' balance in results.
Jun 9 2020, 18:08