Page MenuHomePhabricator
Feed All Stories

Jul 1 2020

majcosta closed D6741: [backport#17076] tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions.
Jul 1 2020, 18:21
jasonbcox requested review of D6799: [land-bot] Pass committer name/email to land bot endpoint.
Jul 1 2020, 18:10
jasonbcox committed rABCae150fdf9d0b: Cleanup unused --with-phononactivation from test_framework (authored by jasonbcox).
Cleanup unused --with-phononactivation from test_framework
Jul 1 2020, 18:09
jasonbcox closed D6797: Cleanup unused --with-phononactivation from test_framework.
Jul 1 2020, 18:09
majcosta updated the diff for D6741: [backport#17076] tests: Add fuzzing harness for CheckTransaction(...), IsStandardTx(...) and other CTransaction related functions.

fixed linker error after rebase

Jul 1 2020, 18:01
teamcity triaged T990: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
Jul 1 2020, 17:47
jasonbcox committed rABC9bbe4cd78d8c: Cleanup phonon activation in functional tests (authored by jasonbcox).
Cleanup phonon activation in functional tests
Jul 1 2020, 17:36
jasonbcox closed D6796: Cleanup phonon activation in functional tests.
Jul 1 2020, 17:36
teamcity closed T989: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Jul 1 2020, 16:40
majcosta committed rABCac5ff19dd46a: [backport#16237 3/3] Add GetNewChangeDestination for getting new change… (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#16237 3/3] Add GetNewChangeDestination for getting new change…
Jul 1 2020, 16:18
majcosta closed D6721: [backport#16237 3/3] Add GetNewChangeDestination for getting new change Destinations.
Jul 1 2020, 16:18
majcosta committed rABCbf733950e6f5: [backport#16237 2/3] Replace CReserveKey with ReserveDestinatoin (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#16237 2/3] Replace CReserveKey with ReserveDestinatoin
Jul 1 2020, 16:17
majcosta closed D6717: [backport#16237 2/3] Replace CReserveKey with ReserveDestinatoin.
Jul 1 2020, 16:17
majcosta committed rABC922fd79e11bf: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations
Jul 1 2020, 16:17
majcosta closed D6716: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations.
Jul 1 2020, 16:17
majcosta committed rABC828b2e964361: [backport#16542 4/4] Additional tests for other failure cases (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#16542 4/4] Additional tests for other failure cases
Jul 1 2020, 15:23
majcosta closed D6649: [backport#16542 4/4] Additional tests for other failure cases.
Jul 1 2020, 15:23
majcosta committed rABCed3d5a8dfe04: [backport#16542 3/4] Check error messages in descriptor tests (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#16542 3/4] Check error messages in descriptor tests
Jul 1 2020, 15:23
majcosta closed D6648: [backport#16542 3/4] Check error messages in descriptor tests.
Jul 1 2020, 15:22
majcosta committed rABCa2c1a34f16f8: [backport#pr16542 2/4] Give more errors for specific failure conditions (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#pr16542 2/4] Give more errors for specific failure conditions
Jul 1 2020, 15:22
majcosta closed D6643: [backport#pr16542 2/4] Give more errors for specific failure conditions.
Jul 1 2020, 15:22
majcosta committed rABC2abb29db9d5b: [backport#16542 1/4] Return an error from descriptor Parse that gives more… (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#16542 1/4] Return an error from descriptor Parse that gives more…
Jul 1 2020, 15:22
majcosta closed D6642: [backport#16542 1/4] Return an error from descriptor Parse that gives more information about what failed.
Jul 1 2020, 15:21
deadalnix closed D6787: [avalanche] Manipulate peers via PeerId.
Jul 1 2020, 14:13
deadalnix committed rABCc23e06f18a83: [avalanche] Manipulate peers via PeerId (authored by deadalnix).
[avalanche] Manipulate peers via PeerId
Jul 1 2020, 14:13
teamcity added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.
Jul 1 2020, 14:13
teamcity added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.
Jul 1 2020, 14:04
deadalnix committed rABC614e9c8a6056: [avalanche] Make peer score an uint32_t instead of an uint64_t (authored by deadalnix).
[avalanche] Make peer score an uint32_t instead of an uint64_t
Jul 1 2020, 14:01
deadalnix closed D6793: [avalanche] Make peer score an uint32_t instead of an uint64_t.
Jul 1 2020, 14:01
deadalnix requested changes to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.
Jul 1 2020, 13:59
teamcity added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.
Jul 1 2020, 13:55
Fabien added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

https://build.bitcoinabc.org/viewLog.html?buildId=90008&buildTypeId=BitcoinABC_BitcoinAbcStaging&tab=buildResultsDiv&guest=1 completed successfully

Jul 1 2020, 13:45
Fabien added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

The above comment will trigger a build failure, don't take it into account.

Jul 1 2020, 13:40
Fabien added a comment to D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.

@bot build-tsan

Jul 1 2020, 13:40
Fabien requested review of D6798: Fix TSAN out of memory when running the radix_tests/insert_stress_test.
Jul 1 2020, 13:19
BroStapl added a comment to F178551: harbormaster-log-1500.log.
Jul 1 2020, 10:03
akira424 edited a custom field on akira424.
Jul 1 2020, 07:51
Fabien accepted D6797: Cleanup unused --with-phononactivation from test_framework.
Jul 1 2020, 07:00
Fabien accepted D6796: Cleanup phonon activation in functional tests.
Jul 1 2020, 06:59
jasonbcox accepted D6716: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations.
Jul 1 2020, 01:36
jasonbcox accepted D6787: [avalanche] Manipulate peers via PeerId.
Jul 1 2020, 01:32
jasonbcox accepted D6793: [avalanche] Make peer score an uint32_t instead of an uint64_t.
Jul 1 2020, 01:31
jasonbcox requested review of D6797: Cleanup unused --with-phononactivation from test_framework.
Jul 1 2020, 01:10
jasonbcox requested review of D6796: Cleanup phonon activation in functional tests.
Jul 1 2020, 01:08
majcosta committed rABC8790173c76a4: [backport#15639 3/3] bitcoin-wallet tool: Drop libbitcoin_server.a dependency (authored by Russell Yanofsky <russ@yanofsky.org>).
[backport#15639 3/3] bitcoin-wallet tool: Drop libbitcoin_server.a dependency
Jul 1 2020, 00:02
majcosta closed D6795: [backport#15639 3/3] bitcoin-wallet tool: Drop libbitcoin_server.a dependency.
Jul 1 2020, 00:01

Jun 30 2020

deadalnix accepted D6795: [backport#15639 3/3] bitcoin-wallet tool: Drop libbitcoin_server.a dependency.

Discussed off line. This is good.

Jun 30 2020, 23:54
majcosta committed rABC08f90b135f33: [backport#15492 2/2] [cleanup] Remove unused CReserveKey (authored by John Newbery <john@johnnewbery.com>).
[backport#15492 2/2] [cleanup] Remove unused CReserveKey
Jun 30 2020, 23:43
majcosta closed D6714: [backport#15492 2/2] [cleanup] Remove unused CReserveKey.
Jun 30 2020, 23:43
deadalnix accepted D6649: [backport#16542 4/4] Additional tests for other failure cases.
Jun 30 2020, 23:39
deadalnix accepted D6648: [backport#16542 3/4] Check error messages in descriptor tests.
Jun 30 2020, 23:38
deadalnix requested changes to D6795: [backport#15639 3/3] bitcoin-wallet tool: Drop libbitcoin_server.a dependency.
Jun 30 2020, 23:37
deadalnix accepted D6721: [backport#16237 3/3] Add GetNewChangeDestination for getting new change Destinations.
Jun 30 2020, 23:31
deadalnix accepted D6717: [backport#16237 2/3] Replace CReserveKey with ReserveDestinatoin.
Jun 30 2020, 23:31
majcosta committed rABCdb8bab35b22a: [backport#15492 1/2] [rpc] simplify generate RPC (authored by John Newbery <john@johnnewbery.com>).
[backport#15492 1/2] [rpc] simplify generate RPC
Jun 30 2020, 23:28
majcosta closed D6712: [backport#15492 1/2] [rpc] simplify generate RPC.
Jun 30 2020, 23:28
deadalnix updated the diff for D6787: [avalanche] Manipulate peers via PeerId.

Check insertion and remove refactoring leftover

Jun 30 2020, 23:27
majcosta committed rABC1f1482f5483f: [fix] replace leftover dustRelayFee symbols in wallet/wallet.cpp (authored by majcosta).
[fix] replace leftover dustRelayFee symbols in wallet/wallet.cpp
Jun 30 2020, 23:25
majcosta closed D6792: [fix] replace leftover dustRelayFee symbols in wallet/wallet.cpp.
Jun 30 2020, 23:25
majcosta requested review of D6795: [backport#15639 3/3] bitcoin-wallet tool: Drop libbitcoin_server.a dependency.
Jun 30 2020, 23:13
deadalnix requested review of D6793: [avalanche] Make peer score an uint32_t instead of an uint64_t.
Jun 30 2020, 23:08
deadalnix accepted D6792: [fix] replace leftover dustRelayFee symbols in wallet/wallet.cpp.
Jun 30 2020, 23:04
teamcity updated the summary of D6792: [fix] replace leftover dustRelayFee symbols in wallet/wallet.cpp.
Jun 30 2020, 22:56
teamcity added a comment to D6792: [fix] replace leftover dustRelayFee symbols in wallet/wallet.cpp.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 30 2020, 22:56
majcosta requested review of D6792: [fix] replace leftover dustRelayFee symbols in wallet/wallet.cpp.
Jun 30 2020, 22:56
deadalnix accepted D6716: [backport#16237 1/3] Add GetNewDestination to CWallet to fetch new destinations.
Jun 30 2020, 22:42
majcosta committed rABCe3f3596aeccb: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus (authored by majcosta).
[fix] actually move tx_check.cpp from libserver to libbitcoin consensus
Jun 30 2020, 22:41
majcosta closed D6789: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus.
Jun 30 2020, 22:41
deadalnix accepted D6712: [backport#15492 1/2] [rpc] simplify generate RPC.
Jun 30 2020, 22:29
jasonbcox accepted D6789: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus.
Jun 30 2020, 22:26
jasonbcox requested changes to D6787: [avalanche] Manipulate peers via PeerId.

The nits aren't a big deal, but the comment in selectPeerImpl() needs to be addressed in some way.

Jun 30 2020, 22:23
majcosta requested review of D6789: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus.
Jun 30 2020, 21:20
teamcity triaged T989: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
Jun 30 2020, 20:47
majcosta committed rABC1ad604ee3ee1: [backport#15492] [rpc] remove deprecated generate method (authored by Sjors Provoost <sjors@sprovoost.nl>).
[backport#15492] [rpc] remove deprecated generate method
Jun 30 2020, 20:08
majcosta closed D6710: [backport#15492] [rpc] remove deprecated generate method.
Jun 30 2020, 20:08
Fabien accepted D6710: [backport#15492] [rpc] remove deprecated generate method.
Jun 30 2020, 19:51
deadalnix requested review of D6787: [avalanche] Manipulate peers via PeerId.
Jun 30 2020, 16:12
rosie updated rosie.
Jun 30 2020, 14:50
teamcity closed T986: Build Bitcoin-ABC / Master / Bitcoin-ABC Master ASAN is broken. as Resolved.
Jun 30 2020, 14:50
teamcity closed T983: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Jun 30 2020, 14:48
deadalnix committed rABC5a148a811ad9: [avalanche] Build Slot using start and score rather than start/stop (authored by deadalnix).
[avalanche] Build Slot using start and score rather than start/stop
Jun 30 2020, 14:31
deadalnix closed D6779: [avalanche] Build Slot using start and score rather than start/stop.
Jun 30 2020, 14:31
deadalnix closed D6786: [avalanche] Early bail when no matchign slot exists.
Jun 30 2020, 14:30
deadalnix committed rABCc87ff257e439: [avalanche] Early bail when no matchign slot exists (authored by deadalnix).
[avalanche] Early bail when no matchign slot exists
Jun 30 2020, 14:30
Fabien accepted D6786: [avalanche] Early bail when no matchign slot exists.
Jun 30 2020, 14:30
deadalnix committed rABC31839eeb4bbc: [avalanche] Track slots as start+score rather than start/stop (authored by deadalnix).
[avalanche] Track slots as start+score rather than start/stop
Jun 30 2020, 14:30
deadalnix closed D6778: [avalanche] Track slots as start+score rather than start/stop.
Jun 30 2020, 14:30
deadalnix requested review of D6786: [avalanche] Early bail when no matchign slot exists.
Jun 30 2020, 14:26
teamcity closed T988: Build Bitcoin-ABC / Master / Bitcoin-ABC Master UBSAN is broken. as Resolved.
Jun 30 2020, 14:13
Fabien committed rABCbab969716d1a: Add an exception for the TSAN lock-order-inversion on reverselock_tests (authored by Fabien).
Add an exception for the TSAN lock-order-inversion on reverselock_tests
Jun 30 2020, 13:58
Fabien closed D6785: Add an exception for the TSAN lock-order-inversion on reverselock_tests.
Jun 30 2020, 13:58
Fabien committed rABCe0649a4bc593: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout (authored by Fabien).
Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout
Jun 30 2020, 13:57
Fabien closed D6784: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout.
Jun 30 2020, 13:57
deadalnix accepted D6785: Add an exception for the TSAN lock-order-inversion on reverselock_tests.
Jun 30 2020, 13:31
deadalnix requested changes to D6783: Fix out-of-bounds index in Avalanche PeerManager.
Jun 30 2020, 13:29
deadalnix committed rABC20c9071c8a9b: [avalanche] Abstract the Slot infos so that layout can be changed easily (authored by deadalnix).
[avalanche] Abstract the Slot infos so that layout can be changed easily
Jun 30 2020, 12:25
deadalnix closed D6777: [avalanche] Abstract the Slot infos so that layout can be changed easily.
Jun 30 2020, 12:25
deadalnix committed rABCad26108e0958: [avalanche] separate avalanche.{h|cpp} into more relevent files (authored by deadalnix).
[avalanche] separate avalanche.{h|cpp} into more relevent files
Jun 30 2020, 12:24
deadalnix closed D6775: [avalanche] separate avalanche.{h|cpp} into more relevent files.
Jun 30 2020, 12:24
deadalnix accepted D6784: Add an exception for UBSAN vptr on boost::unit_test::decorator::timeout.
Jun 30 2020, 12:17