Page MenuHomePhabricator
Feed All Stories

Aug 6 2020

majcosta closed D7119: [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes.
Aug 6 2020, 19:56
majcosta committed rABC4c4b9a652121: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman… (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman…
Aug 6 2020, 19:55
majcosta closed D7006: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file.
Aug 6 2020, 19:55
majcosta committed rABCb41b32f60c4e: [backport#17260 1/3] Move wallet enums to walletutil.h (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#17260 1/3] Move wallet enums to walletutil.h
Aug 6 2020, 19:54
majcosta closed D6998: [backport#17260 1/3] Move wallet enums to walletutil.h.
Aug 6 2020, 19:54
majcosta updated the test plan for D7132: [backport#18206] tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter).
Aug 6 2020, 18:54
majcosta updated the diff for D7132: [backport#18206] tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter).

fix and rebase

Aug 6 2020, 18:50
majcosta committed rABCb0200bfc356d: [autotools] Fixed fuzzer build (authored by majcosta).
[autotools] Fixed fuzzer build
Aug 6 2020, 18:42
majcosta closed D7143: [autotools] Fixed fuzzer build.
Aug 6 2020, 18:42
jasonbcox accepted D7143: [autotools] Fixed fuzzer build.
Aug 6 2020, 18:41
majcosta requested review of D7143: [autotools] Fixed fuzzer build.
Aug 6 2020, 18:40
teamcity closed T1008: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Aug 6 2020, 18:25
jasonbcox committed rABC8aadcedb631f: Ignore cppcheck syntax errors related to prevector (authored by jasonbcox).
Ignore cppcheck syntax errors related to prevector
Aug 6 2020, 18:07
jasonbcox closed D7140: Ignore cppcheck syntax errors related to prevector.
Aug 6 2020, 18:06
jasonbcox committed rABC6ddc183e2b48: Fix signed shift by 31 bits (authored by jasonbcox).
Fix signed shift by 31 bits
Aug 6 2020, 18:02
jasonbcox closed D7141: Fix signed shift by 31 bits.
Aug 6 2020, 18:02
jasonbcox committed rABC1b3695b519a0: Allow large integers to be used in maxtries (authored by jasonbcox).
Allow large integers to be used in maxtries
Aug 6 2020, 17:58
jasonbcox closed D7138: Allow large integers to be used in maxtries.
Aug 6 2020, 17:58
jasonbcox committed rABC12579ad42fda: Polish release notes (authored by jasonbcox).
Polish release notes
Aug 6 2020, 17:54
jasonbcox closed D7142: Polish release notes.
Aug 6 2020, 17:53
majcosta accepted D7141: Fix signed shift by 31 bits.
Aug 6 2020, 17:27
majcosta accepted D7140: Ignore cppcheck syntax errors related to prevector.
Aug 6 2020, 17:25
majcosta accepted D7142: Polish release notes.
Aug 6 2020, 17:24
jasonbcox requested review of D7142: Polish release notes.
Aug 6 2020, 17:19
jasonbcox requested review of D7141: Fix signed shift by 31 bits.
Aug 6 2020, 17:00
jasonbcox requested review of D7140: Ignore cppcheck syntax errors related to prevector.
Aug 6 2020, 16:48
teamcity triaged T1008: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Aug 6 2020, 16:43
teamcity added a comment to D7139: Add signed right shift assumption in assumptions.h.
Aug 6 2020, 16:39
deadalnix accepted D7119: [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes.
Aug 6 2020, 16:33
deadalnix committed rABCdf80432589c2: Add signed right shift assumption in assumptions.h (authored by deadalnix).
Add signed right shift assumption in assumptions.h
Aug 6 2020, 16:28
deadalnix closed D7139: Add signed right shift assumption in assumptions.h.
Aug 6 2020, 16:28
deadalnix accepted D7138: Allow large integers to be used in maxtries.
Aug 6 2020, 16:27
majcosta accepted D7139: Add signed right shift assumption in assumptions.h.
Aug 6 2020, 16:27
deadalnix requested review of D7139: Add signed right shift assumption in assumptions.h.
Aug 6 2020, 16:25
abc-bot committed rABC5be90c3503a1: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Aug 6 2020, 03:21
Mengerian committed rABCWEB66d7d82bc1a0: [website] Add update on George's departure from Bitcoin ABC (authored by Mengerian).
[website] Add update on George's departure from Bitcoin ABC
Aug 6 2020, 03:11
Mengerian closed D7136: [website] Add update on George's departure from Bitcoin ABC.
Aug 6 2020, 03:11
abc-bot committed rABC79b420c8ffb9: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Aug 6 2020, 02:13
abc-bot committed rABCc8c4b6a40cc9: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Aug 6 2020, 02:06
jasonbcox requested review of D7138: Allow large integers to be used in maxtries.
Aug 6 2020, 00:08

Aug 5 2020

jasonbcox accepted D7135: [backport#18417 3/3] tests: Add fuzzing harness for functions in net_permissions.h.
Aug 5 2020, 23:40
jasonbcox accepted D7134: [backport#18417 2/3] tests: Add fuzzing harness for functions in timedata.h.
Aug 5 2020, 23:39
jasonbcox accepted D7133: [backport#18417 1/3] tests: Add fuzzing harness for functions in addrdb.h.
Aug 5 2020, 23:38
jasonbcox requested changes to D7132: [backport#18206] tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter).
Aug 5 2020, 22:23
jasonbcox updated the diff for D7137: Add proof-of-concept for submitblocksolution and block template manager.

Fix copy elision

Aug 5 2020, 22:12
jasonbcox accepted D7136: [website] Add update on George's departure from Bitcoin ABC.
Aug 5 2020, 22:08
teamcity added a comment to D7137: Add proof-of-concept for submitblocksolution and block template manager.
Aug 5 2020, 21:59
Mengerian abandoned D2922: Add SIGPUSHONLY and CLEANSTACK to mandatory flags.
Aug 5 2020, 21:49
teamcity added a comment to D7137: Add proof-of-concept for submitblocksolution and block template manager.
Aug 5 2020, 21:45
jasonbcox requested review of D7137: Add proof-of-concept for submitblocksolution and block template manager.
Aug 5 2020, 21:41
Mengerian requested review of D7136: [website] Add update on George's departure from Bitcoin ABC.
Aug 5 2020, 21:15
majcosta updated the test plan for D7135: [backport#18417 3/3] tests: Add fuzzing harness for functions in net_permissions.h.
Aug 5 2020, 10:59
teamcity added a comment to D7135: [backport#18417 3/3] tests: Add fuzzing harness for functions in net_permissions.h.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 5 2020, 10:59
teamcity updated the summary of D7135: [backport#18417 3/3] tests: Add fuzzing harness for functions in net_permissions.h.
Aug 5 2020, 10:59
majcosta requested review of D7135: [backport#18417 3/3] tests: Add fuzzing harness for functions in net_permissions.h.
Aug 5 2020, 10:58
teamcity added a comment to D7134: [backport#18417 2/3] tests: Add fuzzing harness for functions in timedata.h.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Aug 5 2020, 10:58
teamcity updated the summary of D7134: [backport#18417 2/3] tests: Add fuzzing harness for functions in timedata.h.
Aug 5 2020, 10:57
majcosta requested review of D7134: [backport#18417 2/3] tests: Add fuzzing harness for functions in timedata.h.
Aug 5 2020, 10:57
majcosta updated the summary of D7132: [backport#18206] tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter).
Aug 5 2020, 10:56
majcosta updated the summary of D7133: [backport#18417 1/3] tests: Add fuzzing harness for functions in addrdb.h.
Aug 5 2020, 10:55
majcosta updated the summary of D7133: [backport#18417 1/3] tests: Add fuzzing harness for functions in addrdb.h.
Aug 5 2020, 10:54
majcosta requested review of D7133: [backport#18417 1/3] tests: Add fuzzing harness for functions in addrdb.h.
Aug 5 2020, 10:53
majcosta updated the test plan for D7132: [backport#18206] tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter).
Aug 5 2020, 10:52
majcosta requested review of D7132: [backport#18206] tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter).
Aug 5 2020, 09:59
• JesseSoule added a comment to T495: Fix bip65-cltv-p2p.py for post-fork conditions.
Aug 5 2020, 07:35
majcosta committed rABCf2d57b2aa768: [backport#16798] Refactor rawtransaction_util's SignTransaction to separate… (authored by fanquake <fanquake@gmail.com>).
[backport#16798] Refactor rawtransaction_util's SignTransaction to separate…
Aug 5 2020, 05:11
majcosta closed D7118: [backport#16798] Refactor rawtransaction_util's SignTransaction to separate prevtx parsing.
Aug 5 2020, 05:11
majcosta committed rABCa87b1b6c042e: [backport#17154 3/3][wallet] Remove `state` argument from CWallet… (authored by John Newbery <john@johnnewbery.com>).
[backport#17154 3/3][wallet] Remove `state` argument from CWallet…
Aug 5 2020, 05:08
majcosta closed D7114: [backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction.
Aug 5 2020, 05:08
majcosta committed rABC5e00d4893833: [backport#17154 2/3][wallet] Remove return value from CommitTransaction() (authored by John Newbery <john@johnnewbery.com>).
[backport#17154 2/3][wallet] Remove return value from CommitTransaction()
Aug 5 2020, 05:08
majcosta closed D7113: [backport#17154 2/3][wallet] Remove return value from CommitTransaction().
Aug 5 2020, 05:08
majcosta committed rABC973e07b9f458: [backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction() (authored by John Newbery <john@johnnewbery.com>).
[backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction()
Aug 5 2020, 05:08
majcosta closed D7112: [backport#17154 1/3][wallet] Add doxygen comment to CWallet::CommitTransaction().
Aug 5 2020, 05:07
majcosta committed rABC77d79c034ec9: [backport#15894 3/3] Make AbortNode() aware of MSG_NOPREFIX flag (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[backport#15894 3/3] Make AbortNode() aware of MSG_NOPREFIX flag
Aug 5 2020, 05:01
majcosta closed D7126: [backport#15894 3/3] Make AbortNode() aware of MSG_NOPREFIX flag.
Aug 5 2020, 05:01
majcosta committed rABC53fee36fe9ca: [backport#15894 2/3] Add MSG_NOPREFIX flag for user messages (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[backport#15894 2/3] Add MSG_NOPREFIX flag for user messages
Aug 5 2020, 05:00
majcosta closed D7125: [backport#15894 2/3] Add MSG_NOPREFIX flag for user messages.
Aug 5 2020, 05:00
majcosta committed rABC564f890228a4: [backport#15894 1/3] Prepend the error/warning prefix for GUI messages (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
[backport#15894 1/3] Prepend the error/warning prefix for GUI messages
Aug 5 2020, 04:59
majcosta closed D7124: [backport#15894 1/3] Prepend the error/warning prefix for GUI messages.
Aug 5 2020, 04:59
majcosta updated the diff for D7123: [backport#16383 3/3] tests: functional watch-only wallet tests.

included wallet_watchonly to test_runner.py list of --usecli compatible tests

Aug 5 2020, 04:58
majcosta requested review of D7119: [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes.

sry, added missing link to the commit

Aug 5 2020, 04:34
majcosta updated the summary of D7119: [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes.
Aug 5 2020, 04:34
jasonbcox updated the diff for D7131: Add top-level documentation index for serving docs by version.

Use the new generator to create the index

Aug 5 2020, 00:52
jasonbcox requested review of D7130: Add RPC commands indices, by version.
Aug 5 2020, 00:51
jasonbcox retitled D7130: Add RPC commands indices, by version from Add RPC commands index, by version to Add RPC commands indices, by version.
Aug 5 2020, 00:51
jasonbcox planned changes to D7130: Add RPC commands indices, by version.
Aug 5 2020, 00:13
jasonbcox updated the diff for D7130: Add RPC commands indices, by version.

Use a generator instead of relying on empty index templates to point at the layout file

Aug 5 2020, 00:06
jasonbcox abandoned D7129: Add layout to RPC doc template.

While true, at first glance it appeared this was a necessary evil because I couldn't find a way to generate a set of pages from one template. As it turns out, Jekyll does support generators, so this patch isn't necessary.

Aug 5 2020, 00:03
jasonbcox planned changes to D7131: Add top-level documentation index for serving docs by version.
Aug 5 2020, 00:02

Aug 4 2020

jasonbcox updated the diff for D7130: Add RPC commands indices, by version.

Fix indentation

Aug 4 2020, 22:58
jasonbcox committed rABCWEBeb1bad69148f: Make the doc directory a collection (authored by jasonbcox).
Make the doc directory a collection
Aug 4 2020, 22:53
jasonbcox closed D7127: Make the doc directory a collection.
Aug 4 2020, 22:53
deadalnix accepted D7114: [backport#17154 3/3][wallet] Remove `state` argument from CWallet::CommitTransaction.
Aug 4 2020, 22:49
deadalnix requested changes to D7119: [backport#17260 3/3] Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes.

Please point to the specific commit, please.

Aug 4 2020, 22:48
deadalnix accepted D7006: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file.
Aug 4 2020, 22:48
deadalnix requested changes to D7123: [backport#16383 3/3] tests: functional watch-only wallet tests.

You need to add the --usecli version of the test to the test runner.

Aug 4 2020, 22:43
deadalnix accepted D7122: [backport#16383 2/3] rpcwallet: document include_watchonly default for watchonly wallets.
Aug 4 2020, 22:42
deadalnix accepted D7121: [backport#16383 1/3] rpcwallet: default include_watchonly to true for watchonly wallets.
Aug 4 2020, 22:40
deadalnix accepted D7118: [backport#16798] Refactor rawtransaction_util's SignTransaction to separate prevtx parsing.
Aug 4 2020, 22:36
deadalnix requested changes to D7130: Add RPC commands indices, by version.
Aug 4 2020, 22:19