Page MenuHomePhabricator
Feed All Stories

Oct 2 2020

Fabien requested review of D7737: build: macOS toolchain simplification and bump.
Oct 2 2020, 11:29
majcosta requested review of D7736: [refactor] replace calls to Params() CWallet chainParams member.
Oct 2 2020, 10:34
Fabien accepted D7735: cli: remove duplicate wallet fields from -getinfo.
Oct 2 2020, 10:01
teamcity added a comment to D7735: cli: remove duplicate wallet fields from -getinfo.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 2 2020, 09:33
teamcity updated the summary of D7735: cli: remove duplicate wallet fields from -getinfo.
Oct 2 2020, 09:33
PiRK requested review of D7735: cli: remove duplicate wallet fields from -getinfo.
Oct 2 2020, 09:33
Fabien accepted D7734: cli: replace testnet with chain and return network name as per BIP70..
Oct 2 2020, 09:13
majcosta closed D7721: [backport#17617] doc: unify unix epoch time descriptions.
Oct 2 2020, 08:59
majcosta committed rABC807ed300fa95: [backport#17617] doc: unify unix epoch time descriptions (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#17617] doc: unify unix epoch time descriptions
Oct 2 2020, 08:59
PiRK closed D7730: [rpc] deriveaddresses: add range to CRPCConvertParam.
Oct 2 2020, 08:57
PiRK committed rABCb06d072c8a08: [rpc] deriveaddresses: add range to CRPCConvertParam (authored by Sjors Provoost <sjors@sprovoost.nl>).
[rpc] deriveaddresses: add range to CRPCConvertParam
Oct 2 2020, 08:57
PiRK added a comment to D7734: cli: replace testnet with chain and return network name as per BIP70..

Note that this breaks compatibility. If we want to maintain it (and diverge from Core on this point), it would be easy to keep also the testnet field.

Oct 2 2020, 08:56
teamcity added a comment to D7734: cli: replace testnet with chain and return network name as per BIP70..

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 2 2020, 08:55
teamcity updated the summary of D7734: cli: replace testnet with chain and return network name as per BIP70..
Oct 2 2020, 08:55
PiRK requested review of D7734: cli: replace testnet with chain and return network name as per BIP70..
Oct 2 2020, 08:55
Fabien accepted D7730: [rpc] deriveaddresses: add range to CRPCConvertParam.
Oct 2 2020, 08:32
Fabien requested review of D7733: Avoid dh_missing warnings when building the debian package.
Oct 2 2020, 08:28
Fabien requested review of D7732: Fix obsolete debian watch.
Oct 2 2020, 08:27
Fabien requested review of D7731: Add bitcoin-wallet to the debian package.
Oct 2 2020, 08:26
teamcity added a comment to D7730: [rpc] deriveaddresses: add range to CRPCConvertParam.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 2 2020, 08:09
teamcity updated the summary of D7730: [rpc] deriveaddresses: add range to CRPCConvertParam.
Oct 2 2020, 08:09
PiRK requested review of D7730: [rpc] deriveaddresses: add range to CRPCConvertParam.
Oct 2 2020, 08:09
PiRK closed D7714: remove some magic mining constants in functional tests.
Oct 2 2020, 07:03
PiRK committed rABC5abfa6f26e60: remove some magic mining constants in functional tests (authored by Gregory Sanders <gsanders87@gmail.com>).
remove some magic mining constants in functional tests
Oct 2 2020, 07:03
Fabien closed D7719: [CMAKE] Fix version mismatch during crosscompilation due to pkg-config.
Oct 2 2020, 06:13
Fabien committed rABC62a55c7b010d: [CMAKE] Fix version mismatch during crosscompilation due to pkg-config (authored by Fabien).
[CMAKE] Fix version mismatch during crosscompilation due to pkg-config
Oct 2 2020, 06:13
Fabien accepted D7721: [backport#17617] doc: unify unix epoch time descriptions.
Oct 2 2020, 05:59
teamcity closed T1076: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Oct 2 2020, 02:22
teamcity closed T1074: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Resolved.
Oct 2 2020, 02:19
teamcity closed T1073: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Resolved.
Oct 2 2020, 02:11
jasonbcox closed D7729: Revert recent coin selection changes.
Oct 2 2020, 02:03
jasonbcox added a reverting change for D7691: Merge #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs: rABC85f266319f58: Revert recent coin selection changes.
Oct 2 2020, 02:03
jasonbcox added a reverting change for D7674: Enable BnB coin selection for preset inputs and subtract fee from outputs: rABC85f266319f58: Revert recent coin selection changes.
Oct 2 2020, 02:03
jasonbcox added a reverting change for rABC28efd9a54daa: Enable BnB coin selection for preset inputs and subtract fee from outputs: rABC85f266319f58: Revert recent coin selection changes.
Oct 2 2020, 02:03
jasonbcox added a reverting change for rABC78322dfdfa3c: Merge #17568: wallet: fix when sufficient preset inputs and…: rABC85f266319f58: Revert recent coin selection changes.
Oct 2 2020, 02:03
jasonbcox committed rABC85f266319f58: Revert recent coin selection changes (authored by jasonbcox).
Revert recent coin selection changes
Oct 2 2020, 02:03
majcosta accepted D7729: Revert recent coin selection changes.
Oct 2 2020, 01:15
teamcity added a comment to D7729: Revert recent coin selection changes.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 2 2020, 00:19
teamcity updated the summary of D7729: Revert recent coin selection changes.
Oct 2 2020, 00:19
jasonbcox requested review of D7729: Revert recent coin selection changes.
Oct 2 2020, 00:18
jasonbcox added a reverting change for D7674: Enable BnB coin selection for preset inputs and subtract fee from outputs: D7729: Revert recent coin selection changes.
Oct 2 2020, 00:18
jasonbcox added a reverting change for D7691: Merge #17568: wallet: fix when sufficient preset inputs and subtractFeeFromOutputs: D7729: Revert recent coin selection changes.
Oct 2 2020, 00:18
jasonbcox added a reverting change for rABC28efd9a54daa: Enable BnB coin selection for preset inputs and subtract fee from outputs: D7729: Revert recent coin selection changes.
Oct 2 2020, 00:18
jasonbcox added a reverting change for rABC78322dfdfa3c: Merge #17568: wallet: fix when sufficient preset inputs and…: D7729: Revert recent coin selection changes.
Oct 2 2020, 00:18
majcosta closed D7728: [backport#17677] Activate watchonly wallet behavior for LegacySPKM only.
Oct 2 2020, 00:10
majcosta committed rABCd46fc5678d77: [backport#17677] Activate watchonly wallet behavior for LegacySPKM only (authored by Samuel Dobson <dobsonsa68@gmail.com>).
[backport#17677] Activate watchonly wallet behavior for LegacySPKM only
Oct 2 2020, 00:10

Oct 1 2020

jasonbcox added a comment to D7726: [gitian-builder] By default, cleanup the target after use.

Upstream PR: https://github.com/devrandom/gitian-builder/pull/234

Oct 1 2020, 23:54
jasonbcox accepted D7728: [backport#17677] Activate watchonly wallet behavior for LegacySPKM only.
Oct 1 2020, 23:51
teamcity added a comment to D7728: [backport#17677] Activate watchonly wallet behavior for LegacySPKM only.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 23:48
teamcity updated the summary of D7728: [backport#17677] Activate watchonly wallet behavior for LegacySPKM only.
Oct 1 2020, 23:48
majcosta requested review of D7728: [backport#17677] Activate watchonly wallet behavior for LegacySPKM only.
Oct 1 2020, 23:48
jasonbcox closed D7726: [gitian-builder] By default, cleanup the target after use.
Oct 1 2020, 23:47
jasonbcox committed rABCbe81abd457c5: [gitian-builder] By default, cleanup the target after use (authored by jasonbcox).
[gitian-builder] By default, cleanup the target after use
Oct 1 2020, 23:47
majcosta closed D7727: [backport#16944][gui] watch-only wallet: copy PSBT to clipboard.
Oct 1 2020, 23:45
majcosta committed rABCb4b259e248fe: [backport#16944][gui] watch-only wallet: copy PSBT to clipboard (authored by Sjors Provoost <sjors@sprovoost.nl>).
[backport#16944][gui] watch-only wallet: copy PSBT to clipboard
Oct 1 2020, 23:45
majcosta closed D7295: [backport#16944][wallet] add fillPSBT to interface.
Oct 1 2020, 23:44
majcosta committed rABC5624afe2348d: [backport#16944][wallet] add fillPSBT to interface (authored by Sjors Provoost <sjors@sprovoost.nl>).
[backport#16944][wallet] add fillPSBT to interface
Oct 1 2020, 23:44
majcosta closed D7294: [backport#16944][gui] send: include watch-only.
Oct 1 2020, 23:44
majcosta committed rABC6e86cfea3f69: [backport#16944][gui] send: include watch-only (authored by Sjors Provoost <sjors@sprovoost.nl>).
[backport#16944][gui] send: include watch-only
Oct 1 2020, 23:43
majcosta closed D7293: [backport#16944][wallet] ListCoins: include watch-only for wallets without private keys.
Oct 1 2020, 23:43
majcosta committed rABC19547733f17e: [backport#16944][wallet] ListCoins: include watch-only for wallets without… (authored by Sjors Provoost <sjors@sprovoost.nl>).
[backport#16944][wallet] ListCoins: include watch-only for wallets without…
Oct 1 2020, 23:43
deadalnix accepted D7726: [gitian-builder] By default, cleanup the target after use.
Oct 1 2020, 23:33
deadalnix accepted D7727: [backport#16944][gui] watch-only wallet: copy PSBT to clipboard.
Oct 1 2020, 23:32
teamcity added a comment to D7727: [backport#16944][gui] watch-only wallet: copy PSBT to clipboard.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 23:28
teamcity updated the summary of D7727: [backport#16944][gui] watch-only wallet: copy PSBT to clipboard.
Oct 1 2020, 23:28
majcosta requested review of D7727: [backport#16944][gui] watch-only wallet: copy PSBT to clipboard.
Oct 1 2020, 23:28
majcosta updated the diff for D7295: [backport#16944][wallet] add fillPSBT to interface.

rebase

Oct 1 2020, 23:26
jasonbcox requested review of D7726: [gitian-builder] By default, cleanup the target after use.
Oct 1 2020, 21:48
teamcity added a comment to D7721: [backport#17617] doc: unify unix epoch time descriptions.
Oct 1 2020, 21:38
teamcity added a comment to D7721: [backport#17617] doc: unify unix epoch time descriptions.
Oct 1 2020, 21:23
majcosta updated the summary of D7721: [backport#17617] doc: unify unix epoch time descriptions.
Oct 1 2020, 21:20
jasonbcox planned changes to D7725: [CI] Do not wait too long for build logs to flush.
Oct 1 2020, 21:17
teamcity added a comment to D7725: [CI] Do not wait too long for build logs to flush.
Oct 1 2020, 21:17
majcosta updated the diff for D7721: [backport#17617] doc: unify unix epoch time descriptions.

fixed formatting and squashed one-liner PR14981 into the diff

Oct 1 2020, 21:14
jasonbcox accepted D7719: [CMAKE] Fix version mismatch during crosscompilation due to pkg-config.
Oct 1 2020, 20:44
Fabien accepted D7725: [CI] Do not wait too long for build logs to flush.
Oct 1 2020, 20:36
jasonbcox requested review of D7725: [CI] Do not wait too long for build logs to flush.
Oct 1 2020, 20:36
majcosta closed D7722: [backport#17537] wallet: Cleanup and move opportunistic and superfluous TopUp()s.
Oct 1 2020, 20:29
majcosta committed rABC34b1f1fca4aa: [backport#17537] wallet: Cleanup and move opportunistic and superfluous TopUp()s (authored by fanquake <fanquake@gmail.com>).
[backport#17537] wallet: Cleanup and move opportunistic and superfluous TopUp()s
Oct 1 2020, 20:29
majcosta closed D7724: [backport#17578] rpc: simplify getaddressinfo labels, deprecate previous behavior.
Oct 1 2020, 20:28
majcosta committed rABCb615bbcd0a74: [backport#17578] rpc: simplify getaddressinfo labels, deprecate previous… (authored by Samuel Dobson <dobsonsa68@gmail.com>).
[backport#17578] rpc: simplify getaddressinfo labels, deprecate previous…
Oct 1 2020, 20:28
majcosta closed D7718: [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs.
Oct 1 2020, 20:26
majcosta committed rABCcc5951bf2a3b: [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#17283] rpc: improve getaddressinfo test coverage, help, code docs
Oct 1 2020, 20:26
majcosta closed D7716: [backport#13136] Fix flake8 warnings in several wallet functional tests.
Oct 1 2020, 20:25
majcosta committed rABC66978e85105c: [backport#13136] Fix flake8 warnings in several wallet functional tests (authored by majcosta).
[backport#13136] Fix flake8 warnings in several wallet functional tests
Oct 1 2020, 20:25
Fabien accepted D7716: [backport#13136] Fix flake8 warnings in several wallet functional tests.
Oct 1 2020, 20:22
jasonbcox requested review of D7725: [CI] Do not wait too long for build logs to flush.
Oct 1 2020, 20:00
jasonbcox planned changes to D7725: [CI] Do not wait too long for build logs to flush.
Oct 1 2020, 20:00
majcosta updated the diff for D7716: [backport#13136] Fix flake8 warnings in several wallet functional tests.

thanks for catching that, total oversight on my part

Oct 1 2020, 19:21
Fabien accepted D7724: [backport#17578] rpc: simplify getaddressinfo labels, deprecate previous behavior.
Oct 1 2020, 19:02
Fabien accepted D7722: [backport#17537] wallet: Cleanup and move opportunistic and superfluous TopUp()s.
Oct 1 2020, 18:57
Fabien requested changes to D7721: [backport#17617] doc: unify unix epoch time descriptions.
Oct 1 2020, 18:56
Fabien accepted D7718: [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs.
Oct 1 2020, 18:49
Fabien requested changes to D7716: [backport#13136] Fix flake8 warnings in several wallet functional tests.
Oct 1 2020, 18:43
Fabien updated the diff for D7719: [CMAKE] Fix version mismatch during crosscompilation due to pkg-config.

Rebase

Oct 1 2020, 18:36
Fabien updated the diff for D7720: [CMAKE] Drop dependency search for the native builds.

Rebase

Oct 1 2020, 18:35
teamcity added a comment to D7724: [backport#17578] rpc: simplify getaddressinfo labels, deprecate previous behavior.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Oct 1 2020, 18:28
teamcity updated the summary of D7724: [backport#17578] rpc: simplify getaddressinfo labels, deprecate previous behavior.
Oct 1 2020, 18:28
majcosta requested review of D7724: [backport#17578] rpc: simplify getaddressinfo labels, deprecate previous behavior.
Oct 1 2020, 18:28
majcosta updated the diff for D7718: [backport#17283] rpc: improve getaddressinfo test coverage, help, code docs.

rebase

Oct 1 2020, 18:19