Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Nov 25 2020

teamcity triaged T1275: Build Bitcoin-ABC / Master / Cross Builds / Cross Build OSX is broken. as Unbreak Now! priority.
Nov 25 2020, 16:56
teamcity triaged T1274: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Unbreak Now! priority.
Nov 25 2020, 16:55
Fabien closed D8526: rpc: Remove special case for unknown service flags.
Nov 25 2020, 16:55
Fabien committed rABC386a4de52df1: rpc: Remove special case for unknown service flags (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Remove special case for unknown service flags
Nov 25 2020, 16:55
teamcity triaged T1273: Build Bitcoin-ABC / Master / Benchmarking is broken. as Unbreak Now! priority.
Nov 25 2020, 16:54
teamcity triaged T1272: Build Bitcoin-ABC / Master / Build Documentation is broken. as Unbreak Now! priority.
Nov 25 2020, 16:53
teamcity triaged T1271: Build Bitcoin-ABC / Master / Clang 10 is broken. as Unbreak Now! priority.
Nov 25 2020, 16:53
deadalnix accepted D8526: rpc: Remove special case for unknown service flags.
Nov 25 2020, 16:52
teamcity triaged T1270: Build Bitcoin-ABC / Master / Build without CLI is broken. as Unbreak Now! priority.
Nov 25 2020, 16:50
teamcity triaged T1268: Build Bitcoin-ABC / Master / Build without BIP70 is broken. as Unbreak Now! priority.
Nov 25 2020, 16:50
teamcity triaged T1267: Build Bitcoin-ABC / Master / Build without Qt is broken. as Unbreak Now! priority.
Nov 25 2020, 16:49
teamcity triaged T1266: Build Bitcoin-ABC / Master / Build without Wallet is broken. as Unbreak Now! priority.
Nov 25 2020, 16:47
teamcity triaged T1265: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 32 is broken. as Unbreak Now! priority.
Nov 25 2020, 16:47
Fabien closed D8519: util: simplify the interface of serviceFlagToStr().
Nov 25 2020, 16:44
Fabien committed rABC3114174d8810: util: simplify the interface of serviceFlagToStr() (authored by Vasil Dimov <vd@FreeBSD.org>).
util: simplify the interface of serviceFlagToStr()
Nov 25 2020, 16:44
Fabien closed D8518: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function.
Nov 25 2020, 16:44
Fabien committed rABC81a1f3236ee4: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr… (authored by Luke Dashjr <luke-jr+git@utopios.org>).
Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr…
Nov 25 2020, 16:44
Fabien closed D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
Nov 25 2020, 16:43
Fabien committed rABC4a70e0886aef: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing (authored by Luke Dashjr <luke-jr+git@utopios.org>).
GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing
Nov 25 2020, 16:43
Fabien updated the diff for D8526: rpc: Remove special case for unknown service flags.

Rebase

Nov 25 2020, 16:41
Fabien updated the diff for D8519: util: simplify the interface of serviceFlagToStr().

Rebase

Nov 25 2020, 16:39
deadalnix accepted D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
Nov 25 2020, 16:38
Fabien updated the diff for D8518: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function.

Rebase

Nov 25 2020, 16:38
Fabien updated the diff for D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.

Backport the whole conditional display rendering

Nov 25 2020, 16:31
Fabien closed D8524: Drop the BITCOIN_CASH service bit.
Nov 25 2020, 16:24
Fabien committed rABC8788c6978ca6: Drop the BITCOIN_CASH service bit (authored by Fabien).
Drop the BITCOIN_CASH service bit
Nov 25 2020, 16:24
deadalnix requested changes to D8339: Move seed list vector operations into distinct compilation unit.

I have a hard time believing that you wrote that and said to yourself "this is rally the best that can be done here". You know better can be done.

Nov 25 2020, 16:23
deadalnix requested changes to D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
Nov 25 2020, 16:21
deadalnix requested changes to D8525: Fix a potential data race between CConman and the PeerLogicValidation.

If that can only happen at startup, then locking at every use is clearly not the way to go.

Nov 25 2020, 16:19
deadalnix requested changes to D8526: rpc: Remove special case for unknown service flags.

There is clearly a dependency missing.

Nov 25 2020, 16:14
teamcity updated the summary of D8526: rpc: Remove special case for unknown service flags.
Nov 25 2020, 15:58
Fabien requested review of D8526: rpc: Remove special case for unknown service flags.
Nov 25 2020, 15:58
PiRK accepted D8524: Drop the BITCOIN_CASH service bit.
Nov 25 2020, 15:38
teamcity awarded D8525: Fix a potential data race between CConman and the PeerLogicValidation a Haypence token.
Nov 25 2020, 14:46
Fabien added a comment to D8525: Fix a potential data race between CConman and the PeerLogicValidation.

@bot build-tsan

Nov 25 2020, 14:45
Fabien requested review of D8525: Fix a potential data race between CConman and the PeerLogicValidation.
Nov 25 2020, 14:40
jasminedisouza created T1264: Netflix Support 1-800-383-368 Number Australia – How to Set up Netflix.
Nov 25 2020, 13:31
Fabien added a comment to D8519: util: simplify the interface of serviceFlagToStr().

unrelated failure

Nov 25 2020, 09:14
teamcity added a comment to D8519: util: simplify the interface of serviceFlagToStr().
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
Nov 25 2020, 08:46
Fabien updated the diff for D8519: util: simplify the interface of serviceFlagToStr().

Rebase

Nov 25 2020, 08:21
Fabien updated the diff for D8518: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function.

Rebase

Nov 25 2020, 08:20
Fabien updated the diff for D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.

Rebase on top of D8524.

Nov 25 2020, 08:05
Fabien added inline comments to D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
Nov 25 2020, 08:04
Fabien updated the summary of D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
Nov 25 2020, 08:02
Fabien requested review of D8524: Drop the BITCOIN_CASH service bit.
Nov 25 2020, 07:45
Fabien updated the test plan for D8518: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function.
Nov 25 2020, 07:22
deadalnix added a comment to D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.

Sorry, I looked at the wrong PR. You need to explain or fix as per inline comments.

Nov 25 2020, 03:40
deadalnix accepted D8519: util: simplify the interface of serviceFlagToStr().
Nov 25 2020, 03:37
deadalnix accepted D8518: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function.
Nov 25 2020, 03:36
deadalnix requested changes to D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.

It seems like you have missing dependencies.

Nov 25 2020, 03:33
deadalnix accepted D8523: Merge #17096: gui: rename debug window.
Nov 25 2020, 02:54
teamcity updated the summary of D8523: Merge #17096: gui: rename debug window.
Nov 25 2020, 00:42
jasonbcox requested review of D8523: Merge #17096: gui: rename debug window.
Nov 25 2020, 00:42
jasonbcox closed D8522: [buildbot] Add missing deepmerge dependency.
Nov 25 2020, 00:26
jasonbcox committed rABC2454e5c55741: [buildbot] Add missing deepmerge dependency (authored by jasonbcox).
[buildbot] Add missing deepmerge dependency
Nov 25 2020, 00:26
majcosta accepted D8522: [buildbot] Add missing deepmerge dependency.
Nov 25 2020, 00:24
jasonbcox requested review of D8522: [buildbot] Add missing deepmerge dependency.
Nov 25 2020, 00:24
Fabien updated the diff for D8519: util: simplify the interface of serviceFlagToStr().

Rebase

Nov 25 2020, 00:12

Nov 24 2020

Fabien closed D8520: Make the buildbot aware of the configuration templates.
Nov 24 2020, 23:48
Fabien committed rABC35ded6590a64: Make the buildbot aware of the configuration templates (authored by Fabien).
Make the buildbot aware of the configuration templates
Nov 24 2020, 23:48
jasonbcox accepted D8520: Make the buildbot aware of the configuration templates.
Nov 24 2020, 23:27
Fabien updated the diff for D8520: Make the buildbot aware of the configuration templates.

Fix an indentation issue, add a test

Nov 24 2020, 23:25
Fabien planned changes to D8520: Make the buildbot aware of the configuration templates.
Nov 24 2020, 23:01
Fabien requested review of D8520: Make the buildbot aware of the configuration templates.
Nov 24 2020, 22:58
Fabien added inline comments to D8518: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function.
Nov 24 2020, 22:47
teamcity updated the summary of D8519: util: simplify the interface of serviceFlagToStr().
Nov 24 2020, 22:46
Fabien requested review of D8519: util: simplify the interface of serviceFlagToStr().
Nov 24 2020, 22:46
teamcity updated the summary of D8518: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function.
Nov 24 2020, 22:00
Fabien requested review of D8518: Consolidate service flag bit-to-name conversion to a shared serviceFlagToStr function.
Nov 24 2020, 22:00
jasonbcox updated the diff for D8339: Move seed list vector operations into distinct compilation unit.

Rebase

Nov 24 2020, 21:49
Fabien updated the summary of D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
Nov 24 2020, 21:30
Fabien updated the diff for D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.

Make the code closer to code so the later backports are easier to review

Nov 24 2020, 21:29
Fabien planned changes to D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
Nov 24 2020, 21:16
Fabien closed D8517: Don't specify the C++ standard explicitely for Cppcheck.
Nov 24 2020, 21:01
jasonbcox accepted D8517: Don't specify the C++ standard explicitely for Cppcheck.
Nov 24 2020, 21:01
Fabien committed rABC725cad26a56a: Don't specify the C++ standard explicitely for Cppcheck (authored by Fabien).
Don't specify the C++ standard explicitely for Cppcheck
Nov 24 2020, 21:01
majcosta accepted D8517: Don't specify the C++ standard explicitely for Cppcheck.
Nov 24 2020, 20:58
Fabien requested review of D8517: Don't specify the C++ standard explicitely for Cppcheck.
Nov 24 2020, 20:53
teamcity updated the summary of D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
Nov 24 2020, 20:48
Fabien requested review of D8516: GUI: Refactor formatServicesStr to warn when a ServicesFlag is missing.
Nov 24 2020, 20:47
johnkuney closed D8511: Edits to BCHA page.
Nov 24 2020, 13:59
johnkuney committed rABCWEBae97c8e2cca1: Edits to BCHA page (authored by johnkuney).
Edits to BCHA page
Nov 24 2020, 13:59
Fabien closed D8515: [protocol] Remove unused CADDR_TIME_VERSION.
Nov 24 2020, 13:42
Fabien committed rABC678e25812f4d: [protocol] Remove unused CADDR_TIME_VERSION (authored by John Newbery <john@johnnewbery.com>).
[protocol] Remove unused CADDR_TIME_VERSION
Nov 24 2020, 13:42
deadalnix accepted D8515: [protocol] Remove unused CADDR_TIME_VERSION.
Nov 24 2020, 13:20
Fabien closed D8514: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater.
Nov 24 2020, 13:18
Fabien committed rABCb3acb54e6ca1: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater (authored by Ben Woosley <ben.woosley@gmail.com>).
Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater
Nov 24 2020, 13:18
Fabien closed D8513: net: improve code documentation for dns seed behaviour.
Nov 24 2020, 13:18
Fabien committed rABCfefbdfffdeaa: net: improve code documentation for dns seed behaviour (authored by Anthony Towns <aj@erisian.com.au>).
net: improve code documentation for dns seed behaviour
Nov 24 2020, 13:17
Fabien closed D8512: DNS seeds: wait for 5m instead of 11s if 1000+ peers are known.
Nov 24 2020, 13:17
Fabien committed rABCebbaf0f25cdb: DNS seeds: wait for 5m instead of 11s if 1000+ peers are known (authored by Anthony Towns <aj@erisian.com.au>).
DNS seeds: wait for 5m instead of 11s if 1000+ peers are known
Nov 24 2020, 13:17
teamcity updated the summary of D8515: [protocol] Remove unused CADDR_TIME_VERSION.
Nov 24 2020, 13:16
Fabien requested review of D8515: [protocol] Remove unused CADDR_TIME_VERSION.
Nov 24 2020, 13:16
deadalnix accepted D8514: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater.
Nov 24 2020, 13:01
deadalnix accepted D8513: net: improve code documentation for dns seed behaviour.
Nov 24 2020, 13:00
teamcity updated the summary of D8514: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater.
Nov 24 2020, 13:00
Fabien requested review of D8514: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater.
Nov 24 2020, 13:00
deadalnix accepted D8512: DNS seeds: wait for 5m instead of 11s if 1000+ peers are known.
Nov 24 2020, 12:59
teamcity updated the summary of D8513: net: improve code documentation for dns seed behaviour.
Nov 24 2020, 12:21
Fabien requested review of D8513: net: improve code documentation for dns seed behaviour.
Nov 24 2020, 12:21
First
Prev
Next