Page MenuHomePhabricator
Feed All Stories

Jan 25 2021

Joey King <joseph.roy.king@gmail.com> committed rABC89e3cfb7e5e6: [Cashtab] Match app send min to backend send min with constant (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Match app send min to backend send min with constant
Jan 25 2021, 15:09
PiRK updated the diff for D9042: test: Add mempool_updatefromblock.py.

adjust the batch size from 25 to 50, to account for ABC's DEFAULT_ANCESTOR_LIMIT.

Jan 25 2021, 14:53
teamcity added a comment to D9051: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix.
Jan 25 2021, 14:53
PiRK accepted D9052: [Cashtab] Match app send min to backend send min with constant.
Jan 25 2021, 13:40
PiRK accepted D9051: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix.
Jan 25 2021, 13:37
PiRK accepted D9050: tests: Add fuzzing harness for MessageSign, MessageVerify and other functions in util/message.h.

Code looks good. It probably a good idea to restart the tests after the CI is fixed.

Jan 25 2021, 13:26
bytesofman requested review of D9052: [Cashtab] Match app send min to backend send min with constant.
Jan 25 2021, 12:34
teamcity updated the summary of D9051: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix.
Jan 25 2021, 11:26
Fabien requested review of D9051: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix.
Jan 25 2021, 11:25
PiRK accepted D9048: [net_processing] Move SendBlockTransactions into PeerManager.
Jan 25 2021, 11:15
PiRK accepted D9047: [net processing] Move MaybePunishPeerForTx to PeerManager.
Jan 25 2021, 11:13
PiRK updated the diff for D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.

rebase onto master to fix conflict with D8975 (BLOCKS + 1)

Jan 25 2021, 11:11
teamcity updated the summary of D9050: tests: Add fuzzing harness for MessageSign, MessageVerify and other functions in util/message.h.
Jan 25 2021, 10:30
Fabien requested review of D9050: tests: Add fuzzing harness for MessageSign, MessageVerify and other functions in util/message.h.
Jan 25 2021, 10:30
teamcity updated the summary of D9049: [net processing] Move Misbehaving() to PeerManager.
Jan 25 2021, 10:06
Fabien requested review of D9049: [net processing] Move Misbehaving() to PeerManager.
Jan 25 2021, 10:05
teamcity updated the summary of D9048: [net_processing] Move SendBlockTransactions into PeerManager.
Jan 25 2021, 09:51
Fabien requested review of D9048: [net_processing] Move SendBlockTransactions into PeerManager.
Jan 25 2021, 09:51
teamcity updated the summary of D9047: [net processing] Move MaybePunishPeerForTx to PeerManager.
Jan 25 2021, 09:38
Fabien requested review of D9047: [net processing] Move MaybePunishPeerForTx to PeerManager.
Jan 25 2021, 09:38

Jan 24 2021

Unknown Object (User) added a comment to T205: Create constructor for SigHashType(BaseSigHashType).
Jan 24 2021, 14:54 ยท Bootcamp

Jan 23 2021

deadalnix accepted D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 23 2021, 20:50
Joey King <joseph.roy.king@gmail.com> closed D9045: [Cashtab] Implement BigNumber.js for crypto amounts.
Jan 23 2021, 15:36
Joey King <joseph.roy.king@gmail.com> committed rABC5f96006ad6df: [Cashtab] Implement BigNumber.js for crypto amounts (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Implement BigNumber.js for crypto amounts
Jan 23 2021, 15:36
Fabien closed D9044: [net processing] Move ProcessOrphanTx to PeerManager.
Jan 23 2021, 15:24
Fabien committed rABC94c2f558ee2a: [net processing] Move ProcessOrphanTx to PeerManager (authored by John Newbery <john@johnnewbery.com>).
[net processing] Move ProcessOrphanTx to PeerManager
Jan 23 2021, 15:24
Fabien closed D9043: [net processing] Move MaybePunishNodeForBlock into PeerManager.
Jan 23 2021, 15:15
Fabien committed rABC0225d4f0ef04: [net processing] Move MaybePunishNodeForBlock into PeerManager (authored by John Newbery <john@johnnewbery.com>).
[net processing] Move MaybePunishNodeForBlock into PeerManager
Jan 23 2021, 15:15
bytesofman updated the diff for D9045: [Cashtab] Implement BigNumber.js for crypto amounts.

Fix typo in comment, "more" to "no more"

Jan 23 2021, 15:13
Fabien closed D9038: [net processing] Move ProcessHeadersMessage to PeerManager.
Jan 23 2021, 15:05
Fabien committed rABC6a28c545f1bd: [net processing] Move ProcessHeadersMessage to PeerManager (authored by John Newbery <john@johnnewbery.com>).
[net processing] Move ProcessHeadersMessage to PeerManager
Jan 23 2021, 15:05
Fabien closed D9037: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager.
Jan 23 2021, 15:05
Fabien committed rABC09281847a858: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager (authored by John Newbery <john@johnnewbery.com>).
scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager
Jan 23 2021, 15:04
Fabien accepted D9045: [Cashtab] Implement BigNumber.js for crypto amounts.
Jan 23 2021, 15:03
bytesofman updated the diff for D9045: [Cashtab] Implement BigNumber.js for crypto amounts.

Clarify comment in function

Jan 23 2021, 10:35
bytesofman updated the diff for D9045: [Cashtab] Implement BigNumber.js for crypto amounts.

Ensure function fiatToCrypto returns a string, add unit test

Jan 23 2021, 10:34
PiRK accepted D9037: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager.
Jan 23 2021, 06:08
Mengerian closed D9046: Add Trunk Based Development link to CONTRIBUTING.
Jan 23 2021, 02:10
Mengerian committed rABC42c418fa9977: Add Trunk Based Development link to CONTRIBUTING (authored by Mengerian).
Add Trunk Based Development link to CONTRIBUTING
Jan 23 2021, 02:09
deadalnix accepted D9046: Add Trunk Based Development link to CONTRIBUTING.
Jan 23 2021, 00:25
Mengerian requested review of D9046: Add Trunk Based Development link to CONTRIBUTING.
Jan 23 2021, 00:15

Jan 22 2021

deadalnix requested changes to D8899: Check for overflow when calculating sum of outputs.
Jan 22 2021, 23:06
deadalnix abandoned D8811: [cashtab] Upgrade node modules.
Jan 22 2021, 23:00
Fabien updated the diff for D9037: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager.

Fix the fuzzer

Jan 22 2021, 19:36
Fabien requested changes to D9042: test: Add mempool_updatefromblock.py.
Jan 22 2021, 19:21
Fabien requested changes to D9045: [Cashtab] Implement BigNumber.js for crypto amounts.
Jan 22 2021, 19:15
bytesofman updated the diff for D9045: [Cashtab] Implement BigNumber.js for crypto amounts.

Ensure testedAmount is still validated as a BigNumber if user selected USD

Jan 22 2021, 17:14
bytesofman updated the diff for D9045: [Cashtab] Implement BigNumber.js for crypto amounts.

Remove unused BigNumber.js import from validation.test.js

Jan 22 2021, 17:08
bytesofman requested review of D9045: [Cashtab] Implement BigNumber.js for crypto amounts.
Jan 22 2021, 17:06
PiRK closed D9041: bench: Start nodes with -nodebuglogfile.
Jan 22 2021, 16:41
PiRK committed rABCf0889488b2a5: bench: Start nodes with -nodebuglogfile (authored by MarcoFalke <falke.marco@gmail.com>).
bench: Start nodes with -nodebuglogfile
Jan 22 2021, 16:41
PiRK closed D9040: bench: Remove requirement that all benches use same testing setup.
Jan 22 2021, 16:28
PiRK committed rABC57776826d3aa: bench: Remove requirement that all benches use same testing setup (authored by MarcoFalke <falke.marco@gmail.com>).
bench: Remove requirement that all benches use same testing setup
Jan 22 2021, 16:28
PiRK accepted D9044: [net processing] Move ProcessOrphanTx to PeerManager.
Jan 22 2021, 16:25
Joey King <joseph.roy.king@gmail.com> closed D9021: [Cashtab] Add unit tests for send BCHA amount validation.
Jan 22 2021, 16:24
Joey King <joseph.roy.king@gmail.com> committed rABC048b9b0884bc: [Cashtab] Add unit tests for send BCHA amount validation (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Add unit tests for send BCHA amount validation
Jan 22 2021, 16:24
PiRK requested review of D9042: test: Add mempool_updatefromblock.py.

correct PR number

Jan 22 2021, 16:19
PiRK updated the summary of D9042: test: Add mempool_updatefromblock.py.
Jan 22 2021, 16:19
PiRK accepted D9043: [net processing] Move MaybePunishNodeForBlock into PeerManager.
Jan 22 2021, 16:18
PiRK added inline comments to D9037: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager.
Jan 22 2021, 16:15
PiRK requested changes to D9037: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager.

<s>The code looks good. I don't understand the failures, maybe you should rebase.</s>
I didn't look closely enough at the fuzzer failure. See inline comment.

Jan 22 2021, 16:12
teamcity updated the summary of D9044: [net processing] Move ProcessOrphanTx to PeerManager.
Jan 22 2021, 16:03
Fabien requested review of D9044: [net processing] Move ProcessOrphanTx to PeerManager.
Jan 22 2021, 16:03
teamcity updated the summary of D9043: [net processing] Move MaybePunishNodeForBlock into PeerManager.
Jan 22 2021, 15:56
Fabien requested review of D9043: [net processing] Move MaybePunishNodeForBlock into PeerManager.
Jan 22 2021, 15:56
Fabien requested changes to D9042: test: Add mempool_updatefromblock.py.

Please check the PR #

Jan 22 2021, 15:51
Fabien accepted D9041: bench: Start nodes with -nodebuglogfile.
Jan 22 2021, 15:50
Fabien accepted D9040: bench: Remove requirement that all benches use same testing setup.
Jan 22 2021, 15:50
Fabien updated the summary of D9041: bench: Start nodes with -nodebuglogfile.
Jan 22 2021, 15:46
Fabien accepted D9021: [Cashtab] Add unit tests for send BCHA amount validation.
Jan 22 2021, 15:42
teamcity updated the summary of D9042: test: Add mempool_updatefromblock.py.
Jan 22 2021, 15:30
PiRK requested review of D9042: test: Add mempool_updatefromblock.py.
Jan 22 2021, 15:29
teamcity updated the summary of D9041: bench: Start nodes with -nodebuglogfile.
Jan 22 2021, 15:03
PiRK requested review of D9041: bench: Start nodes with -nodebuglogfile.
Jan 22 2021, 15:03
Fabien closed D9039: Bump version to 0.22.13.
Jan 22 2021, 14:37
Fabien committed rABCee2b8181a061: Bump version to 0.22.13 (authored by Fabien).
Bump version to 0.22.13
Jan 22 2021, 14:37
PiRK updated the summary of D9040: bench: Remove requirement that all benches use same testing setup.
Jan 22 2021, 14:30
majcosta accepted D9039: Bump version to 0.22.13.
Jan 22 2021, 14:27
teamcity updated the summary of D9040: bench: Remove requirement that all benches use same testing setup.
Jan 22 2021, 14:19
PiRK requested review of D9040: bench: Remove requirement that all benches use same testing setup.
Jan 22 2021, 14:19
Fabien requested review of D9039: Bump version to 0.22.13.
Jan 22 2021, 14:10
PiRK accepted D9038: [net processing] Move ProcessHeadersMessage to PeerManager.
Jan 22 2021, 13:34
teamcity updated the summary of D9038: [net processing] Move ProcessHeadersMessage to PeerManager.
Jan 22 2021, 13:06
Fabien requested review of D9038: [net processing] Move ProcessHeadersMessage to PeerManager.
Jan 22 2021, 13:05
PiRK accepted D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.
Jan 22 2021, 12:29
teamcity added a comment to D9037: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager.
Jan 22 2021, 12:16
teamcity added a comment to D9037: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager.
Jan 22 2021, 12:10
bytesofman updated the diff for D9021: [Cashtab] Add unit tests for send BCHA amount validation.

Function rename in Send.js

Jan 22 2021, 12:02
Fabien closed D9015: test: Add fuzzing harnesses for various classes/functions in util/.
Jan 22 2021, 11:56
Fabien committed rABC90e448c74dc5: test: Add fuzzing harnesses for various classes/functions in util/ (authored by practicalswift <practicalswift@users.noreply.github.com>).
test: Add fuzzing harnesses for various classes/functions in util/
Jan 22 2021, 11:56
Fabien requested changes to D9021: [Cashtab] Add unit tests for send BCHA amount validation.
Jan 22 2021, 11:54
teamcity added a comment to D9021: [Cashtab] Add unit tests for send BCHA amount validation.
Jan 22 2021, 11:53
teamcity updated the summary of D9037: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager.
Jan 22 2021, 11:51
Fabien requested review of D9037: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager.
Jan 22 2021, 11:50
majcosta updated the diff for D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.

rebase

Jan 22 2021, 11:36
bytesofman updated the diff for D9021: [Cashtab] Add unit tests for send BCHA amount validation.

Make all test inputs strings, better function name for validation method

Jan 22 2021, 11:35
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

rebase

Jan 22 2021, 11:35
PiRK requested changes to D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.

Code looks good. But you removed the executable flag for the functional test file.

Jan 22 2021, 11:28
PiRK closed D9036: [trivial/doc] Fix comment type.
Jan 22 2021, 11:21
PiRK committed rABC9be10274eb75: [trivial/doc] Fix comment type (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[trivial/doc] Fix comment type
Jan 22 2021, 11:21