- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 26 2021
investigate failure
giving this a whirl
rebase from hell
already done, abandoning
Note to reviewers: I don't like adding new pages to the root, but so far I failed to move them to another directory due to various issues with Jekyll linkage. I'll keep working on this.
Before this diff I would cause a test failure by changing the default fee, which is bad.
After this diff I would cause 3 test failures by changing the default fee, which is worst.
We can take yours, it has additional code style improvements. I chose not to change the quotes to single quotes in my backport, which lead the linter not to fix those lines.
I would just put the comments on their own lines in the new function in test_node.py
Jan 25 2021
@bot build-debug
rebase
Removing comment with hardcoded 8
There is a .decimals parameter for token utxos, which can be between 0 and 9 inclusive depending on the SLPA token. I wanted to avoid duplicating this key, which is used directly on the SendToken.js page.
Why did you choose to call it currency.cashDecimals and not just currency.decimals ? Could it be confused with something else ?
add tests for the case of a sum of outputs equal to MAX_MONEY, which is a valid case.
Fix comment
Replace '8' with currency.cashDecimals in validation error msg
Implemented in other diffs