Page MenuHomePhabricator
Feed All Stories

Jan 26 2021

PiRK updated the summary of D9067: rpc: Do not advertise dumptxoutset as a way to flush the chainstate.
Jan 26 2021, 17:52
PiRK updated the summary of D9065: test: fix message for ECC_InitSanityCheck test.
Jan 26 2021, 17:52
PiRK updated the summary of D9064: fix: update rest info on block size and json.
Jan 26 2021, 17:51
teamcity updated the summary of D9068: test: use unittest and test_runner for test framework unit testing.
Jan 26 2021, 17:51
PiRK requested review of D9068: test: use unittest and test_runner for test framework unit testing.
Jan 26 2021, 17:51
PiRK closed D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 26 2021, 17:44
PiRK committed rABCbd45ab5e8e22: test: add wait_for_cookie_credentials() to framework for rpcwait tests (authored by Jon Atack <jon@atack.com>).
test: add wait_for_cookie_credentials() to framework for rpcwait tests
Jan 26 2021, 17:44
majcosta planned changes to D9066: [backport#18727] test: Add CreateWalletFromFile test.

investigate failure

Jan 26 2021, 17:33
PiRK accepted D9066: [backport#18727] test: Add CreateWalletFromFile test.
Jan 26 2021, 17:28
teamcity added a comment to D9066: [backport#18727] test: Add CreateWalletFromFile test.
Jan 26 2021, 17:24
majcosta planned changes to D8671: Add a --descriptors option to various tests.
Jan 26 2021, 17:14
PiRK requested review of D9067: rpc: Do not advertise dumptxoutset as a way to flush the chainstate.
Jan 26 2021, 17:12
teamcity updated the summary of D9066: [backport#18727] test: Add CreateWalletFromFile test.
Jan 26 2021, 17:11
majcosta requested review of D9066: [backport#18727] test: Add CreateWalletFromFile test.
Jan 26 2021, 17:11
PiRK requested review of D9065: test: fix message for ECC_InitSanityCheck test.
Jan 26 2021, 17:08
teamcity updated the summary of D9064: fix: update rest info on block size and json.
Jan 26 2021, 17:03
PiRK requested review of D9064: fix: update rest info on block size and json.
Jan 26 2021, 17:03
majcosta commandeered D8671: Add a --descriptors option to various tests.

giving this a whirl

Jan 26 2021, 16:57
teamcity added a comment to D8671: Add a --descriptors option to various tests.
Jan 26 2021, 16:47
teamcity added a comment to D8671: Add a --descriptors option to various tests.
Jan 26 2021, 16:43
deadalnix updated the diff for D8671: Add a --descriptors option to various tests.

rebase from hell

Jan 26 2021, 16:32
Fabien closed D9063: tests: Add fuzzing harness for CCoinsViewCache.
Jan 26 2021, 16:02
Fabien committed rABC6332444c073f: tests: Add fuzzing harness for CCoinsViewCache (authored by practicalswift <practicalswift@users.noreply.github.com>).
tests: Add fuzzing harness for CCoinsViewCache
Jan 26 2021, 16:02
PiRK accepted D9063: tests: Add fuzzing harness for CCoinsViewCache.
Jan 26 2021, 15:28
Fabien closed D9062: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers).
Jan 26 2021, 15:16
Fabien committed rABCd87c0e81140a: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers) (authored by practicalswift <practicalswift@users.noreply.github.com>).
tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers)
Jan 26 2021, 15:16
Fabien closed D9058: [WEBSITE] Add a logos page.
Jan 26 2021, 15:03
Fabien committed rABCWEB194bbdc05751: [WEBSITE] Add a logos page (authored by Fabien).
[WEBSITE] Add a logos page
Jan 26 2021, 15:03
abc-bot committed rABC0319a075f6fb: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Jan 26 2021, 14:56
teamcity updated the summary of D9063: tests: Add fuzzing harness for CCoinsViewCache.
Jan 26 2021, 14:43
Fabien requested review of D9063: tests: Add fuzzing harness for CCoinsViewCache.
Jan 26 2021, 14:42
majcosta accepted D9062: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers).
Jan 26 2021, 13:52
majcosta accepted D9058: [WEBSITE] Add a logos page.
Jan 26 2021, 13:04
teamcity updated the summary of D9062: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers).
Jan 26 2021, 12:41
Fabien requested review of D9062: tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers).
Jan 26 2021, 12:41
Fabien closed D9061: tests: Fill fuzzing coverage gaps for functions in primitives/block.h.
Jan 26 2021, 12:33
Fabien committed rABCf1300adec374: tests: Fill fuzzing coverage gaps for functions in primitives/block.h (authored by practicalswift <practicalswift@users.noreply.github.com>).
tests: Fill fuzzing coverage gaps for functions in primitives/block.h
Jan 26 2021, 12:33
Fabien closed D9060: fuzz: use std::optional for sep_pos variable.
Jan 26 2021, 12:32
Fabien committed rABC04e0fd2b3eff: fuzz: use std::optional for sep_pos variable (authored by Harris <brakmic@gmail.com>).
fuzz: use std::optional for sep_pos variable
Jan 26 2021, 12:32
Fabien closed D9059: fuzz: fix vector size problem in system fuzzer.
Jan 26 2021, 12:32
Fabien committed rABCeb81b068cd88: fuzz: fix vector size problem in system fuzzer (authored by Harris <brakmic@gmail.com>).
fuzz: fix vector size problem in system fuzzer
Jan 26 2021, 12:32
PiRK accepted D9061: tests: Fill fuzzing coverage gaps for functions in primitives/block.h.
Jan 26 2021, 12:31
majcosta abandoned D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.

already done, abandoning

Jan 26 2021, 12:29
PiRK accepted D9060: fuzz: use std::optional for sep_pos variable.
Jan 26 2021, 12:27
PiRK accepted D9059: fuzz: fix vector size problem in system fuzzer.
Jan 26 2021, 12:25
teamcity updated the summary of D9061: tests: Fill fuzzing coverage gaps for functions in primitives/block.h.
Jan 26 2021, 11:31
Fabien requested review of D9061: tests: Fill fuzzing coverage gaps for functions in primitives/block.h.
Jan 26 2021, 11:31
teamcity added a comment to D9060: fuzz: use std::optional for sep_pos variable.
Jan 26 2021, 11:23
teamcity updated the summary of D9060: fuzz: use std::optional for sep_pos variable.
Jan 26 2021, 10:57
Fabien requested review of D9060: fuzz: use std::optional for sep_pos variable.
Jan 26 2021, 10:57
teamcity updated the summary of D9059: fuzz: fix vector size problem in system fuzzer.
Jan 26 2021, 10:48
Fabien requested review of D9059: fuzz: fix vector size problem in system fuzzer.
Jan 26 2021, 10:47
Fabien added a comment to D9058: [WEBSITE] Add a logos page.

Note to reviewers: I don't like adding new pages to the root, but so far I failed to move them to another directory due to various issues with Jekyll linkage. I'll keep working on this.

Jan 26 2021, 10:30
Fabien requested changes to D9056: [Cashtab] Add unit tests for function that sends BCHA.

Before this diff I would cause a test failure by changing the default fee, which is bad.
After this diff I would cause 3 test failures by changing the default fee, which is worst.

Jan 26 2021, 10:28
Fabien requested review of D9058: [WEBSITE] Add a logos page.
Jan 26 2021, 10:21
PiRK requested changes to D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 26 2021, 07:32
PiRK added a comment to D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.

We can take yours, it has additional code style improvements. I chose not to change the quotes to single quotes in my backport, which lead the linter not to fix those lines.
I would just put the comments on their own lines in the new function in test_node.py

Jan 26 2021, 07:29
Fabien closed D9051: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix.
Jan 26 2021, 07:28
Fabien committed rABCf614ca7395fd: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix
Jan 26 2021, 07:28
Fabien closed D9049: [net processing] Move Misbehaving() to PeerManager.
Jan 26 2021, 07:27
Fabien committed rABC245041dc2324: [net processing] Move Misbehaving() to PeerManager (authored by John Newbery <john@johnnewbery.com>).
[net processing] Move Misbehaving() to PeerManager
Jan 26 2021, 07:27
PiRK added a comment to D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.

D8947

Jan 26 2021, 07:20

Jan 25 2021

teamcity added a comment to D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 25 2021, 23:23
teamcity updated the summary of D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 25 2021, 22:57
majcosta requested review of D9057: [backport#18691] test: add wait_for_cookie_credentials() to framework for rpcwait tests.
Jan 25 2021, 22:57
bytesofman requested review of D9056: [Cashtab] Add unit tests for function that sends BCHA.
Jan 25 2021, 22:14
Fabien closed D9055: Improve asmap checks and add sanity check.
Jan 25 2021, 21:37
Fabien committed rABCeda85704fcd2: Improve asmap checks and add sanity check (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Improve asmap checks and add sanity check
Jan 25 2021, 21:37
Fabien closed D9050: tests: Add fuzzing harness for MessageSign, MessageVerify and other functions in util/message.h.
Jan 25 2021, 21:35
Fabien committed rABC15eb13e42302: tests: Add fuzzing harness for MessageSign, MessageVerify and other functions… (authored by practicalswift <practicalswift@users.noreply.github.com>).
tests: Add fuzzing harness for MessageSign, MessageVerify and other functions…
Jan 25 2021, 21:35
Fabien closed D9048: [net_processing] Move SendBlockTransactions into PeerManager.
Jan 25 2021, 21:28
Fabien committed rABC86c08ac05463: [net_processing] Move SendBlockTransactions into PeerManager (authored by John Newbery <john@johnnewbery.com>).
[net_processing] Move SendBlockTransactions into PeerManager
Jan 25 2021, 21:28
teamcity closed T1468: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 32 is broken. as Resolved.
Jan 25 2021, 19:02
majcosta accepted D9049: [net processing] Move Misbehaving() to PeerManager.
Jan 25 2021, 18:49
Joey King <joseph.roy.king@gmail.com> closed D9054: [Cashtab] replace BCHA decimal unit with a constant.
Jan 25 2021, 18:34
Joey King <joseph.roy.king@gmail.com> committed rABCe06b0ec4e874: [Cashtab] replace BCHA decimal unit with a constant (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] replace BCHA decimal unit with a constant
Jan 25 2021, 18:34
teamcity awarded D9049: [net processing] Move Misbehaving() to PeerManager a Haypence token.
Jan 25 2021, 18:17
majcosta added a comment to D9049: [net processing] Move Misbehaving() to PeerManager.

@bot build-debug

Jan 25 2021, 18:17
teamcity triaged T1468: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 32 is broken. as Unbreak Now! priority.
Jan 25 2021, 17:52
PiRK closed D9042: test: Add mempool_updatefromblock.py.
Jan 25 2021, 17:28
PiRK committed rABC4a29fe3f7a60: test: Add mempool_updatefromblock.py (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
test: Add mempool_updatefromblock.py
Jan 25 2021, 17:28
Fabien accepted D9054: [Cashtab] replace BCHA decimal unit with a constant.
Jan 25 2021, 17:27
PiRK updated the diff for D8947: test: add wait_for_cookie_credentials() to framework for rpcwait tests.

rebase

Jan 25 2021, 17:13
PiRK accepted D9055: Improve asmap checks and add sanity check.
Jan 25 2021, 16:57
teamcity added a comment to D9049: [net processing] Move Misbehaving() to PeerManager.
Jan 25 2021, 16:52
bytesofman updated the diff for D9054: [Cashtab] replace BCHA decimal unit with a constant.

Removing comment with hardcoded 8

Jan 25 2021, 16:49
Fabien closed D9047: [net processing] Move MaybePunishPeerForTx to PeerManager.
Jan 25 2021, 16:49
Fabien committed rABC7330ea64ea09: [net processing] Move MaybePunishPeerForTx to PeerManager (authored by John Newbery <john@johnnewbery.com>).
[net processing] Move MaybePunishPeerForTx to PeerManager
Jan 25 2021, 16:49
bytesofman added a comment to D9054: [Cashtab] replace BCHA decimal unit with a constant.

There is a .decimals parameter for token utxos, which can be between 0 and 9 inclusive depending on the SLPA token. I wanted to avoid duplicating this key, which is used directly on the SendToken.js page.

Jan 25 2021, 16:45
Fabien added a comment to D9054: [Cashtab] replace BCHA decimal unit with a constant.

Why did you choose to call it currency.cashDecimals and not just currency.decimals ? Could it be confused with something else ?

Jan 25 2021, 16:44
PiRK updated the diff for D8899: Check for overflow when calculating sum of outputs.

add tests for the case of a sum of outputs equal to MAX_MONEY, which is a valid case.

Jan 25 2021, 16:43
Fabien accepted D9042: test: Add mempool_updatefromblock.py.
Jan 25 2021, 16:38
Fabien updated the diff for D9049: [net processing] Move Misbehaving() to PeerManager.

Fix comment

Jan 25 2021, 16:36
teamcity updated the summary of D9055: Improve asmap checks and add sanity check.
Jan 25 2021, 16:34
Fabien requested review of D9055: Improve asmap checks and add sanity check.
Jan 25 2021, 16:34
bytesofman updated the diff for D9054: [Cashtab] replace BCHA decimal unit with a constant.

Replace '8' with currency.cashDecimals in validation error msg

Jan 25 2021, 15:58
bytesofman requested review of D9054: [Cashtab] replace BCHA decimal unit with a constant.
Jan 25 2021, 15:55
majcosta requested changes to D9049: [net processing] Move Misbehaving() to PeerManager.
Jan 25 2021, 15:48
bytesofman abandoned D9019: [Cashtab] Convert BCHA send form validation to use BigNumber.js.

Implemented in other diffs

Jan 25 2021, 15:34
Joey King <joseph.roy.king@gmail.com> closed D9052: [Cashtab] Match app send min to backend send min with constant.
Jan 25 2021, 15:09