Page MenuHomePhabricator
Feed All Stories

Sep 29 2021

PiRK closed D9101: test: Remove RPCOverloadWrapper boilerplate.
Sep 29 2021, 06:16
PiRK committed rABC2c3f1596ee46: test: Remove RPCOverloadWrapper boilerplate (authored by MarcoFalke <falke.marco@gmail.com>).
test: Remove RPCOverloadWrapper boilerplate
Sep 29 2021, 06:16
deadalnix accepted D10211: [avalanche] Explicitely set the legacy format where expected.
Sep 29 2021, 01:22

Sep 28 2021

bytesofman requested changes to D10212: [website] Remove ecashpage div ID.
Sep 28 2021, 22:21
Mengerian requested review of D10212: [website] Remove ecashpage div ID.
Sep 28 2021, 20:36
Fabien requested review of D10211: [avalanche] Explicitely set the legacy format where expected.
Sep 28 2021, 20:03
Fabien planned changes to D10032: [avalanche] Cache the peer score.
Sep 28 2021, 19:05
Fabien planned changes to D10031: [avalanche] Order the peer set by score.
Sep 28 2021, 19:05
Fabien closed D10179: [avalanche] Introduce the StakeCommitment class.
Sep 28 2021, 19:02
Fabien committed rABC7cdd4d670a95: [avalanche] Introduce the StakeCommitment class (authored by Fabien).
[avalanche] Introduce the StakeCommitment class
Sep 28 2021, 19:02
Fabien accepted D10186: Add --address, bind to specific address.
Sep 28 2021, 18:54
nancybeyrd updated nancybeyrd.
Sep 28 2021, 18:52
Fabien accepted D9101: test: Remove RPCOverloadWrapper boilerplate.
Sep 28 2021, 18:50
Fabien requested changes to D10124: add a linter for python imports.

This is missing the installation for the CI, please fill up the contrib/utils/install-dependencies.sh script

Sep 28 2021, 18:48
Fabien added inline comments to D10206: sort python imports in remaining test_framework and misc files.
Sep 28 2021, 18:08
Fabien accepted D10205: sort python imports in wallet_* functional tests.
Sep 28 2021, 18:04
Fabien accepted D10204: sort python imports in rpc_* functional tests.
Sep 28 2021, 18:03
Fabien accepted D10203: sort python imports in p2p_* functional tests.
Sep 28 2021, 18:02
Fabien accepted D10202: Sort imports in interface_*, mining_* and mempool_* functional tests.
Sep 28 2021, 18:00
Fabien accepted D10201: sort python imports in feature_* functional tests.
Sep 28 2021, 17:58
Fabien requested changes to D10200: sort python imports in abc* functional tests with isort.
Sep 28 2021, 17:57
PiRK updated the diff for D9101: test: Remove RPCOverloadWrapper boilerplate.

rebase from hell and take care of createwallet

Sep 28 2021, 14:23
PiRK updated the summary of D10124: add a linter for python imports.
Sep 28 2021, 11:33
PiRK updated the summary of D10200: sort python imports in abc* functional tests with isort.
Sep 28 2021, 11:31
Heltho24 set Slack Username to https://www.heltho.com/ on Heltho24.
Sep 28 2021, 09:40
teamcity closed T1882: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Sep 28 2021, 08:24
teamcity triaged T1882: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Sep 28 2021, 08:04
PiRK closed D10195: Do not pass chain params to CheckForStaleTipAndEvictPeers twice.
Sep 28 2021, 07:52
PiRK committed rABC5bc1e2c854ba: Do not pass chain params to CheckForStaleTipAndEvictPeers twice (authored by MarcoFalke <falke.marco@gmail.com>).
Do not pass chain params to CheckForStaleTipAndEvictPeers twice
Sep 28 2021, 07:52
PiRK closed D10193: wallet: fix scanning progress calculation for single block range.
Sep 28 2021, 07:33
PiRK committed rABCb4aac05e7188: wallet: fix scanning progress calculation for single block range (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
wallet: fix scanning progress calculation for single block range
Sep 28 2021, 07:33
PiRK requested review of D10200: sort python imports in abc* functional tests with isort.
Sep 28 2021, 07:28
thonkle closed D10208: Recommend port 15353 when running in user space.
Sep 28 2021, 02:09
thonkle committed rABC68b6c641f45d: Recommend port 15353 when running in user space (authored by thonkle).
Recommend port 15353 when running in user space
Sep 28 2021, 02:09
thonkle updated the diff for D10186: Add --address, bind to specific address.
  • Added comment about IPv6 transformation
  • Use constant for args help text
Sep 28 2021, 02:07

Sep 27 2021

deadalnix requested changes to D10140: [avalanche] Sign the avalanche proof.
Sep 27 2021, 22:08
deadalnix requested changes to D10151: [avalanche] Only sign the subset of data we want to commit the stakes to.
Sep 27 2021, 22:06
deadalnix accepted D10193: wallet: fix scanning progress calculation for single block range.
Sep 27 2021, 21:58
deadalnix accepted D10195: Do not pass chain params to CheckForStaleTipAndEvictPeers twice.
Sep 27 2021, 21:57
deadalnix requested changes to D10027: [avalanche] Add conflicting proofs to the vote.

Ok I think I'm getting a sense of where this is going. This patch definitely suffers from doing too many things. The whole ConflictingProofHandlerbusiness could be extracted from this and put in another patch.

Sep 27 2021, 21:55
deadalnix accepted D10208: Recommend port 15353 when running in user space.
Sep 27 2021, 21:30
thonkle added inline comments to D10186: Add --address, bind to specific address.
Sep 27 2021, 21:20
thonkle requested review of D10208: Recommend port 15353 when running in user space.
Sep 27 2021, 21:18
Fabien requested changes to D10200: sort python imports in abc* functional tests with isort.
Sep 27 2021, 19:11
Fabien requested review of D10207: [avalanche] Don't vote against our own proof in case of a conflict.
Sep 27 2021, 19:07
PiRK closed D10189: wallet: Reload previously loaded wallets on GUI startup.
Sep 27 2021, 12:59
PiRK committed rABCc43171d5a344: wallet: Reload previously loaded wallets on GUI startup (authored by Andrew Chow <achow101-github@achow101.com>).
wallet: Reload previously loaded wallets on GUI startup
Sep 27 2021, 12:59
PiRK closed D10185: Add loadwallet and createwallet RPC load_on_startup options.
Sep 27 2021, 12:58
PiRK committed rABC62bae4b8a97f: Add loadwallet and createwallet RPC load_on_startup options (authored by Russell Yanofsky <russ@yanofsky.org>).
Add loadwallet and createwallet RPC load_on_startup options
Sep 27 2021, 12:58
Fabien accepted D10185: Add loadwallet and createwallet RPC load_on_startup options.
Sep 27 2021, 12:06
Fabien requested changes to D10199: test: Mockwallet.
Sep 27 2021, 09:39
PiRK updated the diff for D10189: wallet: Reload previously loaded wallets on GUI startup.

rebase after landing D10188

Sep 27 2021, 09:34
PiRK closed D10191: Remove mapLinks in favor of entry inlined structs with iterator type erasure.
Sep 27 2021, 09:17
PiRK committed rABC957ddb12b36b: Remove mapLinks in favor of entry inlined structs with iterator type erasure (authored by Jeremy Rubin <j@rubin.io>).
Remove mapLinks in favor of entry inlined structs with iterator type erasure
Sep 27 2021, 09:17
PiRK updated the diff for D10185: Add loadwallet and createwallet RPC load_on_startup options.

fix newline consistency in release-notes.md

Sep 27 2021, 09:15
PiRK accepted D10197: [avalanche] Accept conflicting proofs from p2p.
Sep 27 2021, 09:05
PiRK updated the diff for D10191: Remove mapLinks in favor of entry inlined structs with iterator type erasure.

address review and rebase onto master

Sep 27 2021, 09:03
PiRK abandoned D10123: lint all the python imports with isort.

Split into multiple diffs: D10200 - D10206

Sep 27 2021, 09:00
PiRK updated the diff for D10124: add a linter for python imports.

rebase onto D10200, D10201, D10202, D10203, D10204, D10205, D10206

Sep 27 2021, 08:59
PiRK requested review of D10206: sort python imports in remaining test_framework and misc files.
Sep 27 2021, 08:57
Fabien accepted D10191: Remove mapLinks in favor of entry inlined structs with iterator type erasure.
Sep 27 2021, 08:56
PiRK requested review of D10205: sort python imports in wallet_* functional tests.
Sep 27 2021, 08:55
PiRK requested review of D10204: sort python imports in rpc_* functional tests.
Sep 27 2021, 08:54
PiRK requested review of D10203: sort python imports in p2p_* functional tests.
Sep 27 2021, 08:52
PiRK requested review of D10202: Sort imports in interface_*, mining_* and mempool_* functional tests.
Sep 27 2021, 08:50
PiRK requested review of D10201: sort python imports in feature_* functional tests.
Sep 27 2021, 08:48
PiRK requested review of D10200: sort python imports in abc* functional tests with isort.
Sep 27 2021, 08:46
Fabien accepted D10193: wallet: fix scanning progress calculation for single block range.
Sep 27 2021, 07:29
Fabien accepted D10189: wallet: Reload previously loaded wallets on GUI startup.
Sep 27 2021, 07:28
Fabien requested changes to D10185: Add loadwallet and createwallet RPC load_on_startup options.
Sep 27 2021, 07:27
Demain updated Demain.
Sep 27 2021, 06:26
PiRK updated the diff for D10195: Do not pass chain params to CheckForStaleTipAndEvictPeers twice.

revert unnecessary changes in denialofservice_tests.cpp

Sep 27 2021, 06:21
PiRK closed D10188: remove CChainParams from wallet methods that don't need it.
Sep 27 2021, 06:13
PiRK committed rABC9a147d403524: remove CChainParams from wallet methods that don't need it (authored by PiRK).
remove CChainParams from wallet methods that don't need it
Sep 27 2021, 06:13
PiRK closed D10190: wallet: Avoid multiple BerkeleyBatch in DelAddressBook.
Sep 27 2021, 06:12
PiRK committed rABCdf5b53eeee60: wallet: Avoid multiple BerkeleyBatch in DelAddressBook (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
wallet: Avoid multiple BerkeleyBatch in DelAddressBook
Sep 27 2021, 06:12

Sep 25 2021

fxzig updated fxzig.
Sep 25 2021, 20:53

Sep 24 2021

PiRK requested review of D10193: wallet: fix scanning progress calculation for single block range.

Sorry. I fixed it in the summary.

Sep 24 2021, 20:05
PiRK updated the summary of D10193: wallet: fix scanning progress calculation for single block range.
Sep 24 2021, 20:04
deadalnix requested changes to D10196: clear the validation interface before destructing the WalletTestingSetup.

I'd like an explanation of what's going on here. If this is presumably something, then there is a way to test if it is that thing.

Sep 24 2021, 19:57
deadalnix requested changes to D10193: wallet: fix scanning progress calculation for single block range.

The PR clearly doesn't match.

Sep 24 2021, 19:55
PiRK added a comment to D10195: Do not pass chain params to CheckForStaleTipAndEvictPeers twice.

I favored the solution that brings the code closer to Core's codebase , because I have not preference either way and it makes future backports a bit easier.
I can change it back.

Sep 24 2021, 19:44
PiRK updated the diff for D10189: wallet: Reload previously loaded wallets on GUI startup.

use std::make_optional

Sep 24 2021, 19:41
tobias_ruck closed D10198: Fix incorrect comment in intmath_tests.cpp.
Sep 24 2021, 19:40
tobias_ruck committed rABCc9532822d419: Fix incorrect comment in intmath_tests.cpp (authored by tobias_ruck).
Fix incorrect comment in intmath_tests.cpp
Sep 24 2021, 19:40
deadalnix requested changes to D10195: Do not pass chain params to CheckForStaleTipAndEvictPeers twice.
Sep 24 2021, 19:39
deadalnix accepted D10198: Fix incorrect comment in intmath_tests.cpp.
Sep 24 2021, 19:37
PiRK updated the summary of D10199: test: Mockwallet.
Sep 24 2021, 19:26
PiRK added inline comments to D10199: test: Mockwallet.
Sep 24 2021, 19:25
teamcity updated the summary of D10199: test: Mockwallet.
Sep 24 2021, 19:20
PiRK requested review of D10199: test: Mockwallet.
Sep 24 2021, 19:20
Fabien accepted D10190: wallet: Avoid multiple BerkeleyBatch in DelAddressBook.
Sep 24 2021, 18:55
Fabien requested changes to D10189: wallet: Reload previously loaded wallets on GUI startup.
Sep 24 2021, 18:52
tobias_ruck requested review of D10198: Fix incorrect comment in intmath_tests.cpp.
Sep 24 2021, 18:46
PiRK added a comment to D10188: remove CChainParams from wallet methods that don't need it.

You very often have these build failures. Are you running your test plan?

Sep 24 2021, 17:24
deadalnix accepted D10188: remove CChainParams from wallet methods that don't need it.

You very often have these build failures. Are you running your test plan?

Sep 24 2021, 14:42
teamcity closed T1877: Build Bitcoin-ABC / Master / Cross Builds / Cross Build OSX is broken. as Resolved.
Sep 24 2021, 14:05
Fabien closed D10194: [CI] Fix the OSX cross build.
Sep 24 2021, 13:49
Fabien committed rABC51fb541e059c: [CI] Fix the OSX cross build (authored by Fabien).
[CI] Fix the OSX cross build
Sep 24 2021, 13:49
Fabien requested review of D10197: [avalanche] Accept conflicting proofs from p2p.
Sep 24 2021, 13:35