Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Sep 30 2021

teamcity updated the summary of D10226: refactor: Use DatabaseStatus and DatabaseOptions types.

Sep 30 2021, 13:33

PiRK updated the summary of D10224: Remove WalletLocation class.

Sep 30 2021, 13:31

PiRK requested review of D10226: refactor: Use DatabaseStatus and DatabaseOptions types.

Sep 30 2021, 13:31

PiRK updated the summary of D10224: Remove WalletLocation class.

Sep 30 2021, 13:30

teamcity updated the summary of D10225: wallet: Add MakeDatabase function.

Sep 30 2021, 13:30

PiRK requested review of D10225: wallet: Add MakeDatabase function.

Sep 30 2021, 13:29

teamcity updated the summary of D10224: Remove WalletLocation class.

Sep 30 2021, 13:28

PiRK requested review of D10224: Remove WalletLocation class.

Sep 30 2021, 13:28

Fabien requested review of D10223: [avalanche] Rename vote_records to blockVoteRecords in the processor.

Sep 30 2021, 13:24

Fabien updated the diff for D10207: [avalanche] Don't vote against our own proof in case of a conflict.

Fix the bad rebase

Sep 30 2021, 13:07

teamcity added a comment to D10207: [avalanche] Don't vote against our own proof in case of a conflict.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Sep 30 2021, 13:01

teamcity added a comment to D10207: [avalanche] Don't vote against our own proof in case of a conflict.

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Sep 30 2021, 12:57

Fabien planned changes to D10207: [avalanche] Don't vote against our own proof in case of a conflict.

Poor rebase

Sep 30 2021, 12:57

teamcity added a comment to D10207: [avalanche] Don't vote against our own proof in case of a conflict.

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Sep 30 2021, 12:56

teamcity added a comment to D10207: [avalanche] Don't vote against our own proof in case of a conflict.

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Sep 30 2021, 12:54

teamcity added a comment to D10207: [avalanche] Don't vote against our own proof in case of a conflict.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Sep 30 2021, 12:52

Fabien updated the diff for D10197: [avalanche] Accept conflicting proofs from p2p.

Rebase

Sep 30 2021, 12:51

Fabien updated the diff for D10207: [avalanche] Don't vote against our own proof in case of a conflict.

Rebase

Sep 30 2021, 12:47

Fabien updated the summary of D10027: [avalanche] Add conflicting proofs to the vote.

Sep 30 2021, 12:36

Fabien updated the diff for D10027: [avalanche] Add conflicting proofs to the vote.

Rebase on top of D10219 and D10222 to keep it small enough.
Rename the conflicting_proofs map to proofVoteRecords. The vote_records will be renamed to blockVoteRecords in another diff.

Sep 30 2021, 12:35

Fabien requested review of D10222: [avalanche] Let the peermanager select whether a conflicting proof should be preferred.

Sep 30 2021, 11:50

Fabien added a comment to D10221: [avalanche] Add a notification handler to the peer manager.

unrelated failure

Sep 30 2021, 09:55

teamcity added a comment to D10221: [avalanche] Add a notification handler to the peer manager.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Sep 30 2021, 09:52

Fabien requested review of D10221: [avalanche] Add a notification handler to the peer manager.

Sep 30 2021, 09:40

teamcity updated the summary of D10220: Add a --descriptors option to more tests.

Sep 30 2021, 08:36

PiRK requested review of D10220: Add a --descriptors option to more tests.

Sep 30 2021, 08:36

Fabien requested review of D10219: [avalanche] Add a comparator for proof shared pointers.

Sep 30 2021, 08:28

Fabien accepted D10215: Use constants in seeder help text.

Sep 30 2021, 05:38

Fabien accepted D10218: [website] Add FAQ question about burning.

Sep 30 2021, 05:37

Fabien accepted D10217: [website] Add ecash.suppply link to FAQ.

Sep 30 2021, 05:35

teamcity closed T1885: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.

Sep 30 2021, 03:38

abc-bot committed rABC1a5389d9fcf8: [Automated] Update timing.json (authored by abc-bot).

[Automated] Update timing.json

Sep 30 2021, 03:20

Mengerian requested review of D10218: [website] Add FAQ question about burning.

Sep 30 2021, 02:53

teamcity triaged T1885: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.

Sep 30 2021, 02:38

abc-bot committed rABCe63887511884: [Automated] Update seeds (authored by abc-bot).

[Automated] Update seeds

Sep 30 2021, 02:17

abc-bot committed rABC781b7fe23753: [Automated] Update chainparams (authored by abc-bot).

[Automated] Update chainparams

Sep 30 2021, 02:08

Sep 29 2021

Mengerian requested review of D10217: [website] Add ecash.suppply link to FAQ.

Sep 29 2021, 22:52

Mengerian closed D10214: [website] Rename bcha section names.

Sep 29 2021, 22:06

Mengerian committed rABCWEB4fae7cdbb7e0: [website] Rename bcha section names (authored by Mengerian).

[website] Rename bcha section names

Sep 29 2021, 22:06

Mengerian updated the diff for D10214: [website] Rename bcha section names.

rebase

Sep 29 2021, 22:05

Mengerian closed D10212: [website] Remove ecashpage div ID.

Sep 29 2021, 22:04

Mengerian committed rABCWEBadf603cbdf26: [website] Remove ecashpage div ID (authored by Mengerian).

[website] Remove ecashpage div ID

Sep 29 2021, 22:04

bytesofman accepted D10214: [website] Rename bcha section names.

Sep 29 2021, 21:52

bytesofman accepted D10212: [website] Remove ecashpage div ID.

Sep 29 2021, 21:50

bytesofman requested changes to D10212: [website] Remove ecashpage div ID.

Sep 29 2021, 21:50

Fabien updated the summary of D10140: [avalanche] Sign the avalanche proof.

Sep 29 2021, 19:26

Fabien updated the diff for D10140: [avalanche] Sign the avalanche proof.

Rebase on top of D10216 and expand upon what changed in the tests in the summary.
Hopefully this will make more explicit what are the changes to this hex mess, and
give confidence that the tests are correct and covering the relevant cases.

Sep 29 2021, 19:21

Fabien requested review of D10216: [avalanche] Make regular proof format deserialization tests in par with the legacy.

Sep 29 2021, 19:16

thonkle requested review of D10215: Use constants in seeder help text.

Sep 29 2021, 18:17

thonkle closed D10186: Add --address, bind to specific address.

Sep 29 2021, 17:24

thonkle committed rABCe7f7ed186ec0: Add --address, bind to specific address (authored by uhliksk <uhlik@uhlik.sk>).

Add --address, bind to specific address

Sep 29 2021, 17:24

teamcity closed T1884: Build Bitcoin-ABC / Master / Coverage is broken. as Resolved.

Sep 29 2021, 17:05

Mengerian added a comment to D10212: [website] Remove ecashpage div ID.

@bytesofman see D10214 follow-on Diff

Sep 29 2021, 16:46

Mengerian updated the diff for D10214: [website] Rename bcha section names.

add reviewer

Sep 29 2021, 16:42

Mengerian requested review of D10214: [website] Rename bcha section names.

Sep 29 2021, 16:38

Mengerian requested review of D10212: [website] Remove ecashpage div ID.

Sep 29 2021, 16:05

PiRK closed D10124: add a linter for python imports.

Sep 29 2021, 15:49

PiRK closed D10206: sort python imports in remaining test_framework and misc files.

Sep 29 2021, 15:49

PiRK committed rABC6f244fbea854: add a linter for python imports (authored by PiRK).

add a linter for python imports

Sep 29 2021, 15:49

PiRK committed rABCf5ff0c42de56: sort python imports in remaining test_framework and misc files (authored by PiRK).

sort python imports in remaining test_framework and misc files

Sep 29 2021, 15:49

PiRK closed D10205: sort python imports in wallet_* functional tests.

Sep 29 2021, 15:47

PiRK closed D10204: sort python imports in rpc_* functional tests.

Sep 29 2021, 15:47

PiRK closed D10203: sort python imports in p2p_* functional tests.

Sep 29 2021, 15:47

PiRK committed rABCfb4d8d48ff42: sort python imports in wallet_* functional tests (authored by PiRK).

sort python imports in wallet_* functional tests

Sep 29 2021, 15:47

PiRK committed rABCa80445e2fff7: sort python imports in rpc_* functional tests (authored by PiRK).

sort python imports in rpc_* functional tests

Sep 29 2021, 15:47

PiRK committed rABC2c523fa47665: sort python imports in p2p_* functional tests (authored by PiRK).

sort python imports in p2p_* functional tests

Sep 29 2021, 15:47

PiRK closed D10202: Sort imports in interface_*, mining_* and mempool_* functional tests.

Sep 29 2021, 15:46

PiRK committed rABCd03514a78671: Sort imports in interface_*, mining_* and mempool_* functional tests (authored by PiRK).

Sort imports in interface_*, mining_* and mempool_* functional tests

Sep 29 2021, 15:46

PiRK closed D10201: sort python imports in feature_* functional tests.

Sep 29 2021, 15:46

PiRK closed D10200: sort python imports in abc* functional tests with isort.

Sep 29 2021, 15:46

PiRK committed rABCe227dd4c3ae5: sort python imports in feature_* functional tests (authored by PiRK).

sort python imports in feature_* functional tests

Sep 29 2021, 15:46

PiRK committed rABCb29d6ca9bf28: sort python imports in abc* functional tests with isort (authored by PiRK).

sort python imports in abc* functional tests with isort

Sep 29 2021, 15:45

Fabien accepted D10124: add a linter for python imports.

Sep 29 2021, 15:41

PiRK updated the diff for D10124: add a linter for python imports.

Set the minimum isort version to 5.6.4, which seems to be a stable version used by debian. 5.0.0 produces different results wrt to newlines before the first import compared to the latest version (5.9.3), whereas 5.6.4 produces identical results when run on our code.

Sep 29 2021, 15:30

teamcity updated the summary of D10213: Add a --descriptors option to various tests.

Sep 29 2021, 13:58

PiRK requested review of D10213: Add a --descriptors option to various tests.

Sep 29 2021, 13:58

PiRK updated the diff for D10124: add a linter for python imports.

make install-dependencies.sh install isort for the CI.

Sep 29 2021, 13:30

PiRK added a comment to D10124: add a linter for python imports.

I see. I saw only the inline comments. Sorry, I will pay closer attention next time.

Sep 29 2021, 13:10

Fabien added a comment to D10124: add a linter for python imports.

You missed that part:

Sep 29 2021, 13:07

PiRK added a comment to D10124: add a linter for python imports.

In D10124#229719, @Fabien wrote:

Please address the remaining items before submitting for review

I don't understand what you mean.

Sep 29 2021, 12:44

ecommerceweb updated ecommerceweb.

Sep 29 2021, 10:44

teamcity triaged T1884: Build Bitcoin-ABC / Master / Coverage is broken. as Unbreak Now! priority.

Sep 29 2021, 09:35

Fabien requested changes to D10124: add a linter for python imports.

Please address the remaining items before submitting for review

Sep 29 2021, 08:55

PiRK closed D10209: refactor: Add BerkeleyDatabaseVersion() function.

Sep 29 2021, 08:53

PiRK committed rABC85aad1446581: refactor: Add BerkeleyDatabaseVersion() function (authored by PiRK).

refactor: Add BerkeleyDatabaseVersion() function

Sep 29 2021, 08:53

PiRK updated the diff for D10124: add a linter for python imports.

I missed an item in CONTRIBUTING.md: include isort in the paragraph that explains how to install mypy with pip install on debian.

Sep 29 2021, 08:38

teamcity closed T1883: Build Bitcoin-ABC / Master / Build without BIP70 is broken. as Resolved.

Sep 29 2021, 08:19

Fabien accepted D10209: refactor: Add BerkeleyDatabaseVersion() function.

Sep 29 2021, 08:09

Fabien requested changes to D10124: add a linter for python imports.

Please address the remaining items before submitting for review

Sep 29 2021, 08:06

Fabien accepted D10206: sort python imports in remaining test_framework and misc files.

Sep 29 2021, 08:05

Fabien accepted D10200: sort python imports in abc* functional tests with isort.

Sep 29 2021, 08:04

PiRK published D10209: refactor: Add BerkeleyDatabaseVersion() function for review.

This can be reviewed and landed independently of D10210.

Sep 29 2021, 08:03

Fabien closed D10211: [avalanche] Explicitely set the legacy format where expected.

Sep 29 2021, 08:03

Fabien committed rABCb9faa755ae66: [avalanche] Explicitely set the legacy format where expected (authored by Fabien).

[avalanche] Explicitely set the legacy format where expected

Sep 29 2021, 08:02

PiRK added inline comments to D10206: sort python imports in remaining test_framework and misc files.

Sep 29 2021, 07:15

PiRK updated the summary of D10200: sort python imports in abc* functional tests with isort.

Sep 29 2021, 07:14

PiRK updated the diff for D10124: add a linter for python imports.

address review: add url, improve description and installation instruction, remove unused methods, set parameters in getMandatoryFlags

Sep 29 2021, 07:07

PiRK updated the diff for D10205: sort python imports in wallet_* functional tests.

rebase to include recently added wallet_startup.py file

Sep 29 2021, 07:05

PiRK requested review of D10200: sort python imports in abc* functional tests with isort.

Sep 29 2021, 06:43

teamcity triaged T1883: Build Bitcoin-ABC / Master / Build without BIP70 is broken. as Unbreak Now! priority.

Sep 29 2021, 06:29