You should remove the whole peerid business, it doesn't seem relevant to the first iteration.

I really need to fix my arcanist...

Thanks for your review. Please help to close the PR. I'll be more careful next time.

Rebase

Remove the handlers for now and use addProofToReconcile to unit tests the invs are added as expected.

Rebase

Thanks for the patch.

Thanks for the patch, but committing IDE specific files to the repository should be avoided. Each user has its own favorite, and in the end we will get a lot of unmaintained files that will cause more confusion than help.
You can still add this file to your local repo by following the guidelines from the developer notes: https://github.com/Bitcoin-ABC/bitcoin-abc/blob/master/doc/developer-notes.md#ignoring-ideeditor-files

add the error message that was accidentaly removed.i

fix rebase accident (revert to std::optional to std::make_optional))

Fix incorrect baseUrl in jsconfig.json

Fix copyright year

I have tried to find a more reliable way to reproduce the crash by generating a lot of transactions at the end of a test just before it is destructed, hoping it would cause the validation interface thread to keep processing pointers to freed memory, but so far I did not have any significant success. For now, the only way i know of to cause this is to run the test in a loop for multiple hours. I need to spend more time understanding this stuff.

Address feedback.
Note to reviewers: the test needs a TestingSetup fixture in order to initialize the coin db required when calling buildRandomProof().

Fix the legacy test vectors clones that had their payout address updated by mistake

Remove the whole proof handler thing. Test from addProofToReconciledirectly.

fix clang-tidy build [readability-braces-around-statements,-warnings-as-errors]: add missing braces

clang-tidy failure (missing braces)