Reduce console.log statements; repush to rebuild teamcity tests
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Oct 5 2021
still need to find an explanation for why importing a desc instead of importing keys with importmulti causes a slightly different fee calculation. I verified that the generated transaction has the same size.
unbreak the test
use a more explicit method to build the scriptSig from the redeemScript
Rebase
After further discussion with @bytesofman, due to issues with commit this diff will now be abandoned with a new fresh diff created (D10252).
Oct 4 2021
Added try-catch loop to validation.js and reverted jest version in package.json
Hey looking good from the screenshots! Some suggested improvements in line by line comments.
use satoshi_round in wallet_basic instead of making a special case for --descriptors.
put the comment back on its own line (rebase regression in previous change)
squashed with D10243
Squash the two commits for core#15454 so that the release note does not refer to a future feature in the first one.
Squash with core#19971 to fix also extended tests.
Update description accordingly (test plan +extended, backport +PR19971)
address review:
- use node0 when creating multisig address in rpc_createmultisig (like in the original PR)
- remove test related to segwit, that in our codebase just duplicates the previous line of test (needlesly added in D6552)
- undo a couple of changes that don't belong in this backport ("regtest" -> "chain" in a comment and style change)
rewrite the scriptSig to make it more explicit that the one byte of the OP_TRUE script is being pushed to the stack.
In D10243#230389, @Fabien wrote:Please run the extended functional tests as part of the test plan
Oct 2 2021
Now I understand the release notes from D10243. Please squash or reverse the order
Please run the extended functional tests as part of the test plan
Summary:
Incorporates review feedback from Fabien and BytesOfMan from 2021-10-01
- Created new function 'formatSavedBalance' in utils/validation.js to take a savedwallet balance as input and return a formated locale string so large XEC balances are legible
- Imported the newly created locale string function into Configure/Configure.js and utilised as part of conditional rendering to mitigate edge cases that may prevent the app from rendering.
- Added unit tests in validation.test.js to test edge case inputs for SWBalances, including undefined/null balances, zero and max supply trillion balances
- Fixed overflow issue with long wallet names pushing buttons off the UI by adjusting overflow:hover css for both <SWName> and <SWBalance>
- Added additional styling in Configuration.js's <SWBalance> component to enhance aesthetics and distinguish SWBalance values from SWName
- Updated snapshot to fix earlier unit test errors
Oct 1 2021
Good progress on this. A few items required before this lands:
Thanks for this diff. It works but requires refinement for display aesthetics, responsiveness, and balance formatting. Since another diff is already in for this change, please abandon this rev and commence work on separate task discussed in Telegram.
see D10221
This is going to be the last step
Waiting for the processor features to be complete before an ultimate rebase
I already updated the summary but forgot to remove the dependency in phab, good catch
I don't think this depends on D10222 anymore.
put comment on its own line