Page MenuHomePhabricator
Feed All Stories

Oct 5 2021

bytesofman updated the diff for D10251: [Cashtab] Add domain migration alert pop-up.

Reduce console.log statements; repush to rebuild teamcity tests

Oct 5 2021, 11:36
teamcity triaged T1893: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Oct 5 2021, 09:36
Fabien requested review of D10253: [avalanche] Turn the vote registration logic into a generic lambda.
Oct 5 2021, 09:16
PiRK closed D10240: bugfix: make LoadWallet assigns status always.
Oct 5 2021, 08:51
PiRK closed D10230: wallet: Remove path checking code from createwallet RPC.
Oct 5 2021, 08:51
PiRK closed D10231: wallet: Remove path checking code from bitcoin-wallet tool.
Oct 5 2021, 08:51
PiRK committed rABC0ddd20024bf7: bugfix: make LoadWallet assigns status always (authored by Akio Nakamura <nakamura@dgtechnologies.co.jp>).
bugfix: make LoadWallet assigns status always
Oct 5 2021, 08:51
PiRK committed rABC19a93bbcd6bd: wallet: Remove path checking code from createwallet RPC (authored by Russell Yanofsky <russ@yanofsky.org>).
wallet: Remove path checking code from createwallet RPC
Oct 5 2021, 08:51
PiRK committed rABC5dc21608b9dd: wallet: Remove path checking code from bitcoin-wallet tool (authored by Russell Yanofsky <russ@yanofsky.org>).
wallet: Remove path checking code from bitcoin-wallet tool
Oct 5 2021, 08:51
PiRK closed D10229: wallet: Remove path checking code from loadwallet RPC.
Oct 5 2021, 08:50
PiRK closed D10227: wallet: Remove Verify and IsLoaded methods.
Oct 5 2021, 08:49
PiRK closed D10228: refactor: Pass wallet database into CWallet::Create.
Oct 5 2021, 08:49
PiRK committed rABC18aeb323c584: wallet: Remove path checking code from loadwallet RPC (authored by Russell Yanofsky <russ@yanofsky.org>).
wallet: Remove path checking code from loadwallet RPC
Oct 5 2021, 08:49
PiRK committed rABC35feef8b4381: wallet: Remove Verify and IsLoaded methods (authored by Russell Yanofsky <russ@yanofsky.org>).
wallet: Remove Verify and IsLoaded methods
Oct 5 2021, 08:49
PiRK committed rABC3d15c53ac93e: refactor: Pass wallet database into CWallet::Create (authored by Russell Yanofsky <russ@yanofsky.org>).
refactor: Pass wallet database into CWallet::Create
Oct 5 2021, 08:48
PiRK closed D10226: refactor: Use DatabaseStatus and DatabaseOptions types.
Oct 5 2021, 08:48
PiRK committed rABC97efc9047ebf: refactor: Use DatabaseStatus and DatabaseOptions types (authored by Russell Yanofsky <russ@yanofsky.org>).
refactor: Use DatabaseStatus and DatabaseOptions types
Oct 5 2021, 08:48
PiRK closed D10225: wallet: Add MakeDatabase function.
Oct 5 2021, 08:48
PiRK committed rABC9c7a754d5935: wallet: Add MakeDatabase function (authored by Russell Yanofsky <russ@yanofsky.org>).
wallet: Add MakeDatabase function
Oct 5 2021, 08:47
PiRK closed D10224: Remove WalletLocation class.
Oct 5 2021, 08:47
PiRK committed rABC0ae7f22b6a53: Remove WalletLocation class (authored by Russell Yanofsky <russ@yanofsky.org>).
Remove WalletLocation class
Oct 5 2021, 08:47
PiRK closed D10213: Add a --descriptors option to various tests.
Oct 5 2021, 08:39
PiRK committed rABCe854278f6db0: Add a --descriptors option to various tests (authored by Andrew Chow <achow101-github@achow101.com>).
Add a --descriptors option to various tests
Oct 5 2021, 08:38
PiRK planned changes to D10220: Add a --descriptors option to more tests.

still need to find an explanation for why importing a desc instead of importing keys with importmulti causes a slightly different fee calculation. I verified that the generated transaction has the same size.

Oct 5 2021, 08:34
PiRK updated the diff for D10220: Add a --descriptors option to more tests.

unbreak the test

Oct 5 2021, 08:32
PiRK updated the diff for D10247: test: use OP_TRUE p2sh address in p2p_permissions.

use a more explicit method to build the scriptSig from the redeemScript

Oct 5 2021, 08:19
Fabien accepted D10213: Add a --descriptors option to various tests.
Oct 5 2021, 08:17
teamcity added a comment to D10250: [avalanche] Extract a template class from BlockUpdate.
Oct 5 2021, 07:23
Fabien updated the diff for D10250: [avalanche] Extract a template class from BlockUpdate.

Rebase

Oct 5 2021, 07:00
PiRK closed D10242: Test batch rpc with params.
Oct 5 2021, 06:40
PiRK committed rABCfd6a2c27546d: Test batch rpc with params (authored by Gregory Sanders <gsanders87@gmail.com>).
Test batch rpc with params
Oct 5 2021, 06:40
PiRK closed D10241: Change CSipHasher's count variable to uint8_t.
Oct 5 2021, 06:40
PiRK committed rABC1df995312b0d: Change CSipHasher's count variable to uint8_t (authored by Pieter Wuille <pieter@wuille.net>).
Change CSipHasher's count variable to uint8_t
Oct 5 2021, 06:40
emack abandoned D10239: SavedWallet balance display + enhancements.
Oct 5 2021, 04:28
emack added a comment to D10252: [Cashtab] display balances for saved wallets.

UI screenshots below

1.PNG (270×620 px, 28 KB)

Oct 5 2021, 01:05
emack added a comment to D10239: SavedWallet balance display + enhancements.

After further discussion with @bytesofman, due to issues with commit this diff will now be abandoned with a new fresh diff created (D10252).

Oct 5 2021, 00:59
emack requested review of D10252: [Cashtab] display balances for saved wallets.
Oct 5 2021, 00:57

Oct 4 2021

emack updated the diff for D10239: SavedWallet balance display + enhancements.

Added try-catch loop to validation.js and reverted jest version in package.json

Oct 4 2021, 23:40
teamcity added a comment to D10251: [Cashtab] Add domain migration alert pop-up.
Oct 4 2021, 21:34
bytesofman requested review of D10251: [Cashtab] Add domain migration alert pop-up.
Oct 4 2021, 21:08
Fabien accepted D10243: Remove the automatic creation and loading of the default wallet.
Oct 4 2021, 18:59
teamcity added a comment to D10220: Add a --descriptors option to more tests.
Oct 4 2021, 17:08
teamcity added a comment to D10220: Add a --descriptors option to more tests.
Oct 4 2021, 17:02
bytesofman requested changes to D10239: SavedWallet balance display + enhancements.

Hey looking good from the screenshots! Some suggested improvements in line by line comments.

Oct 4 2021, 17:01
PiRK planned changes to D10220: Add a --descriptors option to more tests.
Oct 4 2021, 16:55
PiRK updated the diff for D10220: Add a --descriptors option to more tests.

use satoshi_round in wallet_basic instead of making a special case for --descriptors.

Oct 4 2021, 16:52
teamcity closed T1891: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Oct 4 2021, 14:16
teamcity triaged T1891: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Oct 4 2021, 14:03
Fabien closed D10249: [avalanche] Extract the vote status in an enum class.
Oct 4 2021, 13:53
Fabien committed rABCa331135a588f: [avalanche] Extract the vote status in an enum class (authored by Fabien).
[avalanche] Extract the vote status in an enum class
Oct 4 2021, 13:53
Fabien closed D10245: [avalanche] Move the vote eror codes to its own enum class.
Oct 4 2021, 13:52
Fabien committed rABC461b116e804f: [avalanche] Move the vote eror codes to its own enum class (authored by Fabien).
[avalanche] Move the vote eror codes to its own enum class
Oct 4 2021, 13:52
Fabien closed D10248: [avalanche] Fix some naming nits.
Oct 4 2021, 13:50
Fabien committed rABCd02282b896e2: [avalanche] Fix some naming nits (authored by Fabien).
[avalanche] Fix some naming nits
Oct 4 2021, 13:50
Fabien requested review of D10250: [avalanche] Extract a template class from BlockUpdate.
Oct 4 2021, 13:47
deadalnix accepted D10249: [avalanche] Extract the vote status in an enum class.
Oct 4 2021, 13:42
PiRK accepted D10248: [avalanche] Fix some naming nits.
Oct 4 2021, 13:13
Fabien requested review of D10249: [avalanche] Extract the vote status in an enum class.
Oct 4 2021, 13:06
PiRK accepted D10245: [avalanche] Move the vote eror codes to its own enum class.
Oct 4 2021, 12:14
PiRK updated the diff for D10243: Remove the automatic creation and loading of the default wallet.

put the comment back on its own line (rebase regression in previous change)

Oct 4 2021, 12:11
PiRK abandoned D10244: Tell users how to load or create a wallet when no wallet is loaded.

squashed with D10243

Oct 4 2021, 12:07
PiRK planned changes to D10220: Add a --descriptors option to more tests.
Oct 4 2021, 12:06
PiRK updated the diff for D10243: Remove the automatic creation and loading of the default wallet.

Squash the two commits for core#15454 so that the release note does not refer to a future feature in the first one.
Squash with core#19971 to fix also extended tests.
Update description accordingly (test plan +extended, backport +PR19971)

Oct 4 2021, 12:06
PiRK updated the diff for D10213: Add a --descriptors option to various tests.

address review:

  • use node0 when creating multisig address in rpc_createmultisig (like in the original PR)
  • remove test related to segwit, that in our codebase just duplicates the previous line of test (needlesly added in D6552)
  • undo a couple of changes that don't belong in this backport ("regtest" -> "chain" in a comment and style change)
Oct 4 2021, 11:47
Fabien requested review of D10248: [avalanche] Fix some naming nits.
Oct 4 2021, 09:25
PiRK updated the diff for D10247: test: use OP_TRUE p2sh address in p2p_permissions.

rewrite the scriptSig to make it more explicit that the one byte of the OP_TRUE script is being pushed to the stack.

Oct 4 2021, 08:45
Fabien requested changes to D10213: Add a --descriptors option to various tests.
Oct 4 2021, 08:01
PiRK requested review of D10247: test: use OP_TRUE p2sh address in p2p_permissions.
Oct 4 2021, 07:11
PiRK added a comment to D10243: Remove the automatic creation and loading of the default wallet.

Please run the extended functional tests as part of the test plan

Oct 4 2021, 06:23
PiRK updated the summary of D10229: wallet: Remove path checking code from loadwallet RPC.
Oct 4 2021, 06:15
sippibehl updated sippibehl.
Oct 4 2021, 05:48

Oct 2 2021

Fabien requested changes to D10244: Tell users how to load or create a wallet when no wallet is loaded.

Now I understand the release notes from D10243. Please squash or reverse the order

Oct 2 2021, 11:16
Fabien requested changes to D10243: Remove the automatic creation and loading of the default wallet.

Please run the extended functional tests as part of the test plan

Oct 2 2021, 11:13
Fabien accepted D10242: Test batch rpc with params.
Oct 2 2021, 10:59
Fabien accepted D10241: Change CSipHasher's count variable to uint8_t.
Oct 2 2021, 10:58
emack updated the test plan for D10239: SavedWallet balance display + enhancements.
Oct 2 2021, 06:13
emack updated the test plan for D10239: SavedWallet balance display + enhancements.
Oct 2 2021, 06:03
emack updated the summary of D10239: SavedWallet balance display + enhancements.
Oct 2 2021, 06:01
emack updated the diff for D10239: SavedWallet balance display + enhancements.

Summary:
Incorporates review feedback from Fabien and BytesOfMan from 2021-10-01

  • Created new function 'formatSavedBalance' in utils/validation.js to take a savedwallet balance as input and return a formated locale string so large XEC balances are legible
  • Imported the newly created locale string function into Configure/Configure.js and utilised as part of conditional rendering to mitigate edge cases that may prevent the app from rendering.
  • Added unit tests in validation.test.js to test edge case inputs for SWBalances, including undefined/null balances, zero and max supply trillion balances
  • Fixed overflow issue with long wallet names pushing buttons off the UI by adjusting overflow:hover css for both <SWName> and <SWBalance>
  • Added additional styling in Configuration.js's <SWBalance> component to enhance aesthetics and distinguish SWBalance values from SWName
  • Updated snapshot to fix earlier unit test errors
Oct 2 2021, 05:53

Oct 1 2021

bytesofman requested changes to D10239: SavedWallet balance display + enhancements.

Good progress on this. A few items required before this lands:

Oct 1 2021, 20:56
bytesofman requested changes to D10246: added total wallet balanced to saved wallets list.

Thanks for this diff. It works but requires refinement for display aesthetics, responsiveness, and balance formatting. Since another diff is already in for this change, please abandon this rev and commence work on separate task discussed in Telegram.

Oct 1 2021, 20:46
Fabien planned changes to D10222: [avalanche] Let the peermanager select whether a conflicting proof should be preferred.

see D10221

Oct 1 2021, 19:21
Fabien planned changes to D10221: [avalanche] Add a notification handler to the peer manager.

This is going to be the last step

Oct 1 2021, 19:21
Fabien planned changes to D10197: [avalanche] Accept conflicting proofs from p2p.

Waiting for the processor features to be complete before an ultimate rebase

Oct 1 2021, 19:18
Fabien closed D10027: [avalanche] Add conflicting proofs to the vote.
Oct 1 2021, 19:16
Fabien committed rABCbabaeea2cf14: [avalanche] Add conflicting proofs to the vote (authored by Fabien).
[avalanche] Add conflicting proofs to the vote
Oct 1 2021, 19:16
Fabien closed D10219: [avalanche] Add a comparator for proof shared pointers.
Oct 1 2021, 19:13
Fabien committed rABC97c8ab66348b: [avalanche] Add a comparator for proof shared pointers (authored by abc-bot).
[avalanche] Add a comparator for proof shared pointers
Oct 1 2021, 19:13
kieran709 requested review of D10246: added total wallet balanced to saved wallets list.
Oct 1 2021, 18:11
Mengerian closed D10236: [website] Update list of exchanges.
Oct 1 2021, 17:45
Mengerian committed rABCWEB90674e003fc2: [website] Update list of exchanges (authored by Mengerian).
[website] Update list of exchanges
Oct 1 2021, 17:45
Mengerian updated the diff for D10236: [website] Update list of exchanges.

Rebase

Oct 1 2021, 17:40
Fabien requested review of D10245: [avalanche] Move the vote eror codes to its own enum class.
Oct 1 2021, 16:01
Fabien added a comment to D10027: [avalanche] Add conflicting proofs to the vote.

I already updated the summary but forgot to remove the dependency in phab, good catch

Oct 1 2021, 15:05
deadalnix accepted D10027: [avalanche] Add conflicting proofs to the vote.

I don't think this depends on D10222 anymore.

Oct 1 2021, 14:58
teamcity updated the summary of D10244: Tell users how to load or create a wallet when no wallet is loaded.
Oct 1 2021, 14:50
PiRK updated the diff for D10243: Remove the automatic creation and loading of the default wallet.

put comment on its own line

Oct 1 2021, 14:49
teamcity updated the summary of D10244: Tell users how to load or create a wallet when no wallet is loaded.
Oct 1 2021, 14:45
PiRK requested review of D10244: Tell users how to load or create a wallet when no wallet is loaded.
Oct 1 2021, 14:45
PiRK updated the summary of D10243: Remove the automatic creation and loading of the default wallet.
Oct 1 2021, 14:41