Page MenuHomePhabricator
Feed All Stories

Dec 27 2024

Fabien accepted D17408: [Cashtab] Remove unused imports from test file.
Dec 27 2024, 15:35
Fabien accepted D17406: [Cashtab] Minor ts conversion.
Dec 27 2024, 15:33
Fabien accepted D17405: [alias-server] Remove alias-server from the monorepo.
Dec 27 2024, 15:33
Fabien accepted D17404: [Cashtab] Convert App screen and deps to ts.
Dec 27 2024, 15:32
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Dec 27 2024, 15:32
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Dec 27 2024, 15:30
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Dec 27 2024, 15:30
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Dec 27 2024, 15:28
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Dec 27 2024, 15:27
Fabien accepted D17401: [Cashtab] Convert some common components to ts.
Dec 27 2024, 15:26
Fabien accepted D17400: [Cashtab] Convert BackupWallet screen to ts.
Dec 27 2024, 15:25
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Dec 27 2024, 15:23
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Doubloon token.
Dec 27 2024, 15:22
Fabien added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

@bot alias-server-tests ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests

Dec 27 2024, 15:22
bytesofman published D17411: [Cashtab] Move function only used on Send screen to helpers dir for Send screen for review.
Dec 27 2024, 13:41
bytesofman published D17410: [Cashtab] Convert contacts screen to ts for review.
Dec 27 2024, 13:36
bytesofman published D17409: [Cashtab] Convert Configure to ts for review.
Dec 27 2024, 13:36
bytesofman published D17408: [Cashtab] Remove unused imports from test file for review.
Dec 27 2024, 13:01
bytesofman published D17407: [Cashtab + doc] Parse XECX rewards for review.
Dec 27 2024, 13:00
bytesofman closed T1713: Paginated transaction history as Invalid.

not really a chronik task

Dec 27 2024, 00:56 ยท Restricted Project
bytesofman published D17406: [Cashtab] Minor ts conversion for review.
Dec 27 2024, 00:41
bytesofman published D17405: [alias-server] Remove alias-server from the monorepo for review.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Dec 27 2024, 00:11
bytesofman published D17404: [Cashtab] Convert App screen and deps to ts for review.
Dec 27 2024, 00:10

Dec 26 2024

bytesofman closed D17399: [Cashtab] Remove legacy aliases implementation.
Dec 26 2024, 23:15
bytesofman committed rABC1f7871d420dd: [Cashtab] Remove legacy aliases implementation (authored by bytesofman).
[Cashtab] Remove legacy aliases implementation
Dec 26 2024, 23:15
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

Much better logic. I am not totally sure if my implementation here is the right approach (parsing dependencies, making new BuildConfigurations for each one, adding to steps), though I was able to get it to work locally.

Dec 26 2024, 23:11
bytesofman updated the diff for D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

lint

Dec 26 2024, 23:09
bytesofman updated the diff for D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

Simplifying by removing dependencies.yml and its custom methods, instead creating script steps for the dependencies, parsing these before building

Dec 26 2024, 23:08
bytesofman published D17402: [Cashtab] Allow user to sort Agora offers by offer count for review.
Dec 26 2024, 22:26
bytesofman added inline comments to D17401: [Cashtab] Convert some common components to ts.
Dec 26 2024, 22:23
bytesofman updated the diff for D17401: [Cashtab] Convert some common components to ts.

comment clarifying strange typescript/styled-components interaction

Dec 26 2024, 22:23
bytesofman added inline comments to D17400: [Cashtab] Convert BackupWallet screen to ts.
Dec 26 2024, 22:18
Fabien added inline comments to D17401: [Cashtab] Convert some common components to ts.
Dec 26 2024, 21:52
Fabien accepted D17399: [Cashtab] Remove legacy aliases implementation.
Dec 26 2024, 21:48
Fabien added a comment to D17399: [Cashtab] Remove legacy aliases implementation.

What about the alias server ?

imo this also needs to go. I do not think we should implement aliases if it is not on a spec that a chronik plugin can index.

I could remove it in this diff as well. Was planning to do it separately as it has its own CI-related impacts.

Dec 26 2024, 21:46
Fabien added inline comments to D17400: [Cashtab] Convert BackupWallet screen to ts.
Dec 26 2024, 21:45
bytesofman added a comment to D17399: [Cashtab] Remove legacy aliases implementation.

What about the alias server ?

Dec 26 2024, 21:42
Fabien added a comment to D17399: [Cashtab] Remove legacy aliases implementation.

What about the alias server ?

Dec 26 2024, 21:40
Fabien requested changes to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

I like the top level API, but this can be simplified a bit. See suggestions.

Dec 26 2024, 21:30
bytesofman published D17401: [Cashtab] Convert some common components to ts for review.
Dec 26 2024, 18:43
bytesofman published D17399: [Cashtab] Remove legacy aliases implementation for review.
Dec 26 2024, 18:33
bytesofman published D17400: [Cashtab] Convert BackupWallet screen to ts for review.
Dec 26 2024, 18:21
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

Tail of the build log:

> mock-chronik-client@2.1.1 build
> tsc

/work/apps/alias-server /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecash-script /work/modules/ecashaddrjs /work/abc-ci-builds/alias-server-tests
npm warn deprecated har-validator@5.1.5: this library is no longer supported
npm warn deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm warn deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.

added 612 packages, and audited 616 packages in 6s

94 packages are looking for funding
  run `npm fund` for details

15 vulnerabilities (3 low, 7 moderate, 5 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
CI not configured to test build.

> alias-server@1.0.0 test
> mocha --reporter mocha-junit-reporter --reporter-options mochaFile=test_results/alias-server-junit.xml --reporter-options testsuitesTitle=Alias Server Unit Tests --reporter-options rootSuiteTitle=Alias Server

Connected successfully to MongoDB server
Error in function updateServerState. MongoServerError: interrupted at shutdown
    at Connection.sendCommand (/work/apps/alias-server/node_modules/mongodb/lib/cmap/connection.js:290:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Connection.command (/work/apps/alias-server/node_modules/mongodb/lib/cmap/connection.js:317:26)
    at async Server.command (/work/apps/alias-server/node_modules/mongodb/lib/sdam/server.js:167:29)
    at async UpdateOneOperation.executeCommand (/work/apps/alias-server/node_modules/mongodb/lib/operations/command.js:73:16)
    at async UpdateOneOperation.execute (/work/apps/alias-server/node_modules/mongodb/lib/operations/update.js:55:21)
    at async UpdateOneOperation.execute (/work/apps/alias-server/node_modules/mongodb/lib/operations/update.js:69:21)
    at async tryOperation (/work/apps/alias-server/node_modules/mongodb/lib/operations/execute_operation.js:199:20)
    at async executeOperation (/work/apps/alias-server/node_modules/mongodb/lib/operations/execute_operation.js:69:16)
    at async Collection.updateOne (/work/apps/alias-server/node_modules/mongodb/lib/collection.js:204:16)
    at async Object.updateServerState (/work/apps/alias-server/src/db.js:28:92)
    at async initializeDb (/work/apps/alias-server/src/db.js:21:26)
    at async Context.<anonymous> (/work/apps/alias-server/test/app.test.js:35:18) {
  errorResponse: {
    ok: 0,
    errmsg: 'interrupted at shutdown',
    code: 11600,
    codeName: 'InterruptedAtShutdown'
  },
  ok: 0,
  code: 11600,
  codeName: 'InterruptedAtShutdown',
  [Symbol(errorLabels)]: Set(1) { 'ResetPool' }
}
Initialized serverState on app startup
Configured connection to database ecashAliases
Connected successfully to MongoDB server
Initialized serverState on app startup
Configured connection to database ecashAliases
Build alias-server-tests timed out after 3600.0s
Dec 26 2024, 17:29
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Piece of Eight token.
Dec 26 2024, 17:28
bytesofman added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.

@bot alias-server-tests

Dec 26 2024, 17:28
teamcity added a comment to D17398: [CI] Improve handling of JS dependencies in build-configurations CI.
Dec 26 2024, 17:06
bytesofman published D17398: [CI] Improve handling of JS dependencies in build-configurations CI for review.
Dec 26 2024, 16:51
teamcity awarded D17398: [CI] Improve handling of JS dependencies in build-configurations CI a Haypence token.
Dec 26 2024, 16:04
teamcity awarded D17397: depends: xcb-proto 1.15.2 a Haypence token.
Dec 26 2024, 15:17
Fabien added a comment to D17397: depends: xcb-proto 1.15.2.

@bot guix-linux

Dec 26 2024, 15:17
teamcity updated the summary of D17397: depends: xcb-proto 1.15.2.
Dec 26 2024, 15:13
Fabien requested review of D17397: depends: xcb-proto 1.15.2.
Dec 26 2024, 15:13
teamcity awarded D17396: [chronik] Upgrade karyon_jsonrpc library to 0.2.0 a Haypence token.
Dec 26 2024, 14:11
Fabien added a comment to D17396: [chronik] Upgrade karyon_jsonrpc library to 0.2.0.

@bot guix-linux guix-win guix-osx

Dec 26 2024, 14:11
teamcity added a comment to D17396: [chronik] Upgrade karyon_jsonrpc library to 0.2.0.
Dec 26 2024, 14:07
teamcity added a comment to D17396: [chronik] Upgrade karyon_jsonrpc library to 0.2.0.
Dec 26 2024, 13:59
Fabien requested review of D17396: [chronik] Upgrade karyon_jsonrpc library to 0.2.0.
Dec 26 2024, 13:59
bytesofman added inline comments to D17394: [Cashtab] Convert Etokens screen to ts.
Dec 26 2024, 13:47
bytesofman updated the diff for D17394: [Cashtab] Convert Etokens screen to ts.

use same type check bail-out throughout component

Dec 26 2024, 13:46
Fabien closed D17392: Wait for remote proof messages in functional tests.
Dec 26 2024, 10:16
Fabien committed rABCd64d5e3aa9fd: Wait for remote proof messages in functional tests (authored by Fabien).
Wait for remote proof messages in functional tests
Dec 26 2024, 10:15
Fabien closed D17390: Improve Indices on pruned nodes via prune blockers.
Dec 26 2024, 10:05
Fabien committed rABC3d14146b567c: Improve Indices on pruned nodes via prune blockers (authored by Fabien).
Improve Indices on pruned nodes via prune blockers
Dec 26 2024, 10:05
Fabien added a comment to D17392: Wait for remote proof messages in functional tests.

This CI issue appeared with a Teamcity update and has been reported to JetBrains. It causes random failure to fetch the sources which is super annoying

Dec 26 2024, 09:49
teamcity added a comment to D17392: Wait for remote proof messages in functional tests.
Dec 26 2024, 09:48

Dec 25 2024

PiRK accepted D17392: Wait for remote proof messages in functional tests.
Dec 25 2024, 22:32
bytesofman closed D17395: [Cashtab] Link to Cashtab token page instead of explorer for NFTs in a collection.
Dec 25 2024, 00:43
bytesofman committed rABC760983110925: [Cashtab] Link to Cashtab token page instead of explorer for NFTs in aโ€ฆ (authored by bytesofman).
[Cashtab] Link to Cashtab token page instead of explorer for NFTs in aโ€ฆ
Dec 25 2024, 00:43
emack accepted D17395: [Cashtab] Link to Cashtab token page instead of explorer for NFTs in a collection.
Dec 25 2024, 00:03
emack requested changes to D17394: [Cashtab] Convert Etokens screen to ts.
Dec 25 2024, 00:01

Dec 24 2024

PiRK accepted D17390: Improve Indices on pruned nodes via prune blockers.
Dec 24 2024, 16:28
bytesofman published D17395: [Cashtab] Link to Cashtab token page instead of explorer for NFTs in a collection for review.
Dec 24 2024, 14:51
bytesofman published D17394: [Cashtab] Convert Etokens screen to ts for review.
Dec 24 2024, 14:46
bytesofman closed D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat.
Dec 24 2024, 01:20
bytesofman committed rABC1aca7699cbc4: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat (authored by bytesofman).
[Cashtab] Add toggle switch to show Agora prices in XEC or fiat
Dec 24 2024, 01:20
bytesofman added inline comments to D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat.
Dec 24 2024, 01:16
emack accepted D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat.
Dec 24 2024, 01:09
teamcity awarded D17393: [build-configurations.yml] Clean up dependency management a Piece of Eight token.
Dec 24 2024, 00:13
teamcity awarded D17393: [build-configurations.yml] Clean up dependency management a Haypence token.
Dec 24 2024, 00:05

Dec 23 2024

Fabien updated the diff for D17392: Wait for remote proof messages in functional tests.

Revert accidental newline

Dec 23 2024, 22:21
teamcity added a comment to D17392: Wait for remote proof messages in functional tests.
Dec 23 2024, 22:06
Fabien requested review of D17392: Wait for remote proof messages in functional tests.
Dec 23 2024, 22:06
Fabien updated the diff for D17390: Improve Indices on pruned nodes via prune blockers.

Bump the syncing timeout

Dec 23 2024, 18:13
teamcity added a comment to D17390: Improve Indices on pruned nodes via prune blockers.
Dec 23 2024, 17:56
Fabien updated the diff for D17390: Improve Indices on pruned nodes via prune blockers.

Add core#25123

Dec 23 2024, 17:38
Fabien updated the summary of D17390: Improve Indices on pruned nodes via prune blockers.
Dec 23 2024, 17:37
Fabien planned changes to D17390: Improve Indices on pruned nodes via prune blockers.
Dec 23 2024, 17:32
teamcity added a comment to D17390: Improve Indices on pruned nodes via prune blockers.
Dec 23 2024, 16:31
Fabien updated the diff for D17390: Improve Indices on pruned nodes via prune blockers.

Bump the coinstatindex syncing timeout

Dec 23 2024, 16:09
Fabien closed D17387: Fix a race in abc_p2p_avalanche_remote_proofs.py.
Dec 23 2024, 15:53
Fabien committed rABC504a0b703be6: Fix a race in abc_p2p_avalanche_remote_proofs.py (authored by Fabien).
Fix a race in abc_p2p_avalanche_remote_proofs.py
Dec 23 2024, 15:53
Fabien closed D17389: init: disallow reindex-chainstate when pruning.
Dec 23 2024, 15:53
Fabien committed rABC541bfc8db064: init: disallow reindex-chainstate when pruning (authored by Martin Zumsande <mzumsande@gmail.com>).
init: disallow reindex-chainstate when pruning
Dec 23 2024, 15:53
Fabien closed D17388: test: check for invalid `-prune` parameters.
Dec 23 2024, 15:53
Fabien committed rABC65eec8ee3f69: test: check for invalid `-prune` parameters (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: check for invalid `-prune` parameters
Dec 23 2024, 15:52
Fabien planned changes to D17390: Improve Indices on pruned nodes via prune blockers.
Dec 23 2024, 15:47
PiRK accepted D17389: init: disallow reindex-chainstate when pruning.
Dec 23 2024, 15:42
PiRK accepted D17388: test: check for invalid `-prune` parameters.
Dec 23 2024, 15:39
bytesofman added a comment to D17328: [token-server] Bump free xec from 42 to 88.

haven't forgotten about this btw but waiting for a good time to pull the trigger.

Dec 23 2024, 15:11
bytesofman updated the test plan for D17391: [Cashtab] Add toggle switch to show Agora prices in XEC or fiat.
Dec 23 2024, 14:45