Longer explanation:

https://reviews.bitcoinabc.org/D5297

(add depends on 0.21 update)

Yes this works because the mempool is being reprocessed now due to another upgrade, as the reversebytes thing D5130 (==D5283) is landed already. 👍
(that's not bad btw, I rely on the same in my now-landed D5224 tests)

@dagurval this is the only way I know how to do these kinds of tests. We have never written tests that depend explicitly on --with-phononactivation and we avoid writing tests that directly invoke time(), so that would be pretty weird if you did that. In other words we write tests that are either testing activation-independent behaviour, or if they are sensitive then they must handle their own activation parameters and override any effect that --with-phononactivation might have, like you've done here.

I won't block this as I'm not confident to effectively review its substance, but good to see the build failures are showing up now.

In D5282#127660, @deadalnix wrote:

The builds are clean.

All good!

Thanks! I'm going to give this a whirl... (I was the one having pyenv issues 😊 )

just rebase

Where is the spec for this? If there isn't any yet, one can be put under doc/abc/ . It's not clear what is the intended behaviour in simple language -- how does activation work, when does rule take effect, when does rule stop taking effect, etc etc.

For the record in future (as this is going to happen again and again) the required change to fix this kind of thing is not hard, you just need to change the generate rpc to generatetoaddress rpc, see D5267.

update test to work with nowallet build

update func test to work with nowallet build

update functional test to work with nowallet build

I am guessing this is due to D5184, and we are going to see this happen over and over until nowallet build is added to the Diff testing CI

fix the build fail

Teamcity is not able to post build failures here unless it's given permission (it's not part of Bitcoin ABC group) -- if you want that you have to add it to policy as a second entry.

update after D5130 landing, now the mempool is reprocessed on upgrade so this has no dependencies.

simple rebase

simple rebase

putting in a name : axion

Good!

Best runner so far: Axion

I think I am going to leave off the virtualsize tests to a separate Diff, to keep this focussed on consensus behaviour. (It's not like we're introducing any new virtualsize behaviours, just changing what count is used)

fixed parent

minor text fix (will not change result after child)

actually various wrong params -- moved to D5257

braces; drop nonexistent param

update per nit

bump

update comments with --child-silent-after-fork=yes

Should be fixed now by D5254, please rebase.

update based on D5254

see D5254

In D5214#126782, @teamcity wrote:

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Opening this now to take suggestions on names. :-)

update comment

(the 5 remaining reachable leaked blocks are: 4 from leveldb, 1 from LogInstance)

update per comments; still todo: virtualsize test

In D5214#126699, @teamcity wrote:

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_directory
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_is_not_relative
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] init_tests.walletinit_verify_walletdir_no_trailing2
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.psbt_updater_test
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] psbt_wallet_tests.parse_hd_keypath
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.importwallet_rescan
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.coin_mark_dirty_immature_credit
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ComputeTimeSmart
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.LoadReceiveRequests
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.ListCoins
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_tests.wallet_disableprivkeys
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_name
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_purpose
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.write_erase_destdata
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] walletdb_tests.no_dest_fails
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.passphrase
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.encrypt
[01:41:23]i:		 [Bitcoin_ABC_unit_tests] wallet_crypto_tests.decrypt
[01:42:52] :	 [Step 1/1] Running 454 test cases...
[01:42:52] :	 [Step 1/1] 
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:341
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:345
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:355
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:52] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365
[01:42:52] :	 [Step 1/1] Assertion occurred in a following context:
[01:42:58]W:	 [Step 1/1] corrupted double-linked list
[01:42:58] :	 [Step 1/1]     ../src/test/sigcheckcount_tests.cpp:365../src/test/util_tests.cpp(1368):  [1;31;49merror: in "util_tests/test_LockDirectory": check processstatus == 0 has failed [11 != 0] [0;39;49m
[01:43:04]W:	 [Step 1/1] 
[01:43:04]W:	 [Step 1/1]  [1;31;49m*** 1 failure is detected in the test module "Bitcoin ABC unit tests with next upgrade activated"
[01:43:04]W:	 [Step 1/1]  [0;39;49m
[01:43:04]W:	 [Step 1/1] Process exited with code 201
[01:43:04]E:	 [Step 1/1] Process exited with code 201 (Step: Command Line)

Each failure log is accessible here:
Bitcoin_ABC_unit_tests_with_next_upgrade_activated: util_tests.test_LockDirectory

fix //!< comments to be in front

a few examples of the changes:

better IsMine comment