User Details
User Details
- User Since
- Aug 7 2017, 01:36 (385 w, 1 d)
Mar 17 2024
Mar 17 2024
• draghtnight awarded T258: Quality Assurance Improvements a Mountain of Wealth token.
Jun 29 2021
Jun 29 2021
schancel updated the diff for D9694: Ensure `nExtraNonce` is initialized randomly.
Removing deterministic check on txout dump. Does not seem to be
testable given that block hashes and txout hashes are no longer
deterministic on regtest.
Jun 23 2021
Jun 23 2021
schancel added a comment to D9694: Ensure `nExtraNonce` is initialized randomly.
Will look at the second test that's broken later.
schancel updated the diff for D9694: Ensure `nExtraNonce` is initialized randomly.
Fixes rpc_blockchain. It should have used assert_approx, but dependented on
the deterministic nature of the extra nonce.
schancel requested review of D9694: Ensure `nExtraNonce` is initialized randomly.
Aug 27 2020
Aug 27 2020
rottengonzo awarded T246: Testing scripts should run all tests a Like token.
Aug 26 2020
Aug 26 2020
Tom39 awarded T321: Create test to check node banning behavior a Like token.
Sep 19 2019
Sep 19 2019
Fix lock reference in miner.h
Sep 18 2019
Sep 18 2019
schancel committed rSTAGING819b0da6cb91: [mining] Add a test for TestCBlockTemplateEntry (authored by schancel).
[mining] Add a test for TestCBlockTemplateEntry
schancel committed rSTAGING30a7f3e07d22: [nit] do not capture unused `this` in wallet interface (authored by schancel).
[nit] do not capture unused `this` in wallet interface
schancel committed rSTAGINGcebcb34c93c0: [mining] Rename several CBlockTemplateEntry members for clarity (authored by schancel).
[mining] Rename several CBlockTemplateEntry members for clarity
schancel committed rSTAGINGa9acc46b47f0: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction` (authored by schancel).
[nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`
schancel committed rSTAGING64cf5c985353: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py (authored by schancel).
[qa] [nit] remove extranous variable in mining_prioritisetransaction.py
schancel committed rSTAGING3623cccdc6ff: Nits in abc-high_priority_transaction.py (authored by schancel).
Nits in abc-high_priority_transaction.py
schancel committed rSTAGING36fb94ee0821: Remove much of the remaining BIP9 code (authored by schancel).
Remove much of the remaining BIP9 code
schancel committed rSTAGINGa57aebfd30e6: [Part 4 of 5] Add a CChainState class to clarify internal interfaces (authored by Matt Corallo <git@bluematt.me>).
[Part 4 of 5] Add a CChainState class to clarify internal interfaces
schancel committed rSTAGING1201c8ad49e4: Remove unused depends list from `getblocktemplate` transactions (authored by schancel).
Remove unused depends list from `getblocktemplate` transactions
schancel committed rSTAGING0043646b87d1: Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked` (authored by schancel).
Remove unused parameter `validFeeEstimates` from `CTxMempool::addUnchecked`
schancel committed rSTAGINGe3e4e04a390f: Fix comment in CheckInputs to match changed code (authored by schancel).
Fix comment in CheckInputs to match changed code
schancel committed rSTAGING20f59d582b2b: [Part 3 of 5] Add a CChainState class to clarify internal interfaces (authored by Matt Corallo <git@bluematt.me>).
[Part 3 of 5] Add a CChainState class to clarify internal interfaces
Aug 24 2019
Aug 24 2019
James awarded T321: Create test to check node banning behavior a Mountain of Wealth token.
Jun 16 2019
Jun 16 2019
Fix lock reference in miner.h
schancel updated the test plan for D3351: Fix lock reference in miner.h.
schancel retitled D3351: Fix lock reference in miner.h from Fix lock reference in miner.cpp to Fix lock reference in miner.h.
Jun 3 2019
Jun 3 2019
markblundeberg awarded D2788: Remove unknown version warning from UpdateTip a Piece of Eight token.
Jun 2 2019
Jun 2 2019
schancel added a comment to D2866: [mining] Implement new package selection code which is independent of chain length.
Rebase
schancel added a comment to D3164: [mining] Track maximum feerate of parent packages.
Rebase
schancel added a comment to D2865: [mining] Change inBlock to be an unordered set.
Rebase
schancel added a comment to D2864: [mining] Add package accounting functions to CBlockTemplateEntry.
Fix comments
Jun 1 2019
Jun 1 2019
schancel committed rABC819b0da6cb91: [mining] Add a test for TestCBlockTemplateEntry (authored by schancel).
[mining] Add a test for TestCBlockTemplateEntry
schancel committed rABC30a7f3e07d22: [nit] do not capture unused `this` in wallet interface (authored by schancel).
[nit] do not capture unused `this` in wallet interface
schancel updated the diff for D2866: [mining] Implement new package selection code which is independent of chain length.
size_t -> bool ...
May 31 2019
May 31 2019
Herald added a reviewer for D3166: [nit] do not capture unused `this` in wallet interface: deadalnix.
schancel updated the summary of D3028: [mempool] remove `CompareTxMemPoolEntryByAncestorFee` as it is no longer needed.
schancel updated the diff for D2866: [mining] Implement new package selection code which is independent of chain length.
Rebase on diffs that were split up more for clarity.
schancel updated the summary of D2866: [mining] Implement new package selection code which is independent of chain length.
schancel updated the summary of D3164: [mining] Track maximum feerate of parent packages.
schancel updated the diff for D2865: [mining] Change inBlock to be an unordered set.
Rebase
schancel updated the diff for D2864: [mining] Add package accounting functions to CBlockTemplateEntry.
Rebase with a test
schancel updated the summary of D2863: [mining] Add fields for tracking package data..
schancel updated the diff for D2863: [mining] Add fields for tracking package data..
Rebase on D3162
schancel added inline comments to D2866: [mining] Implement new package selection code which is independent of chain length.
May 13 2019
May 13 2019
schancel added a comment to D3013: [rpc] Move tojson.h into blockchain.h.
Okay, I see. That's weird -- still not sure *toJSON functions should go there, but okay.
schancel added a comment to D3013: [rpc] Move tojson.h into blockchain.h.
I think more and more stuff should be better organized. Core doesn't seem to care about separating stuff out much.
May 12 2019
May 12 2019
schancel added inline comments to D3013: [rpc] Move tojson.h into blockchain.h.
schancel requested changes to D3013: [rpc] Move tojson.h into blockchain.h.
I think these should be left in place.
schancel updated the summary of D3027: [mining] Delete accuratelyAddPackageTxns and its associates.
Herald added a reviewer for D3029: [move] move TxCoinAgePriority to it's sole usage location.: deadalnix.
Herald added a reviewer for D3027: [mining] Delete accuratelyAddPackageTxns and its associates: deadalnix.
May 10 2019
May 10 2019
schancel updated the diff for D2863: [mining] Add fields for tracking package data..
packageOrder(1) -> packageOrder(0)
schancel added inline comments to D2864: [mining] Add package accounting functions to CBlockTemplateEntry.
schancel added inline comments to D2864: [mining] Add package accounting functions to CBlockTemplateEntry.
May 9 2019
May 9 2019
schancel added inline comments to D2863: [mining] Add fields for tracking package data..
schancel updated the diff for D2863: [mining] Add fields for tracking package data..
Update comment on the order field
schancel updated the diff for D2863: [mining] Add fields for tracking package data..
Rebase and fix a couple errors in the comments.
schancel committed rABCcebcb34c93c0: [mining] Rename several CBlockTemplateEntry members for clarity (authored by schancel).
[mining] Rename several CBlockTemplateEntry members for clarity
schancel updated the diff for D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Update for clarity that the comment pertains only to the coinbase
schancel updated the summary of D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
schancel updated the diff for D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Update with comment per @jasonbcox
May 5 2019
May 5 2019
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Apr 25 2019
Apr 25 2019
schancel added inline comments to D2863: [mining] Add fields for tracking package data..
schancel committed rABCa9acc46b47f0: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction` (authored by schancel).
[nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`
Apr 24 2019
Apr 24 2019
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
schancel requested review of D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
schancel requested review of D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Apr 23 2019
Apr 23 2019
schancel added inline comments to D2866: [mining] Implement new package selection code which is independent of chain length.
schancel updated the diff for D2866: [mining] Implement new package selection code which is independent of chain length.
Fix rebase error on packageOrder
schancel updated the diff for D2866: [mining] Implement new package selection code which is independent of chain length.
Update some comments
schancel updated the diff for D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.
Make identical to core pr cited
schancel updated the summary of D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.
schancel committed rABC64cf5c985353: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py (authored by schancel).
[qa] [nit] remove extranous variable in mining_prioritisetransaction.py
schancel updated the summary of D2866: [mining] Implement new package selection code which is independent of chain length.
schancel updated the summary of D2865: [mining] Change inBlock to be an unordered set.
Herald added a reviewer for D2864: [mining] Add package accounting functions to CBlockTemplateEntry: deadalnix.
schancel updated the diff for D2863: [mining] Add fields for tracking package data..
Change name of packageCount and add some explanatory comments
schancel retitled D2863: [mining] Add fields for tracking package data. from Add fields for tracking package data. to [mining] Add fields for tracking package data..
Herald added a reviewer for D2862: [mining] Rename several CBlockTemplateEntry members for clarity: deadalnix.
Apr 22 2019
Apr 22 2019
Herald added a reviewer for D2854: [qa] [nit] remove extranous variable in mining_prioritisetransaction.py: deadalnix.
Herald added a reviewer for D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`: deadalnix.
Apr 21 2019
Apr 21 2019