Another way this script can be improved is to only run if the previous run has a different HEAD commit than latest master, though this feature isn't strictly necessary for MVP.

While refactoring, I realized that this won't be used anymore. There's no use it adding it to the config.

This script already exists, for the most part: contrib/teamcity/ibd.sh Update it so that we can pass in -assumevalid=0 -checkpoints=0

As part of this ticket, investigate to see if -txconfirmtarget is useful at all anymore. It's likely that we can get rid of it entirely.

In the interest of facilitating backports, we will either not do this or put it off for a long time. Closing this ticket for now.

In the interest of facilitating backports, we will either not do this or put it off for a long time. Closing this ticket for now.

In the interest of facilitating backports, we will either not do this or put it off for a long time. Closing this ticket for now.

In the interest of facilitating backports, we will either not do this or put it off for a long time. Closing this ticket for now.

In the interest of facilitating backports, we will either not do this or put it off for a long time. Closing this ticket for now.

In the interest of facilitating backports, we will either not do this or put it off for a long time. Closing this ticket for now.

This documentation states that Apple has deprecated this functionality purposely on their lib, and it would be replaced by launchd.

D2191: no more -Wmissing-braces warnings

@deadalnix Is this done?

I don't have a way to assign this to myself, but I put up a diff for this: https://reviews.bitcoinabc.org/D1743

The function uses the global variable vinfoBlockFile, however, this function is locked away in an anonymous namespace. I'm not sure this change is actually worth making at this point as it would require either naming the namespace or moving the the variable outside of the namespace.

Ideally, yes. It's possible there are some dependencies, so breaking it up wherever it makes sense is fine. The goal is to separate the test so that each part is in it's own testable, modifiable chunk. There's no need to run a bunch of unrelated tests (and potentially break them with unrelated changes) just because they're part of the same file.

https://reviews.bitcoinabc.org/D554 for Shammah's fee changes, which is a dependency for this task.

Also move /test/README.md

So is it assumed that the parameters are global to the state? The design becomes a little bit more efficient in some regards if the parameter as given in the example is considered global to the run of the program vs living in the "config" object.

I like this task I can take a shot at it.

Yhis will require special privileges, so I'm not sure we want to bootcamp this.