In src/tests/lcg.h it should pick up the same problem, does it?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 20 2019
May 20 2019
markblundeberg updated the summary of D3075: Merge #11872: [rpc] createrawtransaction: Accept sorted outputs.
Herald added a reviewer for D3075: Merge #11872: [rpc] createrawtransaction: Accept sorted outputs: deadalnix.
markblundeberg updated the diff for D3072: Merge #11877: Improve createrawtransaction functional tests.
rebased for D3071
Hey, just a heads up that this partly overlaps with D3021. Also when you're backporting things from Bitcoin Core, please make sure to mark them as backports and mention the PR number in the description.
markblundeberg updated the diff for D3072: Merge #11877: Improve createrawtransaction functional tests.
relint
Does not actually depend on that...
markblundeberg removed a parent task for T638: Backport Core PR 11738 (fix hang in sendrawtransaction): T639: Backport Core PR 11877 (tests).
markblundeberg added a comment to D3072: Merge #11877: Improve createrawtransaction functional tests.
nb: needs to be re-linted apparently
Herald added a reviewer for D3072: Merge #11877: Improve createrawtransaction functional tests: deadalnix.
Herald added a reviewer for D3071: Merge #12278: Add special error for genesis coinbase to getrawtransaction: deadalnix.
May 19 2019
May 19 2019
markblundeberg updated the summary of D2924: [txindex] Activate new transaction index code that runs in background.
markblundeberg updated the diff for D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
rebased & separated out config removal into D3070
markblundeberg updated the diff for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
rebase
May 16 2019
May 16 2019
markblundeberg accepted D3035: New -includeconf argument for including external configuration files.
OK :)
May 14 2019
May 14 2019
markblundeberg requested review of D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
In D3014#71749, @deadalnix wrote:Please write a proper test plan.
markblundeberg updated the test plan for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
markblundeberg updated the diff for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
rebase for retest (same random rpc_listtransactions.py failure occured earlier in D2750)
markblundeberg updated the diff for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
update per Fabien comments
markblundeberg added inline comments to D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
markblundeberg added inline comments to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
markblundeberg added inline comments to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
markblundeberg added a comment to D3026: Merge #10267: New -includeconf argument for including external configuration files.
In D3026#71602, @Fabien wrote:Clearing my queue, see D3035
May 13 2019
May 13 2019
markblundeberg updated the diff for D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
rebase ; change casting style per comments
markblundeberg updated the diff for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
rebase
In D3013#71477, @schancel wrote:Okay, I see. That's weird -- still not sure *toJSON functions should go there, but okay.
markblundeberg added a comment to D3035: New -includeconf argument for including external configuration files.
Ah I see the extra clause is the fix you mention.
markblundeberg added a comment to D3035: New -includeconf argument for including external configuration files.
Which one should we do? ( D3026 ) 馃槀
markblundeberg added inline comments to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
In D3013#71320, @schancel wrote:I think more and more stuff should be better organized. Core doesn't seem to care about separating stuff out much.
However, this is just my opinion. It seems Amaury shared it. I hope we don't prevent ourself from making needed organizational changes indefinitely because of backports.
add static
In D3013#71305, @schancel wrote:I think these should be left in place.
May 12 2019
May 12 2019
May 12 2019, 14:22 路 Restricted Project
markblundeberg renamed T568: Backport PR12718 "[Tests] Require exact match in assert_start_raises_init_error" from Backport PR12718 to Backport PR12718 "[Tests] Require exact match in assert_start_raises_init_error".
May 12 2019, 13:47 路 Restricted Project
May 12 2019, 13:17 路 Restricted Project
markblundeberg added inline comments to D3012: Backport current GetDifficulty logic (& tests) from Core.
markblundeberg added a subtask for T540: Backport Core PR12755: T568: Backport PR12718 "[Tests] Require exact match in assert_start_raises_init_error".
May 12 2019, 01:45 路 Restricted Project
markblundeberg added a parent task for T568: Backport PR12718 "[Tests] Require exact match in assert_start_raises_init_error": T540: Backport Core PR12755.
May 12 2019, 01:45 路 Restricted Project
May 12 2019, 01:40 路 Restricted Project
May 12 2019, 01:40 路 Restricted Project
markblundeberg added a parent task for T540: Backport Core PR12755: T650: Backport Core PR 13197 "util: warn about ignored recursive -includeconf calls".
May 12 2019, 01:16 路 Restricted Project
markblundeberg updated the diff for D3026: Merge #10267: New -includeconf argument for including external configuration files.
move release notes into main doc
May 11 2019
May 11 2019
markblundeberg added a comment to D3026: Merge #10267: New -includeconf argument for including external configuration files.
Note 13197 should be backported fairly soon too (T650)
markblundeberg triaged T650: Backport Core PR 13197 "util: warn about ignored recursive -includeconf calls" as Normal priority.
markblundeberg added a parent task for T541: Backport Core PR10267 to support includeconf: T650: Backport Core PR 13197 "util: warn about ignored recursive -includeconf calls".
May 11 2019, 23:50 路 Restricted Project
markblundeberg added a revision to T541: Backport Core PR10267 to support includeconf: D3026: Merge #10267: New -includeconf argument for including external configuration files.
May 11 2019, 23:43 路 Restricted Project
May 10 2019
May 10 2019
markblundeberg accepted D2983: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment.
Looks good, thanks!
fix oopsie noticed by Jason
update per Jason comments
markblundeberg added a comment to D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
Due to divergent histories, the blockchain_tests affected in original PR do not exist yet in ABC; this will be fixed in child diff (D3012)
markblundeberg updated the diff for D3012: Backport current GetDifficulty logic (& tests) from Core.
rebase onto D3021
markblundeberg updated the summary of D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`.
markblundeberg updated the summary of D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON.
Herald added a reviewer for D3021: Merge #12151: rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON: deadalnix.
markblundeberg updated the summary of D3012: Backport current GetDifficulty logic (& tests) from Core.
note: TxToJSON is not in blockchain.cpp and doesn't need to be in a header either
markblundeberg updated the diff for D3012: Backport current GetDifficulty logic (& tests) from Core.
rebase onto 10095 backport
Herald added a reviewer for D3014: Merge #10095: refactor: Move GetDifficulty out of `rpc/server.h`: deadalnix.
markblundeberg retitled D3012: Backport current GetDifficulty logic (& tests) from Core from Backport GetDifficulty logic from Core to Backport current GetDifficulty logic from Core.
Herald added a reviewer for D3012: Backport current GetDifficulty logic (& tests) from Core: deadalnix.
Herald added a reviewer for D3011: Merge #9833: Trivial: fix comments referencing AppInit2: deadalnix.
T648 too
still exists in this form in Core.
markblundeberg added inline comments to D2939: [backport PR12653] Allow to optional specify the directory for the blocks storage.
markblundeberg updated the diff for D2939: [backport PR12653] Allow to optional specify the directory for the blocks storage.
rebase ; braces
markblundeberg updated the task description for T636: Backport PR 12653 "Allow to optional specify the directory for the blocks storage".
May 9 2019
May 9 2019
markblundeberg added a parent task for T568: Backport PR12718 "[Tests] Require exact match in assert_start_raises_init_error": T648: Backport PR 12806 qa: Fix function names in feature_blocksdir.
May 9 2019, 23:59 路 Restricted Project
markblundeberg triaged T648: Backport PR 12806 qa: Fix function names in feature_blocksdir as Low priority.
I see, you mean that D1049 backported PR11022 already?