Build Bitcoin-ABC / Diffs / Diff Testing passed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Nov 12 2019
Nov 12 2019
Build Bitcoin-ABC / Diffs / Diff Testing started.
Update variable name to better reflect the intent.
teamcity added a comment to D4425: [CMAKE] Avoid dependencies when building native bin during cross build.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
teamcity added a comment to D4425: [CMAKE] Avoid dependencies when building native bin during cross build.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4425: [CMAKE] Avoid dependencies when building native bin during cross build.
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Harbormaster failed remote builds in B8071: Diff 14068 for D4425: [CMAKE] Avoid dependencies when building native bin during cross build!
teamcity added a comment to D4425: [CMAKE] Avoid dependencies when building native bin during cross build.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien updated the diff for D4425: [CMAKE] Avoid dependencies when building native bin during cross build.
Improve comment.
[CMAKE] Actually build the DMG image
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Moved function to TestSuite.cmake. Function now also handles searching for the boost package and linking the library to the executable.
What is the purpose of the OutputType for us, intended that we don't do segwit ?
Agreed with @deadalnix, clearing my queue.
This seems to me that it is doing half of the work:
- You set a boost library as a requirement, but you don't search for it
- You add a boost unit test specific definition, but you don't link the executable to the boost library
- Intended that this is test specific, why not put it to the TestSuite.cmake module ? The proposed module, by its name and content will likely never contain anything more than this very specific function.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Changed CMake names to be more descriptive, Updated copyright missing copyright lines, fixed formatting, and rebased to remove duplicate code.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
deadalnix committed rABCef4d3766839c: Get rid of ambiguous OutputType::NONE value (authored by Russell Yanofsky <russ@yanofsky.org>).
Get rid of ambiguous OutputType::NONE value
Nov 11 2019
Nov 11 2019
teamcity triaged T690: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
deadalnix committed rABC28f918df531c: Fix unecessary copies in rpcwallet.cpp (authored by deadalnix).
Fix unecessary copies in rpcwallet.cpp
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
rebase and fix merge conflict
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
deadalnix committed rABC11ca044a129f: Add scantxoutset RPC method (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Add scantxoutset RPC method
LGTM excepted a few nits
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Reduce the amount of dependencies required by rebasing on top of D4425.
Disable ccache for the build.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
teamcity added a comment to D4425: [CMAKE] Avoid dependencies when building native bin during cross build.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Reduce the amount of dependencies required by rebasing on top of D4425.
Disable ccache for the build.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Reduce the amount of dependencies required by rebasing on top of D4425.
Disable ccache for the build.
teamcity added a comment to D4425: [CMAKE] Avoid dependencies when building native bin during cross build.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien planned changes to D4406: [CMAKE] Build a stripped version of the application bundle and use it.
I have another solution which can be more elegant to this problem, so moving this diff out of the review queue for now.
[CMAKE] Install DLL to bin/ by default
Fabien committed rABC146f6e2a8079: [CMAKE] Complete the dist directory to prepare for the DMG image build (authored by Fabien).
[CMAKE] Complete the dist directory to prepare for the DMG image build
Fabien committed rABCa823d2833233: [CMAKE] Build the background dist image on native OSX (authored by Fabien).
[CMAKE] Build the background dist image on native OSX
Fabien committed rABCa2e804693cdc: [CMAKE] Add the background image to the dist directory (authored by Fabien).
[CMAKE] Add the background image to the dist directory
Fabien committed rABCa89e8e99843f: [CMAKE] Create a distribution directory with translations (authored by Fabien).
[CMAKE] Create a distribution directory with translations
Fabien committed rABC21a33b011a58: [CMAKE] Prepare the application bundle for localization (authored by Fabien).
[CMAKE] Prepare the application bundle for localization
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Nov 10 2019
Nov 10 2019
Build Bitcoin-ABC / Diffs / Diff Testing passed.
You can include this with the test. It's not really possible to figure out if that is a good idea or not without having an idea of where this is going.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fabien requested review of D4406: [CMAKE] Build a stripped version of the application bundle and use it.