Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Oct 22 2020

jasonbcox requested review of D8059: Add more release notes.
Oct 22 2020, 16:05

Oct 21 2020

jasonbcox requested changes to D8026: [backport#14696 2/2] New regression testing for CVE-2018-17144, CVE-2012-2459, and CVE-2010-5137..
Oct 21 2020, 21:53
jasonbcox closed D8031: Merge #15772: test: Properly log named args in authproxy.
Oct 21 2020, 21:41
jasonbcox committed rABC0064e37fff35: Merge #15772: test: Properly log named args in authproxy (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15772: test: Properly log named args in authproxy
Oct 21 2020, 21:41
jasonbcox requested review of D8034: Merge #13928: qa: blocktools enforce named args for amount.
Oct 21 2020, 21:35
jasonbcox closed D8033: Merge #14664: example_test.py: fixup coinbase height argument, derive number clearly.
Oct 21 2020, 21:28
jasonbcox committed rABC438ec29b07f7: Merge #14664: example_test.py: fixup coinbase height argument, derive number… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14664: example_test.py: fixup coinbase height argument, derive number…
Oct 21 2020, 21:28
jasonbcox closed D8030: [build-bot] Fix skipping comments in ignore list.
Oct 21 2020, 21:21
jasonbcox committed rABCa99c8c9710a8: [build-bot] Fix skipping comments in ignore list (authored by jasonbcox).
[build-bot] Fix skipping comments in ignore list
Oct 21 2020, 21:21
jasonbcox accepted D8012: Add <datadir>/settings.json persistent settings storage..
Oct 21 2020, 21:18
jasonbcox closed D8028: [build-bot] Use unittest.assert* instead of plain asserts.
Oct 21 2020, 21:01
jasonbcox committed rABCab27bf8d7a87: [build-bot] Use unittest.assert* instead of plain asserts (authored by jasonbcox).
[build-bot] Use unittest.assert* instead of plain asserts
Oct 21 2020, 21:01
jasonbcox closed D8032: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes.
Oct 21 2020, 20:47
jasonbcox committed rABC25ce183dcc9f: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15631: qa: mininode: Clearer error message on invalid magic bytes
Oct 21 2020, 20:47
jasonbcox closed D7994: [build-bot] Persist build info between redeployments.
Oct 21 2020, 19:54
jasonbcox committed rABC594d974a35d2: [build-bot] Persist build info between redeployments (authored by jasonbcox).
[build-bot] Persist build info between redeployments
Oct 21 2020, 19:54
jasonbcox closed D8029: [build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds.
Oct 21 2020, 19:39
jasonbcox committed rABC7aec57ad89cd: [build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds (authored by jasonbcox).
[build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds
Oct 21 2020, 19:39
jasonbcox updated the diff for D8030: [build-bot] Fix skipping comments in ignore list.

Added strip() to detect indented comments as well

Oct 21 2020, 19:22
jasonbcox requested review of D8033: Merge #14664: example_test.py: fixup coinbase height argument, derive number clearly.
Oct 21 2020, 18:53
jasonbcox requested review of D8032: Merge #15631: qa: mininode: Clearer error message on invalid magic bytes.
Oct 21 2020, 18:48
jasonbcox closed D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 18:44
jasonbcox added a reverting change for D7729: Revert recent coin selection changes: rABC54fef78d5b20: Revert "Revert recent coin selection changes".
Oct 21 2020, 18:44
jasonbcox committed rABC54fef78d5b20: Revert "Revert recent coin selection changes" (authored by jasonbcox).
Revert "Revert recent coin selection changes"
Oct 21 2020, 18:44
jasonbcox added a reverting change for rABC85f266319f58: Revert recent coin selection changes: rABC54fef78d5b20: Revert "Revert recent coin selection changes".
Oct 21 2020, 18:44
jasonbcox requested review of D8031: Merge #15772: test: Properly log named args in authproxy.
Oct 21 2020, 18:43
jasonbcox requested review of D8030: [build-bot] Fix skipping comments in ignore list.
Oct 21 2020, 18:26
jasonbcox requested review of D8029: [build-bot] Correctly match hex in ignore pattern for flaky Windows cross-builds.
Oct 21 2020, 18:23
jasonbcox requested review of D8028: [build-bot] Use unittest.assert* instead of plain asserts.
Oct 21 2020, 17:26
jasonbcox updated the diff for D7994: [build-bot] Persist build info between redeployments.

Fixed according to feedback

Oct 21 2020, 16:55
jasonbcox updated the diff for D8015: Revert "Revert recent coin selection changes".
  • Rebase
  • Updated summary to better reflect the "why"
Oct 21 2020, 16:28
jasonbcox updated the summary of D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 16:27
jasonbcox closed D8014: test: Set catch_system_errors=no on boost unit tests.
Oct 21 2020, 16:04
jasonbcox committed rABC1a60077296f7: test: Set catch_system_errors=no on boost unit tests (authored by jasonbcox).
test: Set catch_system_errors=no on boost unit tests
Oct 21 2020, 16:04
jasonbcox added inline comments to D8014: test: Set catch_system_errors=no on boost unit tests.
Oct 21 2020, 00:35
jasonbcox requested review of D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:33
jasonbcox added inline comments to D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:14
jasonbcox updated the test plan for D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:13
jasonbcox added a comment to D8015: Revert "Revert recent coin selection changes".

@bot build-tsan

Oct 21 2020, 00:13
jasonbcox planned changes to D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:12
jasonbcox requested review of D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:12
jasonbcox added a reverting change for D7729: Revert recent coin selection changes: D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:12
jasonbcox added a reverting change for rABC85f266319f58: Revert recent coin selection changes: D8015: Revert "Revert recent coin selection changes".
Oct 21 2020, 00:12

Oct 20 2020

jasonbcox requested review of D8014: test: Set catch_system_errors=no on boost unit tests.
Oct 20 2020, 23:46
jasonbcox requested changes to D8012: Add <datadir>/settings.json persistent settings storage..

Back to you. Still a translation issue.

Oct 20 2020, 19:10
jasonbcox accepted D8011: util: Add ReadSettings and WriteSettings functions.
Oct 20 2020, 19:09
jasonbcox closed D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.
Oct 20 2020, 17:33
jasonbcox committed rABC7caa48fc89ba: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept
Oct 20 2020, 17:33
jasonbcox accepted D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().
Oct 20 2020, 16:16
jasonbcox accepted D8008: [backport#16822 3/3] gui: fix autofocus in CreateWalletActivity::askPassphrase().
Oct 20 2020, 16:06
jasonbcox accepted D8007: [backport#16822 2/3] gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog.
Oct 20 2020, 16:05
jasonbcox requested changes to D8006: [backport#16822 1/3] gui: rename encrypt(), blank(), disablePrivateKeys().
Oct 20 2020, 16:04
jasonbcox accepted D8010: [backport#16847] doc: add comments clarifying how local services are advertised.
Oct 20 2020, 16:00
jasonbcox closed D7995: Merge #16931: test: add unittests for CheckProofOfWork.
Oct 20 2020, 15:59
jasonbcox committed rABCa87c1a8f2312: Merge #16931: test: add unittests for CheckProofOfWork (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Merge #16931: test: add unittests for CheckProofOfWork
Oct 20 2020, 15:59
jasonbcox updated the diff for D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.

Rebase

Oct 20 2020, 15:58
jasonbcox accepted D8009: doc: Add detailed info about Bitcoin Core files.
Oct 20 2020, 15:49
jasonbcox accepted D7990: refactor: Pass NodeContext to RPC and REST methods through util::Ref.
Oct 20 2020, 15:44
jasonbcox closed T614: Backport Core PR 11640 as Resolved.
Oct 20 2020, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T613: Backport Core PR 10587 as Resolved.
Oct 20 2020, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T612: Backport Core PR 10408, a subtask of T613: Backport Core PR 10587, as Resolved.
Oct 20 2020, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T612: Backport Core PR 10408 as Resolved.
Oct 20 2020, 00:36 · Bootcamp, Restricted Project
jasonbcox closed T558: Backport Core PR 12830 as Resolved.
Oct 20 2020, 00:35 · Bootcamp, Restricted Project
jasonbcox closed T246: Testing scripts should run all tests as Resolved.
Oct 20 2020, 00:34 · Bootcamp
jasonbcox closed T189: Ensure documentation for new developers is easy to understand as Resolved.

Resolving this since the docs are constantly improving and this task is too open-ended. Patches to improve the docs further are always welcome.

Oct 20 2020, 00:33 · Bootcamp
jasonbcox closed T191: Fix missing-braces warnings. as Resolved.
Oct 20 2020, 00:29 · Bootcamp
jasonbcox closed T321: Create test to check node banning behavior as Resolved.
Oct 20 2020, 00:28 · Bootcamp
jasonbcox updated the diff for D7994: [build-bot] Persist build info between redeployments.

Rebase

Oct 20 2020, 00:27
jasonbcox updated the diff for D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.

Rebase

Oct 20 2020, 00:25
jasonbcox updated the diff for D7995: Merge #16931: test: add unittests for CheckProofOfWork.

Rebase so that CI passes with the new build-debug config

Oct 20 2020, 00:25
jasonbcox requested review of D7996: Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept.
Oct 20 2020, 00:20

Oct 19 2020

jasonbcox requested review of D7995: Merge #16931: test: add unittests for CheckProofOfWork.
Oct 19 2020, 23:58
jasonbcox accepted D7988: rpc: Remove mempool global from miner.
Oct 19 2020, 23:36
jasonbcox requested changes to D7990: refactor: Pass NodeContext to RPC and REST methods through util::Ref.
Oct 19 2020, 22:53
jasonbcox accepted D7989: Add util::Ref class as temporary alternative for c++17 std::any.
Oct 19 2020, 22:48
jasonbcox requested review of D7994: [build-bot] Persist build info between redeployments.
Oct 19 2020, 22:32
jasonbcox accepted D7982: [CI] Improve the error snippet in diffs when a test fails.
Oct 19 2020, 16:19

Oct 16 2020

jasonbcox closed D7966: Merge #17564: rpc: Use mempool from node context instead of global.
Oct 16 2020, 23:39
jasonbcox committed rABC73d648a23683: Merge #17564: rpc: Use mempool from node context instead of global (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #17564: rpc: Use mempool from node context instead of global
Oct 16 2020, 23:39
jasonbcox closed D7965: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers).
Oct 16 2020, 22:23
jasonbcox committed rABC3e158f2af481: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some… (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some…
Oct 16 2020, 22:23
jasonbcox updated the diff for D7966: Merge #17564: rpc: Use mempool from node context instead of global.
  • Removed an unnecessary include
  • Patched changes onto estimateSmartFee since our code diverges from Core
Oct 16 2020, 22:13
jasonbcox planned changes to D7966: Merge #17564: rpc: Use mempool from node context instead of global.
Oct 16 2020, 22:02
jasonbcox requested review of D7966: Merge #17564: rpc: Use mempool from node context instead of global.
Oct 16 2020, 21:52
jasonbcox requested review of D7965: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers).
Oct 16 2020, 21:07
jasonbcox closed D7963: [land-bot] Give a reasonable error when a revision cannot be found.
Oct 16 2020, 19:19
jasonbcox committed rABC39fae5b8b23d: [land-bot] Give a reasonable error when a revision cannot be found (authored by jasonbcox).
[land-bot] Give a reasonable error when a revision cannot be found
Oct 16 2020, 19:19
jasonbcox closed D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 19:09
jasonbcox committed rABC9306dc3d8e81: [land-bot] Allow users to specify the branch/commit in order to determine the… (authored by jasonbcox).
[land-bot] Allow users to specify the branch/commit in order to determine the…
Oct 16 2020, 19:09
jasonbcox requested review of D7963: [land-bot] Give a reasonable error when a revision cannot be found.
Oct 16 2020, 17:52
jasonbcox closed D7468: [land-bot] Add a sanity rebase after running smoke tests.
Oct 16 2020, 17:27
jasonbcox committed rABC12d862c0dffa: [land-bot] Add a sanity rebase after running smoke tests (authored by jasonbcox).
[land-bot] Add a sanity rebase after running smoke tests
Oct 16 2020, 17:27
jasonbcox requested review of D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 16:50
jasonbcox planned changes to D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 16:47
jasonbcox requested review of D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Oct 16 2020, 16:47
jasonbcox accepted D7957: bitcoin-wallet: Add a missing closing parenthesis in the help.
Oct 16 2020, 15:58
jasonbcox accepted D7945: UTXO snapshot creation (dumptxoutset).
Oct 16 2020, 00:56

Oct 15 2020

jasonbcox closed D7940: [build-bot] Fix character escapes in ignore list.
Oct 15 2020, 19:29
jasonbcox committed rABC2c98a843a474: [build-bot] Fix character escapes in ignore list (authored by jasonbcox).
[build-bot] Fix character escapes in ignore list
Oct 15 2020, 19:29
jasonbcox closed D7942: Use new roadmap link.
Oct 15 2020, 19:00
First
Prev
Next