Feed Advanced Search
Apr 19 2024
Apr 19 2024
PiRK committed rABC35519a7612cf: [test] fix broken interface_usdt_utxocache.py test (authored by PiRK).
[test] fix broken interface_usdt_utxocache.py test
PiRK updated the diff for D16021: test: Remove from_node from create_self_transfer* MiniWallet helpers.
fix also interface_usdt_utxocache
PiRK requested review of D16022: [test] fix broken interface_usdt_utxocache.py test.
PiRK planned changes to D16021: test: Remove from_node from create_self_transfer* MiniWallet helpers.
i'm missing a feature_usdt* test
PiRK requested review of D16021: test: Remove from_node from create_self_transfer* MiniWallet helpers.
PiRK committed rABC49ba25cf70e4: validation: Stricter assumeutxo error handling when renaming chainstates (authored by Ryan Ofsky <ryan@ofsky.org>).
validation: Stricter assumeutxo error handling when renaming chainstates
PiRK committed rABC5cfdcd1e6fcd: Replace pindex pointer with block reference (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
Replace pindex pointer with block reference
PiRK committed rABCd893f446d0af: Add BlockManagerOpts::chainparams reference (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
Add BlockManagerOpts::chainparams reference
PiRK committed rABC4fad52ef8211: refactor: Add and use PRUNE_TARGET_MANUAL constexpr (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
refactor: Add and use PRUNE_TARGET_MANUAL constexpr
PiRK committed rABC2b7a66e06daa: Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
Pass fImporting to ImportingNow helper class, Move ::fImporting to BlockManager
PiRK committed rABC0f48c6c439a3: Move ::fPruneMode into BlockManager (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
Move ::fPruneMode into BlockManager
PiRK committed rABC03edbead7c24: Move ::nPruneTarget into BlockManager (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
Move ::nPruneTarget into BlockManager
PiRK committed rABC4990f9bed2bd: Remove reindex special case from the progress bar label (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
Remove reindex special case from the progress bar label
Apr 18 2024
Apr 18 2024
PiRK updated the diff for D16007: Move ::nPruneTarget into BlockManager.
remove blank line before copyright header
PiRK added a comment to D15624: validation: Stricter assumeutxo error handling when renaming chainstates.
PiRK updated the diff for D15624: validation: Stricter assumeutxo error handling when renaming chainstates.
rebase
PiRK updated the summary of D16015: Add BlockManagerOpts::chainparams reference.
PiRK requested review of D16016: Replace pindex pointer with block reference.
PiRK requested review of D16015: Add BlockManagerOpts::chainparams reference.
PiRK committed rABC09ee00dbb2ca: validation tests: Use existing {Chainstate,Block}Man (authored by Carl Dong <contact@carldong.me>).
validation tests: Use existing {Chainstate,Block}Man
Apr 17 2024
Apr 17 2024
PiRK requested review of D16010: refactor: Add and use PRUNE_TARGET_MANUAL constexpr.
PiRK requested review of D16008: Move ::fPruneMode into BlockManager.
PiRK requested review of D16007: Move ::nPruneTarget into BlockManager.
PiRK updated the diff for D16006: Remove reindex special case from the progress bar label.
no need for the else after the return in the previous if
PiRK requested review of D16006: Remove reindex special case from the progress bar label.
PiRK added inline comments to D16004: validation tests: Use existing {Chainstate,Block}Man.
PiRK requested review of D16004: validation tests: Use existing {Chainstate,Block}Man.
Apr 16 2024
Apr 16 2024
PiRK committed rABC88ea3ea9d12e: [electrum] fix flaky tear-down in functional tests (authored by PiRK).
[electrum] fix flaky tear-down in functional tests
PiRK requested review of D15989: [electrum] fix flaky tear-down in functional tests.
Apr 15 2024
Apr 15 2024
PiRK committed rABC2af41ff856ff: test: Combine sync_send_with_ping and sync_with_ping (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
test: Combine sync_send_with_ping and sync_with_ping
PiRK requested review of D15979: test: Combine sync_send_with_ping and sync_with_ping.
Apr 14 2024
Apr 14 2024
PiRK accepted D15954: [ecash-lib] Add `SigHashType`.
Note that the BIP143 naming is not used in the c++ code, the FORKID name is used instead. That got me confused for a while.
Apr 13 2024
Apr 13 2024
Apr 12 2024
Apr 12 2024
PiRK committed rABCf3f193270b70: Faster -reindex by initially deserializing only headers (authored by Larry Ruane <larryruane@gmail.com>).
Faster -reindex by initially deserializing only headers
PiRK committed rABCb96630370588: util: add CBufferedFile::SkipTo() to move ahead in the stream (authored by Larry Ruane <larryruane@gmail.com>).
util: add CBufferedFile::SkipTo() to move ahead in the stream
PiRK committed rABCbbba97aeab3a: Add LoadExternalBlockFile() benchmark (authored by Larry Ruane <larryruane@gmail.com>).
Add LoadExternalBlockFile() benchmark
PiRK added inline comments to D15961: Faster -reindex by initially deserializing only headers.
PiRK requested review of D15961: Faster -reindex by initially deserializing only headers.
PiRK requested review of D15960: util: add CBufferedFile::SkipTo() to move ahead in the stream.
PiRK requested review of D15959: Add LoadExternalBlockFile() benchmark.
Apr 11 2024
Apr 11 2024
PiRK committed rABC7d5ff29ba399: [chronik] fix ChronikBridge::load_raw_tx and compress_script (authored by PiRK).
[chronik] fix ChronikBridge::load_raw_tx and compress_script
PiRK updated the diff for D15948: [chronik] fix ChronikBridge::load_raw_tx and compress_script.
rebase on D15943
PiRK requested review of D15948: [chronik] fix ChronikBridge::load_raw_tx and compress_script.
PiRK committed rABC6f54c5967c4d: Remove unused char serialize (authored by MarcoFalke <falke.marco@gmail.com>).
Remove unused char serialize
PiRK committed rABC4d6d2035e110: span: Add BytePtr helper (authored by MarcoFalke <falke.marco@gmail.com>).
span: Add BytePtr helper
PiRK committed rABC16755cd2a145: Use spans of std::byte in serialize (authored by MarcoFalke <falke.marco@gmail.com>).
Use spans of std::byte in serialize
PiRK committed rABC6f5358fdff52: refactor: [index] Replace deprecated char with uint8_t in serialization (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: [index] Replace deprecated char with uint8_t in serialization
PiRK updated the diff for D15933: refactor: [index] Replace deprecated char with uint8_t in serialization.
rebase
Apr 10 2024
Apr 10 2024
PiRK added a comment to D15920: [Cashtab] Upgrade tx parsing.
Note: investigating this CI failure, which is also happening on other diffs
./contrib/teamcity/build-configurations.py cashtab-tests is working locally
PiRK requested review of D15936: Remove unused char serialize.
PiRK updated the summary of D15935: Use spans of std::byte in serialize.
PiRK requested review of D15935: Use spans of std::byte in serialize.
PiRK requested review of D15934: span: Add BytePtr helper.
PiRK requested review of D15933: refactor: [index] Replace deprecated char with uint8_t in serialization.
PiRK committed rABC6226c274e3be: refactor: Switch serialize to uint8_t (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Switch serialize to uint8_t
Apr 9 2024
Apr 9 2024
PiRK requested review of D15929: refactor: Switch serialize to uint8_t.
tests: remove flaky mocktime test
PiRK requested review of D15927: tests: remove flaky mocktime test.
This would work only for my linux machine. Ideally the max value should be computed for each system ( std::chrono::system_clock::now().max() * std::chrono::system_clock::period), but that is overkill for a test RPC.
PiRK updated the summary of D15926: tests: fix flaky abc_rpc_mocktime test and limit max mocktime in RPC.
PiRK updated the diff for D15926: tests: fix flaky abc_rpc_mocktime test and limit max mocktime in RPC.
add a check for the upper limit in the RPC command, test it
PiRK planned changes to D15926: tests: fix flaky abc_rpc_mocktime test and limit max mocktime in RPC.
Let's have the RPC return an error also, to guard against future flaky tests caused by overflows.
PiRK updated the test plan for D15926: tests: fix flaky abc_rpc_mocktime test and limit max mocktime in RPC.