Page MenuHomePhabricator
Feed Advanced Search

Sep 11 2024

roqqit requested changes to D16728: Compute the real-time hash target for the next block.
Sep 11 2024, 21:03

Sep 6 2024

roqqit accepted D16730: Return the RTT parameters in the block template.
Sep 6 2024, 17:20
roqqit requested changes to D16729: Reject blocks that violate the real time target policy.
Sep 6 2024, 17:11
roqqit accepted D16728: Compute the real-time hash target for the next block.
Sep 6 2024, 16:37

Sep 5 2024

roqqit closed D16695: [avalanche] Add a cache for avalanche voting results of stake contenders.
Sep 5 2024, 16:53
roqqit committed rABCb632dee70503: [avalanche] Add a cache for avalanche voting results of stake contenders (authored by roqqit).
[avalanche] Add a cache for avalanche voting results of stake contenders
Sep 5 2024, 16:53
roqqit updated the diff for D16695: [avalanche] Add a cache for avalanche voting results of stake contenders.
  • const auto & where appropriate
  • fix payouts.reserve() sizing
Sep 5 2024, 16:11
roqqit added inline comments to D16695: [avalanche] Add a cache for avalanche voting results of stake contenders.
Sep 5 2024, 16:03

Sep 4 2024

roqqit added a comment to D16695: [avalanche] Add a cache for avalanche voting results of stake contenders.

This memory is important so that nodes can reply to stake contender avalanche requests of recent past blocks (we cannot guarantee the entire network has finalized the same block in lock step).

Is it really ? If a block has finalized for some nodes but not others, what is the point of voting on past block rewards ? If the node votes idk the block will eventually be finalized by the poller anyway so the outcome of this stake vote doesn't matter. The only case I think it is helpful is if you get a bunch of blocks in a row, faster than finalization time. But as soon as a block is final you can forget about winners for it and past blocks.

Sep 4 2024, 20:35

Sep 3 2024

roqqit added inline comments to D16695: [avalanche] Add a cache for avalanche voting results of stake contenders.
Sep 3 2024, 17:06
roqqit updated the summary of D16695: [avalanche] Add a cache for avalanche voting results of stake contenders.
Sep 3 2024, 17:06
roqqit updated the diff for D16695: [avalanche] Add a cache for avalanche voting results of stake contenders.
  • DEFAULT -> UNKNOWN
  • fix score type
Sep 3 2024, 17:03
roqqit closed D16694: refactor: Enable proof reward rank to be used elsewhere.
Sep 3 2024, 15:59
roqqit committed rABC2ba215927e17: refactor: Enable proof reward rank to be used elsewhere (authored by roqqit).
refactor: Enable proof reward rank to be used elsewhere
Sep 3 2024, 15:59

Aug 29 2024

roqqit requested review of D16695: [avalanche] Add a cache for avalanche voting results of stake contenders.
Aug 29 2024, 18:09
roqqit requested review of D16694: refactor: Enable proof reward rank to be used elsewhere.
Aug 29 2024, 17:47
roqqit closed D16691: [avalanche] Make buildRandomProof use a random payout script.
Aug 29 2024, 16:04
roqqit committed rABC7aafd2f1c1e7: [avalanche] Make buildRandomProof use a random payout script (authored by roqqit).
[avalanche] Make buildRandomProof use a random payout script
Aug 29 2024, 16:04

Aug 28 2024

roqqit requested review of D16691: [avalanche] Make buildRandomProof use a random payout script.
Aug 28 2024, 19:23
roqqit accepted D16688: tests: fix formatting of itemid in p2p_inv_download.
Aug 28 2024, 16:48

Aug 23 2024

roqqit accepted D16664: [electrum] bump mnemonic dependency to >=0.21.
Aug 23 2024, 15:34
roqqit accepted D16669: [electrum] fix the btchip-python dependency for pip > 24.1.
Aug 23 2024, 15:33
roqqit accepted D16667: [electrum] update dockerfiles to unbreak the release build.
Aug 23 2024, 15:30

Aug 22 2024

roqqit closed D16668: [avalanche] Add stake contender inv type.
Aug 22 2024, 15:33
roqqit committed rABCf93c6792c0cf: [avalanche] Add stake contender inv type (authored by roqqit).
[avalanche] Add stake contender inv type
Aug 22 2024, 15:33

Aug 21 2024

roqqit updated the diff for D16668: [avalanche] Add stake contender inv type.

use named arg per feedback

Aug 21 2024, 19:03

Aug 20 2024

roqqit requested review of D16668: [avalanche] Add stake contender inv type.
Aug 20 2024, 16:41

Aug 15 2024

roqqit added inline comments to D16650: [avalanche] Reject transactions that conflict with a finalized one.
Aug 15 2024, 22:48

Aug 13 2024

roqqit closed D16631: [avalanche] Introduce StakeContenderId.
Aug 13 2024, 23:39
roqqit committed rABC5ad50cf4eb85: [avalanche] Introduce StakeContenderId (authored by roqqit).
[avalanche] Introduce StakeContenderId
Aug 13 2024, 23:39
roqqit updated the diff for D16631: [avalanche] Introduce StakeContenderId.

Add hash.h

Aug 13 2024, 21:51
roqqit updated the diff for D16631: [avalanche] Introduce StakeContenderId.
  • cleanups
  • strongly type StakeContenderId
  • switch to blockhash + proofid instead of blockhash + payoutscript since this could be more versatile down the road
  • streamlined implementation a bit, which eliminated stakecontender.cpp
Aug 13 2024, 19:40
roqqit accepted D16638: Let mapNextTx store shared pointers instead of raw pointers.
Aug 13 2024, 19:03
roqqit accepted D16636: Move Orphanage to the mempool.
Aug 13 2024, 16:14
roqqit accepted D16635: Fix nits in txpool.
Aug 13 2024, 16:05
roqqit accepted D16637: Revert "[avalanche] Sort txs to poll by modified fee rate".
Aug 13 2024, 16:05

Aug 12 2024

roqqit requested review of D16631: [avalanche] Introduce StakeContenderId.
Aug 12 2024, 22:17
roqqit accepted D16628: [explorer] Update datatables packages.
Aug 12 2024, 21:03

Aug 8 2024

roqqit closed D16608: [avalanche] Cleanup invalidated dangling proofs.
Aug 8 2024, 20:34
roqqit committed rABC0664212b2379: [avalanche] Cleanup invalidated dangling proofs (authored by roqqit).
[avalanche] Cleanup invalidated dangling proofs
Aug 8 2024, 20:34
roqqit updated the diff for D16608: [avalanche] Cleanup invalidated dangling proofs.

Fix lock annotations

Aug 8 2024, 19:33
roqqit requested review of D16608: [avalanche] Cleanup invalidated dangling proofs.
Aug 8 2024, 18:15

Aug 7 2024

roqqit closed D16604: [avalanche] Use the appropriate fixture for proof_expiry test.
Aug 7 2024, 19:39
roqqit committed rABC080cd39f37d2: [avalanche] Use the appropriate fixture for proof_expiry test (authored by roqqit).
[avalanche] Use the appropriate fixture for proof_expiry test
Aug 7 2024, 19:39
roqqit closed D16602: [avalanche] Add comment to clarify pm::exists.
Aug 7 2024, 19:39
roqqit committed rABCde1a66ace842: [avalanche] Add comment to clarify pm::exists (authored by roqqit).
[avalanche] Add comment to clarify pm::exists
Aug 7 2024, 19:39
roqqit requested review of D16604: [avalanche] Use the appropriate fixture for proof_expiry test.
Aug 7 2024, 18:14
roqqit requested review of D16602: [avalanche] Add comment to clarify pm::exists.
Aug 7 2024, 17:45
roqqit accepted D16598: Strip the windows installer files.
Aug 7 2024, 16:20

Aug 6 2024

roqqit accepted D16594: Let UpdateTime take the adjusted time instead of getting it locally.
Aug 6 2024, 16:29
roqqit accepted D16593: [avalanche] Add a method to return if the node has a finalized tip.
Aug 6 2024, 16:26

Aug 2 2024

roqqit accepted D16575: Add a facility to create arith_uint256 from their double representation.
Aug 2 2024, 20:17
roqqit accepted D16576: rpc, docs: Add note for commands that supports only legacy wallets.
Aug 2 2024, 16:23

Jul 31 2024

roqqit accepted D16561: Extract tx pool outside of txorphanage.
Jul 31 2024, 17:32

Jul 30 2024

roqqit accepted D16554: Add a new chronik backup server.
Jul 30 2024, 16:15
roqqit closed D16545: [avalanche] Do not add the same payout script more than once when calling setstakingreward RPC.
Jul 30 2024, 16:14
roqqit committed rABC2dfd52797aa6: [avalanche] Do not add the same payout script more than once when calling… (authored by roqqit).
[avalanche] Do not add the same payout script more than once when calling…
Jul 30 2024, 16:14

Jul 29 2024

roqqit updated the diff for D16545: [avalanche] Do not add the same payout script more than once when calling setstakingreward RPC.

Throw an error instead of silently deduping

Jul 29 2024, 18:50
roqqit requested review of D16545: [avalanche] Do not add the same payout script more than once when calling setstakingreward RPC.
Jul 29 2024, 17:08

Jul 22 2024

roqqit accepted D16517: [test] remove pointless block_hashes.append(...).
Jul 22 2024, 17:41

Jul 16 2024

roqqit accepted D16472: Add HashWriter without ser-type and ser-version and use it where possible.
Jul 16 2024, 20:32

Jul 15 2024

roqqit requested changes to D16472: Add HashWriter without ser-type and ser-version and use it where possible.
Jul 15 2024, 22:46
roqqit accepted D16471: Make PeerManager own a FastRandomContext.
Jul 15 2024, 22:29
roqqit accepted D16470: fees: make the class FeeFilterRounder thread-safe.
Jul 15 2024, 19:54
roqqit accepted D16467: Seeder: handle empty HEADERS messages more gracefully.
Jul 15 2024, 17:00

Jul 12 2024

roqqit closed D16454: [avalanche] Fix bytes received tracking for avalanche messages.
Jul 12 2024, 15:54
roqqit committed rABC9065327743ae: [avalanche] Fix bytes received tracking for avalanche messages (authored by roqqit).
[avalanche] Fix bytes received tracking for avalanche messages
Jul 12 2024, 15:54

Jul 11 2024

roqqit accepted D16449: [CONTRIBUTING] pin version for eslint.
Jul 11 2024, 23:02
roqqit requested review of D16454: [avalanche] Fix bytes received tracking for avalanche messages.
Jul 11 2024, 23:00

Jul 10 2024

roqqit accepted D16439: validation: return more helpful results for reconsiderable fee failures and skipped transactions.
Jul 10 2024, 16:18
roqqit accepted D13101: [Mitra] Add Intcode integer format.
Jul 10 2024, 15:40

Jul 9 2024

roqqit requested changes to D13101: [Mitra] Add Intcode integer format.
Jul 9 2024, 23:25
roqqit accepted D16435: [CI] Update the sha256 sum for the nodejs setup script.
Jul 9 2024, 16:02

Jul 8 2024

roqqit accepted D16432: test: Run mempool_packages.py with MiniWallet.
Jul 8 2024, 16:31
roqqit closed D16410: Cleanup unused proofCount.
Jul 8 2024, 16:14
roqqit committed rABC650634c156fa: Cleanup unused proofCount (authored by roqqit).
Cleanup unused proofCount
Jul 8 2024, 16:14

Jul 2 2024

roqqit requested review of D16410: Cleanup unused proofCount.
Jul 2 2024, 21:45

Jul 1 2024

roqqit accepted D16399: [rpc] return effective-includes in testmempoolaccept and submitpackage.

Not blocking on this feedback but the keys should ideally be the same and the help text should match

Jul 1 2024, 23:10
roqqit accepted D16398: [rpc] return effective-feerate in testmempoolaccept and submitpackage.
Jul 1 2024, 22:25
roqqit accepted D16397: [validation] return txids of other transactions whose fees were used.
Jul 1 2024, 22:11
roqqit accepted D16396: [validation] return effective feerate from mempool validation.
Jul 1 2024, 22:03
roqqit accepted D16395: package validation quits early due to non-policy, non-missing-inputs failure.
Jul 1 2024, 21:40
roqqit accepted D16392: refactor: Move mempool RPCs to rpc/mempool.
Jul 1 2024, 18:05
roqqit accepted D16387: test: fix misleading fee unit in mempool_limit.py.
Jul 1 2024, 17:59

Jun 28 2024

roqqit closed D16381: Use underscore in chronik-lib package name.
Jun 28 2024, 19:07
roqqit committed rABCa4ef4bb74be5: Use underscore in chronik-lib package name (authored by roqqit).
Use underscore in chronik-lib package name
Jun 28 2024, 19:07
roqqit requested review of D16381: Use underscore in chronik-lib package name.

Cargo.lock file was already updated in this patch

Jun 28 2024, 19:05
roqqit accepted D16386: test: Use MiniWallet in mempool_limit.py.
Jun 28 2024, 19:01
roqqit accepted D16385: test: Use COINBASE_MATURITY in functional tests.
Jun 28 2024, 19:01
roqqit requested changes to D16387: test: fix misleading fee unit in mempool_limit.py.
Jun 28 2024, 17:23
roqqit requested changes to D16386: test: Use MiniWallet in mempool_limit.py.
Jun 28 2024, 17:12
roqqit requested changes to D16385: test: Use COINBASE_MATURITY in functional tests.

One missing case in rpc_packages.py:47

Jun 28 2024, 17:03
teamcity awarded D16381: Use underscore in chronik-lib package name a Piece of Eight token.
Jun 28 2024, 07:54

Jun 27 2024

roqqit updated the diff for D16381: Use underscore in chronik-lib package name.

Fixup generated file paths

Jun 27 2024, 16:09

Jun 26 2024

roqqit closed D16384: Cleanup commented protocol code.
Jun 26 2024, 20:07
roqqit committed rABCb5acc84862a2: Cleanup commented protocol code (authored by roqqit).
Cleanup commented protocol code
Jun 26 2024, 20:07
roqqit planned changes to D16381: Use underscore in chronik-lib package name.
Jun 26 2024, 19:54
teamcity awarded D16361: Bump rust version to 1.79.0 a Piece of Eight token.
Jun 26 2024, 19:51
roqqit accepted D16378: policy / validation: CPFP fee bumping within packages.
Jun 26 2024, 19:47
roqqit closed D16383: [avalanche] Cleanup include in processor_tests.
Jun 26 2024, 19:43