Page MenuHomePhabricator
Feed Advanced Search

Mon, Nov 10

PiRK committed rABC34100ffa6547: [lint] replace flake8 with ruff (authored by PiRK).
[lint] replace flake8 with ruff
Mon, Nov 10, 15:27
PiRK committed rABC2ccfed5a9b22: [lint] remove isort linter, enable isort in ruff (authored by PiRK).
[lint] remove isort linter, enable isort in ruff
Mon, Nov 10, 15:27
PiRK closed D18904: [lint] switch from Black to Ruff for python code formatting.
Mon, Nov 10, 15:27
PiRK closed D18912: [lint] add a blank line after module level docstring in python files.
Mon, Nov 10, 15:27
PiRK closed D18914: contrib: testgen: remove redundant base58 implementation.
Mon, Nov 10, 15:27
PiRK committed rABCdc3a737e37aa: contrib: testgen: remove redundant base58 implementation (authored by PiRK).
contrib: testgen: remove redundant base58 implementation
Mon, Nov 10, 15:27
PiRK committed rABC14fa79a95013: [lint] switch from Black to Ruff for python code formatting (authored by PiRK).
[lint] switch from Black to Ruff for python code formatting
Mon, Nov 10, 15:27
PiRK closed D18903: [lint] bump black to >=25.
Mon, Nov 10, 15:27
PiRK committed rABCb4ec750c43d7: [lint] add a blank line after module level docstring in python files (authored by PiRK).
[lint] add a blank line after module level docstring in python files
Mon, Nov 10, 15:27
PiRK committed rABCffdf9bfd6e3c: [lint] bump black to >=25 (authored by PiRK).
[lint] bump black to >=25
Mon, Nov 10, 15:27
PiRK published D18913: [lint] replace flynt linter with ruff for review.
Mon, Nov 10, 11:26
PiRK added inline comments to D18905: [lint] replace flake8 with ruff.
Mon, Nov 10, 11:25
PiRK updated the summary of D18905: [lint] replace flake8 with ruff.
Mon, Nov 10, 11:12
PiRK requested review of D18914: contrib: testgen: remove redundant base58 implementation.
Mon, Nov 10, 11:12
PiRK updated the diff for D18905: [lint] replace flake8 with ruff.

suffix linter code

Mon, Nov 10, 11:10
PiRK published D18912: [lint] add a blank line after module level docstring in python files for review.

i forgot to publish that one, it is a dependency for the black -> ruff diff

Mon, Nov 10, 11:09
PiRK added inline comments to D18904: [lint] switch from Black to Ruff for python code formatting.
Mon, Nov 10, 10:36
PiRK updated the diff for D18904: [lint] switch from Black to Ruff for python code formatting.

rebase for minor change in Contributing.md

Mon, Nov 10, 08:13
PiRK updated the diff for D18903: [lint] bump black to >=25.

update Contributing.md and install dependencies script

Mon, Nov 10, 08:11
PiRK added inline comments to D18904: [lint] switch from Black to Ruff for python code formatting.
Mon, Nov 10, 08:08
PiRK updated the summary of D18904: [lint] switch from Black to Ruff for python code formatting.
Mon, Nov 10, 08:07
PiRK updated the diff for D18904: [lint] switch from Black to Ruff for python code formatting.

split most newline changes into its own diff

Mon, Nov 10, 07:59

Fri, Nov 7

PiRK retitled D18907: [lint] Find function calls in default arguments from lint: Find function calls in default arguments to [lint] Find function calls in default arguments.
Fri, Nov 7, 16:06
PiRK published D18907: [lint] Find function calls in default arguments for review.
Fri, Nov 7, 16:06
PiRK published D18906: [lint] remove isort linter, enable isort in ruff for review.
Fri, Nov 7, 16:03
PiRK published D18905: [lint] replace flake8 with ruff for review.
Fri, Nov 7, 16:01
PiRK planned changes to D18904: [lint] switch from Black to Ruff for python code formatting.

i should be able to split this more, some changes are probably compatible with black (blank lines, bare tuples...)

Fri, Nov 7, 15:00
PiRK requested review of D18904: [lint] switch from Black to Ruff for python code formatting.
Fri, Nov 7, 14:55
PiRK added inline comments to D18903: [lint] bump black to >=25.
Fri, Nov 7, 14:54
PiRK requested review of D18903: [lint] bump black to >=25.
Fri, Nov 7, 14:52
PiRK closed D18899: guix: move *-check.py scripts under contrib/guix.
Fri, Nov 7, 14:37
PiRK committed rABCc217063d84f1: deps: bump lief to 0.16.6 (authored by David Gumberg <davidzgumberg@gmail.com>).
deps: bump lief to 0.16.6
Fri, Nov 7, 14:37
PiRK closed D18898: guix: remove test-security/symbol-check scripts.
Fri, Nov 7, 14:37
PiRK closed D18900: deps: bump lief to 0.16.6.
Fri, Nov 7, 14:37
PiRK committed rABC4c287f0d5abb: guix: move *-check.py scripts under contrib/guix (authored by fanquake <fanquake@gmail.com>).
guix: move *-check.py scripts under contrib/guix
Fri, Nov 7, 14:37
PiRK committed rABC7a5211401e9e: guix: remove test-security/symbol-check scripts (authored by fanquake <fanquake@gmail.com>).
guix: remove test-security/symbol-check scripts
Fri, Nov 7, 14:37
PiRK added a comment to D18899: guix: move *-check.py scripts under contrib/guix.

why did you skip the linter ?

Fri, Nov 7, 14:04
PiRK published D18900: deps: bump lief to 0.16.6 for review.
Fri, Nov 7, 12:58
PiRK published D18899: guix: move *-check.py scripts under contrib/guix for review.
Fri, Nov 7, 12:57
PiRK published D18898: guix: remove test-security/symbol-check scripts for review.
Fri, Nov 7, 12:57
teamcity awarded D18900: deps: bump lief to 0.16.6 a Doubloon token.
Fri, Nov 7, 11:48
teamcity awarded D18900: deps: bump lief to 0.16.6 a Piece of Eight token.
Fri, Nov 7, 09:54
teamcity awarded D18900: deps: bump lief to 0.16.6 a Haypence token.
Fri, Nov 7, 09:45
teamcity awarded D18899: guix: move *-check.py scripts under contrib/guix a Haypence token.
Fri, Nov 7, 09:07
PiRK closed D18896: test: fix constructor of msg_tx.
Fri, Nov 7, 08:59
PiRK committed rABCdc73a3e11b56: test: fix constructor of msg_tx (authored by Martin Zumsande <mzumsande@gmail.com>).
test: fix constructor of msg_tx
Fri, Nov 7, 08:59

Thu, Nov 6

PiRK added a comment to D18896: test: fix constructor of msg_tx.

We fixed some of these issues with D7910 with some regex catching lists, dicts or set literals. But this is insufficient.

Thu, Nov 6, 17:05
PiRK requested review of D18896: test: fix constructor of msg_tx.
Thu, Nov 6, 17:04
PiRK closed D18894: rpc: include verbose reject-details field in testmempoolaccept response.
Thu, Nov 6, 15:51
PiRK closed D18893: Bump version to 0.32.3.
Thu, Nov 6, 15:51
PiRK committed rABC05390e351cfc: Bump version to 0.32.3 (authored by PiRK).
Bump version to 0.32.3
Thu, Nov 6, 15:51
PiRK committed rABCedbac8bf194f: rpc: include verbose reject-details field in testmempoolaccept response (authored by Matthew Zipkin <pinheadmz@gmail.com>).
rpc: include verbose reject-details field in testmempoolaccept response
Thu, Nov 6, 15:51
PiRK accepted D18895: [website] Update the upgrade banner for the Nov. 15 2025 upgrade.
Thu, Nov 6, 14:43
PiRK updated the diff for D18893: Bump version to 0.32.3.

fix archived release notes

Thu, Nov 6, 14:42
PiRK updated the diff for D18893: Bump version to 0.32.3.

rebase

Thu, Nov 6, 14:04
PiRK requested review of D18894: rpc: include verbose reject-details field in testmempoolaccept response.
Thu, Nov 6, 11:59
PiRK requested review of D18893: Bump version to 0.32.3.
Thu, Nov 6, 11:58
PiRK committed rABC05320e4967a5: Remove broken and unused CDataStream methods (authored by MarcoFalke <falke.marco@gmail.com>).
Remove broken and unused CDataStream methods
Thu, Nov 6, 11:56
PiRK closed D18891: test: Fix sanitizer suppresions in streams_tests.
Thu, Nov 6, 11:56
PiRK closed D18892: Remove broken and unused CDataStream methods.
Thu, Nov 6, 11:56
PiRK committed rABC2c24045ddb98: test: Fix sanitizer suppresions in streams_tests (authored by MarcoFalke <falke.marco@gmail.com>).
test: Fix sanitizer suppresions in streams_tests
Thu, Nov 6, 11:56
PiRK requested review of D18892: Remove broken and unused CDataStream methods.
Thu, Nov 6, 10:38
teamcity awarded D18891: test: Fix sanitizer suppresions in streams_tests a Haypence token.
Thu, Nov 6, 10:27
PiRK added a comment to D18891: test: Fix sanitizer suppresions in streams_tests.

@bot build-ubsan

Thu, Nov 6, 10:27
PiRK requested review of D18891: test: Fix sanitizer suppresions in streams_tests.
Thu, Nov 6, 10:27
PiRK accepted D18886: log: rate limiting followups.
Thu, Nov 6, 09:21
PiRK accepted D18888: [CI] Bump ASAN timeout.
Thu, Nov 6, 07:49
PiRK accepted D18887: test: don't throw from the destructor of DebugLogHelper.
Thu, Nov 6, 07:48
PiRK added inline comments to D18886: log: rate limiting followups.
Thu, Nov 6, 07:44
PiRK accepted D18885: refactor: use Span for SipHash::Write.
Thu, Nov 6, 07:27

Wed, Nov 5

PiRK closed D18879: [validation] include all logged information in BlockValidationState.
Wed, Nov 5, 20:46
PiRK closed D18880: [validation] merge all ConnectBlock debug logging code paths.
Wed, Nov 5, 20:46
PiRK committed rABC4ddd97b95f02: [validation] merge all ConnectBlock debug logging code paths (authored by PiRK).
[validation] merge all ConnectBlock debug logging code paths
Wed, Nov 5, 20:46
PiRK committed rABC0ffeacec23f8: [validation] include all logged information in BlockValidationState (authored by Pieter Wuille <pieter@wuille.net>).
[validation] include all logged information in BlockValidationState
Wed, Nov 5, 20:46
PiRK closed D18876: [checkqueue] support user-defined return type through std::optional.
Wed, Nov 5, 20:46
PiRK closed D18878: [validation] Add detailed txin/txout information for script error messages.
Wed, Nov 5, 20:46
PiRK closed D18877: [validation] Make script error messages uniform for parallel/single validation.
Wed, Nov 5, 20:46
PiRK committed rABC8eb86b00b55f: [validation] Add detailed txin/txout information for script error messages (authored by Pieter Wuille <pieter@wuille.net>).
[validation] Add detailed txin/txout information for script error messages
Wed, Nov 5, 20:46
PiRK committed rABCf844a8f41410: [checkqueue] support user-defined return type through std::optional (authored by Pieter Wuille <pieter@wuille.net>).
[checkqueue] support user-defined return type through std::optional
Wed, Nov 5, 20:46
PiRK committed rABCda83158d475d: [validation] Make script error messages uniform for parallel/single validation (authored by Pieter Wuille <pieter@wuille.net>).
[validation] Make script error messages uniform for parallel/single validation
Wed, Nov 5, 20:46
PiRK closed D18872: Add std::optional support to Boost's equality check.
Wed, Nov 5, 19:37
PiRK committed rABC3fb2ed2ceb27: Add std::optional support to Boost's equality check (authored by Lőrinc <pap.lorinc@gmail.com>).
Add std::optional support to Boost's equality check
Wed, Nov 5, 19:37
PiRK committed rABC8230e66ae88e: test: uint256 - Garbage suffixes and zero padding (authored by Hodlinator <172445034+hodlinator@users.noreply.github.com>).
test: uint256 - Garbage suffixes and zero padding
Wed, Nov 5, 19:37
PiRK closed D18871: test: uint256 - Garbage suffixes and zero padding.
Wed, Nov 5, 19:37
PiRK closed D18870: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().
Wed, Nov 5, 19:37
PiRK committed rABC4d9fdc4a072d: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK() (authored by Hodlinator <172445034+hodlinator@users.noreply.github.com>).
refactor: Make uint256_tests no longer use deprecated BOOST_CHECK()
Wed, Nov 5, 19:37
teamcity awarded D18880: [validation] merge all ConnectBlock debug logging code paths a Haypence token.
Wed, Nov 5, 19:33
PiRK added a comment to D18880: [validation] merge all ConnectBlock debug logging code paths.

@bot build-chronik chronik-client-integration-tests

Wed, Nov 5, 19:33
PiRK accepted D18884: [chronik] Fix a -Wmissing-field-initializers warning in chronikbridge_tests.cpp.
Wed, Nov 5, 19:32
PiRK updated the diff for D18880: [validation] merge all ConnectBlock debug logging code paths.

rebase

Wed, Nov 5, 19:32
PiRK updated the diff for D18879: [validation] include all logged information in BlockValidationState.

rebase

Wed, Nov 5, 19:32
PiRK updated the diff for D18878: [validation] Add detailed txin/txout information for script error messages.

revert the hack introduced in D18876. This seems to be no longer needed after local_result = check() assigns a std::optional<std::pair<R, std::string>> rather than a std::optional<R> in CCheckQueue::Loop

Wed, Nov 5, 19:31
PiRK updated the diff for D18877: [validation] Make script error messages uniform for parallel/single validation.

newline

Wed, Nov 5, 19:13
PiRK accepted D18881: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError.
Wed, Nov 5, 19:07
PiRK updated the diff for D18877: [validation] Make script error messages uniform for parallel/single validation.

rebase

Wed, Nov 5, 18:32
PiRK updated the diff for D18876: [checkqueue] support user-defined return type through std::optional.

fix

Wed, Nov 5, 18:30
PiRK updated the diff for D18876: [checkqueue] support user-defined return type through std::optional.

try replacing std::optional<R> local_result with a bool has_local_result; + R local_result; (remember that we converge back to Core's solution in D18878, so the hack is temporary)

Wed, Nov 5, 18:13
PiRK requested review of D18870: refactor: Make uint256_tests no longer use deprecated BOOST_CHECK().
Wed, Nov 5, 17:59
PiRK updated the diff for D18876: [checkqueue] support user-defined return type through std::optional.

try decltype

Wed, Nov 5, 17:58
PiRK added a comment to D18876: [checkqueue] support user-defined return type through std::optional.

probably https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107919, need to find a temporary workaround (the error goes away for some obscure reason in D18878)

Wed, Nov 5, 16:00