​src/test/buildenv.py has been generated by an old in-tree build from late 2017, it is not used anymore. sorry for the noise.

In D1449#29299, @deadalnix wrote:

What is this file, why do we want to ignore it ?

internal branch reorg. no code changes

remove a spurios commit

last change wasn't supposed to update this diff.. fixing

Format comment

Format comment

diff seems sensible even if automatic build fails (https://reviews.bitcoinabc.org/harbormaster/build/3370/), it seems more an infrastructure problem rather than a code problem

Squash local commits

Remove src/test/buildenv.py

Dunno why but for some reason I seem to have added src/test/buildenv.py by error, wonder if we could add it to .gitignore

nothing wrong with the diff, but wasn't secp256k1 handled as a subtree? is this changed since @tomtomtom7's utxo commitments patches?

patch is still WIP right? cause I don't see any criteria on how to apply excessUTXOCharge

superseded by D866

In D859#15736, @deadalnix wrote:

Can you explain how you end up with that file generated ?

On second thought I think I will setup a new unit test to see if minrelayfee could be set to 0 and leave the more complete functional test on D554.

Test you referring to is part of D554 as this change was.

rebased on top of master and D856

2. just wanted to further specify that minrelaytxfee will be overruled once the mempool will get full and mempol accpetance fee will be modified via incrementalrelay

I partly agree, but we have to take into consideration that theoretically it is not possible to relay more than 20KB of free transactions per minute. Hence 200KB worth of free transactions per block.

• modify sendrawtransaction (in src/rpc/rawtransaction.cpp) so that locally generated transaction is rate limited accordinf to limiterfreerelay

Change default for key fee transactions policies

• Add unit test to verify that 0 fee non high priority transactions are selected for inclusion in a block.
• let minrelaytxfee to be set to 0.

These set of changes fixed a runtime error occuring during the execution of miner_tests.
It was due to the use of ForceSetArg in TestPackageSelection to change the default value of blockMinFeeRate.

Add comment to explain what DEFAULT_LIMITFREERELAY is

Rebased

Guess that a link to the email where the algo is described should be put somewhere in the code comment or in the commit message

wonder if you could have used git subtree rather than including the code directly in the ABC tree

did't mean to accept to for the all abc project, forgot to untick the check button.

nice addition

Add WIP to title a list of TODO taks

100% agreed on having an a Task where to discuss about how to reload bitcoin.conf, be it via a RPC command reload_config or via a SIGHUP sent to bitcoind.

I guess that we need to weight if the added complexity justify the addition of the RPC command.

Run high_priority_transaction.py 240 times in a loop and didn't experience any failure. Previously I got around 7-10% failure ratio.

testing now report back later.