Agree with Fabien. This is how we identified issues with the previous hardfork activation, but it was never landed on master.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 29 2019
Jan 29 2019
jasonbcox added a comment to D2437: qa: Temporarily disable test that reads the default datadir location.
Why does setting greatwallactivationtime uncover this config issue? Seems like there's another underlying problem. I noticed the Core PR didn't give much info about its discovery either. Is this a spurious/flaky failure or is it triggered by some specific action?
jasonbcox updated the summary of D2437: qa: Temporarily disable test that reads the default datadir location.
Regarding the warning: https://github.com/bitcoin/bitcoin/issues/10030 Looks like Core didn't care about the issue much either.
jasonbcox added a comment to D2432: ArgsManager: keep command line and config file arguments separate.
Will green once release notes are in a reviewable state.
Still unable to recv it on SKS or MIT keyservers.
Some items in the summary need to be called out in release notes.
jasonbcox added a comment to D2432: ArgsManager: keep command line and config file arguments separate.
Not only the new features, but also the behavior changes. The behavior changes are actually more important, IMO, as some people have complex configurations that could mysteriously break.
jasonbcox requested changes to D2432: ArgsManager: keep command line and config file arguments separate.
I see the last commit in that PR has release notes: https://github.com/bitcoin/bitcoin/pull/11862/commits/c25321ff96737bdba80d626d2425ef02c7a4c181 Since you're breaking these changes up, do you think updating the release notes to match the current state makes sense, or are you going to just tack c25321ff onto the end once you're done?
Jan 28 2019
Jan 28 2019
jasonbcox added a comment to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Please rebase and then bug me if I don't get to reviewing this again in the next few days.
Herald added a reviewer for D2429: Merge #10231: [Qt] Reduce a significant cs_main lock freeze: Restricted Project.
jasonbcox committed rABCde86c70c2d6b: Don't use pass by reference to const for cheaply-copied types (bool, char, etc. (authored by practicalswift <practicalswift@users.noreply.github.com>).
Don't use pass by reference to const for cheaply-copied types (bool, char, etc.
jasonbcox closed T508: Backport Core PR 10839, a subtask of T417: Backport PR10244 from core, as Resolved.
jasonbcox added inline comments to D2428: [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page.
Herald added a reviewer for D2428: [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page: Restricted Project.
Herald added a reviewer for D2427: Don't use pass by reference to const for cheaply-copied types (bool, char, etc.).: Restricted Project.
We talked more offline and it's clear that using this keyserver by default doesn't not work well on all configurations. It just happens to work well on my machines.
Tried recv-keys on this fingerprint and I get nothing. Please double check that it's available on a few keyservers.
I support this, but I'll wait for @deadalnix to sign off
I'm against this because the default configuration for Ubuntu tends to pick a server like pgp.mit.edu which has very poor uptime. You are free to use whatever keyserver you see fit, but it makes sense to pick one that works at least 99% of the time.
Jan 27 2019
Jan 27 2019
jasonbcox closed T522: Backport Core PR 10390, a subtask of T521: Backport Core PR 10706, as Resolved.
jasonbcox committed rABC7b1fba8cb016: remove minimum total fee option (authored by Gregory Sanders <gsanders87@gmail.com>).
remove minimum total fee option
Bump version number to 0.18.8
Yes, 0.19.0 will probably come after this release since the hardfork upgrade code cutoff is after when 0.18.8 would release.
Jan 26 2019
Jan 26 2019
Jan 25 2019
Jan 25 2019
jasonbcox closed T516: Backport Core PR 10295, a subtask of T515: Backport Core PR 10449, as Resolved.
jasonbcox closed T516: Backport Core PR 10295, a subtask of T521: Backport Core PR 10706, as Resolved.
jasonbcox committed rABC8e43c6385504: Merge #10295: [qt] Move some WalletModel functions into CWallet (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10295: [qt] Move some WalletModel functions into CWallet
jasonbcox committed rABC0d515756271f: Update contrib/teamcity documentation with how to build a teamcity agent VM (authored by jasonbcox).
Update contrib/teamcity documentation with how to build a teamcity agent VM
Herald added a reviewer for D2418: Update contrib/teamcity documentation with how to build a teamcity agent VM: Restricted Project.
jasonbcox committed rABC1da1ddd10d3a: tests: Fix test_runner return value in case of skipped test (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
tests: Fix test_runner return value in case of skipped test
jasonbcox updated the summary of D2414: tests: Fix test_runner return value in case of skipped test.
Herald added a reviewer for D2414: tests: Fix test_runner return value in case of skipped test: Restricted Project.
Jan 24 2019
Jan 24 2019
Add remaining items to release notes
Update chainparams for 0.18.7
Fixed note regarding bitcoin-qt fix
jasonbcox updated the diff for D2401: Merge #10295: [qt] Move some WalletModel functions into CWallet.
Rebase + fixed comment
jasonbcox committed rABC0f4cf482a122: [Qt] replace fee slider with a Dropdown, extend conf. targets (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[Qt] replace fee slider with a Dropdown, extend conf. targets
jasonbcox closed T509: Backport Core PR 10769, a subtask of T508: Backport Core PR 10839, as Resolved.
jasonbcox updated the diff for D2406: [Qt] replace fee slider with a Dropdown, extend conf. targets.
Fix version comment
Herald added a reviewer for D2406: [Qt] replace fee slider with a Dropdown, extend conf. targets: Restricted Project.
nvm I see this diff actually has a dependency on D2336
Looks like same build failure as before. Not sure why this change would re-introduce it though.
I checked again and I see the radio button on master.
Fix typo in radix.h
jasonbcox committed rABC0a6fc0cad443: Fix compilation error in radix.h for older compilers (authored by jasonbcox).
Fix compilation error in radix.h for older compilers
Jan 23 2019
Jan 23 2019
Herald added a reviewer for D2403: Fix compilation error in radix.h for older compilers: Restricted Project.
jasonbcox updated the test plan for D2401: Merge #10295: [qt] Move some WalletModel functions into CWallet.
jasonbcox updated the test plan for D2401: Merge #10295: [qt] Move some WalletModel functions into CWallet.
Herald added a reviewer for D2401: Merge #10295: [qt] Move some WalletModel functions into CWallet: Restricted Project.