Feed All Stories
Oct 4 2023
Oct 4 2023
PiRK requested review of D14596: Do not pass time getter to Chainstate helpers.
PiRK committed rABCab0c72d2bf5d: validation: add Config to ChainstateManager (authored by Anthony Towns <aj@erisian.com.au>).
validation: add Config to ChainstateManager
[e.cash] Swpazone widget edits
PiRK updated the summary of D14594: [electrum] progress converting keystore.py to using bytes.
PiRK updated the summary of D14594: [electrum] progress converting keystore.py to using bytes.
PiRK requested review of D14595: [electrum] remove last usages of int_to_le_hex and rev_hex.
PiRK requested review of D14594: [electrum] progress converting keystore.py to using bytes.
PiRK requested review of D14593: [electrum] fix OldKeyStore.get_pubkey_derivation.
PiRK requested review of D13244: validation: add Config to ChainstateManager.
PiRK committed rABCdde0959297be: [electrum] fix get_tx_derivations for regular keystores and imported keys… (authored by PiRK).
[electrum] fix get_tx_derivations for regular keystores and imported keys…
emack added inline comments to D14571: [Apps][Examples] Refactor sendXec demo to use updated API in ecash-coinselect v2.0.1.
emack updated the diff for D14571: [Apps][Examples] Refactor sendXec demo to use updated API in ecash-coinselect v2.0.1.
Responding to feedback
PiRK committed rABC5cd4d404df97: refactor: Post-"Chainstate loading sequence coalescence" fixups (authored by PiRK).
refactor: Post-"Chainstate loading sequence coalescence" fixups
PiRK committed rABC71742ac7d667: test: call VerifyLoadedChainstate during ChainTestingSetup (authored by James O'Beirne <james.obeirne@pm.me>).
test: call VerifyLoadedChainstate during ChainTestingSetup
PiRK committed rABCa132cedbc755: streams: Add AutoFile without ser-type and ser-version (authored by MacroFake <falke.marco@gmail.com>).
streams: Add AutoFile without ser-type and ser-version
PiRK updated the diff for D14583: streams: Add AutoFile without ser-type and ser-version.
remove unrelated line break
emack updated the diff for D14587: [Cashtab][Alias] Patch silent bugs introduced by spec change.
Remove newline
emack updated the diff for D14587: [Cashtab][Alias] Patch silent bugs introduced by spec change.
Removed the xecAmount override as it was only needed for the original mock data that was not aligned with the latest alias spec, hence previously returning change. This is no longer the case with the latest mocks. This also removes the previous comment around updating the spec.
emack updated the summary of D14587: [Cashtab][Alias] Patch silent bugs introduced by spec change.
PiRK updated the diff for D14592: [electrum] fix get_tx_derivations for regular keystores and imported keys keystores.
no need to verify the sig in the test, it is done via keystore.sign_transaction -> Transaction.sign -> Transaction._sign_txin -> Transaction.verify_signature
emack updated the diff for D14555: [Cashtab][Alias] Pending Aliases.
Following further testing, moving the alias server error logic to the first useEffect that uses balances.totalBalance as a dependency is the right approach. Have verified this useEffect block is triggered upon app load, Alias.js component load and post-registration broadcast. Additional verification can be done by malforming the alias-server endpoint used in useWallet's refreshAliases and in Alias.js' preparePreviewModal.
[qt] Remove assignment in if statement
Fabien updated the test plan for D14591: [qt] Remove assignment in if statement.
Fabien requested changes to D14592: [electrum] fix get_tx_derivations for regular keystores and imported keys keystores.
Back to your queue, the test is failing
teamcity added a comment to D14590: [e.cash] Swpazone widget edits.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41912 for the next 60 minutes.
teamcity awarded D14590: [e.cash] Swpazone widget edits a Haypence token.
Fabien added a comment to D14590: [e.cash] Swpazone widget edits.
@bot preview-e.cash
Fabien requested changes to D14589: [Cashtab] Add deprecation announcement for encrypted msgs.
teamcity added a comment to D14592: [electrum] fix get_tx_derivations for regular keystores and imported keys keystores.
Build Bitcoin ABC Diffs / Diff Testing (electrum-tests) failed.
Fabien requested changes to D13244: validation: add Config to ChainstateManager.
Do you really need this ? Chainstate already has a public CChainParams member, can't this be used (it can be accessed from CChainstateManager.active_chainstate) instead ?
Fabien requested review of D14591: [qt] Remove assignment in if statement.
PiRK added inline comments to D14584: test: call VerifyLoadedChainstate during ChainTestingSetup.
PiRK added inline comments to D14584: test: call VerifyLoadedChainstate during ChainTestingSetup.
emack planned changes to D14555: [Cashtab][Alias] Pending Aliases.
Upon further testing, both useEffects are being triggered upon Alias.js load. Going to have a think about the most efficient approach to this.
emack added inline comments to D14555: [Cashtab][Alias] Pending Aliases.
emack updated the diff for D14555: [Cashtab][Alias] Pending Aliases.
Responding to feedback
Oct 3 2023
Oct 3 2023
bytesofman requested changes to D14587: [Cashtab][Alias] Patch silent bugs introduced by spec change.
I'm not understanding why the amount is wrong. The alias registration tx should just be a "send" tx to the IFP address. So the sent amount should be everything that isn't change, like a normal tx.
bytesofman added inline comments to D14584: test: call VerifyLoadedChainstate during ChainTestingSetup.
bytesofman updated the diff for D14589: [Cashtab] Add deprecation announcement for encrypted msgs.
update snapshots
johnkuney retitled D14590: [e.cash] Swpazone widget edits from [e.cash] Swpazone widget config edits to [e.cash] Swpazone widget edits.
johnkuney updated the diff for D14590: [e.cash] Swpazone widget edits.
move the widget down and copy edit
johnkuney requested review of D14590: [e.cash] Swpazone widget edits.
green w/ formatting nit
bytesofman planned changes to D14578: [Cashtab] Deprecate airdrops.
Will rehabilitate this feature with chronik improvements
bytesofman requested changes to D14555: [Cashtab][Alias] Pending Aliases.
teamcity added a comment to D14589: [Cashtab] Add deprecation announcement for encrypted msgs.
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
bytesofman added a comment to D14577: [Cashtab] Remove encrypted msg sending.
bytesofman added a comment to D14589: [Cashtab] Add deprecation announcement for encrypted msgs.
bytesofman requested review of D14589: [Cashtab] Add deprecation announcement for encrypted msgs.
bytesofman planned changes to D14577: [Cashtab] Remove encrypted msg sending.
bytesofman committed rABC3149596d668f: [Cashtab] Replace obsolete log statement in unit test (authored by bytesofman).
[Cashtab] Replace obsolete log statement in unit test
bytesofman committed rABC7b7220ab9fd3: [Cashtab] Add test cases for one-to-many xec sends (authored by bytesofman).
[Cashtab] Add test cases for one-to-many xec sends
bytesofman committed rABC6fc0fc1db8ad: [Cashtab] Refactor new tx function to accept targetOutputs (authored by bytesofman).
[Cashtab] Refactor new tx function to accept targetOutputs
Fabien committed rABC6ddb501b4785: [avalanche] Fix occasional failures in abc_p2p_avalanche_voting (authored by Fabien).
[avalanche] Fix occasional failures in abc_p2p_avalanche_voting
[e.cash] Add Swapzone widget
teamcity added a comment to D14588: [Chronik-client] Upgrade for in-node chronik (WIP).
Build Bitcoin ABC Diffs / Diff Testing (chronik-client-tests) failed.
emack planned changes to D14588: [Chronik-client] Upgrade for in-node chronik (WIP).
For discussion in tg
emack requested review of D14588: [Chronik-client] Upgrade for in-node chronik (WIP).
PiRK updated the summary of D13244: validation: add Config to ChainstateManager.
PiRK updated the diff for D13244: validation: add Config to ChainstateManager.
rebase from hell
bytesofman requested review of D14575: [Cashtab] Replace obsolete log statement in unit test.
bytesofman added a comment to D14575: [Cashtab] Replace obsolete log statement in unit test.
emack updated the summary of D14587: [Cashtab][Alias] Patch silent bugs introduced by spec change.
emack requested review of D14587: [Cashtab][Alias] Patch silent bugs introduced by spec change.
Fabien requested review of D14586: [avalanche] Fix occasional failures in abc_p2p_avalanche_voting.
teamcity updated the summary of D14585: refactor: Post-"Chainstate loading sequence coalescence" fixups.
PiRK requested review of D14585: refactor: Post-"Chainstate loading sequence coalescence" fixups.
teamcity updated the summary of D14584: test: call VerifyLoadedChainstate during ChainTestingSetup.
PiRK requested review of D14584: test: call VerifyLoadedChainstate during ChainTestingSetup.
teamcity updated the summary of D14583: streams: Add AutoFile without ser-type and ser-version.
PiRK requested review of D14583: streams: Add AutoFile without ser-type and ser-version.
Fabien committed rABC38277b89f2e1: [avalanche] Fix the local proof status when it is already registered (authored by Fabien).
[avalanche] Fix the local proof status when it is already registered
Fabien committed rABCe35ec229a99d: [avalanche] Move the processor updatedBlockTip logic to a private method (authored by Fabien).
[avalanche] Move the processor updatedBlockTip logic to a private method