- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 22 2019
Nov 22 2019
Nov 21 2019
Nov 21 2019
deadalnix committed rABC8a31c2afd39f: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool (authored by practicalswift <practicalswift@users.noreply.github.com>).
util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool
deadalnix committed rABCb386fce87d7b: Make SignPSBTInput operate on a private SignatureData object (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make SignPSBTInput operate on a private SignatureData object
deadalnix committed rABC0f0b515c75a8: Pass HD path data through SignatureData (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Pass HD path data through SignatureData
deadalnix committed rABCf3f969bc3917: Implement key origin lookup in CWallet (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Implement key origin lookup in CWallet
deadalnix committed rABCa3884c52a1cc: wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an… (authored by practicalswift <practicalswift@users.noreply.github.com>).
wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an…
deadalnix committed rABC93aa869bfd7e: Generalize PublicOnlySigningProvider into HidingSigningProvider (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Generalize PublicOnlySigningProvider into HidingSigningProvider
deadalnix committed rABCba3dabfd5980: More tests of signer checks (authored by Andrew Chow <achow101-github@achow101.com>).
More tests of signer checks
deadalnix committed rABCe6c6db649672: Update valid PSBT test vectors so that they properly use the value 0 for… (authored by deadalnix).
Update valid PSBT test vectors so that they properly use the value 0 for…
deadalnix updated the diff for D4498: Update valid PSBT test vectors so that they properly use the value 0 for utxos's key.
Rebase and run the test suite
I fell like you are a bit overdoing it with auto here. I'm not against auto in general, but C++ is a bit trigger happy with copies and implicit conversions.
Actually add the tests that were previusly put in another section by mistake
Nov 20 2019
Nov 20 2019
deadalnix added a comment to D4496: Split out key-value parsing in ArgsManager into its own function.
Considering there are still many backports to do in there, I don't think this is very wise to go there.
Rebase and fix merge conflict
Use the goddamn ChanParams. You broke the net magic and introduce many branches you don't need to introduce.
deadalnix committed rABCd32a1d5f5fe6: Make SigningProvider expose key origin information (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make SigningProvider expose key origin information
deadalnix committed rABC239e9c2a5517: [MOVEONLY] Move ParseHDKeypath to utilstrencodings (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[MOVEONLY] Move ParseHDKeypath to utilstrencodings
deadalnix committed rABC961cb3f865d5: Introduce KeyOriginInfo for fingerprint + path (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Introduce KeyOriginInfo for fingerprint + path
You just removed the ability to use just about 90% of boost's unit tests abilities.
deadalnix committed rABC64b198f39284: Test that a non-witness script as witness utxo is not signed (authored by Andrew Chow <achow101-github@achow101.com>).
Test that a non-witness script as witness utxo is not signed
deadalnix committed rABC0f2655706817: Use 72 byte dummy signatures when watching only inputs may be used (authored by Andrew Chow <achow101-github@achow101.com>).
Use 72 byte dummy signatures when watching only inputs may be used
deadalnix committed rABC0f5488cfa05d: Use 71 byte signature for DUMMY_SIGNATURE_CREATOR (authored by Andrew Chow <achow101-github@achow101.com>).
Use 71 byte signature for DUMMY_SIGNATURE_CREATOR
deadalnix committed rABC1a5829a4b8bf: Always create 70 byte signatures with low R values (authored by Andrew Chow <achow101-github@achow101.com>).
Always create 70 byte signatures with low R values
deadalnix committed rABCd9e677821dc6: Additional sanity checks in SignPSBTInput (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Additional sanity checks in SignPSBTInput
Nov 19 2019
Nov 19 2019
Add missing braces on key.cpp
Go on, trash my ccache :)
Remove 'both'
Nov 18 2019
Nov 18 2019
deadalnix committed rABC6baa2c0642de: Fix merging of global unknown data in PSBTs (authored by Andrew Chow <achow101-github@achow101.com>).
Fix merging of global unknown data in PSBTs
deadalnix committed rABCd395b70087cb: Check that PSBT keys are the correct length (authored by Andrew Chow <achow101-github@achow101.com>).
Check that PSBT keys are the correct length
Add brace in bitcoin-tx.cpp
Fix PSBT error test vectors
deadalnix committed rABCc453a23e9675: Add outputtype module (authored by Anthony Towns <aj@erisian.com.au>).
Add outputtype module
deadalnix added inline comments to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.
Nov 17 2019
Nov 17 2019
It's getting there, this is now much better, but there are still a few things that could be improved.